[GitHub] [maven-compiler-plugin] olamy opened a new pull request #97: MCOMPILER 346 assertion error from javaxcompiler
olamy opened a new pull request #97: URL: https://github.com/apache/maven-compiler-plugin/pull/97 - [MCOMPILER-346] use plexus-compiler snapshot to avoid jdk bug add an it for it - use released of plexus-compilers Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-analyzer] slawekjaranowski merged pull request #54: MSHARED-1038: Inner classes are in same compilation unit as container class
slawekjaranowski merged pull request #54: URL: https://github.com/apache/maven-dependency-analyzer/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCOMPILER-346) workaround to jdk bug: assertionError inside javac when using javax.tools API
[
https://issues.apache.org/jira/browse/MCOMPILER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy updated MCOMPILER-346:
---
Summary: workaround to jdk bug: assertionError inside javac when using
javax.tools API (was: JDK10: Compiler plugin trips AssertionError inside javac
when using javax.tools API)
> workaround to jdk bug: assertionError inside javac when using javax.tools API
> -
>
> Key: MCOMPILER-346
> URL: https://issues.apache.org/jira/browse/MCOMPILER-346
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Tobias Gierke
>Assignee: Olivier Lamy
>Priority: Major
> Attachments: log.txt, sample_project.tgz
>
>
> Maven 3.5.3, 64-bit linux, Oracle JDK 10.0.1
> Compilation fails with a crash inside javac *unless* the
> maven-compiler-plugin is configured with
> {code:java}
> true{code}
> I had a brief look at the sources of Modules.java in the current OpenJDK10
> and it looks like this is the assertion that gets tripped (line numbers do
> not match exactly but it's close enough):
> {code:java}
> public boolean enter(List trees, ClassSymbol c) {
> Assert.check(rootModules != null || inInitModules || !allowModules);
> return enter(trees, modules -> {}, c);
> }
> {code}
> Since the crash does not happen when invoking the compiler using commandline
> arguments I suspect the plugin does something unexpected with the javax.tools
> JavaCompiler API that later trips the exception.
> Unfortunately this is a commercial project so I cannot provide a test case :(
> The project itself is a JDK8 project we're currently migrating to JDK10 and
> while the project itself has no module-info files some of our dependencies do
> (at least Automatic-Module-Name gets set in their manifests).
> I'll attach the output of a compile run with the '-verbose' option to this
> ticket.
> Plugin configuration:
> {code:java}
>
>
>
> maven-compiler-plugin
> 3.7.0
>
> 10
> 10
> 10
>
>
> -Werror
> -verbose
>
>
>
>
>
> {code}
> Exception:
> {code:java}
> Exception in thread "main" java.lang.AssertionError
> at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
> at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46)
> at
> jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
> at
> jdk.compiler/com.sun.tools.javac.main.JavaCompiler.readSourceFile(JavaCompiler.java:829)
> at
> jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete(JavacProcessingEnvironment.java:1506)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol.complete(Symbol.java:633)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1308)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.complete(Type.java:1139)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.getTypeArguments(Type.java:1065)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:237)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:52)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.accept(Type.java:992)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visit(Printer.java:136)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:197)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:183)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.JCDiagnostic.getMessage(JCDiagnostic.java:771)
> at
> jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$Diagnosti
[jira] [Commented] (MCOMPILER-346) workaround to jdk bug: assertionError inside javac when using javax.tools API
[
https://issues.apache.org/jira/browse/MCOMPILER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501896#comment-17501896
]
Olivier Lamy commented on MCOMPILER-346:
few workaround until next release of compiler plugin.
override plexus-compiler version
org.apache.maven.plugins
maven-compiler-plugin
3.10.0
11
org.codehaus.plexus
plexus-compiler-api
2.11.0
org.codehaus.plexus
plexus-compiler-javac
2.11.0
use jdk 17
or having code compiling :P
> workaround to jdk bug: assertionError inside javac when using javax.tools API
> -
>
> Key: MCOMPILER-346
> URL: https://issues.apache.org/jira/browse/MCOMPILER-346
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Tobias Gierke
>Assignee: Olivier Lamy
>Priority: Major
> Attachments: log.txt, sample_project.tgz
>
>
> Maven 3.5.3, 64-bit linux, Oracle JDK 10.0.1
> Compilation fails with a crash inside javac *unless* the
> maven-compiler-plugin is configured with
> {code:java}
> true{code}
> I had a brief look at the sources of Modules.java in the current OpenJDK10
> and it looks like this is the assertion that gets tripped (line numbers do
> not match exactly but it's close enough):
> {code:java}
> public boolean enter(List trees, ClassSymbol c) {
> Assert.check(rootModules != null || inInitModules || !allowModules);
> return enter(trees, modules -> {}, c);
> }
> {code}
> Since the crash does not happen when invoking the compiler using commandline
> arguments I suspect the plugin does something unexpected with the javax.tools
> JavaCompiler API that later trips the exception.
> Unfortunately this is a commercial project so I cannot provide a test case :(
> The project itself is a JDK8 project we're currently migrating to JDK10 and
> while the project itself has no module-info files some of our dependencies do
> (at least Automatic-Module-Name gets set in their manifests).
> I'll attach the output of a compile run with the '-verbose' option to this
> ticket.
> Plugin configuration:
> {code:java}
>
>
>
> maven-compiler-plugin
> 3.7.0
>
> 10
> 10
> 10
>
>
> -Werror
> -verbose
>
>
>
>
>
> {code}
> Exception:
> {code:java}
> Exception in thread "main" java.lang.AssertionError
> at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
> at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46)
> at
> jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
> at
> jdk.compiler/com.sun.tools.javac.main.JavaCompiler.readSourceFile(JavaCompiler.java:829)
> at
> jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete(JavacProcessingEnvironment.java:1506)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol.complete(Symbol.java:633)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1308)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.complete(Type.java:1139)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.getTypeArguments(Type.java:1065)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:237)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:52)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.accept(Type.java:992)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visit(Printer.java:136)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:197)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:183)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.Ba
[jira] [Closed] (MSHARED-1038) Inner classes are in same compilation unit as container class
[ https://issues.apache.org/jira/browse/MSHARED-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1038. Fix Version/s: maven-dependency-analyzer-3.0.0 Assignee: Slawomir Jaranowski Resolution: Fixed > Inner classes are in same compilation unit as container class > - > > Key: MSHARED-1038 > URL: https://issues.apache.org/jira/browse/MSHARED-1038 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.12.0 >Reporter: Charles Honton >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: maven-dependency-analyzer-3.0.0 > > > Since inner classes cannot be created without a container class and will be > in same artifact as the container class, do not track inner class independent > of the container class. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MSHARED-1038) Inner classes are in same compilation unit as container class
[ https://issues.apache.org/jira/browse/MSHARED-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501897#comment-17501897 ] Hudson commented on MSHARED-1038: - Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-analyzer » master #12 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-analyzer/job/master/12/ > Inner classes are in same compilation unit as container class > - > > Key: MSHARED-1038 > URL: https://issues.apache.org/jira/browse/MSHARED-1038 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.12.0 >Reporter: Charles Honton >Assignee: Slawomir Jaranowski >Priority: Minor > Fix For: maven-dependency-analyzer-3.0.0 > > > Since inner classes cannot be created without a container class and will be > in same artifact as the container class, do not track inner class independent > of the container class. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-compiler-plugin] olamy merged pull request #97: MCOMPILER 346 workaround to jdk bug: assertion error from javaxcompiler javax.tools API
olamy merged pull request #97: URL: https://github.com/apache/maven-compiler-plugin/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MCOMPILER-346) workaround to jdk bug: assertionError inside javac when using javax.tools API
[
https://issues.apache.org/jira/browse/MCOMPILER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy resolved MCOMPILER-346.
Fix Version/s: 3.11.0
Resolution: Fixed
> workaround to jdk bug: assertionError inside javac when using javax.tools API
> -
>
> Key: MCOMPILER-346
> URL: https://issues.apache.org/jira/browse/MCOMPILER-346
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Tobias Gierke
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.11.0
>
> Attachments: log.txt, sample_project.tgz
>
>
> Maven 3.5.3, 64-bit linux, Oracle JDK 10.0.1
> Compilation fails with a crash inside javac *unless* the
> maven-compiler-plugin is configured with
> {code:java}
> true{code}
> I had a brief look at the sources of Modules.java in the current OpenJDK10
> and it looks like this is the assertion that gets tripped (line numbers do
> not match exactly but it's close enough):
> {code:java}
> public boolean enter(List trees, ClassSymbol c) {
> Assert.check(rootModules != null || inInitModules || !allowModules);
> return enter(trees, modules -> {}, c);
> }
> {code}
> Since the crash does not happen when invoking the compiler using commandline
> arguments I suspect the plugin does something unexpected with the javax.tools
> JavaCompiler API that later trips the exception.
> Unfortunately this is a commercial project so I cannot provide a test case :(
> The project itself is a JDK8 project we're currently migrating to JDK10 and
> while the project itself has no module-info files some of our dependencies do
> (at least Automatic-Module-Name gets set in their manifests).
> I'll attach the output of a compile run with the '-verbose' option to this
> ticket.
> Plugin configuration:
> {code:java}
>
>
>
> maven-compiler-plugin
> 3.7.0
>
> 10
> 10
> 10
>
>
> -Werror
> -verbose
>
>
>
>
>
> {code}
> Exception:
> {code:java}
> Exception in thread "main" java.lang.AssertionError
> at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
> at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46)
> at
> jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
> at
> jdk.compiler/com.sun.tools.javac.main.JavaCompiler.readSourceFile(JavaCompiler.java:829)
> at
> jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete(JavacProcessingEnvironment.java:1506)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol.complete(Symbol.java:633)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1308)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.complete(Type.java:1139)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.getTypeArguments(Type.java:1065)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:237)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:52)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.accept(Type.java:992)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visit(Printer.java:136)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:197)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:183)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.JCDiagnostic.getMessage(JCDiagnostic.java:771)
> at
> jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$DiagnosticSourceUnwrapper.getMessage(ClientCodeWrapper.java:799)
> at
> org.codehaus.plexus.compiler
[jira] [Closed] (MCOMPILER-346) workaround to jdk bug: assertionError inside javac when using javax.tools API
[
https://issues.apache.org/jira/browse/MCOMPILER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-346.
--
> workaround to jdk bug: assertionError inside javac when using javax.tools API
> -
>
> Key: MCOMPILER-346
> URL: https://issues.apache.org/jira/browse/MCOMPILER-346
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Tobias Gierke
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.11.0
>
> Attachments: log.txt, sample_project.tgz
>
>
> Maven 3.5.3, 64-bit linux, Oracle JDK 10.0.1
> Compilation fails with a crash inside javac *unless* the
> maven-compiler-plugin is configured with
> {code:java}
> true{code}
> I had a brief look at the sources of Modules.java in the current OpenJDK10
> and it looks like this is the assertion that gets tripped (line numbers do
> not match exactly but it's close enough):
> {code:java}
> public boolean enter(List trees, ClassSymbol c) {
> Assert.check(rootModules != null || inInitModules || !allowModules);
> return enter(trees, modules -> {}, c);
> }
> {code}
> Since the crash does not happen when invoking the compiler using commandline
> arguments I suspect the plugin does something unexpected with the javax.tools
> JavaCompiler API that later trips the exception.
> Unfortunately this is a commercial project so I cannot provide a test case :(
> The project itself is a JDK8 project we're currently migrating to JDK10 and
> while the project itself has no module-info files some of our dependencies do
> (at least Automatic-Module-Name gets set in their manifests).
> I'll attach the output of a compile run with the '-verbose' option to this
> ticket.
> Plugin configuration:
> {code:java}
>
>
>
> maven-compiler-plugin
> 3.7.0
>
> 10
> 10
> 10
>
>
> -Werror
> -verbose
>
>
>
>
>
> {code}
> Exception:
> {code:java}
> Exception in thread "main" java.lang.AssertionError
> at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155)
> at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46)
> at
> jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
> at
> jdk.compiler/com.sun.tools.javac.main.JavaCompiler.readSourceFile(JavaCompiler.java:829)
> at
> jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ImplicitCompleter.complete(JavacProcessingEnvironment.java:1506)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol.complete(Symbol.java:633)
> at
> jdk.compiler/com.sun.tools.javac.code.Symbol$ClassSymbol.complete(Symbol.java:1308)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.complete(Type.java:1139)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.getTypeArguments(Type.java:1065)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:237)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visitClassType(Printer.java:52)
> at
> jdk.compiler/com.sun.tools.javac.code.Type$ClassType.accept(Type.java:992)
> at
> jdk.compiler/com.sun.tools.javac.code.Printer.visit(Printer.java:136)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:197)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArgument(AbstractDiagnosticFormatter.java:183)
> at
> jdk.compiler/com.sun.tools.javac.util.AbstractDiagnosticFormatter.formatArguments(AbstractDiagnosticFormatter.java:165)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:111)
> at
> jdk.compiler/com.sun.tools.javac.util.BasicDiagnosticFormatter.formatMessage(BasicDiagnosticFormatter.java:67)
> at
> jdk.compiler/com.sun.tools.javac.util.JCDiagnostic.getMessage(JCDiagnostic.java:771)
> at
> jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$DiagnosticSourceUnwrapper.getMessage(ClientCodeWrapper.java:799)
> at
> org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCo
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820200207
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+ and the
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+
+
+org.junit.jupiter
+junit-jupiter-engine
+5.8.2
+test
+
+
+org.junit.platform
+junit-platform-suite-engine
+1.8.2
+test
+
+
Review comment:
I'm still not sure if we want to write documentations for external
products 😄
But from other side we should be consistent with original product
documentation.
https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine-setup-required-dependencies
There is:
> Required Dependencies
> - junit-platform-suite-api in test scope: artifact containing annotations
needed to configure a test suite
> - junit-platform-suite-engine in test runtime scope: implementation of the
TestEngine API for declarative test suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820200388
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+ and the
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+
+
+org.junit.jupiter
+junit-jupiter-engine
+5.8.2
+test
+
+
+org.junit.platform
+junit-platform-suite-engine
+1.8.2
+test
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+
+
+JUnit5Tests
Review comment:
I afraid that users can simply comply such configurations and will
be surprised
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MCOMPILER-426: --- Fix Version/s: 3.11.0 > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MCOMPILER-426: -- Assignee: Olivier Lamy > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501908#comment-17501908 ] Olivier Lamy commented on MCOMPILER-426: plexus-compiler PR https://github.com/codehaus-plexus/plexus-compiler/pull/199 > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (MNG-7247) Upgrade Maven Resolver to 1.7.2
[ https://issues.apache.org/jira/browse/MNG-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7247: Fix Version/s: 3.9.0-candidate > Upgrade Maven Resolver to 1.7.2 > --- > > Key: MNG-7247 > URL: https://issues.apache.org/jira/browse/MNG-7247 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories, Dependencies >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
Tibor17 commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820209008
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+ and the
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+
+
+org.junit.jupiter
+junit-jupiter-engine
+5.8.2
+test
+
+
+org.junit.platform
+junit-platform-suite-engine
+1.8.2
+test
+
+
+
+
+
+org.apache.maven.plugins
+maven-surefire-plugin
+
+
+JUnit5Tests
Review comment:
Don't be surprised! What is the point of Junit5 Suite? It's the same
point that the Junit4 suite has!
The Point is to start the suite class which is a similar case is in your
Surefire project. The suite children are executed by selecting `JUnit5Tests`
and not by surefire provider and that the reason you have to select it. You
must select the suite and not the children. Why we do not use the parameter
`test`? Because there is a significant difference between `includes` and
`test`. The `test` is a filter performing the selection inside of the JUnit
which cannot be used here because this way you are not able to select the root
class `JUnit5Tests` and you filter out all children. The `includes` does
exactly what we want, it does not perform filtering inside of JUnit, it
performs selection of classes that you `send` to the JUnit framework to execute
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #484: Support junit-platform-runner and junit-platform-suite-engine in plugin dependencies
Tibor17 commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820209569
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
+---+
+** JUnit5 Suite
+
+ For more information see this
+
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+ and the
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+
+
+org.junit.jupiter
+junit-jupiter-engine
+5.8.2
+test
+
+
+org.junit.platform
+junit-platform-suite-engine
+1.8.2
+test
+
+
Review comment:
@slawekjaranowski
Slawomir, we have never repeated "their" documentation. We have always
declared Surefire configuration in order to run some tests, support some
framework, declaring features we support and we made a fix to support these
features.
The JUnit documentation should mentioned us as Surefire, we have to do it,
we are the one who should understand how the framework works and how it should
be used and configured in the Surefire/Failsafe, not opposite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7278) Drop use of Plexus Logger in Maven Core
[
https://issues.apache.org/jira/browse/MNG-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501919#comment-17501919
]
Michael Osipov commented on MNG-7278:
-
Would you backport this to 3.9.0?
> Drop use of Plexus Logger in Maven Core
> ---
>
> Key: MNG-7278
> URL: https://issues.apache.org/jira/browse/MNG-7278
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1
>
>
> We decided to switch to SLF4J logging eons ago, so clean up logging:
> * drop Plexus Logger use in Maven-Core
> * align logger uses (we have injected, directly acquired, static, final)
>
> Make all core component do this:
> {noformat}
> private final Logger logger = LoggerFactory.getLogger( getClass() );
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7278) Drop use of Plexus Logger in Maven Core
[
https://issues.apache.org/jira/browse/MNG-7278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7278:
Fix Version/s: 3.9.0-candidate
> Drop use of Plexus Logger in Maven Core
> ---
>
> Key: MNG-7278
> URL: https://issues.apache.org/jira/browse/MNG-7278
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamás Cservenák
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> We decided to switch to SLF4J logging eons ago, so clean up logging:
> * drop Plexus Logger use in Maven-Core
> * align logger uses (we have injected, directly acquired, static, final)
>
> Make all core component do this:
> {noformat}
> private final Logger logger = LoggerFactory.getLogger( getClass() );
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7329) Upgrade maven-enforcer-plugin to 3.0.0
[ https://issues.apache.org/jira/browse/MNG-7329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7329: Fix Version/s: (was: 3.9.0-candidate) > Upgrade maven-enforcer-plugin to 3.0.0 > -- > > Key: MNG-7329 > URL: https://issues.apache.org/jira/browse/MNG-7329 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1 > > > Upgrade to latest maven-enforcer-plugin to allow building master with maven 4. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (MPOM-300) Replace Google Analytics with ASF Matomo
Benjamin Marwell created MPOM-300: - Summary: Replace Google Analytics with ASF Matomo Key: MPOM-300 URL: https://issues.apache.org/jira/browse/MPOM-300 Project: Maven POMs Issue Type: Improvement Reporter: Benjamin Marwell While GA is still allowed according to the [ASF Privacy Policy|https://www.apache.org/foundation/policies/privacy.html], there's now [an ASF Matomo instance|https://matomo.privacy.apache.org/]. * Matomo doesn't track full IPs, doesn't track sessions after closing the browser, etc. * Additionally, GA is already illegal in some countries,, like France. Let's replace the GA code with Matomo. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-parent] bmarwell opened a new pull request #58: [MPOM-300] switch from GA to ASF Matomo.
bmarwell opened a new pull request #58: URL: https://github.com/apache/maven-parent/pull/58 Fixes https://issues.apache.org/jira/browse/MPOM-300 Will test with a plugin later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-6815) Upgrade Guice to 4.2.2
[ https://issues.apache.org/jira/browse/MNG-6815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-6815: Fix Version/s: (was: 3.9.0-candidate) > Upgrade Guice to 4.2.2 > -- > > Key: MNG-6815 > URL: https://issues.apache.org/jira/browse/MNG-6815 > Project: Maven > Issue Type: Dependency upgrade > Components: Bootstrap & Build >Affects Versions: 3.6.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 4.0.0, 4.0.0-alpha-1 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-compiler-plugin] olamy opened a new pull request #98: [MCOMPILER-426] add flag to enable-preview java compiler feature
olamy opened a new pull request #98: URL: https://github.com/apache/maven-compiler-plugin/pull/98 Signed-off-by: Olivier Lamy Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501938#comment-17501938 ] Olivier Lamy commented on MCOMPILER-426: m-compiler-p PR https://github.com/apache/maven-compiler-plugin/pull/98 > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 merged pull request #482: [SUREFIRE-2015] Implement testRunId and RunMode in the SimpleReportEntry
Tibor17 merged pull request #482: URL: https://github.com/apache/maven-surefire/pull/482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-2015) Implement testRunId and RunMode in the SimpleReportEntry
[ https://issues.apache.org/jira/browse/SUREFIRE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-2015. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=307dee3dfc1b392c8caba3b1a261fcc7c1d72833 > Implement testRunId and RunMode in the SimpleReportEntry > > > Key: SUREFIRE-2015 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2015 > Project: Maven Surefire > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > > This ticketis the most important in SUREFIRE-1860 because it implements > RunMode and testRunId in the ReportEntry, TestSetReportEntry, > SimpleReportEntry, CategorizedReportEntry and WrappedReportEntry in > appropriate implementation form. > Additionally, we should distinguish between two events (OutputReportEntry, > TestOutputReportEntry) and therefore the interface TestReportListener handles > them via generics dependeing on the situation. > The first situation happens when provider's listeners handles the event > OutputReportEntry from System.out and System.err via the > ConsoleOutputCapture. The ConsoleOutputCapture does not have any notion about > runMode and testRunId, and therefore the only provider's listener would add > runMode and testRunId to a recreated entry which would be finally propagated > to the ForkingRunListener and TestSetRunListener. The runMode and testRunId > are determined opon the events testStarted and any test end and Thread local. > The second situation happens when ForkingRunListener and TestSetRunListener > handles TestOutputReportEntry which contains runMode and testRunId. > Some classes are deprecated in the module surefire-junit47 and can be freely > removed after the XML Reporter would be fully capable of parallel tests (must > support events chaos in one thread). That's the reason why parallel tests are > badly handled in JUnit5 reports. The provider surefire-junit47 also supports > parallel tests and we do not see the problem with undeterministic XML report, > but the reason is that the provider has a cache, eats the memory including > the std/out logs and all the messages and test events are replayed in a > sequence as if the tests were executed in one thread. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-2014) Implement testRunId and RunMode in the EventEncoder and EventDecoder
[ https://issues.apache.org/jira/browse/SUREFIRE-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-2014. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=79db90338fb474f91c76991388a35bc412ee1d46 > Implement testRunId and RunMode in the EventEncoder and EventDecoder > > > Key: SUREFIRE-2014 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2014 > Project: Maven Surefire > Issue Type: Improvement > Components: Maven Failsafe Plugin, Maven Surefire Plugin, process > forking >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M6 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 closed pull request #345: [SUREFIRE-1860] extend ReportEntry interface and SimpleReportEntry with mandatory properties runMode:String, id:long, forkId:int
Tibor17 closed pull request #345: URL: https://github.com/apache/maven-surefire/pull/345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (SUREFIRE-1860) extend ReportEntry interface and SimpleReportEntry with mandatory properties runMode:String, testRunId:long
[
https://issues.apache.org/jira/browse/SUREFIRE-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1860.
--
Resolution: Fixed
> extend ReportEntry interface and SimpleReportEntry with mandatory properties
> runMode:String, testRunId:long
> ---
>
> Key: SUREFIRE-1860
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1860
> Project: Maven Surefire
> Issue Type: New Feature
> Components: JUnit 3.x support, Junit 4.7+ (parallel) support, Junit
> 4.x support, JUnit 5.x support, Maven Failsafe Plugin, Maven Surefire Plugin,
> TestNG support
>Reporter: Tibor Digana
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M6
>
>
> We are missing two properties in the {{ReportEntry}} interface
> * *runMode:RunMode*, which "informs" the reporters that the statistics data
> is for normal tests or re-run tests
> * *testRunId:long*, which identifies the test run instead of the current ID
> represented by the combination of class+method.
> Currently the XML reporter is stateful and the run mode is determined by the
> timing and the order of normal tests and rerun tests. The problem is when we
> run the tests in parallel. After we would employ the {{testRunId:long}} we
> would not have these problems and we would solve much more like JUnit5's
> Dynamic tests and the ability to run Cucumber scripts.
> The reporters should identify the test run by the combination of *forkId* +
> test *run id*. The forks have no notion about the other forks, and it's even
> more difficult to make the test ids coherent (without duplicates) across the
> forks because they are very dynamically created and finished during the
> lifetime of the plugin execution. Therefore the reporter implementation
> should respect the *forkId* too.
> Currently the JUnit47 provider has a cache, TestMethod, which has the console
> logs in memory and sends these after the class has finished. This is memory
> resources problem. We are aiming for sending these logs immediately, and have
> the implementation stateless.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-surefire] Tibor17 commented on pull request #345: [SUREFIRE-1860] extend ReportEntry interface and SimpleReportEntry with mandatory properties runMode:String, id:long, forkId:int
Tibor17 commented on pull request #345: URL: https://github.com/apache/maven-surefire/pull/345#issuecomment-1059944350 completed in multiple PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2000) Classpath contains redundant JAR artifacts if ShadeFire provider is active
[
https://issues.apache.org/jira/browse/SUREFIRE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501941#comment-17501941
]
Tibor Digana commented on SUREFIRE-2000:
[~sjaranowski]
If you agree with me, we can close this ticket as "not a bug" due to the
{{junit-platform-runner}} has a transitive dependency {{junit:junit:4.13}}.
The suspicion that the JUnit in provider's class path comes from our project
was not confirmed.
> Classpath contains redundant JAR artifacts if ShadeFire provider is active
> --
>
> Key: SUREFIRE-2000
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2000
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin, Maven Surefire Plugin,
> surefire-shadefire
>Affects Versions: 3.0.0-M5
>Reporter: Tibor Digana
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: MANIFEST.MF-for-M4, MANIFEST.MF-for-M5,
> MANIFEST.MF-for-M6, junit5-runner.tgz
>
>
> There are extra more artifacts than necessary on the classpath if ShadeFire
> provider is used. This may cause new conflicts if testing Surefire itself.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (SUREFIRE-1936) surefire-shared-utils and surefire-shadefire version is out of sync with parent project for M5
[ https://issues.apache.org/jira/browse/SUREFIRE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1936: --- Fix Version/s: (was: 3.0.0-M6) > surefire-shared-utils and surefire-shadefire version is out of sync with > parent project for M5 > -- > > Key: SUREFIRE-1936 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1936 > Project: Maven Surefire > Issue Type: Bug > Components: surefire-shadefire, surefire-shared-utils >Affects Versions: 3.0.0-M5 >Reporter: Johannes >Assignee: Tibor Digana >Priority: Critical > > The > [surefire-shadefire|https://github.com/apache/maven-surefire/blob/a7702853750f4a6b90fab577f8c2284055a2e653/surefire-providers/common-java5/pom.xml#L68] > and > [surefire-shared-utils|https://github.com/apache/maven-surefire/blob/670dbe49855133947fbb436c97d7aa46e81d4d2c/surefire-providers/common-java5/pom.xml#L38] > components versions are out of sync with the [parent pom > version|https://github.com/apache/maven-surefire/blob/a7702853750f4a6b90fab577f8c2284055a2e653/surefire-providers/common-java5/pom.xml#L26] > for the 3.0.0-M5 version. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (SUREFIRE-1936) surefire-shared-utils and surefire-shadefire version is out of sync with parent project for M5
[ https://issues.apache.org/jira/browse/SUREFIRE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1936. -- Resolution: Duplicate > surefire-shared-utils and surefire-shadefire version is out of sync with > parent project for M5 > -- > > Key: SUREFIRE-1936 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1936 > Project: Maven Surefire > Issue Type: Bug > Components: surefire-shadefire, surefire-shared-utils >Affects Versions: 3.0.0-M5 >Reporter: Johannes >Assignee: Tibor Digana >Priority: Critical > > The > [surefire-shadefire|https://github.com/apache/maven-surefire/blob/a7702853750f4a6b90fab577f8c2284055a2e653/surefire-providers/common-java5/pom.xml#L68] > and > [surefire-shared-utils|https://github.com/apache/maven-surefire/blob/670dbe49855133947fbb436c97d7aa46e81d4d2c/surefire-providers/common-java5/pom.xml#L38] > components versions are out of sync with the [parent pom > version|https://github.com/apache/maven-surefire/blob/a7702853750f4a6b90fab577f8c2284055a2e653/surefire-providers/common-java5/pom.xml#L26] > for the 3.0.0-M5 version. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #71: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2
slawekjaranowski commented on pull request #71: URL: https://github.com/apache/maven-apache-parent/pull/71#issuecomment-1060006994 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #71: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2
dependabot[bot] commented on pull request #71: URL: https://github.com/apache/maven-apache-parent/pull/71#issuecomment-1060006998 Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request `@dependabot recreate`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #70: Bump maven-site-plugin from 3.10.0 to 3.11.0
slawekjaranowski commented on pull request #70: URL: https://github.com/apache/maven-apache-parent/pull/70#issuecomment-1060007196 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #70: Bump maven-site-plugin from 3.10.0 to 3.11.0
dependabot[bot] commented on pull request #70: URL: https://github.com/apache/maven-apache-parent/pull/70#issuecomment-1060007805 Looks like org.apache.maven.plugins:maven-site-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] closed pull request #70: Bump maven-site-plugin from 3.10.0 to 3.11.0
dependabot[bot] closed pull request #70: URL: https://github.com/apache/maven-apache-parent/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #69: Bump maven-compiler-plugin from 3.8.1 to 3.10.0
slawekjaranowski commented on pull request #69: URL: https://github.com/apache/maven-apache-parent/pull/69#issuecomment-1060013277 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #68: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
slawekjaranowski commented on pull request #68: URL: https://github.com/apache/maven-apache-parent/pull/68#issuecomment-1060013319 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] closed pull request #69: Bump maven-compiler-plugin from 3.8.1 to 3.10.0
dependabot[bot] closed pull request #69: URL: https://github.com/apache/maven-apache-parent/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #69: Bump maven-compiler-plugin from 3.8.1 to 3.10.0
dependabot[bot] commented on pull request #69: URL: https://github.com/apache/maven-apache-parent/pull/69#issuecomment-1060014006 Looks like org.apache.maven.plugins:maven-compiler-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #68: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] commented on pull request #68: URL: https://github.com/apache/maven-apache-parent/pull/68#issuecomment-1060014056 Looks like org.apache.maven.plugins:maven-javadoc-plugin is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-apache-parent] dependabot[bot] closed pull request #68: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] closed pull request #68: URL: https://github.com/apache/maven-apache-parent/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] bmarwell commented on pull request #58: [MPOM-300] switch from GA to ASF Matomo.
bmarwell commented on pull request #58: URL: https://github.com/apache/maven-parent/pull/58#issuecomment-1060026471 Generated site (example from the checkstyle plugin):  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jenkins-lib] olamy merged pull request #4: reduce matrix build with less maven core version and the last one
olamy merged pull request #4: URL: https://github.com/apache/maven-jenkins-lib/pull/4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-6399) Lift JDK minimum to JDK 8
[
https://issues.apache.org/jira/browse/MNG-6399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6399.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[52b718614ab379dd909e70e4db3b00da54b91263|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=52b718614ab379dd909e70e4db3b00da54b91263]
for {{maven-3.9.x}} branch.
> Lift JDK minimum to JDK 8
> -
>
> Key: MNG-6399
> URL: https://issues.apache.org/jira/browse/MNG-6399
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> I would like to lift the minimum of Maven Core to JDK 8 (I think it's time)..
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MNG-6399) Lift JDK minimum to JDK 8
[ https://issues.apache.org/jira/browse/MNG-6399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-6399: - > Lift JDK minimum to JDK 8 > - > > Key: MNG-6399 > URL: https://issues.apache.org/jira/browse/MNG-6399 > Project: Maven > Issue Type: Task >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > > I would like to lift the minimum of Maven Core to JDK 8 (I think it's time).. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Reopened] (MNG-7247) Upgrade Maven Resolver to 1.7.2
[ https://issues.apache.org/jira/browse/MNG-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-7247: - > Upgrade Maven Resolver to 1.7.2 > --- > > Key: MNG-7247 > URL: https://issues.apache.org/jira/browse/MNG-7247 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories, Dependencies >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MNG-7247) Upgrade Maven Resolver to 1.7.2
[
https://issues.apache.org/jira/browse/MNG-7247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7247.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[453c17371319e985d3a6caba84ae240bb33d6870|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=453c17371319e985d3a6caba84ae240bb33d6870]
for {{maven-3.9.x}} branch.
> Upgrade Maven Resolver to 1.7.2
> ---
>
> Key: MNG-7247
> URL: https://issues.apache.org/jira/browse/MNG-7247
> Project: Maven
> Issue Type: Dependency upgrade
> Components: Artifacts and Repositories, Dependencies
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MNG-6878) Upgrade Guice to 4.2.3
[
https://issues.apache.org/jira/browse/MNG-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reopened MNG-6878:
-
> Upgrade Guice to 4.2.3
> --
>
> Key: MNG-6878
> URL: https://issues.apache.org/jira/browse/MNG-6878
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> h4. Changes since Guice 4.2.2 [https://github.com/google/guice/wiki/Guice423]
> [http://google.github.io/guice/api-docs/4.2.3/api-diffs/changes.html]
> * Java14 support (updated asm).
> * Added {{Injector.getElements}} API, to expose all Element SPI types from
> the Injector.
> * Added {{Injector.getAllMembersInjectorInjectionPoints}} API, to expose
> injection points created by arbitrary members injection.
> * Added {{getAlternateKeys}} to Multibinder SPI types
> ({{MultibinderBinding}}, {{MapBinderBinding}}, {{OptionalBinderBinding}}), to
> explicitly list the other keys these bindings are available as.
> * Scan for (and bind) @Provides-like methods in a consistent ordering,
> rather than relying on the non-deterministic Class.getDeclaredMembers
> ordering.
> * Update {{DaggerAdapter}} to work with newer dagger code.
> * Fixed a [subtle
> bug|https://github.com/google/guice/commit/f8cc1718a33a868e9951f7d3d6b4f74d8b1a1548]
> with eager singleton evaluation.
> * Updated {{@RequestScope}}'s scope annotation to the JSR330 {{@Scope}}, so
> it can be reused by non-Guice DI systems.
> * Clarified the error message when an injectable constructor is missing.
> * Add deprecated overloads to various {{Modules}} methods, to make it
> clearer when calling them is unnecessary.
> * Added factory methods to {{Modules}} for common Binder configuration
> methods, to make it easier to configure them.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MNG-6878) Upgrade Guice to 4.2.3
[
https://issues.apache.org/jira/browse/MNG-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6878.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[e820dbb24e22e12fa058c59c6b3cf555da07abb5|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=e820dbb24e22e12fa058c59c6b3cf555da07abb5]
for {{maven-3.9.x}} branch.
> Upgrade Guice to 4.2.3
> --
>
> Key: MNG-6878
> URL: https://issues.apache.org/jira/browse/MNG-6878
> Project: Maven
> Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> h4. Changes since Guice 4.2.2 [https://github.com/google/guice/wiki/Guice423]
> [http://google.github.io/guice/api-docs/4.2.3/api-diffs/changes.html]
> * Java14 support (updated asm).
> * Added {{Injector.getElements}} API, to expose all Element SPI types from
> the Injector.
> * Added {{Injector.getAllMembersInjectorInjectionPoints}} API, to expose
> injection points created by arbitrary members injection.
> * Added {{getAlternateKeys}} to Multibinder SPI types
> ({{MultibinderBinding}}, {{MapBinderBinding}}, {{OptionalBinderBinding}}), to
> explicitly list the other keys these bindings are available as.
> * Scan for (and bind) @Provides-like methods in a consistent ordering,
> rather than relying on the non-deterministic Class.getDeclaredMembers
> ordering.
> * Update {{DaggerAdapter}} to work with newer dagger code.
> * Fixed a [subtle
> bug|https://github.com/google/guice/commit/f8cc1718a33a868e9951f7d3d6b4f74d8b1a1548]
> with eager singleton evaluation.
> * Updated {{@RequestScope}}'s scope annotation to the JSR330 {{@Scope}}, so
> it can be reused by non-Guice DI systems.
> * Clarified the error message when an injectable constructor is missing.
> * Add deprecated overloads to various {{Modules}} methods, to make it
> clearer when calling them is unnecessary.
> * Added factory methods to {{Modules}} for common Binder configuration
> methods, to make it easier to configure them.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MNG-7068) Active dependency management for Google Guice/Guava
[ https://issues.apache.org/jira/browse/MNG-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-7068: - > Active dependency management for Google Guice/Guava > --- > > Key: MNG-7068 > URL: https://issues.apache.org/jira/browse/MNG-7068 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Affects Versions: 3.6.3 >Reporter: Boris Unckel >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > > The current pom includes com.google.inject:guice with the default transitive > dependency of com.google.guava:guava. Guava has declared several > dependencies, which are not needed at runtime. Only > com.google.guava:failureaccess is needed. > The proposal is first to add com.google.guava:guava to the excludes of guice. > Second guava and failureaccess shall be added as direct dependencies. > This has two advantages: Downstream projects only get the needed dependencies > and the version of guava can be independently set. > The runtime dependencies for Guava are explained in the last section of the > [README|https://github.com/google/guava/tree/v30.1] "Important Warnings" #3 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MNG-7068) Active dependency management for Google Guice/Guava
[
https://issues.apache.org/jira/browse/MNG-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7068.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[e1b46e233930b46f83bc47c373beb41681bb6972|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=e1b46e233930b46f83bc47c373beb41681bb6972]
for {{maven-3.9.x}} branch.
> Active dependency management for Google Guice/Guava
> ---
>
> Key: MNG-7068
> URL: https://issues.apache.org/jira/browse/MNG-7068
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Affects Versions: 3.6.3
>Reporter: Boris Unckel
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> The current pom includes com.google.inject:guice with the default transitive
> dependency of com.google.guava:guava. Guava has declared several
> dependencies, which are not needed at runtime. Only
> com.google.guava:failureaccess is needed.
> The proposal is first to add com.google.guava:guava to the excludes of guice.
> Second guava and failureaccess shall be added as direct dependencies.
> This has two advantages: Downstream projects only get the needed dependencies
> and the version of guava can be independently set.
> The runtime dependencies for Guava are explained in the last section of the
> [README|https://github.com/google/guava/tree/v30.1] "Important Warnings" #3
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MNG-6826) Remove condition check for JDK8+ in FileSizeFormatTest
[ https://issues.apache.org/jira/browse/MNG-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-6826: - > Remove condition check for JDK8+ in FileSizeFormatTest > -- > > Key: MNG-6826 > URL: https://issues.apache.org/jira/browse/MNG-6826 > Project: Maven > Issue Type: Improvement > Components: Bootstrap & Build >Affects Versions: 3.6.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Trivial > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > > Conditions to check for JDK8+ in FileSizeFormatTest test cases are obsolete > with the lift to JDK8. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Reopened] (MNG-7019) Notify also at start when profile is missing
[ https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MNG-7019: - > Notify also at start when profile is missing > > > Key: MNG-7019 > URL: https://issues.apache.org/jira/browse/MNG-7019 > Project: Maven > Issue Type: Sub-task > Components: Profiles >Affects Versions: 3.6.3 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate > > > This will implement the first task on the list. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MNG-6826) Remove condition check for JDK8+ in FileSizeFormatTest
[
https://issues.apache.org/jira/browse/MNG-6826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6826.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[7d6f281fe3a4ccdc532c84d421c2680cfb79a68d|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=7d6f281fe3a4ccdc532c84d421c2680cfb79a68d]
for {{maven-3.9.x}} branch.
> Remove condition check for JDK8+ in FileSizeFormatTest
> --
>
> Key: MNG-6826
> URL: https://issues.apache.org/jira/browse/MNG-6826
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap & Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Trivial
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> Conditions to check for JDK8+ in FileSizeFormatTest test cases are obsolete
> with the lift to JDK8.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MNG-7019) Notify also at start when profile is missing
[
https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-7019.
---
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
Resolution: Fixed
Fixed with
[6b7beb4db8ad15f1ed26c08df32d6ac1ae96ac0c|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=6b7beb4db8ad15f1ed26c08df32d6ac1ae96ac0c]
for {{maven-3.9.x}} branch.
> Notify also at start when profile is missing
>
>
> Key: MNG-7019
> URL: https://issues.apache.org/jira/browse/MNG-7019
> Project: Maven
> Issue Type: Sub-task
> Components: Profiles
>Affects Versions: 3.6.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> This will implement the first task on the list.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Reopened] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reopened MNG-6972:
-
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6972.
---
Resolution: Fixed
Fixed with
[a55300a588d3694966fd797323304e1ed0bc6de1|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a55300a588d3694966fd797323304e1ed0bc6de1]
for {{maven-3.9.x}} branch.
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0-candidate
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-6972) Allow access to org.apache.maven.graph
[
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6972:
Fix Version/s: 3.9.0
(was: 3.9.0-candidate)
> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
> Issue Type: Improvement
> Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
> Labels: easyfix, pull-request-available
> Fix For: 4.0.0, 4.0.0-alpha-1, 3.9.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in
> maven-core/src/main/resources/META-INF/maven/extension.xml so the
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError:
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency
> graph is out of date. This is because the graph is only rebuilt after
> executing _all_ extensions. One solution to this would be to update the
> {{MavenSession}} and setting the new dependency graph in the first extension,
> but for this we need access to the {{GraphBuilder}}.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7316:
Fix Version/s: wontfix-candidate
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [maven-compiler-plugin] olamy merged pull request #98: [MCOMPILER-426] add flag to enable-preview java compiler feature
olamy merged pull request #98: URL: https://github.com/apache/maven-compiler-plugin/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MCOMPILER-426. -- > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy resolved MCOMPILER-426. Resolution: Fixed > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MCOMPILER-244) Compiler plugin silently drops -XD flags when fork=false
[
https://issues.apache.org/jira/browse/MCOMPILER-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-244.
--
Assignee: Olivier Lamy
Resolution: Won't Fix
> Compiler plugin silently drops -XD flags when fork=false
>
>
> Key: MCOMPILER-244
> URL: https://issues.apache.org/jira/browse/MCOMPILER-244
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.0, 3.1, 3.2, 3.3
>Reporter: Paweł Kozioł
>Assignee: Olivier Lamy
>Priority: Major
>
> I have Java code that uses two classes from private Java API
> (sun.security.\*). When i tried to compile it using jdk1.8.0_45 it failed
> with error saying that package sun.security.\* does not exist. I found that i
> should add flag {{-XDignore.symbol.file}} to compiler arguments.
> It turns out that Maven Compiler Plugin silently ignores that flag and it
> does not work unless you also specify {{true}} ([thanks to
> karmakaze from StackOverflow for
> sollution|http://stackoverflow.com/a/30472473])
> If you cannot fix this to work with fork=false maybe you could add printing
> warning/error to stdout?
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MCOMPILER-340) Give a clear error when compiler can't find the JDK
[
https://issues.apache.org/jira/browse/MCOMPILER-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-340.
--
Resolution: Duplicate
duplicate of MCOMPILER-307
> Give a clear error when compiler can't find the JDK
> ---
>
> Key: MCOMPILER-340
> URL: https://issues.apache.org/jira/browse/MCOMPILER-340
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Cap10Bill
>Priority: Major
>
> I had an issue where my settings.xml pointed to a JDK that didn't exist and I
> received the following error (Below) which wasn't very helpful.
> The error should have been more clear about not finding JDK
> Additionally the link the exception wasn't very helpful
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile)
> on project schedulesyncservice-s
> chema: Compilation failure -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (d
> efault-compile) on project schedulesyncservice-schema: Compilation failure
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:497)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
> Caused by: org.apache.maven.plugin.compiler.CompilationFailureException:
> Compilation failure
> at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute
> (AbstractCompilerMojo.java:915)
> at org.apache.maven.plugin.compiler.CompilerMojo.execute
> (CompilerMojo.java:129)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:497)
> at org.codehaus.plexus.classworlds.laun
[jira] [Commented] (MCOMPILER-307) Improve error message when compiler executable path invalid
[
https://issues.apache.org/jira/browse/MCOMPILER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502038#comment-17502038
]
Olivier Lamy commented on MCOMPILER-307:
currently I got such error message which looks to be a human readable error
message :) `Cannot run program "/invalid/path/to/bin/javac"`
{quote}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.10.1-SNAPSHOT:compile
(default-compile) on project plexus-compiler-api: Fatal error compiling: Error
while executing the external compiler. Error while executing process. Cannot
run program "/invalid/path/to/bin/javac" (in directory
"/Volumes/workspace/dev/sources/plexus/plexus-compiler/plexus-compiler-api"):
error=2, No such file or directory -> [Help 1]
{quote}
> Improve error message when compiler executable path invalid
> ---
>
> Key: MCOMPILER-307
> URL: https://issues.apache.org/jira/browse/MCOMPILER-307
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.6.2
>Reporter: Bryan Parry
>Priority: Major
> Attachments: Maven compiler error.txt
>
>
> When the compiler executable path and fork properties are set, and also the
> compiler executable file does not exist, a CompilationFailureException is
> thrown with a message: "Compilation failure". The plugin should be able to
> check whether the compiler executable is a valid file, and print a message if
> it does not exist (e.g. {{"Path to compiler executable " + path + " is
> invalid. File not found."}})
> Here is an example of the maven compiler properties that can cause the error
> to occur:
> {code}
>
>
> /invalid/path/to/bin/javac
> true
>
> {code}
> This error can be tricky to debug when a specific maven profile is enabled
> only on a build server by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MCOMPILER-307) Improve error message when compiler executable path invalid
[
https://issues.apache.org/jira/browse/MCOMPILER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-307.
--
Resolution: Not A Problem
if you have more concern about the error message please reopen.
> Improve error message when compiler executable path invalid
> ---
>
> Key: MCOMPILER-307
> URL: https://issues.apache.org/jira/browse/MCOMPILER-307
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.6.2
>Reporter: Bryan Parry
>Priority: Major
> Attachments: Maven compiler error.txt
>
>
> When the compiler executable path and fork properties are set, and also the
> compiler executable file does not exist, a CompilationFailureException is
> thrown with a message: "Compilation failure". The plugin should be able to
> check whether the compiler executable is a valid file, and print a message if
> it does not exist (e.g. {{"Path to compiler executable " + path + " is
> invalid. File not found."}})
> Here is an example of the maven compiler properties that can cause the error
> to occur:
> {code}
>
>
> /invalid/path/to/bin/javac
> true
>
> {code}
> This error can be tricky to debug when a specific maven profile is enabled
> only on a build server by default.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502040#comment-17502040 ] Hudson commented on MCOMPILER-426: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-compiler-plugin » master #36 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-compiler-plugin/job/master/36/ > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MCOMPILER-347) Includes and excludes not passed into CompilerConfiguration
[
https://issues.apache.org/jira/browse/MCOMPILER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-347.
--
Assignee: Olivier Lamy
Resolution: Won't Fix
groovy-eclipse-compiler is not maintained here please contact the appropriate
project
> Includes and excludes not passed into CompilerConfiguration
> ---
>
> Key: MCOMPILER-347
> URL: https://issues.apache.org/jira/browse/MCOMPILER-347
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.5
>Reporter: zhangchang
>Assignee: Olivier Lamy
>Priority: Major
>
> Some groovy script is only for runtime excute, other source need compile for
> test.
> So I set exclude in maven-compiler-plugin tag, but it not work.
> {code:java}
>
> ...
>
>
> maven-compiler-plugin
> 3.5
>
> groovy-eclipse-compiler
>
> **/rest/*
>
>
>
>
> org.codehaus.groovy
> groovy-eclipse-compiler
> 2.9.2-01
>
>
> org.codehaus.groovy
> groovy-eclipse-batch
> 2.4.3-01
>
>
>
>
> ...
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Closed] (MCOMPILER-363) Use of new feature implemented in maven-shared-incremental 1.2-SNAPSHOT
[ https://issues.apache.org/jira/browse/MCOMPILER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MCOMPILER-363. -- Assignee: Olivier Lamy Resolution: Won't Fix feature close > Use of new feature implemented in maven-shared-incremental 1.2-SNAPSHOT > --- > > Key: MCOMPILER-363 > URL: https://issues.apache.org/jira/browse/MCOMPILER-363 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Liwae Lamaa >Assignee: Olivier Lamy >Priority: Major > > The minor change in maven-compiler-plugin is related to the use of the > dependency change detection done in > https://issues.apache.org/jira/browse/MSHARED-763. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MCOMPILER-426) dedicated option for enabling preview feature
[ https://issues.apache.org/jira/browse/MCOMPILER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502043#comment-17502043 ] Hudson commented on MCOMPILER-426: -- Build succeeded in Jenkins: Maven » Ci Reporting Builds Tests » maven-compiler-plugin » master #4 See https://ci-maven.apache.org/job/Maven/job/ci-reporting-test/job/maven-compiler-plugin/job/master/4/ > dedicated option for enabling preview feature > - > > Key: MCOMPILER-426 > URL: https://issues.apache.org/jira/browse/MCOMPILER-426 > Project: Maven Compiler Plugin > Issue Type: New Feature >Reporter: Clément Guillaume >Assignee: Olivier Lamy >Priority: Minor > Fix For: 3.11.0 > > > Would it make sense to add a new parameter for enabling preview features? > The javac compiler implementation would transform it to a --enable-preview > argument > I think a similar work has been done for -parameters MCOMPILER-298 > > With this feature it become easy for tool like m2e to automatically configure > the IDE base on the maven configuration (see > [https://bugs.eclipse.org/bugs/show_bug.cgi?id=518218]) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Closed] (MCOMPILER-388) Certain errors appearing at the end of error stream are not parsed and displayed
[
https://issues.apache.org/jira/browse/MCOMPILER-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-388.
--
Assignee: Olivier Lamy
Resolution: Fixed
already fixed with a previous release of plexus-compiler
> Certain errors appearing at the end of error stream are not parsed and
> displayed
>
>
> Key: MCOMPILER-388
> URL: https://issues.apache.org/jira/browse/MCOMPILER-388
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: James Gough
>Assignee: Olivier Lamy
>Priority: Major
>
> Whilst investigating [MTOOLCHAINS-19] I came across a bug where certain
> errors are not parsed and displayed to the user, the specific example is when
> the compiler has an error for an access/bad source file.
> Using git bisect I found the issue to be related to the upgrade of the
> plexus-compiler:
> {code:bash}
> commit db6050f06e22065f7687ae0c7cda616e4183a9b8
> Author: Robert Scholte
> Date: Sun Jun 26 14:33:13 2016 +
> [MCOMPILER-269] Support modulepath (Java9/Jigsaw)
> [MCOMPILER-270] Support release=8 on JDK 9 (with fallback on source=8 and
> target=8 on JDK 8)
> Upgrade plexus-compiler to 2.8
> {code}
> The issue only seems to manifest during a compile out of process compilation,
> which then relies on parsing the output of the forked process.
> I have provide a merged bug fix to the plexus-compiler project
> https://github.com/codehaus-plexus/plexus-compiler/pull/63 that fixes the
> issue.
> To fix this bug in the maven-compiler we will need to use the above fix.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (MCOMPILER-480) Running om macOS Monterey produces an error
[
https://issues.apache.org/jira/browse/MCOMPILER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502073#comment-17502073
]
Olivier Lamy commented on MCOMPILER-480:
using osx everyday and running mvn from console I never have any issue.
Should reported to IntelliJ folks or please give us something to reproduce.
> Running om macOS Monterey produces an error
> ---
>
> Key: MCOMPILER-480
> URL: https://issues.apache.org/jira/browse/MCOMPILER-480
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
> Environment: macOS 12.1 Monterey
>Reporter: Michal Sladek
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> We get the following error building our project with MCP 3.9.0 on 12.1
> Morterey macOS (verified on 2 other machines).
> Running on maven 3.8.3 and 3.8.4.
> The problem disappears when downgrading to 3.8.1. We haven't observed this
> issue on ubuntu os neither windows machines.
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project dokgen: Error while storing the mojo status:
> Input length = 1 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project fp-dokgen: Error while storing the mojo
> status
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error while
> storing the mojo status
> at
> org.apache.maven.shared.incremental.IncrementalBuildHelper.afterRebuildExecution
> (IncrementalBuildHelper.java:338)
> at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute
> (AbstractCompilerMojo.java:1191)
> at org.apache.maven.plugin.compiler.TestCompilerMojo.execute
> (TestCompilerMojo.java:175)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.ex
[jira] [Closed] (MCOMPILER-480) Running om macOS Monterey produces an error
[
https://issues.apache.org/jira/browse/MCOMPILER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MCOMPILER-480.
--
Assignee: Olivier Lamy
Resolution: Cannot Reproduce
closing as "cannot reproduce"
if you have more details please reopen it.
> Running om macOS Monterey produces an error
> ---
>
> Key: MCOMPILER-480
> URL: https://issues.apache.org/jira/browse/MCOMPILER-480
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
> Environment: macOS 12.1 Monterey
>Reporter: Michal Sladek
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> We get the following error building our project with MCP 3.9.0 on 12.1
> Morterey macOS (verified on 2 other machines).
> Running on maven 3.8.3 and 3.8.4.
> The problem disappears when downgrading to 3.8.1. We haven't observed this
> issue on ubuntu os neither windows machines.
> {code:java}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project dokgen: Error while storing the mojo status:
> Input length = 1 -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-compiler-plugin:3.9.0:testCompile
> (default-testCompile) on project fp-dokgen: Error while storing the mojo
> status
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error while
> storing the mojo status
> at
> org.apache.maven.shared.incremental.IncrementalBuildHelper.afterRebuildExecution
> (IncrementalBuildHelper.java:338)
> at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute
> (AbstractCompilerMojo.java:1191)
> at org.apache.maven.plugin.compiler.TestCompilerMojo.execute
> (TestCompilerMojo.java:175)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
>
[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request #107: Bump maven-plugins from 34 to 35
dependabot[bot] opened a new pull request #107: URL: https://github.com/apache/maven-invoker-plugin/pull/107 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] dependabot[bot] opened a new pull request #16: Bump maven-plugins from 34 to 35
dependabot[bot] opened a new pull request #16: URL: https://github.com/apache/maven-resources-plugin/pull/16 Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35. Commits See full diff in https://github.com/apache/maven-parent/commits";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] andreybpanfilov edited a comment on pull request #190: [SUREFIRE-1535] Surefire unable to run testng suites in parallel
andreybpanfilov edited a comment on pull request #190: URL: https://github.com/apache/maven-surefire/pull/190#issuecomment-404185429 > I expected these two FORKTESTSET, TEST_SUITE_XML_FILES been exclusive According to surefire documentation these two options should be mutually exclusive, unfortunately from code perspective they aren't and there is some mess in TestNGProvider#invoke (my initial attempt was to change this method, but related changes are less straightforward: https://github.com/andreybpanfilov/maven-surefire/commit/fb4ea46be677a1eff55c8bf692c6cf9412dd0cbc) > Question, should be the testSuiteDefinition.getSuiteXmlFiles() be already filled up with value and then testSet become null? Here we interchanged these two, but mabe the (pre)caller of BooterSerializer should detect this situation with XML Suites. At first glance there is no place where we can modify TestRequest#suiteXmlFiles, doing that in ForkStarter#runSuitesForkPerTestSet or ForkStarter#fork will cause mutation, cloning is useless because next call is BooterSerializer#serialize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] asfgit merged pull request #58: [MPOM-300] switch from GA to ASF Matomo.
asfgit merged pull request #58: URL: https://github.com/apache/maven-parent/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] hboutemy commented on pull request #58: [MPOM-300] switch from GA to ASF Matomo.
hboutemy commented on pull request #58: URL: https://github.com/apache/maven-parent/pull/58#issuecomment-1060246990 notice that the new tracking will be directly used for main Maven site once update is merged to SNAPSHOT POM => you can immediately see the new tracking in Matomo for release documentation, it will happen on future releases if we create a script to automatically update an old generated documentation, we'll be able to upgrade old releases with svnpubsub... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-300) Replace Google Analytics with ASF Matomo
[ https://issues.apache.org/jira/browse/MPOM-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502099#comment-17502099 ] Hudson commented on MPOM-300: - Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #13 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/13/ > Replace Google Analytics with ASF Matomo > > > Key: MPOM-300 > URL: https://issues.apache.org/jira/browse/MPOM-300 > Project: Maven POMs > Issue Type: Improvement >Reporter: Benjamin Marwell >Priority: Major > > While GA is still allowed according to the [ASF Privacy > Policy|https://www.apache.org/foundation/policies/privacy.html], there's now > [an ASF Matomo instance|https://matomo.privacy.apache.org/]. > * Matomo doesn't track full IPs, doesn't track sessions after closing the > browser, etc. > * Additionally, GA is already illegal in some countries,, like France. > Let's replace the GA code with Matomo. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (MRESOLVER-246) m-deploy-p will create hashes for hashes
[
https://issues.apache.org/jira/browse/MRESOLVER-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17502117#comment-17502117
]
Benjamin Marwell commented on MRESOLVER-246:
Ok, understood.
Maybe what I actually want is "let's update the Maven2 repository layout to
also support more modern hashes".
> m-deploy-p will create hashes for hashes
>
>
> Key: MRESOLVER-246
> URL: https://issues.apache.org/jira/browse/MRESOLVER-246
> Project: Maven Resolver
> Issue Type: Bug
>Reporter: Benjamin Marwell
>Priority: Major
>
> Hi everyone,
> recent ASF parent pom will create hashes for source-release-zip files using
> the checksum-maven-plugin.
> However, the SHIRO project decided to hash ALL artifacts:
> {code:xml}
>
> org.apache.maven.plugins
> maven-gpg-plugin
>
>
>
> **/*.md5
> **/*.sha1
> **/*.sha256
> **/*.sha512
> **/*.asc
>
> **/*.sha3512
>
>
>
>
> net.nicoulaj.maven.plugins
> checksum-maven-plugin
> 1.11
>
>
> source-release-checksum
> none
>
>
> main-artifact-checksum
> verify
>
> artifacts
>
>
>
>
>
> SHA-256
> SHA-512
> SHA3-512
>
> false
>
> true
>
>
> {code}
> Now as you can see, gpg plugin had to be extended, but we also create
> *.sha3512 files. Those and all other hashes are being hashed by the deploy
> plugin, though:
> {code}
> $ ls -1F ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/*sources*
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.asc
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.md5
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha1
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha256
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha256.md5
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha256.sha1
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha3512
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha3512.md5
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha3512.sha1
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha512
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha512.md5
> ./org/apache/shiro/shiro-lang/1.9.0-SNAPSHOT/shiro-lang-1.9.0-20220303.204242-1-sources.jar.sha512.sha1
> {code}
> Notice the *.sha512.md1 and *.sha512.sha1 files.
> Currently there is no exclusion possible.
> Therefore:
> * Let's add an exclusion parameter for hashing, similar to gpg's one.
> * set a sane default (to be discussed).
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
