Tibor17 commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820209569



##########
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##########
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
 </dependencies>
 +---+
 
+** JUnit5 Suite
+
+  For more information see this
+  
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+  and the 
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+<dependencies>
+    <dependency>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter-engine</artifactId>
+        <version>5.8.2</version>
+        <scope>test</scope>
+    </dependency>
+    <dependency>
+        <groupId>org.junit.platform</groupId>
+        <artifactId>junit-platform-suite-engine</artifactId>
+        <version>1.8.2</version>
+        <scope>test</scope>
+    </dependency>
+</dependencies>

Review comment:
       @slawekjaranowski 
   Slawomir, we have never repeated "their" documentation. We have always 
declared Surefire configuration in order to run some tests, support some 
framework, declaring features we support and we made a fix to support these 
features.
   The JUnit documentation should mentioned us as Surefire, we have to do it, 
we are the one who should understand how the framework works and how it should 
be used and configured in the Surefire/Failsafe, not opposite.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to