slawekjaranowski commented on a change in pull request #484:
URL: https://github.com/apache/maven-surefire/pull/484#discussion_r820200207



##########
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##########
@@ -411,6 +411,42 @@ Using JUnit 5 Platform
 </dependencies>
 +---+
 
+** JUnit5 Suite
+
+  For more information see this
+  
{{{https://github.com/apache/maven-surefire/tree/master/surefire-its/src/test/resources/junit5-suite}example}}
+  and the 
{{{https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine}tutorial}}.
+
++---+
+<dependencies>
+    <dependency>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter-engine</artifactId>
+        <version>5.8.2</version>
+        <scope>test</scope>
+    </dependency>
+    <dependency>
+        <groupId>org.junit.platform</groupId>
+        <artifactId>junit-platform-suite-engine</artifactId>
+        <version>1.8.2</version>
+        <scope>test</scope>
+    </dependency>
+</dependencies>

Review comment:
       I'm still not sure if we want to write documentations for external 
products ....  😄 
   But from other side we should be consistent with original product 
   documentation.
   
https://junit.org/junit5/docs/current/user-guide/#junit-platform-suite-engine-setup-required-dependencies
   
   There is:
   
   > Required Dependencies
   > - junit-platform-suite-api in test scope: artifact containing annotations 
needed to configure a test suite
   > - junit-platform-suite-engine in test runtime scope: implementation of the 
TestEngine API for declarative test suites
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to