andreybpanfilov edited a comment on pull request #190: URL: https://github.com/apache/maven-surefire/pull/190#issuecomment-404185429
> I expected these two FORKTESTSET, TEST_SUITE_XML_FILES been exclusive According to surefire documentation these two options should be mutually exclusive, unfortunately from code perspective they aren't and there is some mess in TestNGProvider#invoke (my initial attempt was to change this method, but related changes are less straightforward: https://github.com/andreybpanfilov/maven-surefire/commit/fb4ea46be677a1eff55c8bf692c6cf9412dd0cbc) > Question, should be the testSuiteDefinition.getSuiteXmlFiles() be already filled up with value and then testSet become null? Here we interchanged these two, but mabe the (pre)caller of BooterSerializer should detect this situation with XML Suites. At first glance there is no place where we can modify TestRequest#suiteXmlFiles, doing that in ForkStarter#runSuitesForkPerTestSet or ForkStarter#fork will cause mutation, cloning is useless because next call is BooterSerializer#serialize. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
