[GitHub] [lucene-solr] iverase commented on pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint
iverase commented on pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-751994065 if there are no more comments, I will push this change next week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be rel
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be relatively quick.
> *Reviewing diffs manually*
> * switch to branch jira/LUCENE-9570 which the PR
[jira] [Created] (LUCENE-9651) Correct javadoc for benchmarks
Dawid Weiss created LUCENE-9651:
---
Summary: Correct javadoc for benchmarks
Key: LUCENE-9651
URL: https://issues.apache.org/jira/browse/LUCENE-9651
Project: Lucene - Core
Issue Type: Task
Reporter: Dawid Weiss
Assignee: Dawid Weiss
Javadoc still mentions ant
{code}
Easiest way to run a benchmarks is using the predefined ant task:
{code}
It'd be good to correct it to use gradle (or direct java -jar... calls).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be relatively quick.
> *Reviewing diffs manually*
> * switch to branch jira/LUCENE-9570 which the PR is based on:
> {code:java}
> git remote add dweiss g..
[GitHub] [lucene-solr] trdillon commented on a change in pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
trdillon commented on a change in pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#discussion_r549674546 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-caching.xml ## @@ -21,19 +21,16 @@
[GitHub] [lucene-solr] trdillon commented on pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
trdillon commented on pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752048769 > > > For `TestSolr4Spatial2`, I think you just need to add [this line](https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/search/TestSolr4Spatial2.java#L323) Should I make changes to this class? I was working off `branch_8x` but seems those changes, along with some others, were made in `master` but not `branch_8x`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255972#comment-17255972
]
Uwe Schindler commented on LUCENE-9650:
---
That's what I did, see the log dump a posted on the GitHub PR (I forgot to post
here). Jenkins runs Gradle with Java 11, and just replaces runtime JVM.
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Dawid Weiss
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255973#comment-17255973
]
Uwe Schindler commented on LUCENE-9650:
---
My testing:
{noformat}
> gradlew compileJava -Druntime.java.home=/path/to/jdk-16
To honour the JVM settings for this build a new JVM will be forked. Please
consider using the daemon:
https://docs.gradle.org/6.6.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing
> Configure project :
WARNING: errorprone disabled (won't work with JDK 16)
> Task :altJvmWarning
NOTE: Alternative java toolchain will be used for compilation and tests:
Project will use Java 16 from: C:\Program Files\java\jdk-16
Gradle runs with Java 11 from: C:\Program Files\Java\jdk-11.0.8
> Task :solr:solrj:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
{noformat}
Without this patch it fails as on Jenkins.
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Dawid Weiss
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14608) Faster sorting for the /export handler
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256020#comment-17256020 ] ASF subversion and git services commented on SOLR-14608: Commit cae61336f86295014a1c373774bc56c5b9f21670 in lucene-solr's branch refs/heads/jira/SOLR-14608-export from Joel Bernstein [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=cae6133 ] SOLR-14608: Fix nanoTime to millis calculation and more code cleanup > Faster sorting for the /export handler > -- > > Key: SOLR-14608 > URL: https://issues.apache.org/jira/browse/SOLR-14608 > Project: Solr > Issue Type: New Feature >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Major > > The largest cost of the export handler is the sorting. This ticket will > implement an improved algorithm for sorting that should greatly increase > overall throughput for the export handler. > *The current algorithm is as follows:* > Collect a bitset of matching docs. Iterate over that bitset and materialize > the top level oridinals for the sort fields in the document and add them to > priority queue of size 3. Then export the top 3 docs, turn off the > bits in the bit set and iterate again until all docs are sorted and sent. > There are two performance bottlenecks with this approach: > 1) Materializing the top level ordinals adds a huge amount of overhead to the > sorting process. > 2) The size of priority queue, 30,000, adds significant overhead to sorting > operations. > *The new algorithm:* > Has a top level *merge sort iterator* that wraps segment level iterators that > perform segment level priority queue sorts. > *Segment level:* > The segment level docset will be iterated and the segment level ordinals for > the sort fields will be materialized and added to a segment level priority > queue. As the segment level iterator pops docs from the priority queue the > top level ordinals for the sort fields are materialized. Because the top > level ordinals are materialized AFTER the sort, they only need to be looked > up when the segment level ordinal changes. This takes advantage of the sort > to limit the lookups into the top level ordinal structures. This also > eliminates redundant lookups of top level ordinals that occur during the > multiple passes over the matching docset. > The segment level priority queues can be kept smaller than 30,000 to improve > performance of the sorting operations because the overall batch size will > still be 30,000 or greater when all the segment priority queue sizes are > added up. This allows for batch sizes much larger then 30,000 without using a > single large priority queue. The increased batch size means fewer iterations > over the matching docset and the decreased priority queue size means faster > sorting operations. > *Top level:* > A top level iterator does a merge sort over the segment level iterators by > comparing the top level ordinals materialized when the segment level docs are > popped from the segment level priority queues. This requires no extra memory > and will be very performant. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Assigned] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'
[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Potter reassigned SOLR-15058: - Assignee: Timothy Potter > Solr can not get correct hostname when hostname contain '_' > --- > > Key: SOLR-15058 > URL: https://issues.apache.org/jira/browse/SOLR-15058 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Su Sasa >Assignee: Timothy Potter >Priority: Minor > Attachments: > 0001-SOLR-15058-get-the-correct-hostname-when-hostname-co.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Utils.getBaseUrlForNodeName split the nodename by the first '_' > In ZK, Solr add '_solr' to the end of the hostname > so there should split by the last '_' -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-15058) Solr can not get correct hostname when hostname contain '_'
[ https://issues.apache.org/jira/browse/SOLR-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256071#comment-17256071 ] Timothy Potter commented on SOLR-15058: --- Let's get this fixed for 8.8 ... I'll work to get it committed as I've been in this code recently as well. > Solr can not get correct hostname when hostname contain '_' > --- > > Key: SOLR-15058 > URL: https://issues.apache.org/jira/browse/SOLR-15058 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Su Sasa >Assignee: Timothy Potter >Priority: Minor > Attachments: > 0001-SOLR-15058-get-the-correct-hostname-when-hostname-co.patch > > Time Spent: 40m > Remaining Estimate: 0h > > Utils.getBaseUrlForNodeName split the nodename by the first '_' > In ZK, Solr add '_solr' to the end of the hostname > so there should split by the last '_' -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14608) Faster sorting for the /export handler
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256081#comment-17256081 ] ASF subversion and git services commented on SOLR-14608: Commit d7e81e8197a4b9e06c8d387d34e941a1365ad163 in lucene-solr's branch refs/heads/jira/SOLR-14608-export from Joel Bernstein [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=d7e81e8 ] SOLR-14608: Tone down debug logging > Faster sorting for the /export handler > -- > > Key: SOLR-14608 > URL: https://issues.apache.org/jira/browse/SOLR-14608 > Project: Solr > Issue Type: New Feature >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Major > > The largest cost of the export handler is the sorting. This ticket will > implement an improved algorithm for sorting that should greatly increase > overall throughput for the export handler. > *The current algorithm is as follows:* > Collect a bitset of matching docs. Iterate over that bitset and materialize > the top level oridinals for the sort fields in the document and add them to > priority queue of size 3. Then export the top 3 docs, turn off the > bits in the bit set and iterate again until all docs are sorted and sent. > There are two performance bottlenecks with this approach: > 1) Materializing the top level ordinals adds a huge amount of overhead to the > sorting process. > 2) The size of priority queue, 30,000, adds significant overhead to sorting > operations. > *The new algorithm:* > Has a top level *merge sort iterator* that wraps segment level iterators that > perform segment level priority queue sorts. > *Segment level:* > The segment level docset will be iterated and the segment level ordinals for > the sort fields will be materialized and added to a segment level priority > queue. As the segment level iterator pops docs from the priority queue the > top level ordinals for the sort fields are materialized. Because the top > level ordinals are materialized AFTER the sort, they only need to be looked > up when the segment level ordinal changes. This takes advantage of the sort > to limit the lookups into the top level ordinal structures. This also > eliminates redundant lookups of top level ordinals that occur during the > multiple passes over the matching docset. > The segment level priority queues can be kept smaller than 30,000 to improve > performance of the sorting operations because the overall batch size will > still be 30,000 or greater when all the segment priority queue sizes are > added up. This allows for batch sizes much larger then 30,000 without using a > single large priority queue. The increased batch size means fewer iterations > over the matching docset and the decreased priority queue size means faster > sorting operations. > *Top level:* > A top level iterator does a merge sort over the segment level iterators by > comparing the top level ordinals materialized when the segment level docs are > popped from the segment level priority queues. This requires no extra memory > and will be very performant. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791687
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
String liveNode1 = "192.168.1.1:8983_solr";
String liveNode2 = "127.0.0.1:8983_solr";
String liveNode3 = "127.0.0.1_";
-String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+String liveNode4 = "127.0.0.1:61631_lx%2Fig";
Review comment:
I think a good solution is to find the first underscore after the colon.
If you look at `generateNodeName` in ZkController then you'll see the colon is
always added to the generated `nodeName`. This may require some tests to update
the test node name as there are some tests that use an improper node name that
doesn't adhere to how `ZkController#generateNodeName` creates actual node names
at runtime, this seems like a bad test impl. to me and should be corrected.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791973
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
String liveNode1 = "192.168.1.1:8983_solr";
String liveNode2 = "127.0.0.1:8983_solr";
String liveNode3 = "127.0.0.1_";
-String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+String liveNode4 = "127.0.0.1:61631_lx%2Fig";
Review comment:
fwiw ~ you can't look at the last underscore because nodeName encoding
changes `/` to `_` in the context as you can't create znodes with `/` in them
for obvious reasons ;-)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] nknize commented on pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint
nknize commented on pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-752197102 With the holidays and folks out on vacation would you mind holding off until the end of next week? I plan to have a look at the other two changes by the end of this week and I think it would be fair to make sure @rmuir has enough time to have a look as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2164: SOLR-15058: get the correct hostname when hostname contain '_'
thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549807523
##
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
String liveNode1 = "192.168.1.1:8983_solr";
String liveNode2 = "127.0.0.1:8983_solr";
String liveNode3 = "127.0.0.1_";
-String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+String liveNode4 = "127.0.0.1:61631_lx%2Fig";
Review comment:
Adding the following check to Utils:
```
diff --git a/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
b/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
index 86bef9177c8..13e732d4ed7 100644
--- a/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
+++ b/solr/solrj/src/java/org/apache/solr/common/util/Utils.java
@@ -759,7 +759,12 @@ public class Utils {
return getBaseUrlForNodeName(nodeName, urlScheme, false);
}
public static String getBaseUrlForNodeName(final String nodeName, String
urlScheme, boolean isV2) {
-final int _offset = nodeName.indexOf("_");
+final int colonAt = nodeName.indexOf(':');
+if (colonAt == -1) {
+ throw new IllegalArgumentException("nodeName does not contain
expected ':' separator: " + nodeName);
+}
+
+final int _offset = nodeName.indexOf("_", colonAt);
if (_offset < 0) {
throw new IllegalArgumentException("nodeName does not contain
expected '_' separator: " + nodeName);
}
```
Results in the following test failures:
```
1669 tests completed, 3 failed, 20 skipped
4619 tests completed, 26 failed, 210 skipped
ERROR: The following test(s) have failed:
- org.apache.solr.common.cloud.UrlSchemeTest.testApplyUrlScheme
(:solr:solrj)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/solrj/build/test-results/test/outputs/OUTPUT-org.apache.solr.common.cloud.UrlSchemeTest.txt
Reproduce with: gradlew :solr:solrj:test --tests
"org.apache.solr.common.cloud.UrlSchemeTest.testApplyUrlScheme" -Ptests.jvms=12
-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=14FE50F5891679FC
-Ptests.file.encoding=US-ASCII
-
org.apache.solr.client.solrj.routing.ShufflingReplicaListTransformerTest.testTransformReplicas
(:solr:solrj)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/solrj/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.routing.ShufflingReplicaListTransformerTest.txt
Reproduce with: gradlew :solr:solrj:test --tests
"org.apache.solr.client.solrj.routing.ShufflingReplicaListTransformerTest.testTransformReplicas"
-Ptests.jvms=12 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=14FE50F5891679FC -Ptests.file.encoding=US-ASCII
-
org.apache.solr.client.solrj.routing.ReplicaListTransformerTest.testTransform
(:solr:solrj)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/solrj/build/test-results/test/outputs/OUTPUT-org.apache.solr.client.solrj.routing.ReplicaListTransformerTest.txt
Reproduce with: gradlew :solr:solrj:test --tests
"org.apache.solr.client.solrj.routing.ReplicaListTransformerTest.testTransform"
-Ptests.jvms=12 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=14FE50F5891679FC -Ptests.file.encoding=US-ASCII
-
org.apache.solr.handler.component.CloudReplicaSourceTest.testShardsParam_DownReplica
(:solr:core)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.handler.component.CloudReplicaSourceTest.txt
Reproduce with: gradlew :solr:core:test --tests
"org.apache.solr.handler.component.CloudReplicaSourceTest.testShardsParam_DownReplica"
-Ptests.jvms=12 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=14FE50F5891679FC -Ptests.file.encoding=US-ASCII
-
org.apache.solr.handler.component.CloudReplicaSourceTest.testSimple_OnlyNrt
(:solr:core)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.handler.component.CloudReplicaSourceTest.txt
Reproduce with: gradlew :solr:core:test --tests
"org.apache.solr.handler.component.CloudReplicaSourceTest.testSimple_OnlyNrt"
-Ptests.jvms=12 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=14FE50F5891679FC -Ptests.file.encoding=US-ASCII
-
org.apache.solr.handler.component.CloudReplicaSourceTest.testShardsParam_DeadNode
(:solr:core)
Test output:
/Users/tjp/dev/oss/lucene-solr/master/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.handler.component.CloudReplicaSourceTest.txt
Reproduce with: gradlew :solr:core:test --tests
"org.apache.solr.handler.component.CloudReplicaSourceTest.testShardsParam_DeadNode"
-Ptests.jvms=12 -Ptests.jvmargs=-XX:TieredStopAtLevel=1
-Ptests.seed=14FE50F5891679FC -Ptests.file.enco
[jira] [Resolved] (LUCENE-9622) provide gradle option to disable error-prone checker
[
https://issues.apache.org/jira/browse/LUCENE-9622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9622.
-
Resolution: Duplicate
Fixed by LUCENE-9650
> provide gradle option to disable error-prone checker
>
>
> Key: LUCENE-9622
> URL: https://issues.apache.org/jira/browse/LUCENE-9622
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Robert Muir
>Priority: Major
>
> Trying to just run tests with the latest jdk16-ea, I can't do it because of
> bugs in "error-prone":
> {noformat}
> > Task :lucene:core:compileJava
> /home/rmuir/workspace/lucene-solr/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java:3486:
> error: An unhandled exception was thrown by the Error Prone static analysis
> plugin.
> MergePolicy.MergeSpecification pointInTimeMerges =
> updatePendingMerges(new OneMergeWrappingMergePolicy(config.getMergePolicy(),
> toWrap ->
> ^
> Please report this at https://github.com/google/error-prone/issues/new
> and include the following:
>
> error-prone version: 2.4.0
> BugPattern: ParameterName
> Stack Trace:
> java.lang.NoSuchFieldError: reader
> at
> com.google.errorprone.util.ErrorProneTokens$CommentSavingTokenizer.processComment(ErrorProneTokens.java:85)
> at
> jdk.compiler/com.sun.tools.javac.parser.JavaTokenizer.readToken(JavaTokenizer.java:919)
> at
> jdk.compiler/com.sun.tools.javac.parser.Scanner.nextToken(Scanner.java:115)
> at
> com.google.errorprone.util.ErrorProneTokens.getTokens(ErrorProneTokens.java:57)
> at
> com.google.errorprone.util.ErrorProneTokens.getTokens(ErrorProneTokens.java:74)
> at
> com.google.errorprone.bugpatterns.ParameterName.checkArguments(ParameterName.java:97)
> at
> com.google.errorprone.bugpatterns.ParameterName.matchMethodInvocation(ParameterName.java:66)
> at
> com.google.errorprone.scanner.ErrorProneScanner.processMatchers(ErrorProneScanner.java:451)
> {noformat}
> I really just want to run the tests, so for now I just commented it out
> locally. Let's provide an option as it seems it doesn't necessarily keep up
> with the JDK? Not sure what is going on with this thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
tflobbe commented on pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752336456 > Should I make changes to this class? Looks to me that this change will be needed given the changes in this PR, right? this test is failing for me in your branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on a change in pull request #2152: SOLR-14034: remove deprecated min_rf references
tflobbe commented on a change in pull request #2152:
URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r549948394
##
File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java
##
@@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf, SolrClient
solrClient, String co
doc.addField("a_t", "hello" + docId);
UpdateRequest up = new UpdateRequest();
-if (minRf != null) {
- up.setParam(UpdateRequest.MIN_REPFACT, String.valueOf(minRf));
-}
Review comment:
> It appears that the minRf argument in sendDocsWithRetry is indeed
unused already but it might be clearer to tidy that up in a separate follow-up
pull request rather than mix it in here at this time.
I'm wondering if it would be better for this method to actually start using
this parameter, and retry in the case of `minRf` not achieved? This is not
something that was being done in this method, but may help improve some of the
tests using it. I don't think such a change should be done in this PR, but
maybe lets not remove the parameter yet then. WDYT?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] iverase commented on pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint
iverase commented on pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#issuecomment-752362243 Sure, just hope it can make it to the next release. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256360#comment-17256360
]
ASF subversion and git services commented on SOLR-14723:
Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256361#comment-17256361
]
ASF subversion and git services commented on SOLR-14723:
Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256358#comment-17256358
]
ASF subversion and git services commented on SOLR-14723:
Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256359#comment-17256359
]
ASF subversion and git services commented on SOLR-14723:
Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
tflobbe commented on pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-752364628 Merged to 8.x. Not needed in master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe closed pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
tflobbe closed pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
)
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
)
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe updated SOLR-14723:
-
Comment: was deleted
(was: Commit 196632d538a26b0c92a67941ad7c47e2f9cd2e1d in lucene-solr's branch
refs/heads/branch_8x from Tomas Eduardo Fernandez Lobbe
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=196632d ]
SOLR-14723: Remove the class attribute for the caches in the _default/example
configsets
This is an 8.x change only. Closes #2169
Squashed commit of the following:
commit c638cbcfdb58b57cde8c4be641a7847b8a37422a
Merge: b13011e97ae a22abe8ae0d
Author: Tomas Fernandez Lobbe
Date: Tue Dec 29 23:33:38 2020 -0800
Merge branch 'jira/SOLR-14723' of https://github.com/trdillon/lucene-solr
into trdillon-jira/SOLR-14723
commit a22abe8ae0ddd5934dd8f74f4a48599e188ffc73
Author: Tim Dillon
Date: Wed Dec 30 15:34:34 2020 +0900
Add SOLR-14723 to CHANGES.txt
commit 655bba5db63118c3055c30d331d1d082e0dd6050
Author: Tim Dillon
Date: Wed Dec 30 15:02:16 2020 +0900
Fix TestSolr4Spatial2 test
commit 2d8544fc455de8b596c6fbf3ecd2feb2ca6a84fc
Author: Tim Dillon
Date: Tue Dec 29 20:40:03 2020 +0900
Update doc to state default cache class
commit 3c5ee62d8fe87da080595822b46a3390510dea41
Author: Tim Dillon
Date: Tue Dec 29 19:51:57 2020 +0900
Replaced the class attribute in solrconfig-caching
commit 2341eef4a63696068b010d8da51f2fa818790fc0
Author: Tim Dillon
Date: Sun Dec 27 15:52:07 2020 +0900
Remove REQUIRE_CLASS from SolrCache plugin
commit 627995aba1a29dc4deaf726c0a49599224ea2de5
Author: Tim Dillon
Date: Sat Dec 26 11:14:03 2020 +0900
Remove cast to FastLRUCache in TestJsonRequest
commit 11319c119570c861d62f09fc6b482a6993dd38ff
Author: Tim Dillon
Date: Sat Dec 19 16:53:07 2020 +0900
Removed class attribute from caches
)
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256367#comment-17256367
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14723:
--
Thanks [~trdillon], merged the PR. And thanks [~shshnk28] for the initial
contribution.
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (SOLR-14723) Rremove the class atribute for the caches in the _default/example configsets
[
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomas Eduardo Fernandez Lobbe resolved SOLR-14723.
--
Fix Version/s: 8.8
Resolution: Fixed
> Rremove the class atribute for the caches in the _default/example configsets
>
>
> Key: SOLR-14723
> URL: https://issues.apache.org/jira/browse/SOLR-14723
> Project: Solr
> Issue Type: Improvement
>Reporter: Tomas Eduardo Fernandez Lobbe
>Priority: Trivial
> Labels: newdev
> Fix For: 8.8
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In 8.x branch, the default and example configsets include LRUCache and
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> size="512"
> initialSize="512"
> autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute
> completely and let the default take over (as it's in master), this should
> make upgrading configsets easier:
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
