Re: [PR] Add iceberg_arrow library [iceberg-cpp]
wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897581776
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Accumulate all dependencies to provide suitable static link parameters to the
+# third party libraries.
+set(ICEBERG_SYSTEM_DEPENDENCIES)
+set(ICEBERG_VENDOR_DEPENDENCIES)
+set(ICEBERG_ARROW_INSTALL_INTERFACE_LIBS)
+
+# --
+# Versions and URLs for toolchain builds
+
+set(ICEBERG_ARROW_BUILD_VERSION "18.1.0")
+set(ICEBERG_ARROW_BUILD_SHA256_CHECKSUM
+"2dc8da5f8796afe213ecc5e5aba85bb82d91520eff3cf315784a52d0fa61d7fc")
+set(ARROW_VENDORED TRUE)
+
+if(DEFINED ENV{ICEBERG_ARROW_URL})
+ set(ARROW_SOURCE_URL "$ENV{ICEBERG_ARROW_URL}")
+else()
+ set(ARROW_SOURCE_URL
+
"https://www.apache.org/dyn/closer.cgi?action=download&filename=/arrow/arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+
"https://downloads.apache.org/arrow/arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+
"https://github.com/apache/arrow/releases/download/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+# --
+# FetchContent
+
+include(FetchContent)
+set(FC_DECLARE_COMMON_OPTIONS)
+if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.28)
+ list(APPEND FC_DECLARE_COMMON_OPTIONS EXCLUDE_FROM_ALL TRUE)
+endif()
+
+macro(prepare_fetchcontent)
+ set(BUILD_SHARED_LIBS OFF)
+ set(BUILD_STATIC_LIBS ON)
+ set(CMAKE_COMPILE_WARNING_AS_ERROR FALSE)
+ set(CMAKE_EXPORT_NO_PACKAGE_REGISTRY TRUE)
+ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+endmacro()
+
+# --
+# Apache Arrow
+
+function(resolve_arrow_dependency)
+ prepare_fetchcontent()
+
+ set(ARROW_BUILD_SHARED
+ OFF
+ CACHE BOOL "" FORCE)
+ set(ARROW_BUILD_STATIC
+ ON
+ CACHE BOOL "" FORCE)
+ set(ARROW_FILESYSTEM
+ OFF
+ CACHE BOOL "" FORCE)
+ set(ARROW_SIMD_LEVEL
+ "NONE"
+ CACHE STRING "" FORCE)
+ set(ARROW_RUNTIME_SIMD_LEVEL
+ "NONE"
+ CACHE STRING "" FORCE)
+ set(ARROW_POSITION_INDEPENDENT_CODE
+ ON
+ CACHE BOOL "" FORCE)
+
+ fetchcontent_declare(Arrow
Review Comment:
@kou Sorry to bother you. I tried to add a minimal dependency on Apache
Arrow to this project. The CI fails only on Windows:
```
CMake Error at build/_deps/arrow-src/cpp/src/arrow/CMakeLists.txt:587
(target_link_libraries):
Target "arrow_util_static" links to:
Boost::headers
CMake Error at build/_deps/arrow-src/cpp/src/arrow/CMakeLists.txt:804
(target_link_libraries):
Target "arrow_compute_static" links to:
Boost::headers
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
```
It seems that Boost is enabled due to missing native support of INT128 but
not built via resolve_dependency.
```
-- Looking for _M_ARM64
-- Looking for _M_ARM64 - not found
-- Looking for __SIZEOF_INT128__
-- Looking for __SIZEOF_INT128__ - not found
-- Boost include dir:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Add iceberg_arrow library [iceberg-cpp]
wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897581776
##
cmake_modules/ThirdpartyToolchain.cmake:
##
@@ -0,0 +1,139 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Accumulate all dependencies to provide suitable static link parameters to the
+# third party libraries.
+set(ICEBERG_SYSTEM_DEPENDENCIES)
+set(ICEBERG_VENDOR_DEPENDENCIES)
+set(ICEBERG_ARROW_INSTALL_INTERFACE_LIBS)
+
+# --
+# Versions and URLs for toolchain builds
+
+set(ICEBERG_ARROW_BUILD_VERSION "18.1.0")
+set(ICEBERG_ARROW_BUILD_SHA256_CHECKSUM
+"2dc8da5f8796afe213ecc5e5aba85bb82d91520eff3cf315784a52d0fa61d7fc")
+set(ARROW_VENDORED TRUE)
+
+if(DEFINED ENV{ICEBERG_ARROW_URL})
+ set(ARROW_SOURCE_URL "$ENV{ICEBERG_ARROW_URL}")
+else()
+ set(ARROW_SOURCE_URL
+
"https://www.apache.org/dyn/closer.cgi?action=download&filename=/arrow/arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+
"https://downloads.apache.org/arrow/arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+
"https://github.com/apache/arrow/releases/download/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}/apache-arrow-${ICEBERG_ARROW_BUILD_VERSION}.tar.gz";
+ )
+endif()
+
+# --
+# FetchContent
+
+include(FetchContent)
+set(FC_DECLARE_COMMON_OPTIONS)
+if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.28)
+ list(APPEND FC_DECLARE_COMMON_OPTIONS EXCLUDE_FROM_ALL TRUE)
+endif()
+
+macro(prepare_fetchcontent)
+ set(BUILD_SHARED_LIBS OFF)
+ set(BUILD_STATIC_LIBS ON)
+ set(CMAKE_COMPILE_WARNING_AS_ERROR FALSE)
+ set(CMAKE_EXPORT_NO_PACKAGE_REGISTRY TRUE)
+ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
+endmacro()
+
+# --
+# Apache Arrow
+
+function(resolve_arrow_dependency)
+ prepare_fetchcontent()
+
+ set(ARROW_BUILD_SHARED
+ OFF
+ CACHE BOOL "" FORCE)
+ set(ARROW_BUILD_STATIC
+ ON
+ CACHE BOOL "" FORCE)
+ set(ARROW_FILESYSTEM
+ OFF
+ CACHE BOOL "" FORCE)
+ set(ARROW_SIMD_LEVEL
+ "NONE"
+ CACHE STRING "" FORCE)
+ set(ARROW_RUNTIME_SIMD_LEVEL
+ "NONE"
+ CACHE STRING "" FORCE)
+ set(ARROW_POSITION_INDEPENDENT_CODE
+ ON
+ CACHE BOOL "" FORCE)
+
+ fetchcontent_declare(Arrow
Review Comment:
@kou Sorry to bother you. I tried to add a minimal dependency on Apache
Arrow to this project. The CI fails only on Windows:
```
CMake Error at build/_deps/arrow-src/cpp/src/arrow/CMakeLists.txt:587
(target_link_libraries):
Target "arrow_util_static" links to:
Boost::headers
CMake Error at build/_deps/arrow-src/cpp/src/arrow/CMakeLists.txt:804
(target_link_libraries):
Target "arrow_compute_static" links to:
Boost::headers
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
```
It seems that Boost is enabled due to missing native support of INT128 but
not built via resolve_dependency.
```
-- Looking for _M_ARM64
-- Looking for _M_ARM64 - not found
-- Looking for __SIZEOF_INT128__
-- Looking for __SIZEOF_INT128__ - not found
-- Boost include dir:
```
Is there any setting that can work around this? I'll dig into it on my
Windows PC after work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Add iceberg_arrow library [iceberg-cpp]
lidavidm commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897591862
##
src/CMakeLists.txt:
##
@@ -15,5 +15,20 @@
# specific language governing permissions and limitations
# under the License.
+add_subdirectory(arrow)
add_subdirectory(core)
add_subdirectory(puffin)
+
+include(CMakePackageConfigHelpers)
+
+configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/config.cmake.in"
+
"${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
+ INSTALL_DESTINATION
"${ICEBERG_INSTALL_CMAKEDIR}/Iceberg")
+
+write_basic_package_version_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config-version.cmake"
+ COMPATIBILITY SameMajorVersion)
+
+install(FILES "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
Review Comment:
It seems the demo header shouldn't be installed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Add iceberg_arrow library [iceberg-cpp]
wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897586676
##
src/CMakeLists.txt:
##
@@ -15,5 +15,20 @@
# specific language governing permissions and limitations
# under the License.
+add_subdirectory(arrow)
add_subdirectory(core)
add_subdirectory(puffin)
+
+include(CMakePackageConfigHelpers)
+
+configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/config.cmake.in"
+
"${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
+ INSTALL_DESTINATION
"${ICEBERG_INSTALL_CMAKEDIR}/Iceberg")
+
+write_basic_package_version_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config-version.cmake"
+ COMPATIBILITY SameMajorVersion)
+
+install(FILES "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
Review Comment:
FYI, the install directory (with only static library built) looks like below:
```
/tmp/iceberg/
├── lib/
│ ├── libarrow.a
│ ├── libiceberg_arrow.a
│ ├── libiceberg_core.a
│ ├── libiceberg_puffin.a
│ └── cmake/
│ ├── Iceberg/
│ │ ├── iceberg-arrow-targets.cmake
│ │ ├── iceberg-arrow-targets-debug.cmake
│ │ ├── iceberg-core-targets.cmake
│ │ ├── iceberg-core-targets-debug.cmake
│ │ ├── iceberg-puffin-targets.cmake
│ │ ├── iceberg-puffin-targets-debug.cmake
│ │ ├── iceberg-config.cmake
│ │ └── iceberg-config-version.cmake
├── include/
│ └── iceberg/
│ ├── puffin.h
│ ├── table.h
│ └── demo_arrow.h
└── share/
└── doc/
└── iceberg/
├── LICENSE
└── NOTICE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
[I] CatalogUtil:dropTableData method doesn't remove old Puffin files [iceberg]
ebyhr opened a new issue, #11876: URL: https://github.com/apache/iceberg/issues/11876 ### Apache Iceberg version 1.7.1 (latest release) ### Query engine Trino ### Please describe the bug 🐞 https://github.com/apache/iceberg/pull/9305 and https://github.com/apache/iceberg/pull/9409 remove only the latest Puffin file. Old Puffin files still remain after calling the method. ### Willingness to contribute - [ ] I can contribute a fix for this bug independently - [X] I would be willing to contribute a fix for this bug with guidance from the Iceberg community - [ ] I cannot contribute a fix for this bug at this time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Support Adding File Metadata Directly [iceberg-python]
Fokko commented on issue #1470: URL: https://github.com/apache/iceberg-python/issues/1470#issuecomment-2562201472 Hey @subthedubdub Thanks for reaching out here. We allow appending data files directly: ```python with tbl.transaction() as txn: with txn.update_snapshot() as snapshot: with snapshot.fast_append() as append: append.append_data_file(data_file) ``` This is not documented, since it is a low-level API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Add iceberg_arrow library [iceberg-cpp]
wgtmac commented on code in PR #6:
URL: https://github.com/apache/iceberg-cpp/pull/6#discussion_r1897676702
##
src/CMakeLists.txt:
##
@@ -15,5 +15,20 @@
# specific language governing permissions and limitations
# under the License.
+add_subdirectory(arrow)
add_subdirectory(core)
add_subdirectory(puffin)
+
+include(CMakePackageConfigHelpers)
+
+configure_package_config_file("${CMAKE_CURRENT_SOURCE_DIR}/config.cmake.in"
+
"${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
+ INSTALL_DESTINATION
"${ICEBERG_INSTALL_CMAKEDIR}/Iceberg")
+
+write_basic_package_version_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config-version.cmake"
+ COMPATIBILITY SameMajorVersion)
+
+install(FILES "${CMAKE_CURRENT_BINARY_DIR}/iceberg-config.cmake"
Review Comment:
The demo_arrow.h is included by the example which consumes the iceberg
library via installed location. I add `demo_` prefix by purpose to show this
and it will be removed once we have more source files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
[PR] feat: Expose disable_config_load opendal GCS option [iceberg-rust]
chenzl25 opened a new pull request, #847: URL: https://github.com/apache/iceberg-rust/pull/847 - Expose `gcs.disable-config-load`, `gcs.disable-vm-metadata` and `gcs.allow-anonymous` for GCS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] API: Replace deprecated asList with asInstanceOf in TestExceptionUtil [iceberg]
Fokko merged PR #11875: URL: https://github.com/apache/iceberg/pull/11875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] feat: Expose disable_config_load opendal GCS option [iceberg-rust]
Xuanwo commented on code in PR #847:
URL: https://github.com/apache/iceberg-rust/pull/847#discussion_r1897698605
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -41,6 +41,17 @@ pub const GCS_CREDENTIALS_JSON: &str =
"gcs.credentials-json";
/// Google Cloud Storage token
pub const GCS_TOKEN: &str = "gcs.oauth2.token";
+/// Option to skip signing requests (e.g. for public buckets/folders).
+pub const GCS_ALLOW_ANONYMOUS: &str = "gcs.allow-anonymous";
+/// Option to skip loading the credential from GCE metadata server (typically
used in conjunction with `GCS_ALLOW_ANONYMOUS`).
+pub const GCS_DISABLE_VM_METADATA: &str = "gcs.disable-vm-metadata";
+/// Option to skip loading configuration from config file and the env.
+pub const GCS_DISABLE_CONFIG_LOAD: &str = "gcs.disable-config-load";
+
+fn is_truthy(value: &str) -> bool {
+["true", "t", "1", "on"].contains(&value)
Review Comment:
We can check against `value.to_lowercase()`.
##
crates/iceberg/src/io/storage_gcs.rs:
##
@@ -41,6 +41,17 @@ pub const GCS_CREDENTIALS_JSON: &str =
"gcs.credentials-json";
/// Google Cloud Storage token
pub const GCS_TOKEN: &str = "gcs.oauth2.token";
+/// Option to skip signing requests (e.g. for public buckets/folders).
+pub const GCS_ALLOW_ANONYMOUS: &str = "gcs.allow-anonymous";
+/// Option to skip loading the credential from GCE metadata server (typically
used in conjunction with `GCS_ALLOW_ANONYMOUS`).
+pub const GCS_DISABLE_VM_METADATA: &str = "gcs.disable-vm-metadata";
+/// Option to skip loading configuration from config file and the env.
+pub const GCS_DISABLE_CONFIG_LOAD: &str = "gcs.disable-config-load";
+
+fn is_truthy(value: &str) -> bool {
Review Comment:
Maybe we can have such thing in io mod instead of just gcs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
[PR] Build: Fix ignoring `license-check.yml` in PR [iceberg]
manuzhang opened a new pull request, #11873: URL: https://github.com/apache/iceberg/pull/11873 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[PR] API: Replace deprecated asList with asInstanceOf in TestExceptionUtil [iceberg]
ebyhr opened a new pull request, #11875: URL: https://github.com/apache/iceberg/pull/11875 `asList` method is deprecated: https://www.javadoc.io/doc/org.assertj/assertj-core/latest/org/assertj/core/api/AbstractAssert.html#asList() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1897321567
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkCatalogOperations.java:
##
@@ -107,8 +107,8 @@ public void testAlterTable() throws NoSuchTableException {
assertThat(table).as("Should return updated table").isNotNull();
-StructField expectedField = DataTypes.createStructField(fieldName,
DataTypes.StringType, true);
-assertThat(table.schema().fields()[2])
+Column expectedField = Column.create(fieldName, DataTypes.StringType,
true);
+assertThat(table.columns()[2])
Review Comment:
https://github.com/apache/spark/blob/ef4be07fdad9c8078e22d4f3f068fee1b81cf967/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Table.java#L51-L58
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkCatalogOperations.java:
##
@@ -107,8 +107,8 @@ public void testAlterTable() throws NoSuchTableException {
assertThat(table).as("Should return updated table").isNotNull();
-StructField expectedField = DataTypes.createStructField(fieldName,
DataTypes.StringType, true);
-assertThat(table.schema().fields()[2])
Review Comment:
https://github.com/apache/spark/blob/ef4be07fdad9c8078e22d4f3f068fee1b81cf967/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Table.java#L51-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1897322776
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -251,7 +251,8 @@ private String getCompressionType(InputFile inputFile)
throws Exception {
return orcReader.getCompressionKind().name();
case PARQUET:
ParquetMetadata footer =
-ParquetFileReader.readFooter(CONF, new Path(inputFile.location()),
NO_FILTER);
Review Comment:
https://javadoc.io/doc/org.apache.parquet/parquet-hadoop/latest/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1897323379
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/data/ParquetWithSparkSchemaVisitor.java:
##
@@ -59,106 +59,101 @@ public static T visit(DataType sType, Type type,
ParquetWithSparkSchemaVisit
} else {
// if not a primitive, the typeId must be a group
GroupType group = type.asGroupType();
- OriginalType annotation = group.getOriginalType();
+ LogicalTypeAnnotation annotation = group.getLogicalTypeAnnotation();
if (annotation != null) {
-switch (annotation) {
- case LIST:
-Preconditions.checkArgument(
-!group.isRepetition(Repetition.REPEATED),
-"Invalid list: top-level group is repeated: %s",
-group);
-Preconditions.checkArgument(
-group.getFieldCount() == 1,
-"Invalid list: does not contain single repeated field: %s",
-group);
-
-GroupType repeatedElement = group.getFields().get(0).asGroupType();
-Preconditions.checkArgument(
-repeatedElement.isRepetition(Repetition.REPEATED),
-"Invalid list: inner group is not repeated");
-Preconditions.checkArgument(
-repeatedElement.getFieldCount() <= 1,
-"Invalid list: repeated group is not a single field: %s",
-group);
-
-Preconditions.checkArgument(
-sType instanceof ArrayType, "Invalid list: %s is not an
array", sType);
-ArrayType array = (ArrayType) sType;
-StructField element =
-new StructField(
-"element", array.elementType(), array.containsNull(),
Metadata.empty());
-
-visitor.fieldNames.push(repeatedElement.getName());
-try {
- T elementResult = null;
- if (repeatedElement.getFieldCount() > 0) {
-elementResult = visitField(element,
repeatedElement.getType(0), visitor);
- }
-
- return visitor.list(array, group, elementResult);
-
-} finally {
- visitor.fieldNames.pop();
+if (annotation.equals(LogicalTypeAnnotation.listType())) {
Review Comment:
I would recommend reviewing this changer with "Hide whitespace" option.
I changed `switch` to `if` because `LogicalTypeAnnotation` isn't enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1897322776
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestCompressionSettings.java:
##
@@ -251,7 +251,8 @@ private String getCompressionType(InputFile inputFile)
throws Exception {
return orcReader.getCompressionKind().name();
case PARQUET:
ParquetMetadata footer =
-ParquetFileReader.readFooter(CONF, new Path(inputFile.location()),
NO_FILTER);
Review Comment:
`readFooter` method is deprecated:
https://javadoc.io/doc/org.apache.parquet/parquet-hadoop/latest/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr commented on code in PR #11874:
URL: https://github.com/apache/iceberg/pull/11874#discussion_r1897322861
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestSparkCatalogOperations.java:
##
@@ -107,8 +107,8 @@ public void testAlterTable() throws NoSuchTableException {
assertThat(table).as("Should return updated table").isNotNull();
-StructField expectedField = DataTypes.createStructField(fieldName,
DataTypes.StringType, true);
-assertThat(table.schema().fields()[2])
Review Comment:
`schema` method is deprecated:
https://github.com/apache/spark/blob/ef4be07fdad9c8078e22d4f3f068fee1b81cf967/sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/Table.java#L51-L58
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
[PR] Spark 3.5: Avoid deprecated method [iceberg]
ebyhr opened a new pull request, #11874: URL: https://github.com/apache/iceberg/pull/11874 I would recommend reviewing `ParquetWithSparkSchemaVisitor.java` with the hiding whitespace option. I changed `switch` to `if` because `LogicalTypeAnnotation` isn't enum. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Flaky test `TestCopyOnWriteDelete > testDeleteWithSnapshotIsolation()` [iceberg]
ebyhr commented on issue #11651: URL: https://github.com/apache/iceberg/issues/11651#issuecomment-2561844859 https://github.com/apache/iceberg/actions/runs/12491852295/job/34858377591?pr=11873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Build: Fix ignoring `license-check.yml` in PR [iceberg]
ebyhr commented on PR #11873: URL: https://github.com/apache/iceberg/pull/11873#issuecomment-2561844827 CI hit #11651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] chore: Use nightly toolchain for check [iceberg-rust]
xxchan commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1897190259
##
.github/workflows/ci.yml:
##
@@ -63,8 +72,14 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Setup Rust toolchain
+uses: ./.github/actions/setup-builder
+with:
+ rust-version: ${{ env.rust_msrv }}
+
- name: Build
-run: cargo build
+run: make build
Review Comment:
I don't get this. It seems we only installed stable toolchain `rust_msrv`,
but not used in the build process. :eyes:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] chore: Use nightly toolchain for check [iceberg-rust]
xxchan commented on code in PR #445:
URL: https://github.com/apache/iceberg-rust/pull/445#discussion_r1897190743
##
.github/workflows/ci.yml:
##
@@ -63,8 +72,14 @@ jobs:
- windows-latest
steps:
- uses: actions/checkout@v4
+
+ - name: Setup Rust toolchain
+uses: ./.github/actions/setup-builder
+with:
+ rust-version: ${{ env.rust_msrv }}
+
- name: Build
-run: cargo build
+run: make build
Review Comment:
We should `cargo +${{ env.rust_msrv}} build`, or `rustup override set ${{
env.rust_msrv}}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Core: Use FileIO for hadoop table metadata file operations [iceberg]
IzzelAliz commented on code in PR #11690:
URL: https://github.com/apache/iceberg/pull/11690#discussion_r1897338510
##
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##
@@ -237,15 +237,15 @@ Path getMetadataFile(int metadataVersion) throws
IOException {
for (TableMetadataParser.Codec codec : TABLE_METADATA_PARSER_CODEC_VALUES)
{
Path metadataFile = metadataFilePath(metadataVersion, codec);
FileSystem fs = getFileSystem(metadataFile, conf);
- if (fs.exists(metadataFile)) {
+ if (fs.isFile(metadataFile)) {
Review Comment:
I've updated them with FileIO. Users who configures a S3FileIO can benefit
from it, and the default HadoopFileIO basically behaves the same as the
fs.exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] fix: support both gs and gcs schemes for google cloud storage [iceberg-rust]
Xuanwo merged PR #845: URL: https://github.com/apache/iceberg-rust/pull/845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Rest catalog integration testing [iceberg-python]
AhmedNader42 commented on PR #1469: URL: https://github.com/apache/iceberg-python/pull/1469#issuecomment-2561825232 I had a look at the failing tests, and it appears the issue is in the sigv4 authentication option. But I can't reproduce it on local. Any ideas where to proceed from here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
[PR] feat: Support metadata table "Metadata Log Entries" [iceberg-rust]
rshkv opened a new pull request, #846: URL: https://github.com/apache/iceberg-rust/pull/846 Re #823. This adds support for the [Metadata Log Entries][Java] metadata table. This is building on @xxchan's unmerged #822. I'll update and rebase this PR when #822 merges. Metadata Log Entires is the metadata log with the latest snapshot per metadata file. Reference implementations: * [Java] * [PyIceberg] [Java]: https://github.com/apache/iceberg/blob/apache-iceberg-1.7.1/core/src/main/java/org/apache/iceberg/MetadataLogEntriesTable.java [PyIceberg]: https://github.com/apache/iceberg-python/blob/0e5086ceb77351bc0b6ec3a592f5eda70a0afe46/pyiceberg/table/inspect.py#L415-L447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Flink: IcebergTableSink to write data into multiple iceberg tables [iceberg]
thuongle2210 commented on issue #2208: URL: https://github.com/apache/iceberg/issues/2208#issuecomment-2561938516 > @caseylucas keyBy can help address some of the problems. not sure about your datasets. just watch out the traffic imbalance for the keyBy shuffle. How did you ensure Flink sink data to iceberg that achieve exactly-once semantic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Flink: IcebergTableSink to write data into multiple iceberg tables [iceberg]
thuongle2210 commented on issue #2208: URL: https://github.com/apache/iceberg/issues/2208#issuecomment-2561938944 > Currently, Flink Iceberg sink can only write to one table with exactly-once semantic. > > If the table partition doesn't fit your requirements, maybe you can use filter or side output to split the stream into multiple sub streams. then attach a separate Iceberg sink to each sub DataStream. This probably won't work if the number of tables/datasets is really high (like hundreds). In that case, maybe split the uber stream before the Iceberg ingestion jobs. How did you ensure Flink sink data to iceberg that achieve exactly-once semantic? @stevenzwu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Flink: IcebergTableSink to write data into multiple iceberg tables [iceberg]
thuongle2210 commented on issue #2208: URL: https://github.com/apache/iceberg/issues/2208#issuecomment-2561938744 > Currently, Flink Iceberg sink can only write to one table with exactly-once semantic. > > If the table partition doesn't fit your requirements, maybe you can use filter or side output to split the stream into multiple sub streams. then attach a separate Iceberg sink to each sub DataStream. This probably won't work if the number of tables/datasets is really high (like hundreds). In that case, maybe split the uber stream before the Iceberg ingestion jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] feat: Support metadata table "Metadata Log Entries" [iceberg-rust]
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897369513
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Metadata table api.
+
+use std::sync::Arc;
+
+use arrow_array::builder::{MapBuilder, PrimitiveBuilder, StringBuilder};
+use arrow_array::types::{Int32Type, Int64Type, TimestampMillisecondType};
+use arrow_array::RecordBatch;
+use arrow_schema::{DataType, Field, Schema, TimeUnit};
+
+use crate::spec::{SnapshotRef, TableMetadataRef};
+use crate::table::Table;
+use crate::Result;
+
+/// Table metadata scan.
+///
+/// Used to inspect a table's history, snapshots, and other metadata as a
table.
+///
+/// See also
.
+#[derive(Debug)]
+pub struct MetadataScan {
+metadata_ref: TableMetadataRef,
+metadata_location: Option,
+}
+
+impl MetadataScan {
+/// Creates a new metadata scan.
+pub fn new(table: &Table) -> Self {
+Self {
+metadata_ref: table.metadata_ref(),
+metadata_location: table.metadata_location().map(String::from),
+}
+}
+
+/// Returns the snapshots of the table.
+pub fn snapshots(&self) -> Result {
+SnapshotsTable::scan(self)
+}
+
+/// Return the metadata log entries of the table.
+pub fn metadata_log_entries(&self) -> Result {
+MetadataLogEntriesTable::scan(self)
+}
+}
+
+/// Table metadata scan.
+///
+/// Use to inspect a table's history, snapshots, and other metadata as a table.
+///
+/// References:
+/// -
+/// -
+/// -
+pub trait MetadataTable {
+/// Returns the schema of the metadata table.
+fn schema() -> Schema;
+
+/// Scans the metadata table.
+fn scan(scan: &MetadataScan) -> Result;
+}
+
+/// Snapshots table.
+pub struct SnapshotsTable;
+
+impl MetadataTable for SnapshotsTable {
+fn schema() -> Schema {
+Schema::new(vec![
+Field::new(
+"committed_at",
+DataType::Timestamp(TimeUnit::Millisecond,
Some("+00:00".into())),
+false,
+),
+Field::new("snapshot_id", DataType::Int64, false),
+Field::new("parent_id", DataType::Int64, true),
+Field::new("operation", DataType::Utf8, false),
+Field::new("manifest_list", DataType::Utf8, false),
+Field::new(
+"summary",
+DataType::Map(
+Arc::new(Field::new(
+"entries",
+DataType::Struct(
+vec![
+Field::new("keys", DataType::Utf8, false),
+Field::new("values", DataType::Utf8, true),
+]
+.into(),
+),
+false,
+)),
+false,
+),
+false,
+),
+])
+}
+
+fn scan(scan: &MetadataScan) -> Result {
+let mut committed_at =
+
PrimitiveBuildernew().with_timezone("+00:00");
+let mut snapshot_id = PrimitiveBuildernew();
+let mut parent_id = PrimitiveBuildernew();
+let mut operation = StringBuilder::new();
+let mut manifest_list = StringBuilder::new();
+let mut summary = MapBuilder::new(None, StringBuilder::new(),
StringBuilder::new());
+
+for snapshot in scan.metadata_ref.snapshots() {
+committed_at.append_value(snapshot.timestamp_ms());
+snapshot_id.append_value(snapshot.snapshot_id());
+parent_id.append_option(snapshot.parent_snapshot_id());
+manifest_list.append_value(snapshot.manifest_list());
+operation.append_value(snapshot.summary().operation.
Re: [PR] feat: Support metadata table "Metadata Log Entries" [iceberg-rust]
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897371026
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,404 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Metadata table api.
+
+use std::sync::Arc;
+
+use arrow_array::builder::{MapBuilder, PrimitiveBuilder, StringBuilder};
+use arrow_array::types::{Int32Type, Int64Type, TimestampMillisecondType};
+use arrow_array::RecordBatch;
+use arrow_schema::{DataType, Field, Schema, TimeUnit};
+
+use crate::spec::{SnapshotRef, TableMetadataRef};
+use crate::table::Table;
+use crate::Result;
+
+/// Table metadata scan.
+///
+/// Used to inspect a table's history, snapshots, and other metadata as a
table.
+///
+/// See also
.
+#[derive(Debug)]
+pub struct MetadataScan {
+metadata_ref: TableMetadataRef,
+metadata_location: Option,
+}
+
+impl MetadataScan {
+/// Creates a new metadata scan.
+pub fn new(table: &Table) -> Self {
+Self {
+metadata_ref: table.metadata_ref(),
+metadata_location: table.metadata_location().map(String::from),
+}
+}
+
+/// Returns the snapshots of the table.
+pub fn snapshots(&self) -> Result {
+SnapshotsTable::scan(self)
+}
+
+/// Return the metadata log entries of the table.
+pub fn metadata_log_entries(&self) -> Result {
+MetadataLogEntriesTable::scan(self)
+}
+}
+
+/// Table metadata scan.
+///
+/// Use to inspect a table's history, snapshots, and other metadata as a table.
+///
+/// References:
+/// -
+/// -
+/// -
+pub trait MetadataTable {
+/// Returns the schema of the metadata table.
+fn schema() -> Schema;
+
+/// Scans the metadata table.
+fn scan(scan: &MetadataScan) -> Result;
+}
+
+/// Snapshots table.
+pub struct SnapshotsTable;
+
+impl MetadataTable for SnapshotsTable {
+fn schema() -> Schema {
+Schema::new(vec![
+Field::new(
+"committed_at",
+DataType::Timestamp(TimeUnit::Millisecond,
Some("+00:00".into())),
+false,
+),
+Field::new("snapshot_id", DataType::Int64, false),
+Field::new("parent_id", DataType::Int64, true),
+Field::new("operation", DataType::Utf8, false),
+Field::new("manifest_list", DataType::Utf8, false),
+Field::new(
+"summary",
+DataType::Map(
+Arc::new(Field::new(
+"entries",
+DataType::Struct(
+vec![
+Field::new("keys", DataType::Utf8, false),
+Field::new("values", DataType::Utf8, true),
+]
+.into(),
+),
+false,
+)),
+false,
+),
+false,
+),
+])
+}
+
+fn scan(scan: &MetadataScan) -> Result {
+let mut committed_at =
+
PrimitiveBuildernew().with_timezone("+00:00");
+let mut snapshot_id = PrimitiveBuildernew();
+let mut parent_id = PrimitiveBuildernew();
+let mut operation = StringBuilder::new();
+let mut manifest_list = StringBuilder::new();
+let mut summary = MapBuilder::new(None, StringBuilder::new(),
StringBuilder::new());
+
+for snapshot in scan.metadata_ref.snapshots() {
+committed_at.append_value(snapshot.timestamp_ms());
+snapshot_id.append_value(snapshot.snapshot_id());
+parent_id.append_option(snapshot.parent_snapshot_id());
+manifest_list.append_value(snapshot.manifest_list());
+operation.append_value(snapshot.summary().operation.
Re: [PR] Build: Fix ignoring `license-check.yml` in PR [iceberg]
Fokko merged PR #11873: URL: https://github.com/apache/iceberg/pull/11873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] feat: Support metadata table "Metadata Log Entries" [iceberg-rust]
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897375353
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Metadata table api.
+
+use std::sync::Arc;
+
+use arrow_array::builder::{MapBuilder, PrimitiveBuilder, StringBuilder};
+use arrow_array::types::{Int32Type, Int64Type, TimestampMillisecondType};
+use arrow_array::RecordBatch;
+use arrow_schema::{DataType, Field, Schema, TimeUnit};
+
+use crate::spec::{SnapshotRef, TableMetadataRef};
+use crate::table::Table;
+use crate::Result;
+
+/// Table metadata scan.
+///
+/// Used to inspect a table's history, snapshots, and other metadata as a
table.
+///
+/// See also
.
+#[derive(Debug)]
+pub struct MetadataScan {
+metadata_ref: TableMetadataRef,
+metadata_location: Option,
+}
+
+impl MetadataScan {
+/// Creates a new metadata scan.
+pub fn new(table: &Table) -> Self {
+Self {
+metadata_ref: table.metadata_ref(),
+metadata_location: table.metadata_location().map(String::from),
+}
+}
+
+/// Returns the snapshots of the table.
+pub fn snapshots(&self) -> Result {
+SnapshotsTable::scan(self)
+}
+
+/// Return the metadata log entries of the table.
+pub fn metadata_log_entries(&self) -> Result {
+MetadataLogEntriesTable::scan(self)
+}
+}
+
+/// Table metadata scan.
+///
+/// Use to inspect a table's history, snapshots, and other metadata as a table.
+///
+/// References:
+/// -
+/// -
+/// -
+pub trait MetadataTable {
+/// Returns the schema of the metadata table.
+fn schema() -> Schema;
+
+/// Scans the metadata table.
+fn scan(scan: &MetadataScan) -> Result;
+}
+
+/// Snapshots table.
+pub struct SnapshotsTable;
+
+impl MetadataTable for SnapshotsTable {
+fn schema() -> Schema {
+Schema::new(vec![
+Field::new(
+"committed_at",
+DataType::Timestamp(TimeUnit::Millisecond,
Some("+00:00".into())),
+false,
+),
+Field::new("snapshot_id", DataType::Int64, false),
+Field::new("parent_id", DataType::Int64, true),
+Field::new("operation", DataType::Utf8, false),
+Field::new("manifest_list", DataType::Utf8, false),
+Field::new(
+"summary",
+DataType::Map(
+Arc::new(Field::new(
+"entries",
+DataType::Struct(
+vec![
+Field::new("keys", DataType::Utf8, false),
+Field::new("values", DataType::Utf8, true),
+]
+.into(),
+),
+false,
+)),
+false,
+),
+false,
+),
+])
+}
+
+fn scan(scan: &MetadataScan) -> Result {
+let mut committed_at =
+
PrimitiveBuildernew().with_timezone("+00:00");
+let mut snapshot_id = PrimitiveBuildernew();
+let mut parent_id = PrimitiveBuildernew();
+let mut operation = StringBuilder::new();
+let mut manifest_list = StringBuilder::new();
+let mut summary = MapBuilder::new(None, StringBuilder::new(),
StringBuilder::new());
+
+for snapshot in scan.metadata_ref.snapshots() {
+committed_at.append_value(snapshot.timestamp_ms());
+snapshot_id.append_value(snapshot.snapshot_id());
+parent_id.append_option(snapshot.parent_snapshot_id());
+manifest_list.append_value(snapshot.manifest_list());
+operation.append_value(snapshot.summary().operation.
Re: [PR] feat: Support metadata table "Metadata Log Entries" [iceberg-rust]
rshkv commented on code in PR #846:
URL: https://github.com/apache/iceberg-rust/pull/846#discussion_r1897375800
##
crates/iceberg/src/scan.rs:
##
@@ -1019,7 +1022,7 @@ mod tests {
.metadata(table_metadata)
.identifier(TableIdent::from_strs(["db", "table1"]).unwrap())
.file_io(file_io.clone())
-
.metadata_location(table_metadata1_location.as_os_str().to_str().unwrap())
+.metadata_location(template_json_location)
Review Comment:
Before this change, the location in the metadata log and the current
location would both be `../metadata/v1.json`.
I wanted to have a distinction so we can assert that `metadata_log_entries`
includes the current metadata location, even if not in the metadata log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Core: Replace deprecated Schema.toString with SchemaFormatter [iceberg]
Fokko merged PR #11867: URL: https://github.com/apache/iceberg/pull/11867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] feat: support metadata table "snapshots" [iceberg-rust]
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1897394640
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Metadata table api.
+
+use std::sync::Arc;
+
+use arrow_array::builder::{MapBuilder, PrimitiveBuilder, StringBuilder};
+use arrow_array::types::{Int64Type, TimestampMillisecondType};
+use arrow_array::RecordBatch;
+use arrow_schema::{DataType, Field, Schema, TimeUnit};
+
+use crate::spec::TableMetadataRef;
+use crate::table::Table;
+use crate::Result;
+
+/// Table metadata scan.
+///
+/// Used to inspect a table's history, snapshots, and other metadata as a
table.
+///
+/// See also
.
+#[derive(Debug)]
+pub struct MetadataScan {
+metadata_ref: TableMetadataRef,
+}
Review Comment:
Wondering what you think about
```suggestion
pub struct MetadataScan<'a> {
table: &'a Table,
}
```
so we can get at `FileIO` and other table properties that aren't in the
metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] feat: support metadata table "snapshots" [iceberg-rust]
rshkv commented on code in PR #822:
URL: https://github.com/apache/iceberg-rust/pull/822#discussion_r1897394640
##
crates/iceberg/src/metadata_scan.rs:
##
@@ -0,0 +1,265 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+//! Metadata table api.
+
+use std::sync::Arc;
+
+use arrow_array::builder::{MapBuilder, PrimitiveBuilder, StringBuilder};
+use arrow_array::types::{Int64Type, TimestampMillisecondType};
+use arrow_array::RecordBatch;
+use arrow_schema::{DataType, Field, Schema, TimeUnit};
+
+use crate::spec::TableMetadataRef;
+use crate::table::Table;
+use crate::Result;
+
+/// Table metadata scan.
+///
+/// Used to inspect a table's history, snapshots, and other metadata as a
table.
+///
+/// See also
.
+#[derive(Debug)]
+pub struct MetadataScan {
+metadata_ref: TableMetadataRef,
+}
Review Comment:
Wondering what you think about
```suggestion
pub struct MetadataScan<'a> {
table: &'a Table,
}
```
so we can get at `FileIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Can't add column with the same name as a deleted and previously partitioned key column [iceberg]
github-actions[bot] commented on issue #10487: URL: https://github.com/apache/iceberg/issues/10487#issuecomment-2562033204 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `DataStatisticsSerializer` [iceberg]
github-actions[bot] commented on issue #10588: URL: https://github.com/apache/iceberg/issues/10588#issuecomment-2562033258 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `TableScanContext` [iceberg]
github-actions[bot] commented on issue #10589: URL: https://github.com/apache/iceberg/issues/10589#issuecomment-2562033278 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `org.apache.iceberg.ManifestEntry` [iceberg]
github-actions[bot] commented on issue #10585: URL: https://github.com/apache/iceberg/issues/10585#issuecomment-2562033228 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Potential NPE in `o.a.i.orc.OrcValueReaders.StructReader#readInternal` [iceberg]
github-actions[bot] commented on issue #10594: URL: https://github.com/apache/iceberg/issues/10594#issuecomment-2562033299 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `org.apache.iceberg.dell.ecs.EcsURI` [iceberg]
github-actions[bot] commented on issue #10587: URL: https://github.com/apache/iceberg/issues/10587#issuecomment-2562033243 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `org.apache.iceberg.expressions.BoundAggregate.Aggregator` [iceberg]
github-actions[bot] commented on issue #10584: URL: https://github.com/apache/iceberg/issues/10584#issuecomment-2562033223 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Can't add column with the same name as a deleted and previously partitioned key column [iceberg]
github-actions[bot] closed issue #10487: Can't add column with the same name as a deleted and previously partitioned key column URL: https://github.com/apache/iceberg/issues/10487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] `o.a.i.util.Tasks.Builder.runSingleThreaded` possbily broken [iceberg]
github-actions[bot] commented on issue #10597: URL: https://github.com/apache/iceberg/issues/10597#issuecomment-2562033309 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issue for `SnowflakeTableMetadata` and `SnowflakeIdentifier` [iceberg]
github-actions[bot] commented on issue #10586: URL: https://github.com/apache/iceberg/issues/10586#issuecomment-2562033237 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]
github-actions[bot] commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2562033317 This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the d...@iceberg.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Potential bug in `o.a.i.mapping.MappingUtil.UpdateMapping.addNewFields()` [iceberg]
github-actions[bot] commented on issue #10596: URL: https://github.com/apache/iceberg/issues/10596#issuecomment-2562033304 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Java visibility issues in `o.a.i.flink.sink.shuffle.AggregatedStatisticsSerializer` [iceberg]
github-actions[bot] commented on issue #10590: URL: https://github.com/apache/iceberg/issues/10590#issuecomment-2562033291 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] Core: Add support for `view-default` property in catalog [iceberg]
ebyhr commented on PR #11064: URL: https://github.com/apache/iceberg/pull/11064#issuecomment-2562034661 Rebased on main branch to resolve conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
