IzzelAliz commented on code in PR #11690:
URL: https://github.com/apache/iceberg/pull/11690#discussion_r1897338510


##########
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java:
##########
@@ -237,15 +237,15 @@ Path getMetadataFile(int metadataVersion) throws 
IOException {
     for (TableMetadataParser.Codec codec : TABLE_METADATA_PARSER_CODEC_VALUES) 
{
       Path metadataFile = metadataFilePath(metadataVersion, codec);
       FileSystem fs = getFileSystem(metadataFile, conf);
-      if (fs.exists(metadataFile)) {
+      if (fs.isFile(metadataFile)) {

Review Comment:
   I've updated them with FileIO. Users who configures a S3FileIO can benefit 
from it, and the default HadoopFileIO basically behaves the same as the 
fs.exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to