[jira] [Commented] (GEODE-8537) Memory increases whenever LRU eviction is enabled
[ https://issues.apache.org/jira/browse/GEODE-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231409#comment-17231409 ] ASF GitHub Bot commented on GEODE-8537: --- gaussianrecurrence edited a comment on pull request #687: URL: https://github.com/apache/geode-native/pull/687#issuecomment-725326162 Maybe @moleske @pivotal-jbarrett @mreddington @pdxcodemonkey @mivanac you could throw some comments? Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Memory increases whenever LRU eviction is enabled > - > > Key: GEODE-8537 > URL: https://issues.apache.org/jira/browse/GEODE-8537 > Project: Geode > Issue Type: Bug > Components: native client >Affects Versions: 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > Attachments: massif-8419.png, massif.out.8419 > > > *HAVING* configured concurrency-checks-enabled=false in the client-cache.xml > for a region > *HAVING* configured heap-lru-limit=10 in the client-cache.xml for the region > region > *HAVING* configured heap-lru-delta=10 in the client-cache.xml for the region > region > *HAVING* configured subscription-notification for the pool on which the > region is defined > *HAVING* regsitered interest on all the keys of this region, values included > *AFTER* receiving lots of LOCA_CREATE and LOCAL_DESTROY notifications > *THEN* memory increases continously over time, even going over the LRU limit. > Find massif tool report as massif.out.8419 showing the memory increase. > Also this is a capture of massif-visualizer for the report: > !massif-8419.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8704) many CI failures in Jetty9CachingClientServerTest
[
https://issues.apache.org/jira/browse/GEODE-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231496#comment-17231496
]
ASF GitHub Bot commented on GEODE-8704:
---
sabbey37 merged pull request #5745:
URL: https://github.com/apache/geode/pull/5745
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> many CI failures in Jetty9CachingClientServerTest
> -
>
> Key: GEODE-8704
> URL: https://issues.apache.org/jira/browse/GEODE-8704
> Project: Geode
> Issue Type: Bug
> Components: http session
>Affects Versions: 1.14.0
>Reporter: Kamilla Aslami
>Assignee: Benjamin P Ross
>Priority: Major
> Labels: pull-request-available
>
> A bunch of failures:
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 1 running
> on Host e4bd15534025 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:434)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:102)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:57)
> Caused by:
> java.lang.IllegalStateException: Session is invalid
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.checkValid(GemfireHttpSession.java:317)
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.setAttribute(GemfireHttpSession.java:301)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$null$0(Jetty9CachingClientServerTest.java:60)
> at java.lang.Iterable.forEach(Iterable.java:75)
> at
> java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1085)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$shouldCacheSessionOnClient$6b5e8371$1(Jetty9CachingClientServerTest.java:60)org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > shouldNotLeaveNativeSessionInContainer FAILED
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldReplicateCookies FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
>
> java.util.concurrent.TimeoutExceptionorg.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldShareSessionExpirationReset FAILED
> org.junit.ComparisonFailure:
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldExpireInSetTimeframe FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldHavePersistentSessionData FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > failureShouldStillAllowOtherContainersDataAccess FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > invalidationShouldRemoveValueAccessForAllContainers FAILE
[jira] [Commented] (GEODE-8704) many CI failures in Jetty9CachingClientServerTest
[
https://issues.apache.org/jira/browse/GEODE-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231513#comment-17231513
]
ASF subversion and git services commented on GEODE-8704:
Commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb in geode's branch
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8f8cc7b ]
GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745)
> many CI failures in Jetty9CachingClientServerTest
> -
>
> Key: GEODE-8704
> URL: https://issues.apache.org/jira/browse/GEODE-8704
> Project: Geode
> Issue Type: Bug
> Components: http session
>Affects Versions: 1.14.0
>Reporter: Kamilla Aslami
>Assignee: Benjamin P Ross
>Priority: Major
> Labels: pull-request-available
>
> A bunch of failures:
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 1 running
> on Host e4bd15534025 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:434)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:102)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:57)
> Caused by:
> java.lang.IllegalStateException: Session is invalid
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.checkValid(GemfireHttpSession.java:317)
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.setAttribute(GemfireHttpSession.java:301)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$null$0(Jetty9CachingClientServerTest.java:60)
> at java.lang.Iterable.forEach(Iterable.java:75)
> at
> java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1085)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$shouldCacheSessionOnClient$6b5e8371$1(Jetty9CachingClientServerTest.java:60)org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > shouldNotLeaveNativeSessionInContainer FAILED
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldReplicateCookies FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
>
> java.util.concurrent.TimeoutExceptionorg.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldShareSessionExpirationReset FAILED
> org.junit.ComparisonFailure:
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldExpireInSetTimeframe FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldHavePersistentSessionData FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > failureShouldStillAllowOtherContainersDataAccess FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > invalidationShouldRemoveValueAccessForAllContainers FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 1 runni
[jira] [Commented] (GEODE-8704) many CI failures in Jetty9CachingClientServerTest
[
https://issues.apache.org/jira/browse/GEODE-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231533#comment-17231533
]
ASF subversion and git services commented on GEODE-8704:
Commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb in geode's branch
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8f8cc7b ]
GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745)
> many CI failures in Jetty9CachingClientServerTest
> -
>
> Key: GEODE-8704
> URL: https://issues.apache.org/jira/browse/GEODE-8704
> Project: Geode
> Issue Type: Bug
> Components: http session
>Affects Versions: 1.14.0
>Reporter: Kamilla Aslami
>Assignee: Benjamin P Ross
>Priority: Major
> Labels: pull-request-available
>
> A bunch of failures:
> {code:java}
> org.apache.geode.session.tests.Jetty9CachingClientServerTest >
> shouldCacheSessionOnClient FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 1 running
> on Host e4bd15534025 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:434)
> at
> org.apache.geode.test.junit.rules.VMProvider.invoke(VMProvider.java:102)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.shouldCacheSessionOnClient(Jetty9CachingClientServerTest.java:57)
> Caused by:
> java.lang.IllegalStateException: Session is invalid
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.checkValid(GemfireHttpSession.java:317)
> at
> org.apache.geode.modules.session.internal.filter.GemfireHttpSession.setAttribute(GemfireHttpSession.java:301)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$null$0(Jetty9CachingClientServerTest.java:60)
> at java.lang.Iterable.forEach(Iterable.java:75)
> at
> java.util.Collections$UnmodifiableCollection.forEach(Collections.java:1085)
> at
> org.apache.geode.session.tests.Jetty9CachingClientServerTest.lambda$shouldCacheSessionOnClient$6b5e8371$1(Jetty9CachingClientServerTest.java:60)org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > shouldNotLeaveNativeSessionInContainer FAILED
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldReplicateCookies FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
>
> java.util.concurrent.TimeoutExceptionorg.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldShareSessionExpirationReset FAILED
> org.junit.ComparisonFailure:
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldExpireInSetTimeframe FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > containersShouldHavePersistentSessionData FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > failureShouldStillAllowOtherContainersDataAccess FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
> defined as a lambda expression in
> org.apache.geode.session.tests.CargoTestBase Sessions are not replicating
> properly expected: but
> was: within 5 minutes.
> Caused by:
> org.junit.ComparisonFailure: Sessions are not replicating properly
> expected: but
> was:org.apache.geode.session.tests.Jetty9CachingClientServerTest
> > invalidationShouldRemoveValueAccessForAllContainers FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableRunnable.run in VM 1 runni
[jira] [Commented] (GEODE-8694) Use fork of Redis in Gemfire org to run Redis tests in CI
[ https://issues.apache.org/jira/browse/GEODE-8694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231556#comment-17231556 ] ASF GitHub Bot commented on GEODE-8694: --- sabbey37 commented on a change in pull request #5732: URL: https://github.com/apache/geode/pull/5732#discussion_r522433989 ## File path: ci/scripts/execute_redis_tests.sh ## @@ -19,12 +19,14 @@ cd .. -# We are currently using a personal fork for this repo because our code does not implement all +# We are currently using a patched version of this repo because our code does not implement all # Redis commands. Once all commands needed to run relevant test files are implemented, we hope to -# use Redis's repo instead. -git clone --config transfer.fsckObjects=false https://github.com/prettyClouds/redis.git +# use Redis's repo without a patch. +git clone --config transfer.fsckObjects=false https://github.com/redis/redis.git +cp geode-redis/src/acceptanceTest/resources/0001-configure-redis-tests.patch redis cd redis -git checkout tests-geode-redis +git checkout origin/5.0 +git am < 0001-configure-redis-tests.patch Review comment: Ok, after hijacking the job in the pipeline, if you set ``` git config --global user.email "y...@example.com" git config --global user.name "Your Name" ``` before trying to apply the patch, it will be applied successfully. Not sure what you should set it to though? ..you could also just use `git apply` instead of `git am`, and I think you wouldn't have to set the user or email that way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use fork of Redis in Gemfire org to run Redis tests in CI > - > > Key: GEODE-8694 > URL: https://issues.apache.org/jira/browse/GEODE-8694 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: Sarah Abbey >Assignee: Helena Bales >Priority: Trivial > Labels: pull-request-available > > Currently, we are using a contributor's personal fork of Redis to run tests > against Geode Redis in CI. This should be switched to the fork of Redis in > the Gemfire org. Ideally, we will eventually be able to run tests from the > root Redis repo (currently we are unable to since we are not implementing all > the necessary commands). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8623) Timing between DNS and Geode startup can result in permanent unknown host exceptions.
[
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231574#comment-17231574
]
ASF GitHub Bot commented on GEODE-8623:
---
jinmeiliao commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r523035741
##
File path: geode-common/src/main/java/org/apache/geode/internal/Retry.java
##
@@ -47,45 +47,44 @@ public void sleep(long sleepTime, TimeUnit sleepTimeUnit)
throws InterruptedExce
}
}
- private static final SteadyClock steadyClock = new SteadyClock();
+ private static final SteadyTimer steadyClock = new SteadyTimer();
/**
* Try the supplier function until the predicate is true or timeout occurs.
*
* @param timeout to retry for
+ * @param timeoutUnit the unit for timeout
* @param interval time between each try
- * @param timeUnit to retry for
+ * @param intervalUnit the unit for interval
* @param supplier to execute until predicate is true or times out
* @param predicate to test for retry
* @param type of return value
* @return value from supplier after it passes predicate or times out.
*/
- public static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ public static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate) throws TimeoutException, InterruptedException {
-return tryFor(timeout, interval, timeUnit, supplier, predicate,
steadyClock);
+return tryFor(timeout, timeoutUnit, interval, intervalUnit, supplier,
predicate, steadyClock);
}
@VisibleForTesting
- static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate,
- Clock clock) throws TimeoutException, InterruptedException {
-long until = clock.nanoTime() + NANOSECONDS.convert(timeout, timeUnit);
+ Timer timer) throws TimeoutException, InterruptedException {
+long until = timer.nanoTime() + NANOSECONDS.convert(timeout, timeoutUnit);
T value;
do {
value = supplier.get();
if (predicate.test(value)) {
return value;
} else {
-clock.sleep(interval, timeUnit);
+timer.sleep(interval, intervalUnit);
Review comment:
Yes, but this extra calculation only affects the last iteration, and
either we sleep past the timeout or exactly at the timeout, we would exit the
loop anyway. I wouldn't mind sleeping for some extra time in the last iteration
if we can make the code simpler.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timing between DNS and Geode startup can result in permanent unknown host
> exceptions.
> -
>
> Key: GEODE-8623
> URL: https://issues.apache.org/jira/browse/GEODE-8623
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0,
> 1.14.0, 1.13.1
>Reporter: Jacob Barrett
>Priority: Minor
> Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of
> Geode happen concurrently it is possible for Geode to fail name resolution in
> the local hostname caching. If it fails to resolve the local hostname when
> loading the caching utility class then any service dependent on this name
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC tid=0x1] Jmx manager could not be
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
[jira] [Commented] (GEODE-7389) CI failure: BENCHMARK FAILED: PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231579#comment-17231579
]
John Hutchison commented on GEODE-7389:
---
occurred twice on 11/13
run
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-457-206639_base.tgz]
and run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz
> CI failure: BENCHMARK FAILED:
> PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse
> than baseline
>
>
> Key: GEODE-7389
> URL: https://issues.apache.org/jira/browse/GEODE-7389
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Barrett Oglesby
>Priority: Major
>
> The PartitionedFunctionExecutionWithFiltersBenchmark in Benchmark build 643
> failed:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/643]
> {noformat}
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average ops/second Baseline:350652.64 Test:318470.59
> Difference: -9.2%
>ops/second standard error Baseline: 399.41 Test: 408.97
> Difference: +2.4%
>ops/second standard deviation Baseline: 6906.46 Test: 7071.73
> Difference: +2.4%
> YS 99th percentile latency Baseline: 3006.00 Test: 20005.00
> Difference: +565.5%
> median latency Baseline: 1202175.00 Test: 1327103.00
> Difference: +10.4%
> 90th percentile latency Baseline: 2510847.00 Test: 2826239.00
> Difference: +12.6%
> 99th percentile latency Baseline: 11788287.00 Test: 12476415.00
> Difference: +5.8%
>99.9th percentile latency Baseline: 42631167.00 Test: 46989311.00
> Difference: +10.2%
> average latency Baseline: 1640650.66 Test: 1807133.87
> Difference: +10.1%
> latency standard deviation Baseline: 2881426.77 Test: 3148034.63
> Difference: +9.3%
> latency standard error Baseline: 281.02 Test: 322.21
> Difference: +14.7%
> BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.
> {noformat}
> Please drop a link to any additional CI runs that have this failure and
> restart the benchmarks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7389) CI failure: BENCHMARK FAILED: PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231580#comment-17231580
]
Geode Integration commented on GEODE-7389:
--
Seen in [Benchmark_base
#455|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455].
> CI failure: BENCHMARK FAILED:
> PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse
> than baseline
>
>
> Key: GEODE-7389
> URL: https://issues.apache.org/jira/browse/GEODE-7389
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Barrett Oglesby
>Priority: Major
>
> The PartitionedFunctionExecutionWithFiltersBenchmark in Benchmark build 643
> failed:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/643]
> {noformat}
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average ops/second Baseline:350652.64 Test:318470.59
> Difference: -9.2%
>ops/second standard error Baseline: 399.41 Test: 408.97
> Difference: +2.4%
>ops/second standard deviation Baseline: 6906.46 Test: 7071.73
> Difference: +2.4%
> YS 99th percentile latency Baseline: 3006.00 Test: 20005.00
> Difference: +565.5%
> median latency Baseline: 1202175.00 Test: 1327103.00
> Difference: +10.4%
> 90th percentile latency Baseline: 2510847.00 Test: 2826239.00
> Difference: +12.6%
> 99th percentile latency Baseline: 11788287.00 Test: 12476415.00
> Difference: +5.8%
>99.9th percentile latency Baseline: 42631167.00 Test: 46989311.00
> Difference: +10.2%
> average latency Baseline: 1640650.66 Test: 1807133.87
> Difference: +10.1%
> latency standard deviation Baseline: 2881426.77 Test: 3148034.63
> Difference: +9.3%
> latency standard error Baseline: 281.02 Test: 322.21
> Difference: +14.7%
> BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.
> {noformat}
> Please drop a link to any additional CI runs that have this failure and
> restart the benchmarks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7389) CI failure: BENCHMARK FAILED: PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231581#comment-17231581
]
Geode Integration commented on GEODE-7389:
--
Seen in [Benchmark_base
#457|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457].
> CI failure: BENCHMARK FAILED:
> PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse
> than baseline
>
>
> Key: GEODE-7389
> URL: https://issues.apache.org/jira/browse/GEODE-7389
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Barrett Oglesby
>Priority: Major
>
> The PartitionedFunctionExecutionWithFiltersBenchmark in Benchmark build 643
> failed:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/643]
> {noformat}
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average ops/second Baseline:350652.64 Test:318470.59
> Difference: -9.2%
>ops/second standard error Baseline: 399.41 Test: 408.97
> Difference: +2.4%
>ops/second standard deviation Baseline: 6906.46 Test: 7071.73
> Difference: +2.4%
> YS 99th percentile latency Baseline: 3006.00 Test: 20005.00
> Difference: +565.5%
> median latency Baseline: 1202175.00 Test: 1327103.00
> Difference: +10.4%
> 90th percentile latency Baseline: 2510847.00 Test: 2826239.00
> Difference: +12.6%
> 99th percentile latency Baseline: 11788287.00 Test: 12476415.00
> Difference: +5.8%
>99.9th percentile latency Baseline: 42631167.00 Test: 46989311.00
> Difference: +10.2%
> average latency Baseline: 1640650.66 Test: 1807133.87
> Difference: +10.1%
> latency standard deviation Baseline: 2881426.77 Test: 3148034.63
> Difference: +9.3%
> latency standard error Baseline: 281.02 Test: 322.21
> Difference: +14.7%
> BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.
> {noformat}
> Please drop a link to any additional CI runs that have this failure and
> restart the benchmarks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7389) CI failure: BENCHMARK FAILED: PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231579#comment-17231579
]
John Hutchison edited comment on GEODE-7389 at 11/13/20, 3:54 PM:
--
occurred twice on 11/13
run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457]
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-457-206639_base.tgz]
and run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz]
note: in both of the runs above , other benchmarks also failed
was (Author: john hutch):
occurred twice on 11/13
run
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-457-206639_base.tgz]
and run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz
> CI failure: BENCHMARK FAILED:
> PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse
> than baseline
>
>
> Key: GEODE-7389
> URL: https://issues.apache.org/jira/browse/GEODE-7389
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Barrett Oglesby
>Priority: Major
>
> The PartitionedFunctionExecutionWithFiltersBenchmark in Benchmark build 643
> failed:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/643]
> {noformat}
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average ops/second Baseline:350652.64 Test:318470.59
> Difference: -9.2%
>ops/second standard error Baseline: 399.41 Test: 408.97
> Difference: +2.4%
>ops/second standard deviation Baseline: 6906.46 Test: 7071.73
> Difference: +2.4%
> YS 99th percentile latency Baseline: 3006.00 Test: 20005.00
> Difference: +565.5%
> median latency Baseline: 1202175.00 Test: 1327103.00
> Difference: +10.4%
> 90th percentile latency Baseline: 2510847.00 Test: 2826239.00
> Difference: +12.6%
> 99th percentile latency Baseline: 11788287.00 Test: 12476415.00
> Difference: +5.8%
>99.9th percentile latency Baseline: 42631167.00 Test: 46989311.00
> Difference: +10.2%
> average latency Baseline: 1640650.66 Test: 1807133.87
> Difference: +10.1%
> latency standard deviation Baseline: 2881426.77 Test: 3148034.63
> Difference: +9.3%
> latency standard error Baseline: 281.02 Test: 322.21
> Difference: +14.7%
> BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.
> {noformat}
> Please drop a link to any additional CI runs that have this failure and
> restart the benchmarks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-6394) Analyzed and pinpoint the issue with the latency degradation
[
https://issues.apache.org/jira/browse/GEODE-6394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231586#comment-17231586
]
John Hutchison commented on GEODE-6394:
---
failure seems to occur again on 11/13
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz
> Analyzed and pinpoint the issue with the latency degradation
>
>
> Key: GEODE-6394
> URL: https://issues.apache.org/jira/browse/GEODE-6394
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Nabarun Nag
>Assignee: Helena Bales
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The benchmarks are failing with latency degradation of more than 5% when
> comparing 1.8.0 to current develop (1.9.0).
> This failure needs to be analyzed and pinpoint the issue why there is the
> performance degradation in these benchmarks.
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/66
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionBenchmark
> average latency is 5% worse than baseline.}}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/67
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionBenchmark
> average latency is 5% worse than baseline.}}
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark
> average latency is 5% worse than baseline.}}
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average
> latency is 5% worse than baseline.}}
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithArgumentsBenchmark
> average latency is 5% worse than baseline.}}
> {{BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231587#comment-17231587
]
ASF GitHub Bot commented on GEODE-8670:
---
bschuchardt commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523043949
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -137,6 +137,18 @@ public void startedLocatorHasLocator() throws IOException {
assertThat(InternalLocator.hasLocator()).isTrue();
}
+ @Test
Review comment:
true, but I couldn't see how to write a better test. Maybe you'd like
to work with me on that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8623) Timing between DNS and Geode startup can result in permanent unknown host exceptions.
[
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231590#comment-17231590
]
ASF GitHub Bot commented on GEODE-8623:
---
pivotal-jbarrett commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r523044795
##
File path: geode-common/src/main/java/org/apache/geode/internal/Retry.java
##
@@ -47,45 +47,44 @@ public void sleep(long sleepTime, TimeUnit sleepTimeUnit)
throws InterruptedExce
}
}
- private static final SteadyClock steadyClock = new SteadyClock();
+ private static final SteadyTimer steadyClock = new SteadyTimer();
/**
* Try the supplier function until the predicate is true or timeout occurs.
*
* @param timeout to retry for
+ * @param timeoutUnit the unit for timeout
* @param interval time between each try
- * @param timeUnit to retry for
+ * @param intervalUnit the unit for interval
* @param supplier to execute until predicate is true or times out
* @param predicate to test for retry
* @param type of return value
* @return value from supplier after it passes predicate or times out.
*/
- public static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ public static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate) throws TimeoutException, InterruptedException {
-return tryFor(timeout, interval, timeUnit, supplier, predicate,
steadyClock);
+return tryFor(timeout, timeoutUnit, interval, intervalUnit, supplier,
predicate, steadyClock);
}
@VisibleForTesting
- static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate,
- Clock clock) throws TimeoutException, InterruptedException {
-long until = clock.nanoTime() + NANOSECONDS.convert(timeout, timeUnit);
+ Timer timer) throws TimeoutException, InterruptedException {
+long until = timer.nanoTime() + NANOSECONDS.convert(timeout, timeoutUnit);
T value;
do {
value = supplier.get();
if (predicate.test(value)) {
return value;
} else {
-clock.sleep(interval, timeUnit);
+timer.sleep(interval, intervalUnit);
Review comment:
Also, we sleep at the end only to delay the return of the failed
predicate state. Sleeping min time and then continue after guards against
sleeping past the timeout and gives the opportunity of the predicate to go pass
before returning. No point in sleeping if we are just going to fall through the
while block immediately, we aren't trying to delay the return but rather the
execution of the code block.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timing between DNS and Geode startup can result in permanent unknown host
> exceptions.
> -
>
> Key: GEODE-8623
> URL: https://issues.apache.org/jira/browse/GEODE-8623
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0,
> 1.14.0, 1.13.1
>Reporter: Jacob Barrett
>Priority: Minor
> Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of
> Geode happen concurrently it is possible for Geode to fail name resolution in
> the local hostname caching. If it fails to resolve the local hostname when
> loading the caching utility class then any service dependent on this name
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC tid=0x1] Jmx manager could not be
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistribut
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231592#comment-17231592
]
ASF GitHub Bot commented on GEODE-8670:
---
bschuchardt commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523043949
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -137,6 +137,18 @@ public void startedLocatorHasLocator() throws IOException {
assertThat(InternalLocator.hasLocator()).isTrue();
}
+ @Test
Review comment:
true, but I couldn't see how to write a better test. Maybe you'd like
to work with me on that?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7389) CI failure: BENCHMARK FAILED: PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231579#comment-17231579
]
John Hutchison edited comment on GEODE-7389 at 11/13/20, 4:07 PM:
--
occurred on 11/13
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz]
note: other benchmarks also failed
BENCHMARK FAILED:
org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
average latency is 5% worse than baseline.
[23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:7102]
BENCHMARK FAILED:
org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average
latency is 5% worse than baseline.
[23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:7103]
was (Author: john hutch):
occurred twice on 11/13
run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457]
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-457-206639_base.tgz]
and run
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455]
[http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz]
note: in both of the runs above , other benchmarks also failed
> CI failure: BENCHMARK FAILED:
> PartitionedFunctionExecutionWithFiltersBenchmark average latency is 5% worse
> than baseline
>
>
> Key: GEODE-7389
> URL: https://issues.apache.org/jira/browse/GEODE-7389
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Barrett Oglesby
>Priority: Major
>
> The PartitionedFunctionExecutionWithFiltersBenchmark in Benchmark build 643
> failed:
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark/builds/643]
> {noformat}
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average ops/second Baseline:350652.64 Test:318470.59
> Difference: -9.2%
>ops/second standard error Baseline: 399.41 Test: 408.97
> Difference: +2.4%
>ops/second standard deviation Baseline: 6906.46 Test: 7071.73
> Difference: +2.4%
> YS 99th percentile latency Baseline: 3006.00 Test: 20005.00
> Difference: +565.5%
> median latency Baseline: 1202175.00 Test: 1327103.00
> Difference: +10.4%
> 90th percentile latency Baseline: 2510847.00 Test: 2826239.00
> Difference: +12.6%
> 99th percentile latency Baseline: 11788287.00 Test: 12476415.00
> Difference: +5.8%
>99.9th percentile latency Baseline: 42631167.00 Test: 46989311.00
> Difference: +10.2%
> average latency Baseline: 1640650.66 Test: 1807133.87
> Difference: +10.1%
> latency standard deviation Baseline: 2881426.77 Test: 3148034.63
> Difference: +9.3%
> latency standard error Baseline: 281.02 Test: 322.21
> Difference: +14.7%
> BENCHMARK FAILED:
> org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithFiltersBenchmark
> average latency is 5% worse than baseline.
> {noformat}
> Please drop a link to any additional CI runs that have this failure and
> restart the benchmarks.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8709) ReplicatedFunctionExecutionBenchmark failing
John Hutchison created GEODE-8709: - Summary: ReplicatedFunctionExecutionBenchmark failing Key: GEODE-8709 URL: https://issues.apache.org/jira/browse/GEODE-8709 Project: Geode Issue Type: Bug Reporter: John Hutchison org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6985] average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6986] ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6987] ops/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: -8.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6988] YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6989] median latency Baseline: 1213439.00 Test: 1215487.00 Difference: +0.2% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6990] 90th percentile latency Baseline: 1465343.00 Test: 1518591.00 Difference: +3.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6991] 99th percentile latency Baseline: 4517887.00 Test: 4636671.00 Difference: +2.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6992] 99.9th percentile latency Baseline: 18202623.00 Test: 19234815.00 Difference: +5.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6993] average latency Baseline: 1315053.32 Test: 1337898.07 Difference: +1.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6994] latency standard deviation Baseline: 1303983.91 Test: 1335112.23 Difference: +2.4% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6995] latency standard error Baseline: 101.85 Test: 105.17 Difference: +3.3% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6996] average ops/second Baseline: 546531.56 Test: 537283.96 Difference: -1.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average latency is 5% worse than baseline. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8709) ReplicatedFunctionExecutionBenchmark failing
[ https://issues.apache.org/jira/browse/GEODE-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-8709: -- Description: org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% s/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: -8.6% YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% median latency Baseline: 1213439.00 Test: 1215487.00 Difference: +0.2% 90th percentile latency Baseline: 1465343.00 Test: 1518591.00 Difference: +3.6% 99th percentile latency Baseline: 4517887.00 Test: 4636671.00 Difference: +2.6% 99.9th percentile latency Baseline: 18202623.00 Test: 19234815.00 Difference: +5.7% average latency Baseline: 1315053.32 Test: 1337898.07 Difference: +1.7% latency standard deviation Baseline: 1303983.91 Test: 1335112.23 Difference: +2.4% latency standard error Baseline: 101.85 Test: 105.17 Difference: +3.3% average ops/second Baseline: 546531.56 Test: 537283.96 Difference: -1.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average latency is 5% worse than baseline. was: org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6985] average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6986] ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6987] ops/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: -8.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6988] YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6989] median latency Baseline: 1213439.00 Test: 1215487.00 Difference: +0.2% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6990] 90th percentile latency Baseline: 1465343.00 Test: 1518591.00 Difference: +3.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6991] 99th percentile latency Baseline: 4517887.00 Test: 4636671.00 Difference: +2.6% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6992] 99.9th percentile latency Baseline: 18202623.00 Test: 19234815.00 Difference: +5.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6993] average latency Baseline: 1315053.32 Test: 1337898.07 Difference: +1.7% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6994] latency standard deviation Baseline: 1303983.91 Test: 1335112.23 Difference: +2.4% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6995] latency standard error Baseline: 101.85 Test: 105.17 Difference: +3.3% [23:46:36|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455#L5f7d595d:6996] average ops/second Baseline: 546531.56 Test: 537283.96 Difference: -1.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average latency is 5% worse than baseline. > ReplicatedFunctionExecutionBenchmark failing > - > > Key: GEODE-8709 > URL: https://issues.apache.org/jira/browse/GEODE-8709 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Priority: Major > > > > org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark > > average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% > ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% > s/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: > -8.6% > YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% > median latency Baseline: 1213439.00 Test: 1215487.00 Difference
[jira] [Commented] (GEODE-8709) ReplicatedFunctionExecutionBenchmark failing
[ https://issues.apache.org/jira/browse/GEODE-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231593#comment-17231593 ] John Hutchison commented on GEODE-8709: --- [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455] This reverts commit f6605e0820ba9b858b8128cd31a03a29067b7710. =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > ReplicatedFunctionExecutionBenchmark failing > - > > Key: GEODE-8709 > URL: https://issues.apache.org/jira/browse/GEODE-8709 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Priority: Major > > > > org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark > > average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% > ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% > s/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: > -8.6% > YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% > median latency Baseline: 1213439.00 Test: 1215487.00 Difference: +0.2% > 90th percentile latency Baseline: 1465343.00 Test: 1518591.00 Difference: > +3.6% > 99th percentile latency Baseline: 4517887.00 Test: 4636671.00 Difference: > +2.6% > 99.9th percentile latency Baseline: 18202623.00 Test: 19234815.00 > Difference: +5.7% > average latency Baseline: 1315053.32 Test: 1337898.07 Difference: +1.7% > latency standard deviation Baseline: 1303983.91 Test: 1335112.23 Difference: > +2.4% > latency standard error Baseline: 101.85 Test: 105.17 Difference: +3.3% > average ops/second Baseline: 546531.56 Test: 537283.96 Difference: -1.7% > BENCHMARK FAILED: > org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average > latency is 5% worse than baseline. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231596#comment-17231596
]
ASF GitHub Bot commented on GEODE-8670:
---
bschuchardt commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523054006
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -137,6 +137,18 @@ public void startedLocatorHasLocator() throws IOException {
assertThat(InternalLocator.hasLocator()).isTrue();
}
+ @Test
Review comment:
I think that, in fact, the test is invalid. I'll post a better one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7231) CI: BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline.
[ https://issues.apache.org/jira/browse/GEODE-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231597#comment-17231597 ] Geode Integration commented on GEODE-7231: -- Seen in [Benchmark_base #457|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457]. > CI: BENCHMARK FAILED: > org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark > average latency is 5% worse than baseline. > > > Key: GEODE-7231 > URL: https://issues.apache.org/jira/browse/GEODE-7231 > Project: Geode > Issue Type: Bug > Components: benchmarks, ci >Reporter: Jinmei Liao >Assignee: Jacob Barrett >Priority: Major > > created by mistake -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7231) CI: BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline.
[ https://issues.apache.org/jira/browse/GEODE-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231601#comment-17231601 ] John Hutchison commented on GEODE-7231: --- occurred again in run [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457] org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average ops/second Baseline: 288420.47 Test: 266334.08 Difference: -7.7% ops/second standard error Baseline: 706.84 Test: 639.07 Difference: -9.6% ops/second standard deviation Baseline: 1.36 Test: 11050.63 Difference: -9.6% YS 99th percentile latency Baseline: 1804.00 Test: 1905.00 Difference: +5.6% median latency Baseline: 697343.00 Test: 756735.00 Difference: +8.5% 90th percentile latency Baseline: 1295359.00 Test: 1354751.00 Difference: +4.6% 99th percentile latency Baseline: 8921087.00 Test: 9887743.00 Difference: +10.8% 99.9th percentile latency Baseline: 22659071.00 Test: 23740415.00 Difference: +4.8% average latency Baseline: 996875.28 Test: 1079779.99 Difference: +8.3% latency standard deviation Baseline: 1649168.77 Test: 1814626.40 Difference: +10.0% latency standard error Baseline: 177.33 Test: 203.06 Difference: +14.5% average ops/second Baseline: 288357.32 Test: 266245.32 Difference: -7.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline. > CI: BENCHMARK FAILED: > org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark > average latency is 5% worse than baseline. > > > Key: GEODE-7231 > URL: https://issues.apache.org/jira/browse/GEODE-7231 > Project: Geode > Issue Type: Bug > Components: benchmarks, ci >Reporter: Jinmei Liao >Assignee: Jacob Barrett >Priority: Major > > created by mistake -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7231) CI: BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline.
[ https://issues.apache.org/jira/browse/GEODE-7231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231601#comment-17231601 ] John Hutchison edited comment on GEODE-7231 at 11/13/20, 4:22 PM: -- occurred again in run [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457] org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average ops/second Baseline: 288420.47 Test: 266334.08 Difference: -7.7% ops/second standard error Baseline: 706.84 Test: 639.07 Difference: -9.6% ops/second standard deviation Baseline: 1.36 Test: 11050.63 Difference: -9.6% YS 99th percentile latency Baseline: 1804.00 Test: 1905.00 Difference: +5.6% median latency Baseline: 697343.00 Test: 756735.00 Difference: +8.5% 90th percentile latency Baseline: 1295359.00 Test: 1354751.00 Difference: +4.6% 99th percentile latency Baseline: 8921087.00 Test: 9887743.00 Difference: +10.8% 99.9th percentile latency Baseline: 22659071.00 Test: 23740415.00 Difference: +4.8% average latency Baseline: 996875.28 Test: 1079779.99 Difference: +8.3% latency standard deviation Baseline: 1649168.77 Test: 1814626.40 Difference: +10.0% latency standard error Baseline: 177.33 Test: 203.06 Difference: +14.5% average ops/second Baseline: 288357.32 Test: 266245.32 Difference: -7.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline. was (Author: john hutch): occurred again in run [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457] org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average ops/second Baseline: 288420.47 Test: 266334.08 Difference: -7.7% ops/second standard error Baseline: 706.84 Test: 639.07 Difference: -9.6% ops/second standard deviation Baseline: 1.36 Test: 11050.63 Difference: -9.6% YS 99th percentile latency Baseline: 1804.00 Test: 1905.00 Difference: +5.6% median latency Baseline: 697343.00 Test: 756735.00 Difference: +8.5% 90th percentile latency Baseline: 1295359.00 Test: 1354751.00 Difference: +4.6% 99th percentile latency Baseline: 8921087.00 Test: 9887743.00 Difference: +10.8% 99.9th percentile latency Baseline: 22659071.00 Test: 23740415.00 Difference: +4.8% average latency Baseline: 996875.28 Test: 1079779.99 Difference: +8.3% latency standard deviation Baseline: 1649168.77 Test: 1814626.40 Difference: +10.0% latency standard error Baseline: 177.33 Test: 203.06 Difference: +14.5% average ops/second Baseline: 288357.32 Test: 266245.32 Difference: -7.7% BENCHMARK FAILED: org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark average latency is 5% worse than baseline. > CI: BENCHMARK FAILED: > org.apache.geode.benchmark.tests.PartitionedFunctionExecutionWithArgumentsBenchmark > average latency is 5% worse than baseline. > > > Key: GEODE-7231 > URL: https://issues.apache.org/jira/browse/GEODE-7231 > Project: Geode > Issue Type: Bug > Components: benchmarks, ci >Reporter: Jinmei Liao >Assignee: Jacob Barrett >Priority: Major > > created by mistake -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7616) ReplicatedPutAllBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231608#comment-17231608
]
John Hutchison commented on GEODE-7616:
---
11/3
org.apache.geode.benchmark.tests.ReplicatedPutAllLongBenchmark
average ops/second Baseline: 854.09 Test: 850.53 Difference: -0.4%
ops/second standard error Baseline: 2.82 Test: 2.52 Difference: -10.8%
ops/second standard deviation Baseline: 48.86 Test: 43.51 Difference: -10.9%
YS 99th percentile latency Baseline: 20099.00 Test: 20099.00 Difference: +0.0%
median latency Baseline: 164757503.00 Test: 165543935.00 Difference: +0.5%
90th percentile latency Baseline: 249036799.00 Test: 245366783.00 Difference:
-1.5%
99th percentile latency Baseline: 328466431.00 Test: 319029247.00 Difference:
-2.9%
99.9th percentile latency Baseline: 407896063.00 Test: 383778815.00
Difference: -5.9%
average latency Baseline: 168732913.71 Test: 169570366.99 Difference: +0.5%
latency standard deviation Baseline: 61216607.41 Test: 57135462.90 Difference:
-6.7%
latency standard error Baseline: 121028.48 Test: 113222.36 Difference: -6.4%
average ops/second Baseline: 852.91 Test: 848.79 Difference: -0.5%
BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
average latency is 5% worse than baseline.
> ReplicatedPutAllBenchmark average latency is 5% worse than baseline
> ---
>
> Key: GEODE-7616
> URL: https://issues.apache.org/jira/browse/GEODE-7616
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Bill Burcham
>Assignee: Jacob Barrett
>Priority: Major
>
> Three runs in a row have failed with {{ReplicatedPutAllBenchmark average
> latency is 5% worse than baseline}} starting with:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/23
> e.g.
> {code}
> org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
> average ops/second Baseline: 900.64 Test: 828.40
> Difference: -8.0%
>ops/second standard error Baseline: 2.71 Test: 2.47
> Difference: -8.9%
>ops/second standard deviation Baseline:46.91 Test:42.76
> Difference: -8.9%
> YS 99th percentile latency Baseline: 20099.00 Test: 20099.00
> Difference: +0.0%
> median latency Baseline: 158728191.00 Test: 172359679.00
> Difference: +8.6%
> 90th percentile latency Baseline: 228458495.00 Test: 29279.00
> Difference: +7.0%
> 99th percentile latency Baseline: 299368447.00 Test: 319815679.00
> Difference: +6.8%
>99.9th percentile latency Baseline: 354156543.00 Test: 387710975.00
> Difference: +9.5%
> average latency Baseline: 160197744.39 Test: 174083983.05
> Difference: +8.7%
> latency standard deviation Baseline: 53484962.25 Test: 55775317.05
> Difference: +4.3%
> latency standard error Baseline:103053.88 Test:111997.05
> Difference: +8.7%
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7616) ReplicatedPutAllBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231608#comment-17231608
]
John Hutchison edited comment on GEODE-7616 at 11/13/20, 4:28 PM:
--
11/3
org.apache.geode.benchmark.tests.ReplicatedPutAllLongBenchmark
average ops/second Baseline: 854.09 Test: 850.53 Difference: -0.4%
ops/second standard error Baseline: 2.82 Test: 2.52 Difference: -10.8%
ops/second standard deviation Baseline: 48.86 Test: 43.51 Difference: -10.9%
YS 99th percentile latency Baseline: 20099.00 Test: 20099.00 Difference: +0.0%
median latency Baseline: 164757503.00 Test: 165543935.00 Difference: +0.5%
90th percentile latency Baseline: 249036799.00 Test: 245366783.00 Difference:
-1.5%
99th percentile latency Baseline: 328466431.00 Test: 319029247.00 Difference:
-2.9%
99.9th percentile latency Baseline: 407896063.00 Test: 383778815.00
Difference: -5.9%
average latency Baseline: 168732913.71 Test: 169570366.99 Difference: +0.5%
latency standard deviation Baseline: 61216607.41 Test: 57135462.90 Difference:
-6.7%
latency standard error Baseline: 121028.48 Test: 113222.36 Difference: -6.4%
average ops/second Baseline: 852.91 Test: 848.79 Difference: -0.5%
BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
average latency is 5% worse than baseline.
was (Author: john hutch):
11/3
org.apache.geode.benchmark.tests.ReplicatedPutAllLongBenchmark
average ops/second Baseline: 854.09 Test: 850.53 Difference: -0.4%
ops/second standard error Baseline: 2.82 Test: 2.52 Difference: -10.8%
ops/second standard deviation Baseline: 48.86 Test: 43.51 Difference: -10.9%
YS 99th percentile latency Baseline: 20099.00 Test: 20099.00 Difference: +0.0%
median latency Baseline: 164757503.00 Test: 165543935.00 Difference: +0.5%
90th percentile latency Baseline: 249036799.00 Test: 245366783.00 Difference:
-1.5%
99th percentile latency Baseline: 328466431.00 Test: 319029247.00 Difference:
-2.9%
99.9th percentile latency Baseline: 407896063.00 Test: 383778815.00
Difference: -5.9%
average latency Baseline: 168732913.71 Test: 169570366.99 Difference: +0.5%
latency standard deviation Baseline: 61216607.41 Test: 57135462.90 Difference:
-6.7%
latency standard error Baseline: 121028.48 Test: 113222.36 Difference: -6.4%
average ops/second Baseline: 852.91 Test: 848.79 Difference: -0.5%
BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
average latency is 5% worse than baseline.
> ReplicatedPutAllBenchmark average latency is 5% worse than baseline
> ---
>
> Key: GEODE-7616
> URL: https://issues.apache.org/jira/browse/GEODE-7616
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Bill Burcham
>Assignee: Jacob Barrett
>Priority: Major
>
> Three runs in a row have failed with {{ReplicatedPutAllBenchmark average
> latency is 5% worse than baseline}} starting with:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/23
> e.g.
> {code}
> org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
> average ops/second Baseline: 900.64 Test: 828.40
> Difference: -8.0%
>ops/second standard error Baseline: 2.71 Test: 2.47
> Difference: -8.9%
>ops/second standard deviation Baseline:46.91 Test:42.76
> Difference: -8.9%
> YS 99th percentile latency Baseline: 20099.00 Test: 20099.00
> Difference: +0.0%
> median latency Baseline: 158728191.00 Test: 172359679.00
> Difference: +8.6%
> 90th percentile latency Baseline: 228458495.00 Test: 29279.00
> Difference: +7.0%
> 99th percentile latency Baseline: 299368447.00 Test: 319815679.00
> Difference: +6.8%
>99.9th percentile latency Baseline: 354156543.00 Test: 387710975.00
> Difference: +9.5%
> average latency Baseline: 160197744.39 Test: 174083983.05
> Difference: +8.7%
> latency standard deviation Baseline: 53484962.25 Test: 55775317.05
> Difference: +4.3%
> latency standard error Baseline:103053.88 Test:111997.05
> Difference: +8.7%
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-7616) ReplicatedPutAllBenchmark average latency is 5% worse than baseline
[
https://issues.apache.org/jira/browse/GEODE-7616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231608#comment-17231608
]
John Hutchison edited comment on GEODE-7616 at 11/13/20, 4:29 PM:
--
occurred 11/13/20
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/457
Comparing test result at
/tmp/build/2d6310e3/results/benchmarks-apache-develop-main-Benchmark_base-457-206639_base/branch/benchmarks_20201113090025
to baseline at
/tmp/build/2d6310e3/results/benchmarks-apache-develop-main-Benchmark_base-457-206639_base/baseline/benchmarks_20201113055501
org.apache.geode.benchmark.tests.ReplicatedPutAllLongBenchmark
average ops/second Baseline: 854.09 Test: 850.53 Difference: -0.4%
ops/second standard error Baseline: 2.82 Test: 2.52 Difference: -10.8%
ops/second standard deviation Baseline: 48.86 Test: 43.51 Difference: -10.9%
YS 99th percentile latency Baseline: 20099.00 Test: 20099.00 Difference: +0.0%
median latency Baseline: 164757503.00 Test: 165543935.00 Difference: +0.5%
90th percentile latency Baseline: 249036799.00 Test: 245366783.00 Difference:
-1.5%
99th percentile latency Baseline: 328466431.00 Test: 319029247.00 Difference:
-2.9%
99.9th percentile latency Baseline: 407896063.00 Test: 383778815.00
Difference: -5.9%
average latency Baseline: 168732913.71 Test: 169570366.99 Difference: +0.5%
latency standard deviation Baseline: 61216607.41 Test: 57135462.90 Difference:
-6.7%
latency standard error Baseline: 121028.48 Test: 113222.36 Difference: -6.4%
average ops/second Baseline: 852.91 Test: 848.79 Difference: -0.5%
BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
average latency is 5% worse than baseline.
was (Author: john hutch):
11/3
org.apache.geode.benchmark.tests.ReplicatedPutAllLongBenchmark
average ops/second Baseline: 854.09 Test: 850.53 Difference: -0.4%
ops/second standard error Baseline: 2.82 Test: 2.52 Difference: -10.8%
ops/second standard deviation Baseline: 48.86 Test: 43.51 Difference: -10.9%
YS 99th percentile latency Baseline: 20099.00 Test: 20099.00 Difference: +0.0%
median latency Baseline: 164757503.00 Test: 165543935.00 Difference: +0.5%
90th percentile latency Baseline: 249036799.00 Test: 245366783.00 Difference:
-1.5%
99th percentile latency Baseline: 328466431.00 Test: 319029247.00 Difference:
-2.9%
99.9th percentile latency Baseline: 407896063.00 Test: 383778815.00
Difference: -5.9%
average latency Baseline: 168732913.71 Test: 169570366.99 Difference: +0.5%
latency standard deviation Baseline: 61216607.41 Test: 57135462.90 Difference:
-6.7%
latency standard error Baseline: 121028.48 Test: 113222.36 Difference: -6.4%
average ops/second Baseline: 852.91 Test: 848.79 Difference: -0.5%
BENCHMARK FAILED: org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
average latency is 5% worse than baseline.
> ReplicatedPutAllBenchmark average latency is 5% worse than baseline
> ---
>
> Key: GEODE-7616
> URL: https://issues.apache.org/jira/browse/GEODE-7616
> Project: Geode
> Issue Type: Bug
> Components: benchmarks
>Reporter: Bill Burcham
>Assignee: Jacob Barrett
>Priority: Major
>
> Three runs in a row have failed with {{ReplicatedPutAllBenchmark average
> latency is 5% worse than baseline}} starting with:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/23
> e.g.
> {code}
> org.apache.geode.benchmark.tests.ReplicatedPutAllBenchmark
> average ops/second Baseline: 900.64 Test: 828.40
> Difference: -8.0%
>ops/second standard error Baseline: 2.71 Test: 2.47
> Difference: -8.9%
>ops/second standard deviation Baseline:46.91 Test:42.76
> Difference: -8.9%
> YS 99th percentile latency Baseline: 20099.00 Test: 20099.00
> Difference: +0.0%
> median latency Baseline: 158728191.00 Test: 172359679.00
> Difference: +8.6%
> 90th percentile latency Baseline: 228458495.00 Test: 29279.00
> Difference: +7.0%
> 99th percentile latency Baseline: 299368447.00 Test: 319815679.00
> Difference: +6.8%
>99.9th percentile latency Baseline: 354156543.00 Test: 387710975.00
> Difference: +9.5%
> average latency Baseline: 160197744.39 Test: 174083983.05
> Difference: +8.7%
> latency standard deviation Baseline: 53484962.25 Test: 55775317.05
> Difference: +4.3%
> latency standard error Baseline:103053.88 Test:111997.05
> Difference: +8.7%
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#80
[jira] [Comment Edited] (GEODE-8709) ReplicatedFunctionExecutionBenchmark failing
[ https://issues.apache.org/jira/browse/GEODE-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231593#comment-17231593 ] John Hutchison edited comment on GEODE-8709 at 11/13/20, 4:34 PM: -- [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455] This reverts commit f6605e0820ba9b858b8128cd31a03a29067b7710. =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= [http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz] =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= was (Author: john hutch): [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_base/builds/455] This reverts commit f6605e0820ba9b858b8128cd31a03a29067b7710. =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/benchmarks/apache-develop-main/f23e01a32213245dc684b417d97a14cf5a026741/benchmarks-apache-develop-main-Benchmark_base-455-206443_base.tgz =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > ReplicatedFunctionExecutionBenchmark failing > - > > Key: GEODE-8709 > URL: https://issues.apache.org/jira/browse/GEODE-8709 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Priority: Major > > > > org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionWithFiltersBenchmark > > average ops/second Baseline: 546625.03 Test: 537316.10 Difference: -1.7% > ops/second standard error Baseline: 776.77 Test: 709.95 Difference: -8.6% > s/second standard deviation Baseline: 13431.54 Test: 12276.10 Difference: > -8.6% > YS 99th percentile latency Baseline: 1700.00 Test: 1750.00 Difference: +2.9% > median latency Baseline: 1213439.00 Test: 1215487.00 Difference: +0.2% > 90th percentile latency Baseline: 1465343.00 Test: 1518591.00 Difference: > +3.6% > 99th percentile latency Baseline: 4517887.00 Test: 4636671.00 Difference: > +2.6% > 99.9th percentile latency Baseline: 18202623.00 Test: 19234815.00 > Difference: +5.7% > average latency Baseline: 1315053.32 Test: 1337898.07 Difference: +1.7% > latency standard deviation Baseline: 1303983.91 Test: 1335112.23 Difference: > +2.4% > latency standard error Baseline: 101.85 Test: 105.17 Difference: +3.3% > average ops/second Baseline: 546531.56 Test: 537283.96 Difference: -1.7% > BENCHMARK FAILED: > org.apache.geode.benchmark.tests.ReplicatedFunctionExecutionBenchmark average > latency is 5% worse than baseline. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8697) Propagate ForcedDisconnectException to the user application in a network partition scenario
[
https://issues.apache.org/jira/browse/GEODE-8697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231732#comment-17231732
]
ASF GitHub Bot commented on GEODE-8697:
---
kamilla1201 closed pull request #5729:
URL: https://github.com/apache/geode/pull/5729
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Propagate ForcedDisconnectException to the user application in a network
> partition scenario
> ---
>
> Key: GEODE-8697
> URL: https://issues.apache.org/jira/browse/GEODE-8697
> Project: Geode
> Issue Type: Bug
> Components: membership
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Kamilla Aslami
>Assignee: Bruce J Schuchardt
>Priority: Minor
> Labels: pull-request-available
>
> During network partitioning, we expect that the coordinator closes its
> cluster with a ForcedDisconnectException. However, in some cases, threads end
> up with a MemberDisconnectedException.
> System logs show that a ForcedDisconnect has happened:
> {code:java}
> org.apache.geode.distributed.internal.membership.api.MemberDisconnectedException:
> Membership coordinator
> 10.32.111.185(gemfire3_host1_7340:7340:locator):41000 has declared
> that a network partition has occurred
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.forceDisconnect(GMSMembership.java:2007)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.forceDisconnect(GMSJoinLeave.java:1085)
> at
> org.apache.geode.distributed.internal.membership.gms.membership.GMSJoinLeave.processMessage(GMSJoinLeave.java:1422)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1327)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.JGroupsMessenger$JGroupsReceiver.receive(JGroupsMessenger.java:1266)
> at org.jgroups.JChannel.invokeCallback(JChannel.java:816)
> at org.jgroups.JChannel.up(JChannel.java:741)
> at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1030)
> at org.jgroups.protocols.FRAG2.up(FRAG2.java:165)
> at org.jgroups.protocols.FlowControl.up(FlowControl.java:390)
> at org.jgroups.protocols.UNICAST3.deliverMessage(UNICAST3.java:1077)
> at org.jgroups.protocols.UNICAST3.handleDataReceived(UNICAST3.java:792)
> at org.jgroups.protocols.UNICAST3.up(UNICAST3.java:433)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.StatRecorder.up(StatRecorder.java:72)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.AddressManager.up(AddressManager.java:70)
> at org.jgroups.protocols.TP.passMessageUp(TP.java:1658)
> at org.jgroups.protocols.TP$SingleMessageHandler.run(TP.java:1876)
> at org.jgroups.util.DirectExecutor.execute(DirectExecutor.java:10)
> at org.jgroups.protocols.TP.handleSingleMessage(TP.java:1789)
> at org.jgroups.protocols.TP.receive(TP.java:1714)
> at
> org.apache.geode.distributed.internal.membership.gms.messenger.Transport.receive(Transport.java:159)
> at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:701)
> at java.lang.Thread.run(Thread.java:748){code}
> But it is never propagated upwards to the user application:
> {code:java}
> org.apache.geode.distributed.DistributedSystemDisconnectedException: This
> connection to a distributed system has been disconnected., caused by
> org.apache.geode.distributed.internal.membership.api.MemberDisconnectedException:
> Membership coordinator
> 10.32.111.185(gemfire3_host1_7340:7340:locator):41000 has declared
> that a network partition has occurred
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.checkConnected(InternalDistributedSystem.java:978)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.getDistributionManager(InternalDistributedSystem.java:1679)
> at
> org.apache.geode.distributed.internal.ReplyProcessor21.getDistributionManager(ReplyProcessor21.java:366)
> at
> org.apache.geode.distributed.internal.ReplyProcessor21.postWait(ReplyProcessor21.java:600)
> at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:824)
> at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:779)
> at
> org.apache.geode.distributed.internal.ReplyProcessor21.waitForRepliesUninterruptibly(ReplyProcessor21.java:865)
> at
> org.apache.geode.internal.cache.partitio
[jira] [Commented] (GEODE-7710) JMXMBeanReconnectDUnitTest fails intermittently because one locator is missing the LockServiceMXBean
[
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231740#comment-17231740
]
John Hutchison commented on GEODE-7710:
---
11/13/20
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-results/distributedTest/1605285407/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-artifacts/1605285407/distributedtestfiles-OpenJDK8-1.14.0-build.0484.tgz
> JMXMBeanReconnectDUnitTest fails intermittently because one locator is
> missing the LockServiceMXBean
>
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: flaky
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7710) JMXMBeanReconnectDUnitTest fails intermittently because one locator is missing the LockServiceMXBean
[
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231741#comment-17231741
]
Geode Integration commented on GEODE-7710:
--
Seen in [DistributedTestOpenJDK8
#620|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/620]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-results/distributedTest/1605285407/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-artifacts/1605285407/distributedtestfiles-OpenJDK8-1.14.0-build.0484.tgz].
> JMXMBeanReconnectDUnitTest fails intermittently because one locator is
> missing the LockServiceMXBean
>
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
> Issue Type: Bug
> Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: flaky
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231752#comment-17231752
]
ASF GitHub Bot commented on GEODE-8593:
---
lgtm-com[bot] commented on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-726960924
This pull request **fixes 1 alert** when merging
915f5370bb84f11d380dbac7f119caacb6b10338 into
5c7d47d34c2b8a53874ec6f53e66c2290fd0427c - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-61f1fee8d4d140a49391fa7664569a05b635c1ba)
**fixed alerts:**
* 1 for Useless assignment to local variable
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8710) PartitionedFunctionExecutionBenchmark failure
John Hutchison created GEODE-8710: - Summary: PartitionedFunctionExecutionBenchmark failure Key: GEODE-8710 URL: https://issues.apache.org/jira/browse/GEODE-8710 Project: Geode Issue Type: Bug Reporter: John Hutchison =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=This benchmark run is the result of comparing 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb with baseline 1.13.0=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Commit Message =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bbAuthor: Sarah <41928668+sabbey37@users.noreply.github.comDate: Fri Nov 13 09:12:29 2020 -0500GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745) =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8710) PartitionedFunctionExecutionBenchmark failure
[ https://issues.apache.org/jira/browse/GEODE-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-8710: -- Description: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= This benchmark run is the result of comparing 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb with baseline 1.13.0 =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Commit Message =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb Author: Sarah <41928668+sabbey37@users.noreply.github.comDate: Fri Nov 13 09:12:29 2020 -0500 GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745) =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= [http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] [=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] was: =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=This benchmark run is the result of comparing 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb with baseline 1.13.0=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Commit Message =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bbAuthor: Sarah <41928668+sabbey37@users.noreply.github.comDate: Fri Nov 13 09:12:29 2020 -0500GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745) =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > PartitionedFunctionExecutionBenchmark failure > -- > > Key: GEODE-8710 > URL: https://issues.apache.org/jira/browse/GEODE-8710 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Priority: Major > > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > This benchmark run is the result of comparing > 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb with baseline 1.13.0 > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Commit Message > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb > Author: Sarah <41928668+sabbey37@users.noreply.github.comDate: Fri Nov 13 > 09:12:29 2020 -0500 > GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745) > > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > > [http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] > [=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8710) PartitionedFunctionExecutionBenchmark failure
[ https://issues.apache.org/jira/browse/GEODE-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231755#comment-17231755 ] Geode Integration commented on GEODE-8710: -- Seen in [Benchmark_with_security_manager #456|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/Benchmark_with_security_manager/builds/456]. > PartitionedFunctionExecutionBenchmark failure > -- > > Key: GEODE-8710 > URL: https://issues.apache.org/jira/browse/GEODE-8710 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Priority: Major > > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > This benchmark run is the result of comparing > 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb with baseline 1.13.0 > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Commit Message > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > commit 8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb > Author: Sarah <41928668+sabbey37@users.noreply.github.comDate: Fri Nov 13 > 09:12:29 2020 -0500 > GEODE-8704: many CI failures in Jetty9CachingClientServerTest (#5745) > > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Benchmark Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > > [http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] > [=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=|http://files.apachegeode-ci.info/benchmarks/apache-develop-main/8f8cc7b62be9e7d3a20f18e38fe2cff3228a55bb/benchmarks-apache-develop-main-Benchmark_with_security_manager-456-206679_with_security_manager.tgz=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231764#comment-17231764
]
ASF GitHub Bot commented on GEODE-8593:
---
mmartell merged pull request #689:
URL: https://github.com/apache/geode-native/pull/689
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231761#comment-17231761
]
ASF GitHub Bot commented on GEODE-8593:
---
mmartell commented on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-726973172
Looks good. Thanks for clarifying that this also address GEODE-8431.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231763#comment-17231763
]
ASF subversion and git services commented on GEODE-8593:
Commit 387b9525a31c1a9bb9d4a026eb95756e637272af in geode-native's branch
refs/heads/develop from Dave Barnes
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=387b952 ]
GEODE-8593: Update NC examples to use Builder pattern (.NET) (#689)
* GEODE-8593: Update NC examples to use Builder pattern (.NET)
* Modify locator port (40404 -> 10334) per reviewer's advice
* Clarify that declarative config is XML file-based
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231762#comment-17231762
]
ASF subversion and git services commented on GEODE-8593:
Commit 387b9525a31c1a9bb9d4a026eb95756e637272af in geode-native's branch
refs/heads/develop from Dave Barnes
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=387b952 ]
GEODE-8593: Update NC examples to use Builder pattern (.NET) (#689)
* GEODE-8593: Update NC examples to use Builder pattern (.NET)
* Modify locator port (40404 -> 10334) per reviewer's advice
* Clarify that declarative config is XML file-based
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231765#comment-17231765
]
ASF GitHub Bot commented on GEODE-8593:
---
mmartell edited a comment on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-726973172
Looks good. Thanks for clarifying that this also addresses GEODE-8431.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Barnes resolved GEODE-8593.
Fix Version/s: 1.14.0
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8431) Geode Native Client user guide: Update Connection Pools topic
[ https://issues.apache.org/jira/browse/GEODE-8431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dave Barnes resolved GEODE-8431. Fix Version/s: 1.14.0 Resolution: Fixed > Geode Native Client user guide: Update Connection Pools topic > - > > Key: GEODE-8431 > URL: https://issues.apache.org/jira/browse/GEODE-8431 > Project: Geode > Issue Type: Improvement > Components: docs, native client >Affects Versions: 1.14.0 >Reporter: Dave Barnes >Assignee: Dave Barnes >Priority: Major > Fix For: 1.14.0 > > > The "Using Connection Pools" topic needs updating, in both the .NET and C++ > versions of the user guide: > * Check for up-to-date explanations of connection pools, load balancing, and > configuring for high-availability > * Verify that examples reflect current names and syntax -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8711) Enable SLOWLOG command to support Redis monitoring tools
Raymond Ingles created GEODE-8711: - Summary: Enable SLOWLOG command to support Redis monitoring tools Key: GEODE-8711 URL: https://issues.apache.org/jira/browse/GEODE-8711 Project: Geode Issue Type: Improvement Components: redis Affects Versions: 1.14.0 Reporter: Raymond Ingles The Redis SLOWLOG command tracks slow-executing commands. This will implement a placeholder to prevent errors in tools like Datadog or Redis Insights. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8708) CI failure in build-geode-benchmarks-image
[
https://issues.apache.org/jira/browse/GEODE-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Houghton reassigned GEODE-8708:
--
Assignee: Robert Houghton
> CI failure in build-geode-benchmarks-image
> --
>
> Key: GEODE-8708
> URL: https://issues.apache.org/jira/browse/GEODE-8708
> Project: Geode
> Issue Type: Bug
> Components: ci
>Reporter: Kamilla Aslami
>Assignee: Robert Houghton
>Priority: Major
>
>
> Geode-benchmarks build fails with
>
> {noformat}
> Packer experienced an authentication error when trying to connect via SSH.
> This can happen if your username/password are wrong. You may want to
> double-check your credentials as part of your debugging process.{noformat}
>
> Full build-image log:
> {noformat}
> /tmp/build/2ebbeb81/geode-benchmarks-image/infrastructure/scripts/aws/image
> /tmp/build/2ebbeb81
> geode-benchmarks output will be in this color.==> geode-benchmarks:
> Prevalidating AMI Name: geode-benchmarks-1605228588
> geode-benchmarks: Found Image ID: ami-08f6a7b1c02ad4ece
> ==> geode-benchmarks: Creating temporary keypair:
> packer_5fadd82d-f9b2-0a6d-b69d-1f1298b31866
> ==> geode-benchmarks: Creating temporary security group for this instance:
> packer_5fadd82f-006b-570a-43dd-801c4d305269
> ==> geode-benchmarks: Authorizing access to port 22 from [0.0.0.0/0] in the
> temporary security groups...
> ==> geode-benchmarks: Launching a source AWS instance...
> ==> geode-benchmarks: Adding tags to source instance
> geode-benchmarks: Adding tag: "Name": "Packer Builder"
> geode-benchmarks: Instance ID: i-0590e362acd08ed74
> ==> geode-benchmarks: Waiting for instance (i-0590e362acd08ed74) to become
> ready...
> ==> geode-benchmarks: Using ssh communicator to connect: 18.236.218.182
> ==> geode-benchmarks: Waiting for SSH to become available...
> ==> geode-benchmarks: Error waiting for SSH: Packer experienced an
> authentication error when trying to connect via SSH. This can happen if your
> username/password are wrong. You may want to double-check your credentials as
> part of your debugging process. original error: ssh: handshake failed: ssh:
> unable to authenticate, attempted methods [publickey none], no supported
> methods remain
> ==> geode-benchmarks: Terminating the source AWS instance...
> ==> geode-benchmarks: Cleaning up any extra volumes...
> ==> geode-benchmarks: No volumes to clean up, skipping
> ==> geode-benchmarks: Deleting temporary security group...
> ==> geode-benchmarks: Deleting temporary keypair...
> Build 'geode-benchmarks' errored: Packer experienced an authentication error
> when trying to connect via SSH. This can happen if your username/password are
> wrong. You may want to double-check your credentials as part of your
> debugging process. original error: ssh: handshake failed: ssh: unable to
> authenticate, attempted methods [publickey none], no supported methods
> remain==> Some builds didn't complete successfully and had errors:
> --> geode-benchmarks: Packer experienced an authentication error when trying
> to connect via SSH. This can happen if your username/password are wrong. You
> may want to double-check your credentials as part of your debugging process.
> original error: ssh: handshake failed: ssh: unable to authenticate, attempted
> methods [publickey none], no supported methods remain==> Builds finished but
> no artifacts were created.{noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8712) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode
John Hutchison created GEODE-8712: - Summary: testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode Key: GEODE-8712 URL: https://issues.apache.org/jira/browse/GEODE-8712 Project: Geode Issue Type: Bug Reporter: John Hutchison -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-8706: -- Summary: testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI (was: Redis INFO command 'Keyspace' section should not be present if no keys in database) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: John Hutchison >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Hutchison updated GEODE-8706: -- Description: __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode FAILED org.apache.geode.test.dunit.RMIException: While invoking org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run in VM 4 running on Host 3e4042fb1cd7 with 8 VMs Caused by: org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase that uses java.util.Set, java.util.Setint Expected queue entries: 0 but actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. Caused by: java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 expected:<0> but was:<8000> java.lang.AssertionError: Suspicious strings were written to the log during this run. Fix the strings or use IgnoredException.addIgnoredException to ignore. -- Found suspect string in 'dunit_suspect-vm4.log' at line 68 [fatal 2020/11/13 18:09:30.989 GMT tid=619] Stopping the processor because the following exception occurred while processing a batch: java.lang.NullPointerException at org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) at org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) at org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: John Hutchison >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231803#comment-17231803 ] John Hutchison commented on GEODE-8706: --- =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-results/distributedTest/1605295952/ =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test report artifacts from this job are available at: http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-artifacts/1605295952/distributedtestfiles-OpenJDK8-1.14.0-build.0484.tgz > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: John Hutchison >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231806#comment-17231806 ] Geode Integration commented on GEODE-8706: -- Seen in [DistributedTestOpenJDK8 #621|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/621] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-results/distributedTest/1605295952/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0484/test-artifacts/1605295952/distributedtestfiles-OpenJDK8-1.14.0-build.0484.tgz]. > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement > Components: redis >Reporter: John Hutchison >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8713) Geode-Native .NET user guide: API reference links point to C++ API
Dave Barnes created GEODE-8713: -- Summary: Geode-Native .NET user guide: API reference links point to C++ API Key: GEODE-8713 URL: https://issues.apache.org/jira/browse/GEODE-8713 Project: Geode Issue Type: Bug Components: docs Affects Versions: 1.13.0 Reporter: Dave Barnes The "Client Cache XML Reference" section in the .NET user guide contains links to "API Class Reference" that all point to the C++ API ref. These should point to the .NET API ref. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey updated GEODE-8706: --- Component/s: (was: redis) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8672) Concurrent transactional destroy with GII could cause an entry to be removed and version information to be lost
[ https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231816#comment-17231816 ] ASF GitHub Bot commented on GEODE-8672: --- pivotal-eshu merged pull request #5746: URL: https://github.com/apache/geode/pull/5746 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Concurrent transactional destroy with GII could cause an entry to be removed > and version information to be lost > --- > > Key: GEODE-8672 > URL: https://issues.apache.org/jira/browse/GEODE-8672 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > > In a newly rebalanced bucket, while GII is in progress, a transactional > destroy is applied to cache. There is a logic that it should be in token mode > and leaves the entry as a Destroyed token, even though the version tag of the > entry indicates that it has the correct version. > However, at end of the GII, there is a > cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed > entries – this wipes off the entry version tag information and cause the > subsequent creates starts fresh with new version tags. > This could leads to client server data inconsistency as the newly created > entries will be ignored by the clients as the newly created entry has lower > version number while client has high ones. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8672) Concurrent transactional destroy with GII could cause an entry to be removed and version information to be lost
[ https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231818#comment-17231818 ] ASF subversion and git services commented on GEODE-8672: Commit 7a55cba21cbe1fd22668c014a8a96ff161a75820 in geode's branch refs/heads/develop from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7a55cba ] GEODE-8672: No need in token mode if concurrencyChecksEnabled (#5746) * The DESTROYED token is only needed to prevent concurrent destroy op is lost in GII. If concurrency checks are enabled, the version tag should be able to prevent the destroy op being lost. * Correctly set the inTokenMode to avoid a potential hang in replicate region as invokeTXCallbacks needs to wait for the region initialization finished, but region intialization could not due to lock held by threads invoking callbacks. > Concurrent transactional destroy with GII could cause an entry to be removed > and version information to be lost > --- > > Key: GEODE-8672 > URL: https://issues.apache.org/jira/browse/GEODE-8672 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > > In a newly rebalanced bucket, while GII is in progress, a transactional > destroy is applied to cache. There is a logic that it should be in token mode > and leaves the entry as a Destroyed token, even though the version tag of the > entry indicates that it has the correct version. > However, at end of the GII, there is a > cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed > entries – this wipes off the entry version tag information and cause the > subsequent creates starts fresh with new version tags. > This could leads to client server data inconsistency as the newly created > entries will be ignored by the clients as the newly created entry has lower > version number while client has high ones. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8672) Concurrent transactional destroy with GII could cause an entry to be removed and version information to be lost
[ https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231817#comment-17231817 ] ASF subversion and git services commented on GEODE-8672: Commit 7a55cba21cbe1fd22668c014a8a96ff161a75820 in geode's branch refs/heads/develop from Eric Shu [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7a55cba ] GEODE-8672: No need in token mode if concurrencyChecksEnabled (#5746) * The DESTROYED token is only needed to prevent concurrent destroy op is lost in GII. If concurrency checks are enabled, the version tag should be able to prevent the destroy op being lost. * Correctly set the inTokenMode to avoid a potential hang in replicate region as invokeTXCallbacks needs to wait for the region initialization finished, but region intialization could not due to lock held by threads invoking callbacks. > Concurrent transactional destroy with GII could cause an entry to be removed > and version information to be lost > --- > > Key: GEODE-8672 > URL: https://issues.apache.org/jira/browse/GEODE-8672 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > > In a newly rebalanced bucket, while GII is in progress, a transactional > destroy is applied to cache. There is a logic that it should be in token mode > and leaves the entry as a Destroyed token, even though the version tag of the > entry indicates that it has the correct version. > However, at end of the GII, there is a > cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed > entries – this wipes off the entry version tag information and cause the > subsequent creates starts fresh with new version tags. > This could leads to client server data inconsistency as the newly created > entries will be ignored by the clients as the newly created entry has lower > version number while client has high ones. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231853#comment-17231853 ] John Hutchison commented on GEODE-8706: --- possibly recurrence of https://issues.apache.org/jira/browse/GEODE-8485 > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8711) Enable SLOWLOG command to support Redis monitoring tools
[ https://issues.apache.org/jira/browse/GEODE-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8711: -- Labels: pull-request-available (was: ) > Enable SLOWLOG command to support Redis monitoring tools > > > Key: GEODE-8711 > URL: https://issues.apache.org/jira/browse/GEODE-8711 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Priority: Major > Labels: pull-request-available > > The Redis SLOWLOG command tracks slow-executing commands. This will implement > a placeholder to prevent errors in tools like Datadog or Redis Insights. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8711) Enable SLOWLOG command to support Redis monitoring tools
[ https://issues.apache.org/jira/browse/GEODE-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231854#comment-17231854 ] ASF GitHub Bot commented on GEODE-8711: --- ringles opened a new pull request #5749: URL: https://github.com/apache/geode/pull/5749 Enable SLOWLOG Redis command to help support Redis monitoring tools like Redis Insights and Datadog. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enable SLOWLOG command to support Redis monitoring tools > > > Key: GEODE-8711 > URL: https://issues.apache.org/jira/browse/GEODE-8711 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Priority: Major > > The Redis SLOWLOG command tracks slow-executing commands. This will implement > a placeholder to prevent errors in tools like Datadog or Redis Insights. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8521) Add P2P message reader threads to thread monitoring
[ https://issues.apache.org/jira/browse/GEODE-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231870#comment-17231870 ] ASF subversion and git services commented on GEODE-8521: Commit 9afa536d0cfa1938b9c5926908a72df1ab96913b in geode's branch refs/heads/GEODE-8521-CoreLoggingExecutors-tests from Kirk Lund [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9afa536 ] GEODE-8521: Cleanup CoreLoggingExecutors constructors > Add P2P message reader threads to thread monitoring > --- > > Key: GEODE-8521 > URL: https://issues.apache.org/jira/browse/GEODE-8521 > Project: Geode > Issue Type: Wish > Components: messaging >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Add P2P message reader threads to thread monitoring to help with identifying > stuck P2P message readers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8521) Add P2P message reader threads to thread monitoring
[ https://issues.apache.org/jira/browse/GEODE-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231871#comment-17231871 ] ASF subversion and git services commented on GEODE-8521: Commit 9afa536d0cfa1938b9c5926908a72df1ab96913b in geode's branch refs/heads/GEODE-8521-CoreLoggingExecutors-tests from Kirk Lund [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9afa536 ] GEODE-8521: Cleanup CoreLoggingExecutors constructors > Add P2P message reader threads to thread monitoring > --- > > Key: GEODE-8521 > URL: https://issues.apache.org/jira/browse/GEODE-8521 > Project: Geode > Issue Type: Wish > Components: messaging >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > Add P2P message reader threads to thread monitoring to help with identifying > stuck P2P message readers. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231875#comment-17231875
]
ASF GitHub Bot commented on GEODE-8670:
---
Bill commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523280748
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -97,16 +118,16 @@ public void constructs() {
assertThatCode(() -> {
internalLocator =
- new InternalLocator(port, loggingSession, logFile, logWriter,
securityLogWriter,
+ new InternalLocator(port, loggingSession, logFile, null, null,
Review comment:
My read of `InternalLocator` is that it's ok to provide `null` log
writers to the constructor ✓
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -69,6 +70,8 @@
@Before
public void setUp() throws IOException {
+// set a property to tell membership to create a new cluster
+System.setProperty(GMSJoinLeave.BYPASS_DISCOVERY_PROPERTY, "true");
Review comment:
I assume this is done to speed up the test. I like it!
But shouldn't we be restoring the system property after the test runs? I
believe we have a JUnit rule for that?
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/cache30/ReconnectDUnitTest.java
##
@@ -1115,6 +1118,9 @@ public String description() {
*/
@Test
public void testReconnectFailsDueToBadCacheXML() throws Exception {
+
IgnoredException.addIgnoredException(DistributedSystemDisconnectedException.class);
+IgnoredException.addIgnoredException("Cause parsing to fail");
+IgnoredException.addIgnoredException("Exception while initializing an
instance");
Review comment:
Now that the (broken) regexp is no longer hiding exceptions, and you've
explicitly added expectations for all of them, this test serves a good
documentation for these exceptions and their role in reconnect.
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -88,6 +91,24 @@ public void tearDown() {
}
}
+ @Test
+ public void startedLocatorDoesNotAttemptReconnect() throws IOException,
InterruptedException {
+// start a locator that's not part of a cluster
+final boolean joinCluster = false;
+internalLocator = InternalLocator.startLocator(port, logFile, null,
+null, bindAddress, joinCluster,
+distributedSystemProperties, hostnameForClients, workingDirectory);
+port = internalLocator.getPort();
+// the locator shouldn't attempt a reconnect because it's not part of a
cluster
+internalLocator.stoppedForReconnect = true;
+assertThat(internalLocator.attemptReconnect()).isFalse();
+String output = FileUtils.readFileToString(logFile,
Charset.defaultCharset());
+assertThat(output).isNotEmpty();
+assertThat(output).contains(InternalLocator.IGNORING_RECONNECT_REQUEST);
+ }
Review comment:
I guess we had the reconnect cases covered (in the DUnit test) and this
new test is for the no-reconnect case ✓
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullP
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231877#comment-17231877
]
ASF GitHub Bot commented on GEODE-8670:
---
Bill commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523284286
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##
@@ -69,6 +70,8 @@
@Before
public void setUp() throws IOException {
+// set a property to tell membership to create a new cluster
+System.setProperty(GMSJoinLeave.BYPASS_DISCOVERY_PROPERTY, "true");
Review comment:
I just noticed that @bschuchardt did add a `RestoreSystemProperties`
rule so this is all good now
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou reassigned GEODE-8706: Assignee: Xiaojian Zhou > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou updated GEODE-8706: - Labels: Operation (was: ) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: Operation > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou updated GEODE-8706: - Issue Type: Bug (was: Improvement) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: Operation > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou updated GEODE-8706: - Labels: (was: Operation) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaojian Zhou updated GEODE-8706: - Labels: GeodeOperationAPI (was: ) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231878#comment-17231878
]
ASF GitHub Bot commented on GEODE-8670:
---
bschuchardt merged pull request #5744:
URL: https://github.com/apache/geode/pull/5744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231879#comment-17231879
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231880#comment-17231880
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8697) Propagate ForcedDisconnectException to the user application in a network partition scenario
[
https://issues.apache.org/jira/browse/GEODE-8697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231883#comment-17231883
]
ASF GitHub Bot commented on GEODE-8697:
---
Bill commented on a change in pull request #5739:
URL: https://github.com/apache/geode/pull/5739#discussion_r523286184
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##
@@ -2283,7 +2288,7 @@ public Distribution getDistribution() {
* This is the listener implementation for responding from events from the
Membership Manager.
*
*/
- private class DMListener implements
+ static class DMListener implements
Review comment:
Good improvement making this inner class static ✓
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##
@@ -2209,6 +2209,11 @@ private void removeAllHealthMonitors() {
}
}
+ private List getMembershipTestHooks() {
+return membershipTestHooks;
+ }
Review comment:
`DMListener` needs an accessor now ok
##
File path:
geode-core/src/test/java/org/apache/geode/distributed/internal/ClusterDistributionManagerTest.java
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.distributed.internal;
+
+import static org.mockito.ArgumentMatchers.isA;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+
+import org.junit.Test;
+
+import org.apache.geode.ForcedDisconnectException;
+import
org.apache.geode.distributed.internal.membership.api.MemberDisconnectedException;
+
+public class ClusterDistributionManagerTest {
+
+ @Test
+ public void membershipFailureProcessingCreatesForcedDisconnectException() {
+ClusterDistributionManager manager =
mock(ClusterDistributionManager.class);
Review comment:
It's a little bit surprising that the `ClusterDistributionManager` test,
mocks the `ClusterDistributionManager` ;-) But I get it and it's ok. It's
really a test of the inner `DMListener` ✓
##
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java
##
@@ -2293,26 +2298,25 @@ public Distribution getDistribution() {
@Override
public void membershipFailure(String reason, Throwable t) {
- exceptionInThreads = true;
- rootCause = t;
- if (rootCause != null && !(rootCause instanceof
ForcedDisconnectException)) {
-logger.info("cluster membership failed due to ", rootCause);
-rootCause = new ForcedDisconnectException(rootCause.getMessage());
+ dm.exceptionInThreads = true;
+ Throwable cause = t;
+ if (cause != null && !(cause instanceof ForcedDisconnectException)) {
+logger.info("cluster membership failed due to ", cause);
+cause = new ForcedDisconnectException(cause.getMessage());
}
+ dm.setRootCause(cause);
try {
-if (membershipTestHooks != null) {
- List l = membershipTestHooks;
- for (final MembershipTestHook aL : l) {
-MembershipTestHook dml = aL;
-dml.beforeMembershipFailure(reason, rootCause);
+List testHooks = dm.getMembershipTestHooks();
Review comment:
ah now that this inner class is static we have to use an accessor to get
at the test hooks ✓
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Propagate ForcedDisconnectException to the user application in a network
> partition scenario
> ---
>
> Key: GEODE-8697
> URL: https://issues.apache.org/jira/browse/GEODE-8697
> Project: Geode
> Issue Type: Bug
> Components: membership
>
[jira] [Commented] (GEODE-8623) Timing between DNS and Geode startup can result in permanent unknown host exceptions.
[
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231887#comment-17231887
]
ASF GitHub Bot commented on GEODE-8623:
---
Bill commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r523289199
##
File path: geode-common/src/main/java/org/apache/geode/internal/Retry.java
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal;
+
+import static java.util.concurrent.TimeUnit.MILLISECONDS;
+import static java.util.concurrent.TimeUnit.NANOSECONDS;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+import java.util.function.Predicate;
+import java.util.function.Supplier;
+
+import org.apache.geode.annotations.VisibleForTesting;
+
+/**
+ * Utility class for retrying operations.
+ */
+public class Retry {
+
+ interface Clock {
+long nanoTime();
+
+void sleep(long sleepTime, TimeUnit sleepTimeUnit) throws
InterruptedException;
+ }
+
+ private static class SteadyClock implements Clock {
+@Override
+public long nanoTime() {
+ return System.nanoTime();
+}
+
+@Override
+public void sleep(long sleepTime, TimeUnit sleepTimeUnit) throws
InterruptedException {
Review comment:
We've been using two separate interfaces in other places in Geode where
we do this, and I'd recommend it here too. Lemme go find an example… Ah yes,
have a look at `PrimaryHandler` which has `Sleeper` and `MillisecondProvider`
interfaces. Hmm looks like `PrimaryHandler.processRequest()` might benefit from
this `Retry` class eventually!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timing between DNS and Geode startup can result in permanent unknown host
> exceptions.
> -
>
> Key: GEODE-8623
> URL: https://issues.apache.org/jira/browse/GEODE-8623
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0,
> 1.14.0, 1.13.1
>Reporter: Jacob Barrett
>Priority: Minor
> Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of
> Geode happen concurrently it is possible for Geode to fail name resolution in
> the local hostname caching. If it fails to resolve the local hostname when
> loading the caching utility class then any service dependent on this name
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC tid=0x1] Jmx manager could not be
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1239)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:219)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuild
[jira] [Commented] (GEODE-8623) Timing between DNS and Geode startup can result in permanent unknown host exceptions.
[
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231888#comment-17231888
]
ASF GitHub Bot commented on GEODE-8623:
---
Bill commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r523291215
##
File path:
geode-common/src/main/java/org/apache/geode/internal/inet/LocalHostUtil.java
##
@@ -54,19 +59,27 @@
private static final boolean useLinkLocalAddresses =
Boolean.getBoolean(USE_LINK_LOCAL_ADDRESSES_PROPERTY);
- /**
- * we cache localHost to avoid bug #40619, access-violation in native code
- */
- private static final InetAddress localHost;
-
/**
* all classes should use this variable to determine whether to use IPv4 or
IPv6 addresses
*/
@MakeNotStatic
private static boolean useIPv6Addresses =
!Boolean.getBoolean("java.net.preferIPv4Stack")
&& Boolean.getBoolean("java.net.preferIPv6Addresses");
- static {
+ /**
+ * Resolves local host. Will retry if resolution fails.
+ *
+ * @return local host if resolved otherwise null.
+ */
+ private static InetAddress tryToResolveLocalHost() {
+try {
+ return tryFor(60, SECONDS, 1, SECONDS, LocalHostUtil::resolveLocalHost,
Objects::nonNull);
Review comment:
so cool!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timing between DNS and Geode startup can result in permanent unknown host
> exceptions.
> -
>
> Key: GEODE-8623
> URL: https://issues.apache.org/jira/browse/GEODE-8623
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0,
> 1.14.0, 1.13.1
>Reporter: Jacob Barrett
>Priority: Minor
> Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of
> Geode happen concurrently it is possible for Geode to fail name resolution in
> the local hostname caching. If it fails to resolve the local hostname when
> loading the caching utility class then any service dependent on this name
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC tid=0x1] Jmx manager could not be
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1239)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:219)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:171)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> org.apache.geode.distributed.internal.DefaultServerLauncherCacheProvider.createCache(DefaultServerLauncherCacheProvider.java:52)
> at
> org.apache.geode.distributed.ServerLauncher.createCache(ServerLauncher.java:887)
> at
> org.apache.geode.distributed.ServerLauncher.start(ServerLauncher.java:803)
> at
> org.apache.geode.distributed.ServerLauncher.run(ServerLauncher.java:732)
> at
> org.apache.geode.distributed.ServerLauncher.main(ServerLauncher.java:251)
> Caused by: java.net.UnknownHostException
> at
> org.apache.geode.internal.net.SocketCreator.getLocalHost(SocketCreator.java:285)
> at
> org.apache.geode.management.internal.ManagementAgent.configureAndStart(ManagementAgent.java:310)
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:131)
> ... 14 more
> [error 2020/09/30 19:50:21.724 UTC tid=0x1]
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> Exception in thread
[jira] [Commented] (GEODE-8687) Durable client is continuously re-registering CQs on all servers when event de-serialization fails causing resource exhaustion on servers
[
https://issues.apache.org/jira/browse/GEODE-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231891#comment-17231891
]
ASF GitHub Bot commented on GEODE-8687:
---
Bill commented on pull request #5730:
URL: https://github.com/apache/geode/pull/5730#issuecomment-727092815
I don't know this area of the code yet. I'm going to see if I can find some
other reviewers @kohlmu-pivotal
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Durable client is continuously re-registering CQs on all servers when event
> de-serialization fails causing resource exhaustion on servers
> --
>
> Key: GEODE-8687
> URL: https://issues.apache.org/jira/browse/GEODE-8687
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Affects Versions: 1.13.0
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
> Attachments: deserialzationFault.log
>
>
> When ReflectionBasedAutoSerializer is wrongly/not set it results with
> serialization exception on client at the reception of the CQ events.
> Serialization exception isn't logged which is misleading, and is hard to find
> that actually ReflectionBasedAutoSerializer isn't set correctly. Only log
> that can be seen is that client/servers subscription connections are closed
> due to EOF. This is because client destroys subscriptions connections
> intentionally, but doesn't log reason (PdxSerializationException) that led to
> this. It would be good that serialization exceptions are logged as error or
> warn.
> Client destroys subscription connection and perform server fail-over whenever
> serialization issue occurs. Additionally when subscription connection for
> particular server fails multiple times then this server is put in deny list
> for 10 seconds (this is configurable with {{ping-interval}}). After 10s
> expire the server is removed from list and it is available for subscription
> connection which will be destroyed again due serialization issue. This will
> go indefinitely and approx. every 10s in this case the client subscribes to
> each servers at least once. Due to serialization issue events aren't sent to
> client and remain in subscription queues.
> Whenever connection fails due to serialization issue and client is not
> durable then subscription queue is closed and events are lost.
> The biggest problem arises when client is durable. This is because
> subscription queue remains on server for configurable period of time (e.g.
> 300s) waiting for client to reconnect. When client perform fail-over to
> another server it will create new subscription queue using initial image from
> old queue that is currently paused. This means that all events from old queue
> will be transferred to new subscription queue hosted by the current primary
> server. This will happen on all servers and all of them will have copy of the
> queue even subscription redundancy isn't configured. The problem here is that
> client will periodically (every 10s in this case) establish connection to
> each servers, so configured timeout (e.g. 300s) will never expire, but it
> will be renewed each time client is registered. This could cause a lots of
> problems since memory and disk usage (if overflow on queue is configured)
> will increase on all servers.
> You can find in attached logs for the problematic case with durable client :
> vm0 -> locator
> vm1, vm2 -> servers
> vm3 -> durable client with enabled subscription handling CQ
> events
> vm4 -> client generating traffic that should trigger registered
> CQ
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8685) Exporting data causes a ClassNotFoundException
[
https://issues.apache.org/jira/browse/GEODE-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231895#comment-17231895
]
ASF GitHub Bot commented on GEODE-8685:
---
kohlmu-pivotal commented on a change in pull request #5735:
URL: https://github.com/apache/geode/pull/5735#discussion_r523301719
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/EntrySnapshot.java
##
@@ -123,6 +123,20 @@ public Object getRawValue(boolean forceCopy) {
return v;
}
+ /**
+ * If the value is available as a CachedDeserializable instance then return
it.
+ * Otherwise behave as if getValue() was called.
+ */
+ public Object getValuePreferringCachedDeserializable() {
+checkEntryDestroyed();
+Object v = this.regionEntry.getValue(null);
Review comment:
Please rename variable to something more meaningful other than the
character `v`
##
File path:
geode-gfsh/src/integrationTest/java/org/apache/geode/management/internal/cli/commands/ExportDataIntegrationTest.java
##
@@ -53,10 +58,29 @@
@Rule
public TemporaryFolder tempDir = new TemporaryFolder();
- private Region region;
+ private Region region;
private Path snapshotFile;
private Path snapshotDir;
+ public static class StringWrapper implements DataSerializable {
+
+private String value;
+
+public StringWrapper(String v) {
+ value = v;
Review comment:
Please refrain from using single character names
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Exporting data causes a ClassNotFoundException
> --
>
> Key: GEODE-8685
> URL: https://issues.apache.org/jira/browse/GEODE-8685
> Project: Geode
> Issue Type: Task
> Components: regions
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0
>Reporter: Anthony Baker
>Assignee: Darrel Schneider
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> See
> [https://lists.apache.org/thread.html/rfa4fc47eb4cb4e75c39d7cb815416bebf2ec233d4db24e37728e922e%40%3Cuser.geode.apache.org%3E.]
>
> Report is that exporting data whose values are Classes defined in a deployed
> jar result in a ClassNotFound exception:
> {noformat}
> [error 2020/10/30 08:54:29.317 PDT tid=0x41]
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.SerializationException: A ClassNotFoundException was thrown
> while trying to deserialize cached value.
> java.io.IOException: org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.SerializationException: A ClassNotFoundException was thrown
> while trying to deserialize cached value.
> at
> org.apache.geode.internal.cache.snapshot.WindowedExporter.export(WindowedExporter.java:106)
> at
> org.apache.geode.internal.cache.snapshot.RegionSnapshotServiceImpl.exportOnMember(RegionSnapshotServiceImpl.java:361)
> at
> org.apache.geode.internal.cache.snapshot.RegionSnapshotServiceImpl.save(RegionSnapshotServiceImpl.java:161)
> at
> org.apache.geode.internal.cache.snapshot.RegionSnapshotServiceImpl.save(RegionSnapshotServiceImpl.java:146)
> at
> org.apache.geode.management.internal.cli.functions.ExportDataFunction.executeFunction(ExportDataFunction.java:62)
> at
> org.apache.geode.management.cli.CliFunction.execute(CliFunction.java:37)
> at
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:201)
> at
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
> at
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:441)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at
> org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:442)
> at
> org.apache.geode.distributed.internal.ClusterOperationExecutors.doFunctionExecutionThread(ClusterOperationExecutors.java:377)
> at
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
> at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.SerializationException: A ClassNotFoundException was thrown
>
[jira] [Commented] (GEODE-8623) Timing between DNS and Geode startup can result in permanent unknown host exceptions.
[
https://issues.apache.org/jira/browse/GEODE-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231898#comment-17231898
]
ASF GitHub Bot commented on GEODE-8623:
---
jinmeiliao commented on a change in pull request #5743:
URL: https://github.com/apache/geode/pull/5743#discussion_r523309085
##
File path: geode-common/src/main/java/org/apache/geode/internal/Retry.java
##
@@ -47,45 +47,44 @@ public void sleep(long sleepTime, TimeUnit sleepTimeUnit)
throws InterruptedExce
}
}
- private static final SteadyClock steadyClock = new SteadyClock();
+ private static final SteadyTimer steadyClock = new SteadyTimer();
/**
* Try the supplier function until the predicate is true or timeout occurs.
*
* @param timeout to retry for
+ * @param timeoutUnit the unit for timeout
* @param interval time between each try
- * @param timeUnit to retry for
+ * @param intervalUnit the unit for interval
* @param supplier to execute until predicate is true or times out
* @param predicate to test for retry
* @param type of return value
* @return value from supplier after it passes predicate or times out.
*/
- public static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ public static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate) throws TimeoutException, InterruptedException {
-return tryFor(timeout, interval, timeUnit, supplier, predicate,
steadyClock);
+return tryFor(timeout, timeoutUnit, interval, intervalUnit, supplier,
predicate, steadyClock);
}
@VisibleForTesting
- static T tryFor(long timeout,
- long interval,
- TimeUnit timeUnit,
+ static T tryFor(long timeout, TimeUnit timeoutUnit,
+ long interval, TimeUnit intervalUnit,
Supplier supplier,
Predicate predicate,
- Clock clock) throws TimeoutException, InterruptedException {
-long until = clock.nanoTime() + NANOSECONDS.convert(timeout, timeUnit);
+ Timer timer) throws TimeoutException, InterruptedException {
+long until = timer.nanoTime() + NANOSECONDS.convert(timeout, timeoutUnit);
T value;
do {
value = supplier.get();
if (predicate.test(value)) {
return value;
} else {
-clock.sleep(interval, timeUnit);
+timer.sleep(interval, intervalUnit);
Review comment:
I am not sure I follow here. if we sleep past the timeout then we won't
execute the predicate anymore, it would just end the while loop with
TimeoutException.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Timing between DNS and Geode startup can result in permanent unknown host
> exceptions.
> -
>
> Key: GEODE-8623
> URL: https://issues.apache.org/jira/browse/GEODE-8623
> Project: Geode
> Issue Type: Bug
>Affects Versions: 1.9.0, 1.9.1, 1.10.0, 1.9.2, 1.11.0, 1.12.0, 1.13.0,
> 1.14.0, 1.13.1
>Reporter: Jacob Barrett
>Priority: Minor
> Labels: pull-request-available
>
> In a managed environment were local host name DNS entries and the startup of
> Geode happen concurrently it is possible for Geode to fail name resolution in
> the local hostname caching. If it fails to resolve the local hostname when
> loading the caching utility class then any service dependent on this name
> will fail without chance for recovery.
> {code}
> [error 2020/09/30 19:50:21.644 UTC tid=0x1] Jmx manager could not be
> started because java.net.UnknownHostException
> org.apache.geode.management.ManagementException: java.net.UnknownHostException
> at
> org.apache.geode.management.internal.ManagementAgent.startAgent(ManagementAgent.java:133)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:432)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:181)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2063)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:606)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1239)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231908#comment-17231908 ] ASF GitHub Bot commented on GEODE-8706: --- gesterzhou opened a new pull request #5750: URL: https://github.com/apache/geode/pull/5750 …nection Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8706: -- Labels: GeodeOperationAPI pull-request-available (was: GeodeOperationAPI) > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231909#comment-17231909 ] ASF subversion and git services commented on GEODE-8706: Commit 903be88a43d058e379dbd8a77e9f254065ab8968 in geode's branch refs/heads/feature/GEODE-8706 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=903be88 ] GEODE-8706: getConnection should get readLock to sync with destroyConnection > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231940#comment-17231940
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/feature/GEODE-8706 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231941#comment-17231941 ] ASF subversion and git services commented on GEODE-8706: Commit a64ab2e2e0a37954d660074170f5f72e2f0680bc in geode's branch refs/heads/feature/GEODE-8706 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a64ab2e ] GEODE-8706: getConnection should get readLock to sync with destroyConnection > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231939#comment-17231939
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/feature/GEODE-8706 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231943#comment-17231943
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/feature/GEODE-8706 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8706) testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure in CI
[ https://issues.apache.org/jira/browse/GEODE-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231944#comment-17231944 ] ASF subversion and git services commented on GEODE-8706: Commit a64ab2e2e0a37954d660074170f5f72e2f0680bc in geode's branch refs/heads/feature/GEODE-8706 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=a64ab2e ] GEODE-8706: getConnection should get readLock to sync with destroyConnection > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode failure > in CI > --- > > Key: GEODE-8706 > URL: https://issues.apache.org/jira/browse/GEODE-8706 > Project: Geode > Issue Type: Bug >Reporter: John Hutchison >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > __org.apache.geode.internal.cache.wan.offheap.SerialWANPropagationOffHeapDUnitTest > > testReplicatedSerialPropagationWithRemoteReceiverRestartedOnOtherNode > FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialWANPropagationDUnitTest$$Lambda$181/1328086690.run > in VM 4 running on Host 3e4042fb1cd7 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition defined > as a lambda expression in org.apache.geode.internal.cache.wan.WANTestBase > that uses java.util.Set, java.util.Setint Expected queue entries: 0 but > actual entries: 8000 expected:<0> but was:<8000> within 5 minutes. > Caused by: > java.lang.AssertionError: Expected queue entries: 0 but actual entries: 8000 > expected:<0> but was:<8000> > java.lang.AssertionError: Suspicious strings were written to the log during > this run. > Fix the strings or use IgnoredException.addIgnoredException to ignore. > -- > Found suspect string in 'dunit_suspect-vm4.log' at line 68 > [fatal 2020/11/13 18:09:30.989 GMT for GatewaySender_ln> tid=619] Stopping the processor because the following > exception occurred while processing a batch: > java.lang.NullPointerException > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.getConnection(GatewaySenderEventRemoteDispatcher.java:299) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.readAcknowledgement(GatewaySenderEventRemoteDispatcher.java:107) > at > org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher$AckReaderThread.run(GatewaySenderEventRemoteDispatcher.java:605) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8670) ReconnectDUnitTest is hiding a NullPointerException
[
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231942#comment-17231942
]
ASF subversion and git services commented on GEODE-8670:
Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch
refs/heads/feature/GEODE-8706 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]
GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)
* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException
1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
added a test for this change
* fixing invalid test - had to move it to a new class to use SystemOutRule
the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest
* removed use of SystemOutRule, which wasn't working in Stress tests
> ReconnectDUnitTest is hiding a NullPointerException
> ---
>
> Key: GEODE-8670
> URL: https://issues.apache.org/jira/browse/GEODE-8670
> Project: Geode
> Issue Type: Test
> Components: membership, tests
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is
> incorrect. Specifically it looks like this:
> {noformat}
> IgnoredException.addIgnoredException("ForcedDisconnectException||Possible
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT
> tid=203] Uncaught exception in thread Thread[Location services restart
> thread,5,RMI Runtime]
> java.lang.NullPointerException
> at
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
> at
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which
> probably just requires an addition to the other ignored exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
