[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231752#comment-17231752
]
ASF GitHub Bot commented on GEODE-8593:
---------------------------------------
lgtm-com[bot] commented on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-726960924
This pull request **fixes 1 alert** when merging
915f5370bb84f11d380dbac7f119caacb6b10338 into
5c7d47d34c2b8a53874ec6f53e66c2290fd0427c - [view on
LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-61f1fee8d4d140a49391fa7664569a05b635c1ba)
**fixed alerts:**
* 1 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
> ----------------------------------------------------
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
> Affects Versions: 1.13.0
> Reporter: Dave Barnes
> Assignee: Dave Barnes
> Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
> .set("log-level", "debug")
> .set("ssl-enabled", "true")
> .set("ssl-truststore", clientTruststore.string())
> .create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
