[ 
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231877#comment-17231877
 ] 

ASF GitHub Bot commented on GEODE-8670:
---------------------------------------

Bill commented on a change in pull request #5744:
URL: https://github.com/apache/geode/pull/5744#discussion_r523284286



##########
File path: 
geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/InternalLocatorIntegrationTest.java
##########
@@ -69,6 +70,8 @@
 
   @Before
   public void setUp() throws IOException {
+    // set a property to tell membership to create a new cluster
+    System.setProperty(GMSJoinLeave.BYPASS_DISCOVERY_PROPERTY, "true");

Review comment:
       I just noticed that @bschuchardt did add a `RestoreSystemProperties` 
rule so this is all good now




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ReconnectDUnitTest is hiding a NullPointerException
> ---------------------------------------------------
>
>                 Key: GEODE-8670
>                 URL: https://issues.apache.org/jira/browse/GEODE-8670
>             Project: Geode
>          Issue Type: Test
>          Components: membership, tests
>    Affects Versions: 1.14.0
>            Reporter: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is 
> incorrect. Specifically it looks like this:
> {noformat}
>     IgnoredException.addIgnoredException("ForcedDisconnectException||Possible 
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a 
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during 
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT <Location services restart thread> 
> tid=203] Uncaught exception in thread Thread[Location services restart 
> thread,5,RMI Runtime]
> java.lang.NullPointerException
>       at 
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
>       at 
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
>       at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which 
> probably just requires an addition to the other ignored exceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to