[ 
https://issues.apache.org/jira/browse/GEODE-8670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231939#comment-17231939
 ] 

ASF subversion and git services commented on GEODE-8670:
--------------------------------------------------------

Commit 99e7a138064419c9a676411252e64077c2a1180f in geode's branch 
refs/heads/feature/GEODE-8706 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=99e7a13 ]

GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException (#5744)

* GEODE-8670: ReconnectDUnitTest is hiding a NullPointerException

1. Fixed all of the IgnorableException problems in ReconnectDUnitTest
2. Modified InternalLocator to avoid throwing a NullPointerException and
   added a test for this change

* fixing invalid test - had to move it to a new class to use SystemOutRule

the rule wasn't working for some reason when I added it to
InternalLocatorIntegrationTest

* removed use of SystemOutRule, which wasn't working in Stress tests

> ReconnectDUnitTest is hiding a NullPointerException
> ---------------------------------------------------
>
>                 Key: GEODE-8670
>                 URL: https://issues.apache.org/jira/browse/GEODE-8670
>             Project: Geode
>          Issue Type: Test
>          Components: membership, tests
>    Affects Versions: 1.14.0
>            Reporter: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>
> Since working on GEODE-8609, I found that the regex in ReconnectDUnitTest is 
> incorrect. Specifically it looks like this:
> {noformat}
>     IgnoredException.addIgnoredException("ForcedDisconnectException||Possible 
> loss of quorum");
> {noformat}
> When removing the double pipe ({{||}}) various test methods fail with a 
> {{NullPointerException}}. For example:
> {noformat}
> java.lang.AssertionError: Suspicious strings were written to the log during 
> this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> -----------------------------------------------------------------------
> Found suspect string in 'dunit_suspect-vm1.log' at line 692
> [fatal 2020/10/29 05:59:26.027 PDT <Location services restart thread> 
> tid=203] Uncaught exception in thread Thread[Location services restart 
> thread,5,RMI Runtime]
> java.lang.NullPointerException
>       at 
> org.apache.geode.distributed.internal.InternalLocator.attemptReconnect(InternalLocator.java:1108)
>       at 
> org.apache.geode.distributed.internal.InternalLocator.lambda$launchRestartThread$4(InternalLocator.java:1070)
>       at java.lang.Thread.run(Thread.java:748)
> {noformat}
> There is also an additional {{DistributedSystemDisconnectedException}} which 
> probably just requires an addition to the other ignored exceptions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to