[Bug 69316] New: FastHttpDateFormat#getCurrentDate(): returns inaccurate date string.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69316 Bug ID: 69316 Summary: FastHttpDateFormat#getCurrentDate(): returns inaccurate date string. Product: Tomcat 9 Version: 9.0.x Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Util Assignee: dev@tomcat.apache.org Reporter: ch...@msn.com Target Milestone: - Created attachment 39864 --> https://bz.apache.org/bugzilla/attachment.cgi?id=39864&action=edit Testcase FastHttpDateFormat#getCurrentDate() returns same string for two different second datetime. For following date: 1st:1726041009036, Wed, 11 Sep 2024 07:50:09 GMT 2nd:1726041009940, Wed, 11 Sep 2024 07:50:09 GMT 1st:1726041011501, Wed, 11 Sep 2024 07:50:11 GMT 2nd:1726041012101, Wed, 11 Sep 2024 07:50:11 GMT Due to incorrect result, client may receive different current date strings from different tomcat nodes in same time. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
Chenjp opened a new pull request, #751: URL: https://github.com/apache/tomcat/pull/751 FastHttpDateFormat#getCurrentDate() returns same string for two different second datetime. For following date: 1st:1726041009036, Wed, 11 Sep 2024 07:50:09 GMT 2nd:1726041009940, Wed, 11 Sep 2024 07:50:09 GMT 1st:1726041011501, Wed, 11 Sep 2024 07:50:11 GMT ***2nd:1726041012101, Wed, 11 Sep 2024 07:50:11 GMT*** --it is incorrect. Fix: check whether cached date and current date are in same second. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 69316] FastHttpDateFormat#getCurrentDate(): returns inaccurate date string.
https://bz.apache.org/bugzilla/show_bug.cgi?id=69316 Justin Chen changed: What|Removed |Added OS||All --- Comment #1 from Justin Chen --- github PR #751 submitted. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[ANN] Apache Tomcat 9.0.94 available
The Apache Tomcat team announces the immediate availability of Apache Tomcat 9.0.94. Apache Tomcat 9 is an open source software implementation of the Java Servlet, JavaServer Pages, Java Unified Expression Language, Java WebSocket and JASPIC technologies. Apache Tomcat 9.0.94 is a bugfix and feature release. The notable changes compared to 9.0.93 include: - If an HTTP/2 client resets a stream before the request body is fully written, ensure that any ReadListener is notified via a call to ReadListener.onErrror() - An Exception being thrown during WebSocket message processing (e.g. in a method annotated with @onMessage) should not automatically cause the connection to close. The application should handle the exception and make the decision whether or not to close the connection. Along with lots of other bug fixes and improvements. Please refer to the change log for the complete list of changes: https://tomcat.apache.org/tomcat-9.0-doc/changelog.html Downloads: https://tomcat.apache.org/download-90.cgi Migration guides from Apache Tomcat 7.x and 8.x: https://tomcat.apache.org/migration.html Enjoy! - The Apache Tomcat team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch 11.0.x updated: Next release expected to be 11.0.0
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 11.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/11.0.x by this push: new e26440e475 Next release expected to be 11.0.0 e26440e475 is described below commit e26440e475e69c9fd945bf7abecf8e1a809f2313 Author: Mark Thomas AuthorDate: Wed Sep 11 11:26:05 2024 +0100 Next release expected to be 11.0.0 --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 13b5f989ce..4254d0965e 100644 --- a/build.properties.default +++ b/build.properties.default @@ -33,7 +33,7 @@ version.major=11 version.minor=0 version.build=0 version.patch=0 -version.suffix=-M26 +version.suffix= version.dev=-dev # - Build tools - diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index ada9efaada..a0c47caf07 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=11.0.0-M26 +maven.asf.release.deploy.version=11.0.0 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 2eaccfb06c..d8141c5a26 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,7 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch main updated: Update baseline version for 12.0.0-M1
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 618a354227 Update baseline version for 12.0.0-M1 618a354227 is described below commit 618a354227e801a95be367496e5fa5cf1a9cf53f Author: Mark Thomas AuthorDate: Wed Sep 11 11:26:34 2024 +0100 Update baseline version for 12.0.0-M1 --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 788a5a2682..b30a554613 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -109,7 +109,7 @@ This release contains all of the changes up to and including those in -Apache Tomcat 11.0.0-M26 plus the additional changes listed below. (markt) +Apache Tomcat 11.0.0 plus the additional changes listed below. (markt) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] i18n zh translation improvement for 9.0.x [tomcat]
markt-asf closed pull request #748: i18n zh translation improvement for 9.0.x URL: https://github.com/apache/tomcat/pull/748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Resize elements array and update index in SynchronizedStack#setLimit when needed [tomcat]
markt-asf commented on PR #750: URL: https://github.com/apache/tomcat/pull/750#issuecomment-2343275006 This PR will not be applied. `SynchronizedStack` is deliberately designed not to support shrinking the stack because: - Tomcat doesn't need the capability to shrink the stack - shrinking the stack creates garbage and this class is intended to avoid unnecessary garbage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Resize elements array and update index in SynchronizedStack#setLimit when needed [tomcat]
markt-asf closed pull request #750: Resize elements array and update index in SynchronizedStack#setLimit when needed URL: https://github.com/apache/tomcat/pull/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
rmaucher commented on PR #751: URL: https://github.com/apache/tomcat/pull/751#issuecomment-2343329930 This looks to be more precise (so maybe ?) but the start of processing and/or actual completion of requests on two separate connections is a rather random affair timing wise. Anything can happen ... So what is then the benefit of the extra precision of the date header ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Buildbot success in on tomcat-11.0.x
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/1267 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 11.0.x] e26440e475e69c9fd945bf7abecf8e1a809f2313 Steps: worker_preparation: 0 git: 0 shell: 0 shell_1: 0 shell_2: 0 shell_3: 0 shell_4: 0 shell_5: 0 shell_6: 0 compile: 1 shell_7: 0 shell_8: 0 shell_9: 0 shell_10: 0 Rsync docs to nightlies.apache.org: 0 shell_11: 0 Rsync RAT to nightlies.apache.org: 0 compile_1: 1 shell_12: 0 Rsync Logs to nightlies.apache.org: 0 -- ASF Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
markt-asf commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754134779
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
There are faster ways of achieving the same results. This adds ~ 9% to
getCurrentDate(). Look as dividing now by 1000 instead.
##
test/org/apache/tomcat/util/http/TesterFastHttpDateFormat.java:
##
@@ -0,0 +1,48 @@
+package org.apache.tomcat.util.http;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TesterFastHttpDateFormat {
Review Comment:
This needs to be called `TestFastHttpDateFormat` so it gets included in
standard test runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 69318] New: Why assetdeals is the best real estate constuant company in gurugram
https://bz.apache.org/bugzilla/show_bug.cgi?id=69318 Bug ID: 69318 Summary: Why assetdeals is the best real estate constuant company in gurugram Product: Tomcat Native Version: unspecified Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: navjot.assetde...@gmail.com Target Milestone: --- There are many compelling reasons why AssetDeals stands out as the best real estate consultant in Gurugram. Having extensive market knowledge and years of experience, they possess a comprehensive understanding of Gurugram's real estate market, which allows them to provide clients with informed and strategic advice. They provide a wide range of real estate services, including residential and commercial property sales, rentals, investment advisory, property management, and legal consultations. In order to foster a loyal customer base, AssetDeals' personalized approach ensures that clients receive tailored services based on their unique preferences, budget, and objectives. They offer clients exclusive deals and early access to new projects as a result of their strong network and partnerships with leading developers and financial institutions. As an experienced and professional team, AssetDeals is committed to providing exceptional service, maintaining transparency, and upholding ethical practices that lead to the establishment of trust and credibility. By utilizing advanced technology, they provide seamless and efficient experiences through virtual tours and online transaction management. As a result of comprehensive market research and analysis, clients are able to make informed decisions. As a trusted and reliable real estate consultant in Gurugram, AssetDeals offers exceptional customer service and has a proven track record of successful transactions. By choosing AssetDeals, you are partnering with a company committed to delivering exceptional results in real estate. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 69318] Why assetdeals is the best real estate constuant company in gurugram
https://bz.apache.org/bugzilla/show_bug.cgi?id=69318 Assetdeals changed: What|Removed |Added URL||https://www.assetdeals.in/ OS||All -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Rough idea: add "current" variables currentDateGeneratedLower and
currentDateGeneratedSecsUpper
Only set them when we generate a new currentDate, and then use:
currentDateGeneratedLower = currentDateGenerated - currentDateGenerated %
1000
currentDateGeneratedUpper = currentDateGeneratedLower + 1000
Finally change the new comparison expression to
if (now < currentDateGeneratedLower || now >= currentDateGeneratedUpper)
which involved only two comparisons in the hot path.
Untested, but I could try and provide a formal patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Rough idea: add "current" variables currentDateGeneratedLower and
currentDateGeneratedUpper
Only set them when we generate a new currentDate, and then use:
currentDateGeneratedLower = currentDateGenerated - currentDateGenerated %
1000
currentDateGeneratedUpper = currentDateGeneratedLower + 1000
Finally change the new comparison expression to
if (now < currentDateGeneratedLower || now >= currentDateGeneratedUpper)
which involved only two comparisons in the hot path.
Untested, but I could try and provide a formal patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
rainerjung commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1754287909
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Rough idea: add "current" variables currentDateGeneratedLower and
currentDateGeneratedUpper
Only set them when we generate a new currentDate, and then use:
```
currentDateGeneratedLower = currentDateGenerated - currentDateGenerated %
1000
currentDateGeneratedUpper = currentDateGeneratedLower + 1000
```
Finally change the new comparison expression to
`if (now < currentDateGeneratedLower || now >= currentDateGeneratedUpper)`
which involved only two comparisons in the hot path.
Untested, but I could try and provide a formal patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r71463 - /release/tomcat/tomcat-10/v10.1.28/
Author: schultz Date: Wed Sep 11 12:25:31 2024 New Revision: 71463 Log: Drop old release artifacts. Removed: release/tomcat/tomcat-10/v10.1.28/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch 9.0.x updated: Add date
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3540b40d45 Add date 3540b40d45 is described below commit 3540b40d45ad6107b426418f0aefaa964ffd1302 Author: remm AuthorDate: Wed Sep 11 14:30:44 2024 +0200 Add date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index 8529b088d0..95037934aa 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -106,7 +106,7 @@ --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1920561 - in /tomcat/site/trunk: ./ docs/ docs/tomcat-10.1-doc/ docs/tomcat-10.1-doc/annotationapi/ docs/tomcat-10.1-doc/annotationapi/jakarta/annotation/ docs/tomcat-10.1-doc/annotationa
Author: schultz Date: Wed Sep 11 12:32:05 2024 New Revision: 1920561 URL: http://svn.apache.org/viewvc?rev=1920561&view=rev Log: Announce the release of v10.1.29. [This commit notification would consist of 64 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Architecture UML diagrams - startup
On Tue, Sep 10, 2024 at 6:15 PM Mark Thomas wrote: > > All, > > I have finished the first pass at updating the startup architecture > diagrams. > > The previous (5.5.x based) PDF can be found at > > https://github.com/apache/tomcat/blob/main/webapps/docs/architecture/startup/serverStartup.pdf > > along with a text description at > > https://github.com/apache/tomcat/blob/main/webapps/docs/architecture/startup/serverStartup.txt > > The new UML diagrams are numbers 1 to 7 and can be found in: > > https://github.com/apache/tomcat/tree/main/webapps/docs/architecture/startup > > alongside the PlantUML source. Well, the end result is excellent given the relative simplicity of the input. Great tool and great work. Rémy > The focus isn't exactly the same. I haven't covered the Digester and how > it uses RuleSets but there is more detail on component start and > configuration. > > Before I start on the request processing diagrams, I'd welcome feedback > on the work so far. > > Mark > > PS Another hat tip to Felix as I am finding PlantUML more and more > impressive as I use it. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat-training) 01/01: Merge pull request #33 from apache/dependabot/npm_and_yarn/postcss-8.4.31
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-training.git commit 32d8153a085d6cc1fa5ffeccc84c4976ee2d38ba Merge: f643d5b 48dd3b9 Author: Mark Thomas AuthorDate: Wed Sep 11 13:54:31 2024 +0100 Merge pull request #33 from apache/dependabot/npm_and_yarn/postcss-8.4.31 Bump postcss from 8.4.7 to 8.4.31 package-lock.json | 52 ++-- 1 file changed, 34 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat-training) branch main updated (f643d5b -> 32d8153)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-training.git from f643d5b First draft of Jakarta EE 11 / Tomcat 11 preview add 48dd3b9 Bump postcss from 8.4.7 to 8.4.31 new 32d8153 Merge pull request #33 from apache/dependabot/npm_and_yarn/postcss-8.4.31 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: package-lock.json | 52 ++-- 1 file changed, 34 insertions(+), 18 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat-training) branch dependabot/npm_and_yarn/postcss-8.4.31 deleted (was 48dd3b9)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch dependabot/npm_and_yarn/postcss-8.4.31 in repository https://gitbox.apache.org/repos/asf/tomcat-training.git was 48dd3b9 Bump postcss from 8.4.7 to 8.4.31 The revisions that were on this branch are still contained in other references; therefore, this change does not discard any commits from the repository. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Bump postcss from 8.4.7 to 8.4.31 [tomcat-training]
markt-asf merged PR #33: URL: https://github.com/apache/tomcat-training/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat-tck) branch main updated: EL TCK 6.0.1 has been published
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-tck.git
The following commit(s) were added to refs/heads/main by this push:
new b178c45 EL TCK 6.0.1 has been published
b178c45 is described below
commit b178c45f05f0b0874cd2241de0d9d601896d793d
Author: Mark Thomas
AuthorDate: Wed Sep 11 14:47:58 2024 +0100
EL TCK 6.0.1 has been published
---
download/pom.xml | 5 -
1 file changed, 5 deletions(-)
diff --git a/download/pom.xml b/download/pom.xml
index bedc40b..af7f501 100644
--- a/download/pom.xml
+++ b/download/pom.xml
@@ -55,12 +55,7 @@
wget
-
-
-
-
https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee11/staged/eftl/jakarta-expression-language-tck-6.0.1.zip
true
${project.build.directory}
8ca4339e1b93c8f490c38b5888d8a54d09f7d12257b222bff2d44d665f323cee
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat-tck) branch main updated: Update Tomcat SNAPSHOT version to test
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-tck.git The following commit(s) were added to refs/heads/main by this push: new cf12e16 Update Tomcat SNAPSHOT version to test cf12e16 is described below commit cf12e1675abd371f46054119bc977b78dbd12b3d Author: Mark Thomas AuthorDate: Wed Sep 11 14:50:30 2024 +0100 Update Tomcat SNAPSHOT version to test --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f86724e..0de7e57 100644 --- a/pom.xml +++ b/pom.xml @@ -31,7 +31,7 @@ 17 -11.0.0-M25-SNAPSHOT +11.0.0-SNAPSHOT 4 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1755922817
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
to minimize costs , ignore ms part to avoid divide ops:
```java
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Ignore millisecond part.
now -= now % 1000L;
// Handle case where time moves backwards (e.g. system time
corrected)
if (now != currentDateGenerated) {
currentDate = FORMAT_RFC5322.format(new Date(now));
currentDateGenerated = now;
}
return currentDate;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] Resize elements array and update index in SynchronizedStack#setLimit when needed [tomcat]
Chenjp commented on PR #750:
URL: https://github.com/apache/tomcat/pull/750#issuecomment-2345073418
> This PR will not be applied.
>
> `SynchronizedStack` is deliberately designed not to support shrinking the
stack because:
>
> * Tomcat doesn't need the capability to shrink the stack
>
> * shrinking the stack creates garbage and this class is intended to
avoid unnecessary garbage
Then method #setLimit should not be public:
```java
public class Http2Protocol implements UpgradeProtocol {
@Override
public void setHttp11Protocol(AbstractHttp11Protocol http11Protocol) {
this.http11Protocol = http11Protocol;
recycledRequestsAndResponses.setLimit(http11Protocol.getMaxConnections());
```
@markt-asf What would happen if we reconfigure a stack(with 200 elements)
limitation from -1 to 100?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756091747
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Modulus is also a slow operation. If there is a chance of this slowing
every request by 1ms as @markt-asf suggested then I'm a `-1` on this. A `1ms`
slowdown means 1,000 less requests-per-second in throughput.
Any unnecessary change should be benchmarked to evaluate the overhead that
it adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756091747
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
Modulus is also a slow operation. If there is a chance of this slowing
every request by 1ms as @markt-asf suggested then I'm a `-1` on this. A `1ms`
slowdown could mean up to 1,000 less requests-per-second in throughput.
Any unnecessary change should be benchmarked to evaluate the overhead that
it adds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756100613
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
@isapir On my laptop pc, new implementation elapse ***3.32 nanoseconds / per
call*** (single thread), comparing to original implementation's ***3.36 ns /
per call***, even performance improved.
Please try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
isapir commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756107715
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
@Chenjp If it's a few nanoseconds then that's fine by me. How did you
measure that? Using JMH?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PR] fix bz #69316 FastHttpDateFormat - getCurrentDate() returns inaccurate result [tomcat]
Chenjp commented on code in PR #751:
URL: https://github.com/apache/tomcat/pull/751#discussion_r1756122503
##
java/org/apache/tomcat/util/http/FastHttpDateFormat.java:
##
@@ -105,7 +105,7 @@ public final class FastHttpDateFormat {
public static String getCurrentDate() {
long now = System.currentTimeMillis();
// Handle case where time moves backwards (e.g. system time corrected)
-if (Math.abs(now - currentDateGenerated) > 1000) {
+if (now - now%1000L != currentDateGenerated -
currentDateGenerated%1000L) {
Review Comment:
TesterFastHttpDateFormatPerformance, change threadCount to 1.
result: Duration: 331058600 (***total callCount = 1***)
per call: 331058600 ns/ 1 (callCount) = ***3.31 ns***;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
