svn commit: r698458 - in /tomcat/connectors/trunk/jk/native/common: jk_lb_worker.c jk_uri_worker_map.c portable.h
Author: mturk
Date: Wed Sep 24 01:17:16 2008
New Revision: 698458
URL: http://svn.apache.org/viewvc?rev=698458&view=rev
Log:
Tab police
Modified:
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c
tomcat/connectors/trunk/jk/native/common/portable.h
Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=698458&r1=698457&r2=698458&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Wed Sep 24 01:17:16
2008
@@ -1651,10 +1651,10 @@
if (!p->states) {
free(p);
jk_log(l, JK_LOG_ERROR,
- "Failed allocating private worker state memory");
- JK_TRACE_EXIT(l);
- return JK_FALSE;
- }
+ "Failed allocating private worker state memory");
+JK_TRACE_EXIT(l);
+return JK_FALSE;
+}
*pend = &p->endpoint;
JK_TRACE_EXIT(l);
return JK_TRUE;
Modified: tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c?rev=698458&r1=698457&r2=698458&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_uri_worker_map.c Wed Sep 24
01:17:16 2008
@@ -44,6 +44,7 @@
#define JK_UWMAP_EXTENSION_DISABLED "disabled="
#define JK_UWMAP_EXTENSION_STOPPED"stopped="
#define JK_UWMAP_EXTENSION_FAIL_ON_STATUS "fail_on_status="
+#define JK_UWMAP_EXTENSION_USE_SRV_ERRORS "use_server_errors="
#define IND_THIS(x)((x)[uw_map->index])
#define IND_NEXT(x)((x)[(uw_map->index+1) % 2])
@@ -583,6 +584,7 @@
uwr->extensions.fail_on_status_size = 0;
uwr->extensions.fail_on_status = NULL;
uwr->extensions.fail_on_status_str = NULL;
+uwr->extensions.use_server_error_pages = 0;
#ifdef _MT_CODE_PTHREAD
param = strtok_r(w, ";", &lasts);
@@ -598,6 +600,9 @@
if (!strncmp(param, JK_UWMAP_EXTENSION_REPLY_TIMEOUT,
strlen(JK_UWMAP_EXTENSION_REPLY_TIMEOUT))) {
uwr->extensions.reply_timeout = atoi(param +
strlen(JK_UWMAP_EXTENSION_REPLY_TIMEOUT));
}
+else if (!strncmp(param, JK_UWMAP_EXTENSION_USE_SRV_ERRORS,
strlen(JK_UWMAP_EXTENSION_USE_SRV_ERRORS))) {
+uwr->extensions.use_server_error_pages = atoi(param +
strlen(JK_UWMAP_EXTENSION_USE_SRV_ERRORS));
+}
else if (!strncmp(param, JK_UWMAP_EXTENSION_ACTIVE,
strlen(JK_UWMAP_EXTENSION_ACTIVE))) {
if (uwr->extensions.active)
jk_log(l, JK_LOG_WARNING,
Modified: tomcat/connectors/trunk/jk/native/common/portable.h
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/portable.h?rev=698458&r1=698457&r2=698458&view=diff
==
--- tomcat/connectors/trunk/jk/native/common/portable.h (original)
+++ tomcat/connectors/trunk/jk/native/common/portable.h Wed Sep 24 01:17:16 2008
@@ -1,18 +1,98 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-/* On most platform this file is overwritten when doing configure */
-/* DON'T COMMIT THE FILE IT BREAKS windoze and Netware, commit the sample file
*/
+/* common/portable.h. Generated by configure. */
+/* common/portable.h.in. Generated from configure.in by autoheader. */
+
+/* Define to 1 if you have the header file. */
+#define HAVE_DLFCN_H 1
+
+/* Have flock() */
+#define HAVE_FLOCK 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_INTTYPES_H 1
+
+/* Define to 1 if you have the header file. */
+#define HAVE_MEMORY_H 1
+
+/* Have snprintf() */
+#define HAVE_SNPRINTF 1
+
+/* Define to 1 if
svn commit: r698459 - /tomcat/connectors/trunk/jk/native/common/portable.h
Author: mturk Date: Wed Sep 24 01:19:56 2008 New Revision: 698459 URL: http://svn.apache.org/viewvc?rev=698459&view=rev Log: Ups, wrong file commited Modified: tomcat/connectors/trunk/jk/native/common/portable.h Modified: tomcat/connectors/trunk/jk/native/common/portable.h URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/portable.h?rev=698459&r1=698458&r2=698459&view=diff == --- tomcat/connectors/trunk/jk/native/common/portable.h (original) +++ tomcat/connectors/trunk/jk/native/common/portable.h Wed Sep 24 01:19:56 2008 @@ -1,98 +1,18 @@ -/* common/portable.h. Generated by configure. */ -/* common/portable.h.in. Generated from configure.in by autoheader. */ - -/* Define to 1 if you have the header file. */ -#define HAVE_DLFCN_H 1 - -/* Have flock() */ -#define HAVE_FLOCK 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_INTTYPES_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_MEMORY_H 1 - -/* Have snprintf() */ -#define HAVE_SNPRINTF 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STDINT_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STDLIB_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STRINGS_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_STRING_H 1 - -/* Define to 1 if you have the header file. */ -/* #undef HAVE_SYS_FILIO_H */ - -/* Define to 1 if you have the header file. */ -#define HAVE_SYS_STAT_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_SYS_TYPES_H 1 - -/* Define to 1 if you have the header file. */ -#define HAVE_UNISTD_H 1 - -/* Have vsnprintf() */ -#define HAVE_VSNPRINTF 1 - -/* Name of package */ -#define PACKAGE "mod_jk" - -/* Define to the address where bug reports for this package should be sent. */ -#define PACKAGE_BUGREPORT "" - -/* Define to the full name of this package. */ -#define PACKAGE_NAME "" - -/* Define to the full name and version of this package. */ -#define PACKAGE_STRING "" - -/* Define to the one symbol short name of this package. */ -#define PACKAGE_TARNAME "" - -/* Define to the version of this package. */ -#define PACKAGE_VERSION "" - -/* The size of a `char', as computed by sizeof. */ -#define SIZEOF_CHAR 1 - -/* The size of a `int', as computed by sizeof. */ -#define SIZEOF_INT 4 - -/* The size of a `long', as computed by sizeof. */ -#define SIZEOF_LONG 4 - -/* The size of a `longlong', as computed by sizeof. */ -#define SIZEOF_LONGLONG 0 - -/* The size of a `long double', as computed by sizeof. */ -#define SIZEOF_LONG_DOUBLE 12 - -/* The size of a `long long', as computed by sizeof. */ -#define SIZEOF_LONG_LONG 8 - -/* The size of pid_t */ -#define SIZEOF_PID_T 4 - -/* The size of a `short', as computed by sizeof. */ -#define SIZEOF_SHORT 2 - -/* Define to 1 if you have the ANSI C header files. */ -#define STDC_HEADERS 1 - -/* Define to use SO_RCVTIMEO with setsockopt() */ -#define USE_SO_RCVTIMEO 1 - -/* Define to use SO_SNDTIMEO with setsockopt() */ -#define USE_SO_SNDTIMEO 1 - -/* Version number of package */ -#define VERSION "1.2.27" +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +/* On most platform this file is overwritten when doing configure */ +/* DON'T COMMIT THE FILE IT BREAKS windoze and Netware, commit the sample file */ - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698466 - in /tomcat/connectors/trunk/jk/native: configure.in scripts/build/jk_common.m4
Author: mturk
Date: Wed Sep 24 01:35:33 2008
New Revision: 698466
URL: http://svn.apache.org/viewvc?rev=698466&view=rev
Log:
Add config.nice generation. Mostly copy/paste from APR
Modified:
tomcat/connectors/trunk/jk/native/configure.in
tomcat/connectors/trunk/jk/native/scripts/build/jk_common.m4
Modified: tomcat/connectors/trunk/jk/native/configure.in
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/configure.in?rev=698466&r1=698465&r2=698466&view=diff
==
--- tomcat/connectors/trunk/jk/native/configure.in (original)
+++ tomcat/connectors/trunk/jk/native/configure.in Wed Sep 24 01:35:33 2008
@@ -35,6 +35,10 @@
dnl
sinclude(scripts/build/jk_common.m4)
+dnl Generate ./config.nice for reproducing runs of configure
+dnl
+JK_CONFIG_NICE(config.nice)
+
AC_PATH_PROG(TEST,test,$PATH)dnl
AC_SUBST(TEST)
Modified: tomcat/connectors/trunk/jk/native/scripts/build/jk_common.m4
URL:
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/scripts/build/jk_common.m4?rev=698466&r1=698465&r2=698466&view=diff
==
--- tomcat/connectors/trunk/jk/native/scripts/build/jk_common.m4 (original)
+++ tomcat/connectors/trunk/jk/native/scripts/build/jk_common.m4 Wed Sep 24
01:35:33 2008
@@ -75,3 +75,86 @@
$1=$jk_new_val
fi
]) dnl
+
+dnl Iteratively interpolate the contents of the second argument
+dnl until interpolation offers no new result. Then assign the
+dnl final result to $1.
+dnl
+dnl Example:
+dnl
+dnl foo=1
+dnl bar='${foo}/2'
+dnl baz='${bar}/3'
+dnl JK_EXPAND_VAR(fraz, $baz)
+dnl $fraz is now "1/2/3"
+dnl
+AC_DEFUN([JK_EXPAND_VAR], [
+jk_last=
+jk_cur="$2"
+while test "x${jk_cur}" != "x${jk_last}";
+do
+ jk_last="${jk_cur}"
+ jk_cur=`eval "echo ${jk_cur}"`
+done
+$1="${jk_cur}"
+])
+
+dnl
+dnl JK_CONFIG_NICE(filename)
+dnl
+dnl Saves a snapshot of the configure command-line for later reuse
+dnl
+AC_DEFUN([JK_CONFIG_NICE], [
+ rm -f $1
+ cat >$1<> $1
+ fi
+ if test -n "$CFLAGS"; then
+echo "CFLAGS=\"$CFLAGS\"; export CFLAGS" >> $1
+ fi
+ if test -n "$CPPFLAGS"; then
+echo "CPPFLAGS=\"$CPPFLAGS\"; export CPPFLAGS" >> $1
+ fi
+ if test -n "$LDFLAGS"; then
+echo "LDFLAGS=\"$LDFLAGS\"; export LDFLAGS" >> $1
+ fi
+ if test -n "$LTFLAGS"; then
+echo "LTFLAGS=\"$LTFLAGS\"; export LTFLAGS" >> $1
+ fi
+ if test -n "$LIBS"; then
+echo "LIBS=\"$LIBS\"; export LIBS" >> $1
+ fi
+ if test -n "$INCLUDES"; then
+echo "INCLUDES=\"$INCLUDES\"; export INCLUDES" >> $1
+ fi
+ if test -n "$NOTEST_CFLAGS"; then
+echo "NOTEST_CFLAGS=\"$NOTEST_CFLAGS\"; export NOTEST_CFLAGS" >> $1
+ fi
+ if test -n "$NOTEST_CPPFLAGS"; then
+echo "NOTEST_CPPFLAGS=\"$NOTEST_CPPFLAGS\"; export NOTEST_CPPFLAGS" >> $1
+ fi
+ if test -n "$NOTEST_LDFLAGS"; then
+echo "NOTEST_LDFLAGS=\"$NOTEST_LDFLAGS\"; export NOTEST_LDFLAGS" >> $1
+ fi
+ if test -n "$NOTEST_LIBS"; then
+echo "NOTEST_LIBS=\"$NOTEST_LIBS\"; export NOTEST_LIBS" >> $1
+ fi
+
+ # Retrieve command-line arguments.
+ eval "set x $[0] $ac_configure_args"
+ shift
+
+ for arg
+ do
+JK_EXPAND_VAR(arg, $arg)
+echo "\"[$]arg\" \\" >> $1
+ done
+ echo '"[$]@"' >> $1
+ chmod +x $1
+])dnl
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45870] javax.crypto.IllegalBlockSizeException for update from 5.5.17 to 5.5.27
https://issues.apache.org/bugzilla/show_bug.cgi?id=45870 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 02:18:54 PST --- 5.5.27 is stricter when parsing cookie values. It looks like you have an illegal cookie value. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45869] DefaultAnnotationProcessor does not scan class hierarchy for @PostConstruct and @PreDestroy annotations
https://issues.apache.org/bugzilla/show_bug.cgi?id=45869 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 05:18:40 PST --- *** This bug has been marked as a duplicate of bug 45285 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45285] RESOURCES DECLARED IN PARENT CLASSES ARE NOT INJECTED
https://issues.apache.org/bugzilla/show_bug.cgi?id=45285 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 05:18:40 PST --- *** Bug 45869 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45872] New: warning message for fail_on_status extension is incorrect
https://issues.apache.org/bugzilla/show_bug.cgi?id=45872 Summary: warning message for fail_on_status extension is incorrect Product: Tomcat 5 Version: Nightly Build Platform: PC OS/Version: Linux Status: NEW Severity: minor Priority: P2 Component: Native:JK AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Hi. In jk_uri_worker_map.c, warning message for fail_on_status extension is incorrect. = if (uwr->extensions.fail_on_status_str) jk_log(l, JK_LOG_WARNING, "extension '%s' in uri worker map only allowed once", - JK_UWMAP_EXTENSION_ACTIVE); + JK_UWMAP_EXTENSION_FAIL_ON_STATUS); === regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Possibility of Making JSESSIONID Configurable
I have the need to change the name of the session cookie to something other than JSESSIONID. With some other containers like Weblogic it can be adjusted via the provider descriptor (weblogic.xml) [http://e-docs.bea.com/wls/docs100/webapp/weblogic_xml.html#wp1071982]. Tomcat makes use of a global field value. I was wondering what the possibility of making the session cookie name, and the related stuff like the URL parameter configurable at run time. I don't think this would impact mod_jk because I believe that is configurable via a directive. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Dan Bush wrote: > I have the need to change the name of the session cookie to something > other than JSESSIONID. With some other containers like Weblogic it can > be adjusted via the provider descriptor (weblogic.xml) > [http://e-docs.bea.com/wls/docs100/webapp/weblogic_xml.html#wp1071982]. > Tomcat makes use of a global field value. I was wondering what the > possibility of making the session cookie name, and the related stuff > like the URL parameter configurable at run time. I don't think this > would impact mod_jk because I believe that is configurable via a > directive. Should be quite simple. It could be made configurable per context by setting it within the session manager. Everywhere it is used, the context is easily accessible. (I haven't checked the url side but I expect it t be similar). The 3.0 servlet spec mentions this (ie Tomcat 7) but there is nothing to stop this being added to 6.0.x Enhancement requests should be entered in bugzilla. Enhancement requests with patches tend to get looked at faster ;) If you want to take a crack at this yourself, you could use this to give you an idea of how to add the configuration. http://svn.apache.org/viewvc?view=rev&revision=694992 Shout if you have any questions / need more pointers. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Dan Bush wrote: I don't think this would impact mod_jk because I believe that is configurable via a directive. Not jet. However the next version we are going to release (1.2.27) will have that feature. Think your question was raised few times, but the answer was always -1, cause per servlet spec the session affinity marks are uniquely defined. I personally don't see any problem in making that configurable with default value as servlet spec defines. It's a trivial thing to implement, and like you said mod_proxy and now mod_jk support that so it can be considered as a nifty feature to have. But this is just one vote from many :) Regards -- ^(TM) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
On Wed, 2008-09-24 at 14:52 +0100, Mark Thomas wrote: > The 3.0 servlet spec mentions this (ie Tomcat 7) but there is nothing to > stop this being added to 6.0.x I am not aware of such a proposal in Servlet 3.0 (session cookie configuration and tracking coinfig, but no config for the cookie name or URL parameter name). Esp making this configuration per context would a problem to manage, so -1 for that. The fixed names are labelled as "MUST" in the sepc. OTOH, I had to accept a hidden system property for specific customers because of Weblo :( Definitely this is a showcase for bad policies of big proprietary vendors, and their bad consequences. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Remy Maucherat wrote: > On Wed, 2008-09-24 at 14:52 +0100, Mark Thomas wrote: >> The 3.0 servlet spec mentions this (ie Tomcat 7) but there is nothing to >> stop this being added to 6.0.x > > I am not aware of such a proposal in Servlet 3.0 (session cookie > configuration and tracking coinfig, but no config for the cookie name or > URL parameter name). It is in section 7.1.1 of the 3.0 early draft. It only applies to the cookie name. Making the url parameter configurable would be non-spec complaint but I don't see a good reason not to allow it if users have a requirement for it. > Esp making this configuration per context would a > problem to manage, so -1 for that. I don't see why. Looking at the code, this would be really simple. At least wait until there is a proposed patch before trying to veto it. > The fixed names are labelled as "MUST" in the sepc. OTOH, I had to > accept a hidden system property for specific customers because of > Weblo :( Definitely this is a showcase for bad policies of big > proprietary vendors, and their bad consequences. That depends if the customers had a genuine requirement to change the name (not that I can think of one of hand). If they did then it is more the spec not keeping pace with user requirements. Tomcat has a couple of non-spec compliant configuration options as well. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
On Wed, 2008-09-24 at 15:53 +0100, Mark Thomas wrote: > It is in section 7.1.1 of the 3.0 early draft. It only applies to the > cookie name. Making the url parameter configurable would be non-spec > complaint but I don't see a good reason not to allow it if users have a > requirement for it. For starters, I am not aware of such a draft document :( I think per context would be a big problem for proxies, so I am against it. There's no need for a patch to state that, I think. Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
It's kind of hard to fight the specification in the long run. I would think the language would need to be loosened up from MUST. The specification could suggest the use JSESSIONID by default, which would be supported by Tomcat; yet still allow it to be configurable. Not sure I understand why it would be so problematic for proxies and looking at the code base it would be a trivial change. Is this matter still a candidate for and enhancement request so we can put it to a vote? On Wed, Sep 24, 2008 at 10:53 AM, Mark Thomas <[EMAIL PROTECTED]> wrote: > Remy Maucherat wrote: >> On Wed, 2008-09-24 at 14:52 +0100, Mark Thomas wrote: >>> The 3.0 servlet spec mentions this (ie Tomcat 7) but there is nothing to >>> stop this being added to 6.0.x >> >> I am not aware of such a proposal in Servlet 3.0 (session cookie >> configuration and tracking coinfig, but no config for the cookie name or >> URL parameter name). > It is in section 7.1.1 of the 3.0 early draft. It only applies to the > cookie name. Making the url parameter configurable would be non-spec > complaint but I don't see a good reason not to allow it if users have a > requirement for it. > >> Esp making this configuration per context would a >> problem to manage, so -1 for that. > I don't see why. Looking at the code, this would be really simple. At least > wait until there is a proposed patch before trying to veto it. > >> The fixed names are labelled as "MUST" in the sepc. OTOH, I had to >> accept a hidden system property for specific customers because of >> Weblo :( Definitely this is a showcase for bad policies of big >> proprietary vendors, and their bad consequences. > That depends if the customers had a genuine requirement to change the name > (not that I can think of one of hand). If they did then it is more the spec > not keeping pace with user requirements. Tomcat has a couple of non-spec > compliant configuration options as well. > > Mark > > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Remy Maucherat wrote: > On Wed, 2008-09-24 at 15:53 +0100, Mark Thomas wrote: >> It is in section 7.1.1 of the 3.0 early draft. It only applies to the >> cookie name. Making the url parameter configurable would be non-spec >> complaint but I don't see a good reason not to allow it if users have a >> requirement for it. > > For starters, I am not aware of such a draft document :( The draft is here: http://jcp.org/en/jsr/detail?id=315 I though you were on the Servlet EG or am I mistaken? > I think per context would be a big problem for proxies, so I am against > it. There's no need for a patch to state that, I think. Certainly, if they were looking at the cookie to manage load-balancing or similar then different values per context would make that configuration more complex than it needs to be. I would expect the few users that used this to set it on the default Manager but I don't see the harm in having the option to do it per context (with suitable warnings in the docs about proxies). Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45878] New: Generated jars do not contain proper manifests or N & L files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45878 Summary: Generated jars do not contain proper manifests or N & L files Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] This seems to be a regression since 5.5.x. The jars in the binary distribution of 6.0.18 contain a MANIFEST, but the contents are minimal, for example jsp-api.jar contains: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Created-By: 1.5.0_12-b04 (Sun Microsystems Inc.) whereas the jsp-api.jar in 5.5.27 contains: Manifest-Version: 1.0 Ant-Version: Apache Ant 1.7.0 Created-By: 1.4.2_12-b03 (Sun Microsystems Inc.) Name: javax/servlet/jsp/ Specification-Title: Java API for JavaServer Pages Specification-Version: 2.0 Specification-Vendor: Sun Microsystems, Inc. Implementation-Title: javax.servlet.jsp Implementation-Version: 2.0.public_draft Implementation-Vendor: Apache Software Foundation I think all the generated jars should contain the following properties: Built-By: Name: Specification-Title: Specification-Version: Specification-Vendor: Implementation-Title: Implementation-Version: Implementation-Vendor: X-Compile-Source-JDK: X-Compile-Target-JDK: Also, all the jars should contain NOTICE and LICENSE files. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Dan Bush wrote: > It's kind of hard to fight the specification in the long run. I would > think the language would need to be loosened up from MUST. The > specification could suggest the use JSESSIONID by default, which would > be supported by Tomcat; yet still allow it to be configurable. This is exactly what the draft for 3.0 does say, but only for the cookie name. The url parameter is still MUST. > Is this matter > still a candidate for and enhancement request so we can put it to a > vote? In my view, yes. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45879] New: Windows installer fails to install NOTICE and RELEASE-NOTES
https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 Summary: Windows installer fails to install NOTICE and RELEASE- NOTES Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The Windows service installer fails to install the NOTICE and RELEASE-NOTES files in the target directory. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
On Wed, 2008-09-24 at 16:23 +0100, Mark Thomas wrote: > The draft is here: > http://jcp.org/en/jsr/detail?id=315 > > I though you were on the Servlet EG or am I mistaken? I was not aware of that file for whatever reason. I now remember the language that was discussed, and I remember being in favor of it. It now tolerates proprietary configuration of the cookie name, but does not actually mandate or change anything. > > I think per context would be a big problem for proxies, so I am against > > it. There's no need for a patch to state that, I think. > Certainly, if they were looking at the cookie to manage load-balancing or > similar then different values per context would make that configuration > more complex than it needs to be. I am -1 for per context configuration, +1 for global configuration (and I know JF has a custom patch to do that, which I think also does the URL parameter). Rémy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45880] New: Problems with Windows service installer
https://issues.apache.org/bugzilla/show_bug.cgi?id=45880 Summary: Problems with Windows service installer Product: Tomcat 5 Version: 5.5.27 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] Created an attachment (id=22630) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22630) Directory listing of src tree The Windows service installer fails to install the NOTICE and RELEASE-NOTES files in the target directory. (Same in Tomcat 6 - Bug 45879). Also, the installer creates several files in the src/ directory (even for a Normal installation) which don't seem to belong there - see the attached listing for details. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698613 - /tomcat/trunk/res/tomcat.nsi
Author: markt Date: Wed Sep 24 08:47:40 2008 New Revision: 698613 URL: http://svn.apache.org/viewvc?rev=698613&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 Add special handling a for charset that Java uses a non-default name for Modified: tomcat/trunk/res/tomcat.nsi Modified: tomcat/trunk/res/tomcat.nsi URL: http://svn.apache.org/viewvc/tomcat/trunk/res/tomcat.nsi?rev=698613&r1=698612&r2=698613&view=diff == --- tomcat/trunk/res/tomcat.nsi (original) +++ tomcat/trunk/res/tomcat.nsi Wed Sep 24 08:47:40 2008 @@ -535,8 +535,11 @@ FileOpen $R9 "$INSTDIR\conf\tomcat-users.xml" w ; File will be written using current windows codepage System::Call 'Kernel32::GetACP() i .r18' - FileWrite $R9 "$\r$\n" - + StrCmp $R8 "932" 0 +3 +; Special case where Java uses non-standard name for character set +FileWrite $R9 "$\r$\n" +Goto +2 +FileWrite $R9 "$\r$\n" Push "$TEMP\confinstall\tomcat-users_1.xml" Call copyFile FileWrite $R9 $R5 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45882] New: Ensure all jars have full manifests and N & L files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45882 Summary: Ensure all jars have full manifests and N & L files Product: Tomcat 5 Version: 5.5.27 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Native:Packaging AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The commons-el.jar, jsp-api.jar and servlet-api.jar files have manifests, which contain some details of the contents of the jar. However, most of the other jars have minimal manifest entries. All the jars should have manifests with at least the following entries: Built-By: X-Compile-Source-JDK: X-Compile-Target-JDK: Name: and/or Extension-Name: Specification-Title: Specification-Vendor: Specification-Version: Implementation-Title: Implementation-Vendor-Id: Implementation-Vendor: Implementation-Version: And all the jars should have NOTICE and LICENSE files, as is done in the commons-logging-api-1.1.1.jar. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698618 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Sep 24 08:54:05 2008 New Revision: 698618 URL: http://svn.apache.org/viewvc?rev=698618&view=rev Log: Propose fix for 45852 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=698618&r1=698617&r2=698618&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Sep 24 08:54:05 2008 @@ -238,3 +238,10 @@ http://people.apache.org/~markt/patches/2008-09-24-lockout-realm.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 + Add special handing to the Windows installer for a charset that doesn't follow + the standard naming convention + http://svn.apache.org/viewvc?rev=698613&view=rev + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45852] conf/tomcat-users.xml has invalid encoding "cp932".
https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 09:03:09 PST --- Thanks for the testing. I have fixed this in trunk and proposed it for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45879] Windows installer fails to install NOTICE and RELEASE-NOTES
https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 09:08:52 PST --- Release notes are included in the ROOT webapp and the docs webapp. The NOTICE file is only in the docs. It should probably be moved to the install dir to sit alongside the LICENSE file -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45879] Windows installer fails to install NOTICE and RELEASE-NOTES
https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 --- Comment #2 from Sebb <[EMAIL PROTECTED]> 2008-09-24 09:15:48 PST --- It would be useful to have RELEASE-NOTES in the top-level directory as well. This what is done in the binary archive. The webapp RELEASE-NOTES.txt files are not as easy to find when trying to establish what release a directory structure contains. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698629 - in /tomcat/trunk: build.xml res/tomcat.nsi
Author: markt Date: Wed Sep 24 09:21:25 2008 New Revision: 698629 URL: http://svn.apache.org/viewvc?rev=698629&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 Move the NOTICE file to the install dir Modified: tomcat/trunk/build.xml tomcat/trunk/res/tomcat.nsi Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=698629&r1=698628&r2=698629&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Wed Sep 24 09:21:25 2008 @@ -338,7 +338,6 @@ - Modified: tomcat/trunk/res/tomcat.nsi URL: http://svn.apache.org/viewvc/tomcat/trunk/res/tomcat.nsi?rev=698629&r1=698628&r2=698629&view=diff == --- tomcat/trunk/res/tomcat.nsi (original) +++ tomcat/trunk/res/tomcat.nsi Wed Sep 24 09:21:25 2008 @@ -134,6 +134,7 @@ SetOutPath $INSTDIR File tomcat.ico File LICENSE + File NOTICE SetOutPath $INSTDIR\lib File /r lib\*.* SetOutPath $INSTDIR\logs - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45879] Windows installer fails to install NOTICE and RELEASE-NOTES
https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 09:33:45 PST --- The NOTICE file has been moved in trunk and the fix proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698641 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Wed Sep 24 09:44:13 2008 New Revision: 698641 URL: http://svn.apache.org/viewvc?rev=698641&view=rev Log: Propose fix for 45879 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=698641&r1=698640&r2=698641&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Sep 24 09:44:13 2008 @@ -245,3 +245,9 @@ http://svn.apache.org/viewvc?rev=698613&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 + Move NOTICE file from docs webapp to install dir + https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45879] Windows installer fails to install NOTICE and RELEASE-NOTES
https://issues.apache.org/bugzilla/show_bug.cgi?id=45879 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 11:19:06 PST --- Test of e-mail address change - please ignore. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Remy Maucherat schrieb: > On Wed, 2008-09-24 at 16:23 +0100, Mark Thomas wrote: >> The draft is here: >> http://jcp.org/en/jsr/detail?id=315 >> >> I though you were on the Servlet EG or am I mistaken? > > I was not aware of that file for whatever reason. I now remember the > language that was discussed, and I remember being in favor of it. It now > tolerates proprietary configuration of the cookie name, but does not > actually mandate or change anything. > >>> I think per context would be a big problem for proxies, so I am against >>> it. There's no need for a patch to state that, I think. >> Certainly, if they were looking at the cookie to manage load-balancing or >> similar then different values per context would make that configuration >> more complex than it needs to be. > > I am -1 for per context configuration, +1 for global configuration (and > I know JF has a custom patch to do that, which I think also does the URL > parameter). If I read Mladen's latest patch to mod_jk (done yesterday or so) correctly, the values will already be configurable per mount (we will have a concept of mount extensions, which does make some configuration options adjustable per mount, like e.g. reply_timeouts). So the concept specific part of it would not really be a technical problem for mod_jk 1.2.27+. For httpd/mod_proxy_balancer you can configure those data via Proxy blocks, which should also work per mount. A proxy needs to integrate various types of backends, so at least mod_proxy needs that type of flexibility since other backends use other types of session identifiers (e.g. PHP). Whether it's good practise is surely questionable. E.g. I like logging the session cookies in the httpd access log, but that's not that easy, if there are a lot of different cookies in use for that purpose. So it does make your life more complicated, but at least proxies do not have a problem with it, or will soon not have a problem with it. Regards, Rainer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45882] Ensure all jars have full manifests and N & L files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45882 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 12:26:24 PST --- I don't see how many of those values apply to most of the Tomcat jars. What, for example, would you expect the manifest for catalina.jar to look like? I can see the point of the NOTICE and LICENSE files as it makes adding the Tomcat jars to Maven etc easier but they are not required for the standard Tomcat distributions. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45878] Generated jars do not contain proper manifests or N & L files
https://issues.apache.org/bugzilla/show_bug.cgi?id=45878 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 12:27:29 PST --- The spec jars should be easy to fix. I don't see how many of those values apply to most of the Tomcat jars. What, for example, would you expect the manifest for catalina.jar to look like? I can see the point of the NOTICE and LICENSE files as it makes adding the Tomcat jars to Maven etc easier but they are not required for the standard Tomcat distributions. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698713 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Wed Sep 24 13:18:32 2008 New Revision: 698713 URL: http://svn.apache.org/viewvc?rev=698713&view=rev Log: Propose fix for 45880 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=698713&r1=698712&r2=698713&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Sep 24 13:18:32 2008 @@ -105,3 +105,9 @@ http://svn.apache.org/viewvc?rev=697183&view=rev +1: rjung -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45880 + More careful use of File /r and and NOTICE file + http://people.apache.org/~markt/patches/2008-09-24-bug45880.patch + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45880] Problems with Windows service installer
https://issues.apache.org/bugzilla/show_bug.cgi?id=45880 --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 13:18:40 PST --- The following patch has been proposed to fix this: http://people.apache.org/~markt/patches/2008-09-24-bug45880.patch -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698716 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Wed Sep 24 13:23:34 2008 New Revision: 698716 URL: http://svn.apache.org/viewvc?rev=698716&view=rev Log: Propose fix for 45827 Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=698716&r1=698715&r2=698716&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Sep 24 13:23:34 2008 @@ -111,3 +111,9 @@ http://people.apache.org/~markt/patches/2008-09-24-bug45880.patch +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45827 + Code clean-up + https://issues.apache.org/bugzilla/attachment.cgi?id=22596 + +1: markt + -1: - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45827] JSSEImplementation.java load JSSE13Factory dynamically
https://issues.apache.org/bugzilla/show_bug.cgi?id=45827 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 13:23:08 PST --- Thanks for the patch. I have proposed it for 5.5.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45215] Request reader returns length zero
https://issues.apache.org/bugzilla/show_bug.cgi?id=45215 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 13:25:29 PST --- No response for over three months. The 44494 fixes are all in 5.5.27 so I am closing this as a dup. *** This bug has been marked as a duplicate of bug 44494 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44494] Requests greater than 8k being truncated.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44494 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #59 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 13:25:29 PST --- *** Bug 45215 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 42443] Please upload tomcat 5.5.23 jars (including jasper compile and runtime) to apache repository.
https://issues.apache.org/bugzilla/show_bug.cgi?id=42443 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Mark Thomas <[EMAIL PROTECTED]> 2008-09-24 13:28:53 PST --- This was done some time ago. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: svn commit: r698229 - in /tomcat/connectors/trunk/jk: native/apache-2.0/mod_jk.c native/common/jk_ajp_common.c native/common/jk_service.h native/common/jk_util.c xdocs/miscellaneous/changelog.xml
This has broken the build on Windows also.
The addition of the log statement pushed the declaration of char* buff below
it out of the beginning of the block, and VC is being pedantic about the C
declaration rules.
tim
From: <[EMAIL PROTECTED]>
Reply-To: Tomcat Developers List
Date: Tue, 23 Sep 2008 16:37:44 -
To:
Subject: svn commit: r698229 - in /tomcat/connectors/trunk/jk:
native/apache-2.0/mod_jk.c native/common/jk_ajp_common.c
native/common/jk_service.h native/common/jk_util.c
xdocs/miscellaneous/changelog.xml
if (s.content_read < s.content_length ||
(s.is_chunked && !s.no_more_chunks)) {
-
+if (JK_IS_DEBUG_LEVEL(xconf->log))
+ jk_log(xconf->log, JK_LOG_DEBUG,
+ "Consuming remaining request data for
worker=%s",
+ STRNULL_FOR_NULL(worker_name));
DO NOT REPLY [Bug 45852] conf/tomcat-users.xml has invalid encoding "cp932".
https://issues.apache.org/bugzilla/show_bug.cgi?id=45852 --- Comment #4 from Yousei Itou <[EMAIL PROTECTED]> 2008-09-24 17:13:22 PST --- Thank you for reply. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Possibility of Making JSESSIONID Configurable
Mark Thomas wrote: Dan Bush wrote: I have the need to change the name of the session cookie to something other than JSESSIONID. With some other containers like Weblogic it can be adjusted via the provider descriptor (weblogic.xml) [http://e-docs.bea.com/wls/docs100/webapp/weblogic_xml.html#wp1071982]. Tomcat makes use of a global field value. I was wondering what the possibility of making the session cookie name, and the related stuff like the URL parameter configurable at run time. I don't think this would impact mod_jk because I believe that is configurable via a directive. Should be quite simple. It could be made configurable per context by setting it within the session manager. Everywhere it is used, the context is easily accessible. (I haven't checked the url side but I expect it t be similar). The 3.0 servlet spec mentions this (ie Tomcat 7) but there is nothing to stop this being added to 6.0.x yes, I would be a proponent for adding adding this. best Filip Enhancement requests should be entered in bugzilla. Enhancement requests with patches tend to get looked at faster ;) If you want to take a crack at this yourself, you could use this to give you an idea of how to add the configuration. http://svn.apache.org/viewvc?view=rev&revision=694992 Shout if you have any questions / need more pointers. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r698785 - /tomcat/current/tc5.5.x/STATUS.txt
Author: billbarker Date: Wed Sep 24 17:36:26 2008 New Revision: 698785 URL: http://svn.apache.org/viewvc?rev=698785&view=rev Log: Vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=698785&r1=698784&r2=698785&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Wed Sep 24 17:36:26 2008 @@ -116,4 +116,7 @@ Code clean-up https://issues.apache.org/bugzilla/attachment.cgi?id=22596 +1: markt - -1: + -1: billbarker - The patch is bad in that it will break SSL support. The patch only checks the running version of + the JVM, not the version that was used to compile it. So the patch won't allow running Tomcat on + a 1.5 or 1.6 JVM if it was compiled using 1.4. A better patch would just remove the 13Factory, + since it only applies to TC 3.x & 4.x which aren't likely to release again. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
