Re: [jira] [Created] (SOLR-16455) Migrate Jira to Github Issues and Github Projects, and migrate mailing lists to Github Discussions

[Jan Høydahl]

+1 from me too.

I'm still not sold on bringing all history from JIRA into GH but that's what 
Lucene did, so perhaps just doing the same (+ lessons learnt) is the smoothest 
path.
Solr would in addition need to find a new process for security issues. But we 
could just fall back on plain security@solr mailing list until a new solution 
is ready.

Jan

> 17. okt. 2022 kl. 16:20 skrev David Smiley :
> 
> +1 to migrate.
> 
> Yeah.  Maybe Tomoko could validate the steps required?  (CC'ed)  Jeb listed
> them in JIRA; the steps/mechanics can be discussed there while we leave
> this thread as voting on the major decision.
> 
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
> 
> 
> On Mon, Oct 17, 2022 at 10:12 AM Houston Putman  wrote:
> 
>> I'm a big +1 on this idea, just like I was for Lucene's migration.
>> 
>> Also I think that we could very much mooch off of the monumental amounts of
>> hard work that Tomoko and Mike did for Lucene.
>> 
>> There would certainly still be manual work, and changes to their script
>> needed, but I don't think it would be as back-breaking of a task.
>> 
>> - Houston
>> 
>> On Fri, Oct 14, 2022 at 1:07 AM Noble Paul  wrote:
>> 
>>> I agree that JIRA is one extra step that is not adding a lot of value.
>>> Github issues are definitely better
>>> 
>>> On Fri, Oct 14, 2022 at 3:04 PM David Smiley  wrote:
>>> 
 Sharing for visibility.
 
 ~ David Smiley
 Apache Lucene/Solr Search Developer
 http://www.linkedin.com/in/davidwsmiley
 
 
 -- Forwarded message -
 From: Jeb Nix (Jira) 
 Date: Mon, Oct 10, 2022 at 7:11 PM
 Subject: [jira] [Created] (SOLR-16455) Migrate Jira to Github Issues
>> and
 Github Projects, and migrate mailing lists to Github Discussions
 To: 
 
 
 Jeb Nix created SOLR-16455:
 --
 
 Summary: Migrate Jira to Github Issues and Github
>> Projects,
 and migrate mailing lists to Github Discussions
 Key: SOLR-16455
 URL: https://issues.apache.org/jira/browse/SOLR-16455
 Project: Solr
  Issue Type: Wish
  Security Level: Public (Default Security Level. Issues are
>> Public)
  Components: github
Reporter: Jeb Nix
 
 
 GitHub is where people are at when they lookup for Solr (or basically
>> any
 project). Most of the modern projects that have been started with Jira
>>> and
 mailing lists have migrated to Github in the last few years. Lucene did
 that just now for the Issues which has allowed me to explore much more
>> of
 their issues. GitHub works great and many think that it works even
>> better
 (I think that there is no doubt that it is working better for the
 Discussions vs. Mailing lists).
 
 I suggest here a pretty heavy move, that personally will allow me to
>>> start
 anticipating within Solr's community (since I really don't like the
>>> mailing
 lists nor Jira), and I think that there are much more like me out
>> there.
>>> In
 my opinion, when the issues are managed on Github, it is much simpler
>> to
 collaborate and they will get wider exposure since developers are
>>> spending
 time on Github anyway (whether if it's for their projects or for
>> looking
>>> at
 the actual source code). It is also important to mention that it is
>>> pretty
 cumbersome for a new contributor that wants to add stuff to Solr, to
>> talk
 about this via mail, then translate them to Jira of the issues, and
>> just
 after that submit a PR on Github. e.g. 3 different systems for each
 process.
 
 Actually, I thought such a great move (for me at least) would never
>>> happen
 in Solr in the next years since I didn't think that the community sees
>> &
 understands the many advantages yet. But now that the Lucene guys did
>>> this,
 I believe that it is possible for Solr too.
 
 
 
 --
 This message was sent by Atlassian Jira
 (v8.20.10#820010)
 
 -
 To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
 For additional commands, e-mail: issues-h...@solr.apache.org
 
>>> 
>>> 
>>> --
>>> -
>>> Noble Paul
>>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org

Re: New branch and feature freeze for Solr 9.1.0

[Ishan Chattopadhyaya]

All the blockers are now resolved and the latest build passes.
https://ci-builds.apache.org/job/Solr/job/Solr-check-9.1/209/
I'll proceed with the RC1 building shortly. Thanks to everyone!

On Fri, Oct 14, 2022 at 2:56 PM Jan Høydahl  wrote:

> Created https://issues.apache.org/jira/browse/SOLR-16463
>
> Will make a PR for 9.0
>
> Jan
>
> > 14. okt. 2022 kl. 00:56 skrev David Smiley :
> >
> > Looks like we need to downgrade the Docker image to JDK 11 :-(.   Or one
> in
> > between maybe.
> >
> > ~ David Smiley
> > Apache Lucene/Solr Search Developer
> > http://www.linkedin.com/in/davidwsmiley
> >
> >
> > On Thu, Oct 13, 2022 at 4:58 PM Jan Høydahl 
> wrote:
> >
> >> On the users list we see several solr 9.0.0 users on Docker/k8s
> reporting
> >> frequent crashes due to a know JDK17 bug.
> >> https://lists.apache.org/thread/wg7qtkddd1t5h08okj7gm9qbrpdf0ox6
> >>
> >> Should we perhaps provide an official solr:9.0.0-temurin11 tag as a
> >> workaround for users?
> >> And also consider releasing 9.1 docker image with temurin11 as default,
> if
> >> the bug is not fixed by then?
> >>
> >> Jan
> >>
> >>> 12. okt. 2022 kl. 18:48 skrev Kevin Risden :
> >>>
> 
>  * https://issues.apache.org/jira/browse/SOLR-16457 - solr.data.home
> set
>  to empty string in bin/solr
>  * https://issues.apache.org/jira/browse/SOLR-16433 - Solr SQL isn't
>  working w/ security manager enabled
> 
> >>>
> >>> Merged and backported to branch_9_1
> >>>
> >>>
> >>> Kevin Risden
> >>>
> >>>
> >>> On Wed, Oct 12, 2022 at 12:32 PM Christine Poerschke (BLOOMBERG/
> LONDON)
> >> <
> >>> cpoersc...@bloomberg.net> wrote:
> >>>
>  Merging and backporting is now complete. Thank you.
> 
>  From: dev@solr.apache.org At: 10/12/22 17:01:02 UTC+1:00To:
> Christine
>  Poerschke (BLOOMBERG/ LONDON ) ,  dev@solr.apache.org
>  Subject: Re: New branch and feature freeze for Solr 9.1.0
> 
>  Sure, please go ahead. Thanks!
> 
>  On Wed, 12 Oct, 2022, 5:27 pm Christine Poerschke (BLOOMBERG/
> LONDON), <
>  cpoersc...@bloomberg.net> wrote:
> 
> > I'd like to also include https://github.com/apache/solr/pull/1050
> for
> > https://issues.apache.org/jira/browse/SOLR-16439 bug fix please if
> >> that
> > is okay?
> >
> > Christine
> >
> > From: dev@solr.apache.org At: 10/11/22 20:11:10 UTC+1:00To:
> > dev@solr.apache.org
> > Subject: Re: New branch and feature freeze for Solr 9.1.0
> >
> > Sure Kevin, please go ahead. Noble and I are debugging a critical
> test
> > failure related to overseer (SOLR-16440) and kind of blocked at the
>  moment
> > for the release.
> >
> > On Tue, 11 Oct, 2022, 10:51 pm Kevin Risden, 
> >> wrote:
> >
> >> Ishan I'm hoping to get these two jiras in for 9.1, the PRs are up
>  there
> >> waiting for reviews and they need to run through tests. The two are
> >> related.
> >> * https://issues.apache.org/jira/browse/SOLR-16457 - solr.data.home
>  set
> > to
> >> empty string in bin/solr
> >> * https://issues.apache.org/jira/browse/SOLR-16433 - Solr SQL isn't
> >> working
> >> w/ security manager enabled
> >>
> >> Kevin Risden
> >>
> >>
> >> On Mon, Oct 10, 2022 at 1:41 AM Ishan Chattopadhyaya <
> >> ichattopadhy...@gmail.com> wrote:
> >>
> >>>
> >>>
> >>
> >
> >
> 
> 
> >>
> https://issues.apache.org/jira/browse/SOLR-16453?jql=project%20%3D%20SOLR%20AND%
> >
> >
> 
> 
> >>
> 20(fixVersion%20%3D%209.1)%20AND%20priority%20%3D%20Blocker%20AND%20resolution%2
> > 0%3D%20Unresolved
> >>>
> >>> On Mon, Oct 10, 2022 at 11:10 AM Ishan Chattopadhyaya <
> >>> ichattopadhy...@gmail.com> wrote:
> >>>
>  There were lots of Blocker issues with affectsVersion as 9.1. I
> > assume
> >>> the
>  intention was to have them be available in 9.1? I've changed them
>  to
>  fixVersion = 9.1 (blocker).
> 
>  On Fri, Oct 7, 2022 at 5:17 PM Christine Poerschke (BLOOMBERG/
> > LONDON)
> >> <
>  cpoersc...@bloomberg.net> wrote:
> 
> > Thanks! Merging and backporting is now complete.
> >
> > From: dev@solr.apache.org At: 10/07/22 04:07:31 UTC+1:00To:
> >> Christine
> > Poerschke (BLOOMBERG/ LONDON ) ,  dev@solr.apache.org
> > Subject: Re: New branch and feature freeze for Solr 9.1.0
> >
> > Sure, please go ahead.
> >
> > On Fri, 7 Oct, 2022, 12:15 am Christine Poerschke (BLOOMBERG/
> >> LONDON), <
> > cpoersc...@bloomberg.net> wrote:
> >
> >> I'd like to include https://github.com/apache/solr/pull/1051
>  for
> >> https://issues.apache.org/jira/browse/SOLR-13219 bug fix please
> > if
> >>> that
> >> is okay?
> >>
> >> Christine
> >>
> >> From: dev@solr.apache.org At: 10

Just want to highlight a PR on simplifying asserts

[Eric Pugh]

Hi all,

I started, and Kevin pushed to completion 
https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify our 
assert logic.  

It touches 330 files, all various tests….  I think it’s a great enhancement, 
but before clicking merge, wanted to give a chance for someone to speak up on 
why these stylistic changes should be reverted!

I’d like to get this merged this week.

Eric

___
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | 
http://www.opensourceconnections.com  | 
My Free/Busy   
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 


This e-mail and all contents, including attachments, is considered to be 
Company Confidential unless explicitly stated otherwise, regardless of whether 
attachments are marked as such.

Re: Just want to highlight a PR on simplifying asserts

[Ishan Chattopadhyaya]

I agree that these changes are good for the codebase. But, I am very much
disturbed by the changeset size. It will make backporting, working on
existing changes etc. a massive pain. I don't see the benefit enough to
outweigh the massive loss in productivity. Solr needs improvement in
efficiency, performance, ease of use etc. most urgently. Stylistic changes
like these don't contribute much there, rather hinder ongoing efforts in
the right direction.

I'm -0 on this merge.

On Tue, Oct 18, 2022 at 7:06 PM Eric Pugh 
wrote:

> Hi all,
>
> I started, and Kevin pushed to completion
> https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify
> our assert logic.
>
> It touches 330 files, all various tests….  I think it’s a great
> enhancement, but before clicking merge, wanted to give a chance for someone
> to speak up on why these stylistic changes should be reverted!
>
> I’d like to get this merged this week.
>
> Eric
>
> ___
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
> http://www.opensourceconnections.com <
> http://www.opensourceconnections.com/> | My Free/Busy <
> http://tinyurl.com/eric-cal>
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>
> This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless of
> whether attachments are marked as such.
>
>

Re: Just want to highlight a PR on simplifying asserts

[Kevin Risden]

Changeset size is ~300 files - much smaller than the thousands of files
touched by spotless.

The tangible benefits being that error messages are no longer "assertion
failed" but instead say what was different in the case of arrays the two
arrays or in the case of some equals the two values. This in and of itself
is a huge benefit to those debugging tests. So this isn't just stylistsic -
it is actually improving the error message on failed tests.

Regarding backporting stuff - the changes are over 300 files but most of
the files have ~4-20 lines changed. They are in a few assertions - not most
of them. So there is very little impact on backporting. The caveat being a
few tests that had a lot of changes (~5 files?) - SQL and streaming
expressions followed a bad pattern originally and so that is where there
are ~1500 lines changed - but they are again simple changes and make the
tests easier to read instead of just assertTrue everywhere.

I don't think these hinder ongoing efforts in the right direction at all.
This effort has uncovered different tests that weren't extending
SolrTestCase so missing benefits like known randomization and thread leak
checks. These little things add up over time and lead to harder to maintain
code bases. This effort tries to get the code base back to a reasonable
state for tests. It also provides good examples for those making new tests
instead of copying the old.

I know this clean up work doesn't seem like it is worth the effort - but I
know it ends up leading to finding latent bugs and fixing real issues.
These small cleanups make things like
https://github.com/apache/solr/pull/1039 much easier since the tests have
been standardized. These are all building blocks towards building a better
Solr and hardening the code base we have.

Kevin Risden


On Tue, Oct 18, 2022 at 10:44 AM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> I agree that these changes are good for the codebase. But, I am very much
> disturbed by the changeset size. It will make backporting, working on
> existing changes etc. a massive pain. I don't see the benefit enough to
> outweigh the massive loss in productivity. Solr needs improvement in
> efficiency, performance, ease of use etc. most urgently. Stylistic changes
> like these don't contribute much there, rather hinder ongoing efforts in
> the right direction.
>
> I'm -0 on this merge.
>
> On Tue, Oct 18, 2022 at 7:06 PM Eric Pugh  >
> wrote:
>
> > Hi all,
> >
> > I started, and Kevin pushed to completion
> > https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify
> > our assert logic.
> >
> > It touches 330 files, all various tests….  I think it’s a great
> > enhancement, but before clicking merge, wanted to give a chance for
> someone
> > to speak up on why these stylistic changes should be reverted!
> >
> > I’d like to get this merged this week.
> >
> > Eric
> >
> > ___
> > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
> > http://www.opensourceconnections.com <
> > http://www.opensourceconnections.com/> | My Free/Busy <
> > http://tinyurl.com/eric-cal>
> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
> >
> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw
> >
> >
> > This e-mail and all contents, including attachments, is considered to be
> > Company Confidential unless explicitly stated otherwise, regardless of
> > whether attachments are marked as such.
> >
> >
>

RAT errors during RC1

[Ishan Chattopadhyaya]

I'm trying to build the RC1 of 9.1 release.
Here are the errors I ran into:
* Where:
Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78

* What went wrong:
Execution failed for task ':rat'.
> Detected license header issues (skip with -Pvalidation.rat.failOnError=
false):
Unknown license:
/home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
Unknown license:
/home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
Unknown license:
/home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
Unknown license:
/home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
Unknown license:
/home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
snippet-type.xml
Unknown license:
/home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
snippet-field.xml
Unknown license:
/home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
snippet-processor.xml


https://termbin.com/rjui

I fixed them locally (to add ASF license in the XML files), but then ran
into various *.txt files that have tabs, not spaces. Clearly, these are all
false alarms, and all the files here are last edited years ago.

Should we add -Pvalidation.sourcePatterns.failOnError=false to the release
script and move on?

Re: RAT errors during RC1

[Kevin Risden]

`out/` is a weird directory... I would remove the out directory and go from
there? It looks like maybe there are some old files under the git checkout?

I personally don't have an out directory in my Solr checkout.

Kevin Risden


On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> I'm trying to build the RC1 of 9.1 release.
> Here are the errors I ran into:
> * Where:
> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
>
> * What went wrong:
> Execution failed for task ':rat'.
> > Detected license header issues (skip with -Pvalidation.rat.failOnError=
> false):
> Unknown license:
> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
> Unknown license:
> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
> Unknown license:
> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
> Unknown license:
> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> snippet-type.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> snippet-field.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
> snippet-processor.xml
>
>
> https://termbin.com/rjui
>
> I fixed them locally (to add ASF license in the XML files), but then ran
> into various *.txt files that have tabs, not spaces. Clearly, these are all
> false alarms, and all the files here are last edited years ago.
>
> Should we add -Pvalidation.sourcePatterns.failOnError=false to the release
> script and move on?
>

Re: RAT errors during RC1

[Kevin Risden]

I see you also already committed the rat change to disable the check. The
license check from rat is very important to ASF releases so it shouldn't
just be removed.

Kevin Risden


On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden  wrote:

> `out/` is a weird directory... I would remove the out directory and go
> from there? It looks like maybe there are some old files under the git
> checkout?
>
> I personally don't have an out directory in my Solr checkout.
>
> Kevin Risden
>
>
> On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> wrote:
>
>> I'm trying to build the RC1 of 9.1 release.
>> Here are the errors I ran into:
>> * Where:
>> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
>>
>> * What went wrong:
>> Execution failed for task ':rat'.
>> > Detected license header issues (skip with -Pvalidation.rat.failOnError=
>> false):
>> Unknown license:
>> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
>> Unknown license:
>> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
>> Unknown license:
>> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
>> Unknown license:
>> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
>> Unknown license:
>> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> snippet-type.xml
>> Unknown license:
>> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> snippet-field.xml
>> Unknown license:
>> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
>> snippet-processor.xml
>>
>>
>> https://termbin.com/rjui
>>
>> I fixed them locally (to add ASF license in the XML files), but then ran
>> into various *.txt files that have tabs, not spaces. Clearly, these are
>> all
>> false alarms, and all the files here are last edited years ago.
>>
>> Should we add -Pvalidation.sourcePatterns.failOnError=false to the release
>> script and move on?
>>
>

Re: RAT errors during RC1

[Ishan Chattopadhyaya]

I just did that in 9.1 branch (not planning to branch_9x), to see if things
work properly.
Thanks for the pointer on out/ directory. I'll try another fresh checkout
and try again.

On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden  wrote:

> I see you also already committed the rat change to disable the check. The
> license check from rat is very important to ASF releases so it shouldn't
> just be removed.
>
> Kevin Risden
>
>
> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden  wrote:
>
> > `out/` is a weird directory... I would remove the out directory and go
> > from there? It looks like maybe there are some old files under the git
> > checkout?
> >
> > I personally don't have an out directory in my Solr checkout.
> >
> > Kevin Risden
> >
> >
> > On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
> > ichattopadhy...@gmail.com> wrote:
> >
> >> I'm trying to build the RC1 of 9.1 release.
> >> Here are the errors I ran into:
> >> * Where:
> >> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
> >>
> >> * What went wrong:
> >> Execution failed for task ':rat'.
> >> > Detected license header issues (skip with
> -Pvalidation.rat.failOnError=
> >> false):
> >> Unknown license:
> >> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> >> snippet-type.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> >> snippet-field.xml
> >> Unknown license:
> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
> >> snippet-processor.xml
> >>
> >>
> >> https://termbin.com/rjui
> >>
> >> I fixed them locally (to add ASF license in the XML files), but then ran
> >> into various *.txt files that have tabs, not spaces. Clearly, these are
> >> all
> >> false alarms, and all the files here are last edited years ago.
> >>
> >> Should we add -Pvalidation.sourcePatterns.failOnError=false to the
> release
> >> script and move on?
> >>
> >
>

Re: RAT errors during RC1

[Ishan Chattopadhyaya]

Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
disable rat.

On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> I just did that in 9.1 branch (not planning to branch_9x), to see if
> things work properly.
> Thanks for the pointer on out/ directory. I'll try another fresh checkout
> and try again.
>
> On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden  wrote:
>
>> I see you also already committed the rat change to disable the check. The
>> license check from rat is very important to ASF releases so it shouldn't
>> just be removed.
>>
>> Kevin Risden
>>
>>
>> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden  wrote:
>>
>> > `out/` is a weird directory... I would remove the out directory and go
>> > from there? It looks like maybe there are some old files under the git
>> > checkout?
>> >
>> > I personally don't have an out directory in my Solr checkout.
>> >
>> > Kevin Risden
>> >
>> >
>> > On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
>> > ichattopadhy...@gmail.com> wrote:
>> >
>> >> I'm trying to build the RC1 of 9.1 release.
>> >> Here are the errors I ran into:
>> >> * Where:
>> >> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
>> >>
>> >> * What went wrong:
>> >> Execution failed for task ':rat'.
>> >> > Detected license header issues (skip with
>> -Pvalidation.rat.failOnError=
>> >> false):
>> >> Unknown license:
>> >>
>> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> >> snippet-type.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> >> snippet-field.xml
>> >> Unknown license:
>> >> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
>> >> snippet-processor.xml
>> >>
>> >>
>> >> https://termbin.com/rjui
>> >>
>> >> I fixed them locally (to add ASF license in the XML files), but then
>> ran
>> >> into various *.txt files that have tabs, not spaces. Clearly, these are
>> >> all
>> >> false alarms, and all the files here are last edited years ago.
>> >>
>> >> Should we add -Pvalidation.sourcePatterns.failOnError=false to the
>> release
>> >> script and move on?
>> >>
>> >
>>
>

Re: Just want to highlight a PR on simplifying asserts

[Jan Høydahl]

+1

If it gets merged both to main and branch_9x it will not cause backport pain at 
all for 95% of the PRs.
Kudos for caring for the "boring" parts of open source!

Jan

> 18. okt. 2022 kl. 15:35 skrev Eric Pugh :
> 
> Hi all,
> 
> I started, and Kevin pushed to completion 
> https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify our 
> assert logic.  
> 
> It touches 330 files, all various tests….  I think it’s a great enhancement, 
> but before clicking merge, wanted to give a chance for someone to speak up on 
> why these stylistic changes should be reverted!
> 
> I’d like to get this merged this week.
> 
> Eric
> 
> ___
> Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | 
> http://www.opensourceconnections.com  
> | My Free/Busy   
> Co-Author: Apache Solr Enterprise Search Server, 3rd Ed 
> 
>   
> This e-mail and all contents, including attachments, is considered to be 
> Company Confidential unless explicitly stated otherwise, regardless of 
> whether attachments are marked as such.
> 


-
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org

Re: Just want to highlight a PR on simplifying asserts

[Houston Putman]

Agreed. I think this is good stuff, there are a lot of bad asserts in our
tests, and this will only help make debugging easier.

I'm going to try my best to get through the PR over the next few days.

- Houston

On Tue, Oct 18, 2022 at 12:50 PM Jan Høydahl  wrote:

> +1
>
> If it gets merged both to main and branch_9x it will not cause backport
> pain at all for 95% of the PRs.
> Kudos for caring for the "boring" parts of open source!
>
> Jan
>
> > 18. okt. 2022 kl. 15:35 skrev Eric Pugh  >:
> >
> > Hi all,
> >
> > I started, and Kevin pushed to completion
> https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify
> our assert logic.
> >
> > It touches 330 files, all various tests….  I think it’s a great
> enhancement, but before clicking merge, wanted to give a chance for someone
> to speak up on why these stylistic changes should be reverted!
> >
> > I’d like to get this merged this week.
> >
> > Eric
> >
> > ___
> > Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 |
> http://www.opensourceconnections.com <
> http://www.opensourceconnections.com/> | My Free/Busy <
> http://tinyurl.com/eric-cal>
> > Co-Author: Apache Solr Enterprise Search Server, 3rd Ed <
> https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw>
>
> > This e-mail and all contents, including attachments, is considered to be
> Company Confidential unless explicitly stated otherwise, regardless of
> whether attachments are marked as such.
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> For additional commands, e-mail: dev-h...@solr.apache.org
>
>

Re: RAT errors during RC1

[Jan Høydahl]

TIP: If you follow the Release Wizard tediously (and you always should), all RM 
building will happen from a clean checkout under ~/.solr-releases/9.1.0/solr

Jan

> 18. okt. 2022 kl. 18:34 skrev Ishan Chattopadhyaya 
> :
> 
> Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
> disable rat.
> 
> On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com> wrote:
> 
>> I just did that in 9.1 branch (not planning to branch_9x), to see if
>> things work properly.
>> Thanks for the pointer on out/ directory. I'll try another fresh checkout
>> and try again.
>> 
>> On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden  wrote:
>> 
>>> I see you also already committed the rat change to disable the check. The
>>> license check from rat is very important to ASF releases so it shouldn't
>>> just be removed.
>>> 
>>> Kevin Risden
>>> 
>>> 
>>> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden  wrote:
>>> 
 `out/` is a weird directory... I would remove the out directory and go
 from there? It looks like maybe there are some old files under the git
 checkout?
 
 I personally don't have an out directory in my Solr checkout.
 
 Kevin Risden
 
 
 On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
 ichattopadhy...@gmail.com> wrote:
 
> I'm trying to build the RC1 of 9.1 release.
> Here are the errors I ran into:
> * Where:
> Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
> 
> * What went wrong:
> Execution failed for task ':rat'.
>> Detected license header issues (skip with
>>> -Pvalidation.rat.failOnError=
> false):
> Unknown license:
> 
>>> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
> Unknown license:
> /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
> Unknown license:
> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
> Unknown license:
> /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> snippet-type.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> snippet-field.xml
> Unknown license:
> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
> snippet-processor.xml
> 
> 
> https://termbin.com/rjui
> 
> I fixed them locally (to add ASF license in the XML files), but then
>>> ran
> into various *.txt files that have tabs, not spaces. Clearly, these are
> all
> false alarms, and all the files here are last edited years ago.
> 
> Should we add -Pvalidation.sourcePatterns.failOnError=false to the
>>> release
> script and move on?
> 
 
>>> 
>> 


-
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org

Re: RAT errors during RC1

[Ishan Chattopadhyaya]

Right, indeed. I was testing out a recently failed test there (
https://issues.apache.org/jira/browse/SOLR-16425), in the wrong terminal
window, which left the release repo's checkout unclean.

On Tue, Oct 18, 2022 at 10:28 PM Jan Høydahl  wrote:

> TIP: If you follow the Release Wizard tediously (and you always should),
> all RM building will happen from a clean checkout under
> ~/.solr-releases/9.1.0/solr
>
> Jan
>
> > 18. okt. 2022 kl. 18:34 skrev Ishan Chattopadhyaya <
> ichattopadhy...@gmail.com>:
> >
> > Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
> > disable rat.
> >
> > On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya <
> > ichattopadhy...@gmail.com> wrote:
> >
> >> I just did that in 9.1 branch (not planning to branch_9x), to see if
> >> things work properly.
> >> Thanks for the pointer on out/ directory. I'll try another fresh
> checkout
> >> and try again.
> >>
> >> On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden 
> wrote:
> >>
> >>> I see you also already committed the rat change to disable the check.
> The
> >>> license check from rat is very important to ASF releases so it
> shouldn't
> >>> just be removed.
> >>>
> >>> Kevin Risden
> >>>
> >>>
> >>> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden 
> wrote:
> >>>
>  `out/` is a weird directory... I would remove the out directory and go
>  from there? It looks like maybe there are some old files under the git
>  checkout?
> 
>  I personally don't have an out directory in my Solr checkout.
> 
>  Kevin Risden
> 
> 
>  On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
>  ichattopadhy...@gmail.com> wrote:
> 
> > I'm trying to build the RC1 of 9.1 release.
> > Here are the errors I ran into:
> > * Where:
> > Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
> >
> > * What went wrong:
> > Execution failed for task ':rat'.
> >> Detected license header issues (skip with
> >>> -Pvalidation.rat.failOnError=
> > false):
> > Unknown license:
> >
> >>>
> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
> > Unknown license:
> > /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
> > Unknown license:
> >
> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
> > Unknown license:
> > /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
> > Unknown license:
> > /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> > snippet-type.xml
> > Unknown license:
> > /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
> > snippet-field.xml
> > Unknown license:
> > /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
> > snippet-processor.xml
> >
> >
> > https://termbin.com/rjui
> >
> > I fixed them locally (to add ASF license in the XML files), but then
> >>> ran
> > into various *.txt files that have tabs, not spaces. Clearly, these
> are
> > all
> > false alarms, and all the files here are last edited years ago.
> >
> > Should we add -Pvalidation.sourcePatterns.failOnError=false to the
> >>> release
> > script and move on?
> >
> 
> >>>
> >>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> For additional commands, e-mail: dev-h...@solr.apache.org
>
>

Re: RAT errors during RC1

[Ishan Chattopadhyaya]

Ah, my ~/.solr-releases dir was symlinked to my dev repo, which caused this
:-D

ishan@x1extreme ~/code/solr (branch_9_1) $ ls ~/.solr-releases/9.1.0/ -la
total 16
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:27 .
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:10 ..
drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:28 RC1
lrwxrwxrwx. 1 ishan ishan   21 Sep 27 11:27 solr -> /home/ishan/code/solr
-rw-rw-r--. 1 ishan ishan 3173 Oct 18 20:23 state.yaml

On Tue, Oct 18, 2022 at 10:37 PM Ishan Chattopadhyaya <
ichattopadhy...@gmail.com> wrote:

> Right, indeed. I was testing out a recently failed test there (
> https://issues.apache.org/jira/browse/SOLR-16425), in the wrong terminal
> window, which left the release repo's checkout unclean.
>
> On Tue, Oct 18, 2022 at 10:28 PM Jan Høydahl 
> wrote:
>
>> TIP: If you follow the Release Wizard tediously (and you always should),
>> all RM building will happen from a clean checkout under
>> ~/.solr-releases/9.1.0/solr
>>
>> Jan
>>
>> > 18. okt. 2022 kl. 18:34 skrev Ishan Chattopadhyaya <
>> ichattopadhy...@gmail.com>:
>> >
>> > Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to
>> > disable rat.
>> >
>> > On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya <
>> > ichattopadhy...@gmail.com> wrote:
>> >
>> >> I just did that in 9.1 branch (not planning to branch_9x), to see if
>> >> things work properly.
>> >> Thanks for the pointer on out/ directory. I'll try another fresh
>> checkout
>> >> and try again.
>> >>
>> >> On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden 
>> wrote:
>> >>
>> >>> I see you also already committed the rat change to disable the check.
>> The
>> >>> license check from rat is very important to ASF releases so it
>> shouldn't
>> >>> just be removed.
>> >>>
>> >>> Kevin Risden
>> >>>
>> >>>
>> >>> On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden 
>> wrote:
>> >>>
>>  `out/` is a weird directory... I would remove the out directory and
>> go
>>  from there? It looks like maybe there are some old files under the
>> git
>>  checkout?
>> 
>>  I personally don't have an out directory in my Solr checkout.
>> 
>>  Kevin Risden
>> 
>> 
>>  On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya <
>>  ichattopadhy...@gmail.com> wrote:
>> 
>> > I'm trying to build the RC1 of 9.1 release.
>> > Here are the errors I ran into:
>> > * Where:
>> > Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78
>> >
>> > * What went wrong:
>> > Execution failed for task ':rat'.
>> >> Detected license header issues (skip with
>> >>> -Pvalidation.rat.failOnError=
>> > false):
>> > Unknown license:
>> >
>> >>>
>> /home/ishan/code/solr/out/production/core/SystemCollectionSolrConfig.xml
>> > Unknown license:
>> > /home/ishan/code/solr/out/production/core/SystemCollectionSchema.xml
>> > Unknown license:
>> >
>> /home/ishan/code/solr/out/test/solrj/solrj/sampleRangeFacetResponse.xml
>> > Unknown license:
>> > /home/ishan/code/solr/out/test/solrj/solrj/sampleGroupResponse.xml
>> > Unknown license:
>> > /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> > snippet-type.xml
>> > Unknown license:
>> > /home/ishan/code/solr/out/test/core/solr/collection1/conf/schema-
>> > snippet-field.xml
>> > Unknown license:
>> >
>> /home/ishan/code/solr/out/test/core/solr/collection1/conf/solrconfig-
>> > snippet-processor.xml
>> >
>> >
>> > https://termbin.com/rjui
>> >
>> > I fixed them locally (to add ASF license in the XML files), but then
>> >>> ran
>> > into various *.txt files that have tabs, not spaces. Clearly, these
>> are
>> > all
>> > false alarms, and all the files here are last edited years ago.
>> >
>> > Should we add -Pvalidation.sourcePatterns.failOnError=false to the
>> >>> release
>> > script and move on?
>> >
>> 
>> >>>
>> >>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
>> For additional commands, e-mail: dev-h...@solr.apache.org
>>
>>