[jira] [Commented] (GEODE-2823) The LuceneEventListener caues deserialized values to be stored in the entry when the region contains DataSerializable or Serializable values

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990651#comment-15990651
 ] 

ASF subversion and git services commented on GEODE-2823:


Commit 8da1ba353185c931d7d1626ca9e188b4f38d0761 in geode's branch 
refs/heads/develop from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8da1ba3 ]

GEODE-2823: The listener now forces a copy of the value to be made


> The LuceneEventListener caues deserialized values to be stored in the entry 
> when the region contains DataSerializable or Serializable values
> 
>
> Key: GEODE-2823
> URL: https://issues.apache.org/jira/browse/GEODE-2823
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>
> If the {{Region}} contains {{DataSerializable}} or {{Serializable}} values, 
> then each {{RegionEntry}} contains a {{VMCachedDeserializable}}. When 
> {{LuceneEventListener.process}} calls {{entry.getValue()}}, the value is 
> deserialized and left in that state in the {{VMCachedDeserializable}}.
> Below is a live histogram for the no index test.
> {noformat}
>  num #instances #bytes  class name
> --
>1:1019016088544  [B
>2:115600056  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>3: 363463236272  [C
>4:10240  
> org.apache.geode.internal.cache.VMCachedDeserializable
>5:  3792 905488  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>6: 36161 867864  java.lang.String
>7:  6546 750464  java.lang.Class
>8:  8051 523264  [Ljava.lang.Object;
>9:  5151 453288  java.lang.reflect.Method
>   10:   704 405280  [J
>   11:  8390 402720  
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync
>   12: 11796 377472  
> java.util.concurrent.ConcurrentHashMap$Node
>   13: 11379 364128  java.util.HashMap$Node
>   14:   597 357552  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
>   15:  3409 319888  [Ljava.util.HashMap$Node;
>   16:  7754 310160  java.util.LinkedHashMap$Entry
>   17:  5817 279216  java.util.TreeMap
>   18:  4031 257984  java.util.concurrent.ConcurrentHashMap
>   19:  6385 255400  java.util.TreeMap$Entry
>   20: 13587 217392  java.lang.Object
> Total611397   28902304
> {noformat}
> Below is a live histogram for the index test. The main thing to notice 
> regarding this bug is the 10 Trade instances.
> {noformat}
>  num #instances #bytes  class name
> --
>1:338275   16181384  [C
>2:322931   15500688  
> org.apache.geode.internal.cache.TombstoneService$Tombstone
>3:220717   12360152  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapObjectKey
>4:197837   11078872  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>5:3380368112864  java.lang.String
>6:3231287755072  
> java.util.concurrent.ConcurrentLinkedQueue$Node
>7: 205015658048  [B
>8:1626495204768  java.util.UUID
>9:1592753822600  
> org.apache.geode.cache.lucene.internal.filesystem.ChunkKey
>   10:  56003787016  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>   11:10320  Trade
>   12:1034872483688  
> org.apache.geode.internal.cache.VMCachedDeserializable
>   13: 634942031808  java.util.HashMap$Node
>   14: 139741241616  [Ljava.util.HashMap$Node;
>   15: 254561221888  java.util.HashMap
>   16:  7396 843664  java.lang.Class
>   17: 10948 726856  [Ljava.lang.Object;
>   18: 11357 726848  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey2
>   19: 15856 634240  java.util.TreeMap$Entry
>   20:  1067 614992  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
> Total   2856366  118323456
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2823) The LuceneEventListener caues deserialized values to be stored in the entry when the region contains DataSerializable or Serializable values

[Barry Oglesby (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barry Oglesby resolved GEODE-2823.
--
   Resolution: Fixed
Fix Version/s: 1.2.0

> The LuceneEventListener caues deserialized values to be stored in the entry 
> when the region contains DataSerializable or Serializable values
> 
>
> Key: GEODE-2823
> URL: https://issues.apache.org/jira/browse/GEODE-2823
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If the {{Region}} contains {{DataSerializable}} or {{Serializable}} values, 
> then each {{RegionEntry}} contains a {{VMCachedDeserializable}}. When 
> {{LuceneEventListener.process}} calls {{entry.getValue()}}, the value is 
> deserialized and left in that state in the {{VMCachedDeserializable}}.
> Below is a live histogram for the no index test.
> {noformat}
>  num #instances #bytes  class name
> --
>1:1019016088544  [B
>2:115600056  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>3: 363463236272  [C
>4:10240  
> org.apache.geode.internal.cache.VMCachedDeserializable
>5:  3792 905488  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>6: 36161 867864  java.lang.String
>7:  6546 750464  java.lang.Class
>8:  8051 523264  [Ljava.lang.Object;
>9:  5151 453288  java.lang.reflect.Method
>   10:   704 405280  [J
>   11:  8390 402720  
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync
>   12: 11796 377472  
> java.util.concurrent.ConcurrentHashMap$Node
>   13: 11379 364128  java.util.HashMap$Node
>   14:   597 357552  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
>   15:  3409 319888  [Ljava.util.HashMap$Node;
>   16:  7754 310160  java.util.LinkedHashMap$Entry
>   17:  5817 279216  java.util.TreeMap
>   18:  4031 257984  java.util.concurrent.ConcurrentHashMap
>   19:  6385 255400  java.util.TreeMap$Entry
>   20: 13587 217392  java.lang.Object
> Total611397   28902304
> {noformat}
> Below is a live histogram for the index test. The main thing to notice 
> regarding this bug is the 10 Trade instances.
> {noformat}
>  num #instances #bytes  class name
> --
>1:338275   16181384  [C
>2:322931   15500688  
> org.apache.geode.internal.cache.TombstoneService$Tombstone
>3:220717   12360152  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapObjectKey
>4:197837   11078872  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>5:3380368112864  java.lang.String
>6:3231287755072  
> java.util.concurrent.ConcurrentLinkedQueue$Node
>7: 205015658048  [B
>8:1626495204768  java.util.UUID
>9:1592753822600  
> org.apache.geode.cache.lucene.internal.filesystem.ChunkKey
>   10:  56003787016  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>   11:10320  Trade
>   12:1034872483688  
> org.apache.geode.internal.cache.VMCachedDeserializable
>   13: 634942031808  java.util.HashMap$Node
>   14: 139741241616  [Ljava.util.HashMap$Node;
>   15: 254561221888  java.util.HashMap
>   16:  7396 843664  java.lang.Class
>   17: 10948 726856  [Ljava.lang.Object;
>   18: 11357 726848  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey2
>   19: 15856 634240  java.util.TreeMap$Entry
>   20:  1067 614992  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
> Total   2856366  118323456
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2796) NPE in ClassPathLoader

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart updated GEODE-2796:
-
Fix Version/s: 1.2.0

> NPE in ClassPathLoader
> --
>
> Key: GEODE-2796
> URL: https://issues.apache.org/jira/browse/GEODE-2796
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> It looks like an NPE was introduced by the fix for GEODE-2290:
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.geode.internal.ClassPathLoader.getResource(ClassPathLoader.java:130)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:239)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:264)
> at 
> org.apache.geode.internal.GemFireVersion$VersionDescription.(GemFireVersion.java:191)
> at 
> org.apache.geode.internal.GemFireVersion.getDescription(GemFireVersion.java:52)
> at 
> org.apache.geode.internal.GemFireVersion.getGemFireVersion(GemFireVersion.java:66)
> at org.apache.geode.cache.CacheFactory.getVersion(CacheFactory.java:305)
> ...
> {noformat}
> This is caused by the following method: 
> {noformat}
>  private List getClassLoaders() {
> ArrayList classLoaders = new ArrayList<>();
> if (!excludeTCCL) {
>   classLoaders.add(Thread.currentThread().getContextClassLoader());
> }
> classLoaders.add(classLoaderForDeployedJars);
> return classLoaders;
>   }
> {noformat}
> According to the JavaDocs, `getContextClassLoader()` actually returns null to 
> indicate the system class loader (rather than actually returning the system 
> class loader).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2796) NPE in ClassPathLoader

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-2796.
--
Resolution: Fixed

> NPE in ClassPathLoader
> --
>
> Key: GEODE-2796
> URL: https://issues.apache.org/jira/browse/GEODE-2796
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> It looks like an NPE was introduced by the fix for GEODE-2290:
> {noformat}
> Caused by: java.lang.NullPointerException
> at 
> org.apache.geode.internal.ClassPathLoader.getResource(ClassPathLoader.java:130)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:239)
> at 
> org.apache.geode.internal.ClassPathLoader.getResourceAsStream(ClassPathLoader.java:264)
> at 
> org.apache.geode.internal.GemFireVersion$VersionDescription.(GemFireVersion.java:191)
> at 
> org.apache.geode.internal.GemFireVersion.getDescription(GemFireVersion.java:52)
> at 
> org.apache.geode.internal.GemFireVersion.getGemFireVersion(GemFireVersion.java:66)
> at org.apache.geode.cache.CacheFactory.getVersion(CacheFactory.java:305)
> ...
> {noformat}
> This is caused by the following method: 
> {noformat}
>  private List getClassLoaders() {
> ArrayList classLoaders = new ArrayList<>();
> if (!excludeTCCL) {
>   classLoaders.add(Thread.currentThread().getContextClassLoader());
> }
> classLoaders.add(classLoaderForDeployedJars);
> return classLoaders;
>   }
> {noformat}
> According to the JavaDocs, `getContextClassLoader()` actually returns null to 
> indicate the system class loader (rather than actually returning the system 
> class loader).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2369) Exporting cluster-config with just a filename throws an NPE

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-2369.
--
Resolution: Fixed

> Exporting cluster-config with just a filename throws an NPE
> ---
>
> Key: GEODE-2369
> URL: https://issues.apache.org/jira/browse/GEODE-2369
> Project: Geode
>  Issue Type: Bug
>  Components: docs, gfsh, management
>Reporter: Kevin Duling
>Assignee: Jared Stewart
>  Labels: ClusterConfig, ExportClusterConfigurationCommand, 
> export, gfsh
>
> When running export cluster-configuration from gfsh and providing just a 
> filename rather than an absolute path, or a filename and the --dir parameter, 
> an exception is thrown.
> The {{--dir}} option appears to be unused.
> {noformat}
> [info 2017/01/25 13:10:08.436 PST locator1  Connection(3)-192.168.1.45> tid=0x46] (tid=70 msgId=67) Could not execute 
> "export
>  cluster-configuration --zip-file-name=cluster.zip --dir=/tmp".
> java.lang.NullPointerException
> at 
> org.apache.geode.management.internal.cli.commands.ExportImportClusterConfigurationCommands.exportSharedConfig(ExportImport
> ClusterConfigurationCommands.java:85)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.springframework.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:216)
> at 
> org.apache.geode.management.internal.cli.remote.RemoteExecutionStrategy.execute(RemoteExecutionStrategy.java:91)
> at 
> org.apache.geode.management.internal.cli.remote.CommandProcessor.executeCommand(CommandProcessor.java:117)
> at 
> org.apache.geode.management.internal.cli.remote.CommandStatementImpl.process(CommandStatementImpl.java:71)
> at 
> org.apache.geode.management.internal.cli.remote.MemberCommandService.processCommand(MemberCommandService.java:52)
> at 
> org.apache.geode.management.internal.beans.MemberMBeanBridge.processCommand(MemberMBeanBridge.java:1639)
> at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:404)
> at 
> org.apache.geode.management.internal.beans.MemberMBean.processCommand(MemberMBean.java:397)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
> at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)
> at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)
> at 
> com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)
> at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)
> at 
> com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)
> at 
> com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
> at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
> at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
> at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)
> at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doOperation(RMIConnectionImpl.java:1468)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.access$300(RMIConnectionImpl.java:76)
> at 
> javax.management.remote.rmi.RMIConnectionImpl$PrivilegedOperation.run(RMIConnectionImpl.java:1309)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.doPrivilegedOperation(RMIConnectionImpl.java:1401)
> at 
> javax.management.remote.rmi.RMIConnectionImpl.invoke(RMIConnectionImpl.java:829)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43

[jira] [Resolved] (GEODE-2730) Refactor ServerStarterRule and LocatorStarterRule

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-2730.
--
Resolution: Won't Fix

> Refactor ServerStarterRule and LocatorStarterRule
> -
>
> Key: GEODE-2730
> URL: https://issues.apache.org/jira/browse/GEODE-2730
> Project: Geode
>  Issue Type: Improvement
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
>
> Right now many tests that use ServerStarterRule and LocatorStarterRule are 
> flaky due to relying on default ports that intermittently cause 
> BindExceptions when those ports are in use. They also do not consistently use 
> the @Rule lifecycle to manage starting the member, but can optionally start 
> members when the rule is instantiated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-958) AgentUtilJUnitTest.testRESTApiExists failed with java.lang.AssertionError: GemFire REST API WAR File was not found

[Jared Stewart (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jared Stewart resolved GEODE-958.
-
Resolution: Fixed

> AgentUtilJUnitTest.testRESTApiExists failed with java.lang.AssertionError: 
> GemFire REST API WAR File was not found
> --
>
> Key: GEODE-958
> URL: https://issues.apache.org/jira/browse/GEODE-958
> Project: Geode
>  Issue Type: Bug
>  Components: rest (dev)
>Reporter: Hitesh Khamesra
>Assignee: Jared Stewart
>  Labels: ci
> Fix For: 1.0.0-incubating.M2
>
>
> java.lang.AssertionError: GemFire REST API WAR File was not found
>   at org.junit.Assert.fail(Assert.java:88)
>   at org.junit.Assert.assertTrue(Assert.java:41)
>   at org.junit.Assert.assertNotNull(Assert.java:712)
>   at 
> com.gemstone.gemfire.management.internal.AgentUtilJUnitTest.testRESTApiExists(AgentUtilJUnitTest.java:55)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:105)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:56)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
>   at 
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
>   at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
>   at 
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
>   at 
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
>   at 
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
>   at 
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
>   at 
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
>   at 
> java.util.concurrent.ThreadP

[jira] [Created] (GEODE-2855) Document Rename Execution.withArgs to Execution.setArguments

[Joey McAllister (JIRA)]

Joey McAllister created GEODE-2855:
--

 Summary: Document Rename Execution.withArgs to 
Execution.setArguments
 Key: GEODE-2855
 URL: https://issues.apache.org/jira/browse/GEODE-2855
 Project: Geode
  Issue Type: Sub-task
  Components: docs
Reporter: Joey McAllister
 Fix For: 1.2.0


FunctionContext has a getArguments method. withArgs should be renamed to match.

See https://issues.apache.org/jira/browse/GEODE-728



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2854) GEODE REST API Docs Missing Authentication

[Michael Martell (JIRA)]

Michael Martell created GEODE-2854:
--

 Summary: GEODE REST API Docs Missing Authentication
 Key: GEODE-2854
 URL: https://issues.apache.org/jira/browse/GEODE-2854
 Project: Geode
  Issue Type: Task
  Components: docs
Reporter: Michael Martell


The REST API docs don't document how to do authentication. Looks like HEAD 
params "security-username" and "security-password" are supported but 
undocumented in the REST API.

There is a comment about REST auth in this link: 
https://geode.apache.org/docs/guide/11/managing/security/implementing_authentication.html




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2381) Make enums not get so mangled by Spotless

[Galen O'Sullivan (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan resolved GEODE-2381.
-
   Resolution: Fixed
 Assignee: Galen O'Sullivan
Fix Version/s: 1.2.0

> Make enums not get so mangled by Spotless
> -
>
> Key: GEODE-2381
> URL: https://issues.apache.org/jira/browse/GEODE-2381
> Project: Geode
>  Issue Type: Bug
>Reporter: Galen O'Sullivan
>Assignee: Galen O'Sullivan
> Fix For: 1.2.0
>
>
> Perhaps the worst example is in {{CacheXMLVersion}}:
> {code}
> GEMFIRE_3_0(CacheXml.VERSION_3_0, CacheXml.PUBLIC_ID_3_0, 
> CacheXml.SYSTEM_ID_3_0, null,
> null), GEMFIRE_4_0(CacheXml.VERSION_4_0, CacheXml.PUBLIC_ID_4_0, 
> CacheXml.SYSTEM_ID_4_0, null,
> null), GEMFIRE_4_1(CacheXml.VERSION_4_1, CacheXml.PUBLIC_ID_4_1, 
> CacheXml.SYSTEM_ID_4_1,
> null, null), GEMFIRE_5_0(CacheXml.VERSION_5_0, 
> CacheXml.PUBLIC_ID_5_0,
> CacheXml.SYSTEM_ID_5_0, null, null), 
> GEMFIRE_5_1(CacheXml.VERSION_5_1,
> CacheXml.PUBLIC_ID_5_1, CacheXml.SYSTEM_ID_5_1, null, 
> null), GEMFIRE_5_5(
> CacheXml.VERSION_5_5, CacheXml.PUBLIC_ID_5_5, 
> CacheXml.SYSTEM_ID_5_5,
> null, null), GEMFIRE_5_7(CacheXml.VERSION_5_7, 
> CacheXml.PUBLIC_ID_5_7,
> CacheXml.SYSTEM_ID_5_7, null, null), 
> GEMFIRE_5_8(CacheXml.VERSION_5_8,
> CacheXml.PUBLIC_ID_5_8, 
> CacheXml.SYSTEM_ID_5_8, null,
> null), GEMFIRE_6_0(CacheXml.VERSION_6_0, 
> CacheXml.PUBLIC_ID_6_0,
> CacheXml.SYSTEM_ID_6_0, null, null), 
> GEMFIRE_6_1(
> CacheXml.VERSION_6_1, 
> CacheXml.PUBLIC_ID_6_1,
> CacheXml.SYSTEM_ID_6_1, null, null), 
> GEMFIRE_6_5(
> CacheXml.VERSION_6_5, 
> CacheXml.PUBLIC_ID_6_5,
> CacheXml.SYSTEM_ID_6_5, null, 
> null), GEMFIRE_6_6(
> CacheXml.VERSION_6_6, 
> CacheXml.PUBLIC_ID_6_6,
> CacheXml.SYSTEM_ID_6_6, null, 
> null), GEMFIRE_7_0(
> CacheXml.VERSION_7_0, 
> CacheXml.PUBLIC_ID_7_0,
> CacheXml.SYSTEM_ID_7_0, 
> null,
> null), 
> GEMFIRE_8_0(CacheXml.VERSION_8_0,
> 
> CacheXml.PUBLIC_ID_8_0,
> 
> CacheXml.SYSTEM_ID_8_0, null,
> null), 
> GEMFIRE_8_1(CacheXml.VERSION_8_1,
> null, null,
> 
> CacheXml.SCHEMA_8_1_LOCATION,
> 
> CacheXml.GEMFIRE_NAMESPACE),
> {code}
> I'd love to just format these one per line. This can be done by changing a 
> single line in the Spotless eclipse formatter xml file (I'll put up a PR in 
> just a minute).
> I'm not sure how attached we are to using {{eclipse-java-google-style.xml}} 
> in the same format as upstream (where did it come from exactly?). I also 
> noticed that Google has [their own 
> tool|https://github.com/google/google-java-format] for formatting text. 
> Probably what we have is fine for now, and this modification will make it 
> better.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode issue #482: gfsh help now uses log4j log levels: update user guide

[davebarnes97]

Github user davebarnes97 commented on the issue:

https://github.com/apache/geode/pull/482
  
PR associated itself with a secondary ticket. Will re-post with an improved 
comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #482: gfsh help now uses log4j log levels: update user gu...

[davebarnes97]

Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/482


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2778) gfsh help now uses log4j log levels: update user guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991112#comment-15991112
 ] 

ASF GitHub Bot commented on GEODE-2778:
---

Github user davebarnes97 closed the pull request at:

https://github.com/apache/geode/pull/482


> gfsh help now uses log4j log levels: update user guide
> --
>
> Key: GEODE-2778
> URL: https://issues.apache.org/jira/browse/GEODE-2778
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Update the user guide to reflect this change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991128#comment-15991128
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 73db6e376696fdc9dd17a5f9df78c80545b5a60a in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=73db6e3 ]

GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #484: GEODE-2778: gfsh help now uses log4j log levels: up...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/484

GEODE-2778: gfsh help now uses log4j log levels: update user guide

Confined changes to gfsh commands, only.
Further changes may be needed for xml-based configs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2778

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #484






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2778) gfsh help now uses log4j log levels: update user guide

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991131#comment-15991131
 ] 

ASF GitHub Bot commented on GEODE-2778:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/484

GEODE-2778: gfsh help now uses log4j log levels: update user guide

Confined changes to gfsh commands, only.
Further changes may be needed for xml-based configs.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2778

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/484.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #484






> gfsh help now uses log4j log levels: update user guide
> --
>
> Key: GEODE-2778
> URL: https://issues.apache.org/jira/browse/GEODE-2778
> Project: Geode
>  Issue Type: Sub-task
>  Components: docs, gfsh
>Reporter: Dave Barnes
>Assignee: Dave Barnes
> Fix For: 1.2.0
>
>
> Update the user guide to reflect this change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114158965
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 ---
@@ -131,30 +131,41 @@ protected void initialize() {
 if (!hasInitialized) {
   /* create index region */
   dataRegion = getDataRegion();
-  // assert dataRegion != null;
-
-  repositoryManager = createRepositoryManager();
-
-  // create AEQ, AEQ listener and specify the listener to 
repositoryManager
-  createAEQ(dataRegion);
-
+  createLuceneListenersAndFileChunkRegions(
+  (AbstractPartitionedRepositoryManager) repositoryManager);
--- End diff --

More casting going on here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[upthewaterspout]

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114158872
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
 // create PR fileAndChunkRegion, but not to create its buckets for now
 final String fileRegionName = createFileRegionName();
 PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
-
-
-// create PR chunkRegion, but not to create its buckets for now
-
-// we will create RegionDirectories on the fly when data comes in
-HeterogeneousLuceneSerializer mapper = new 
HeterogeneousLuceneSerializer(getFieldNames());
-PartitionedRepositoryManager partitionedRepositoryManager =
-new PartitionedRepositoryManager(this, mapper);
 DM dm = 
this.cache.getInternalDistributedSystem().getDistributionManager();
 LuceneBucketListener lucenePrimaryBucketListener =
-new LuceneBucketListener(partitionedRepositoryManager, dm);
+new LuceneBucketListener((PartitionedRepositoryManager) 
partitionedRepositoryManager, dm);
--- End diff --

Having to cast is a bit of a bad smell here. It seems like either 
LuceneBucketListener should take an AbstractPartitionedRepositoryManager, or 
createLuceneListenersAndFileChunkRegions should have been passed in a 
PartitionRespositoryManager.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991141#comment-15991141
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114158872
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
 // create PR fileAndChunkRegion, but not to create its buckets for now
 final String fileRegionName = createFileRegionName();
 PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
-
-
-// create PR chunkRegion, but not to create its buckets for now
-
-// we will create RegionDirectories on the fly when data comes in
-HeterogeneousLuceneSerializer mapper = new 
HeterogeneousLuceneSerializer(getFieldNames());
-PartitionedRepositoryManager partitionedRepositoryManager =
-new PartitionedRepositoryManager(this, mapper);
 DM dm = 
this.cache.getInternalDistributedSystem().getDistributionManager();
 LuceneBucketListener lucenePrimaryBucketListener =
-new LuceneBucketListener(partitionedRepositoryManager, dm);
+new LuceneBucketListener((PartitionedRepositoryManager) 
partitionedRepositoryManager, dm);
--- End diff --

Having to cast is a bit of a bad smell here. It seems like either 
LuceneBucketListener should take an AbstractPartitionedRepositoryManager, or 
createLuceneListenersAndFileChunkRegions should have been passed in a 
PartitionRespositoryManager.


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991140#comment-15991140
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user upthewaterspout commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114158965
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 ---
@@ -131,30 +131,41 @@ protected void initialize() {
 if (!hasInitialized) {
   /* create index region */
   dataRegion = getDataRegion();
-  // assert dataRegion != null;
-
-  repositoryManager = createRepositoryManager();
-
-  // create AEQ, AEQ listener and specify the listener to 
repositoryManager
-  createAEQ(dataRegion);
-
+  createLuceneListenersAndFileChunkRegions(
+  (AbstractPartitionedRepositoryManager) repositoryManager);
--- End diff --

More casting going on here.


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114160633
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -47,18 +48,22 @@
   new ConcurrentHashMap();
 
   /** The user region for this index */
-  protected final PartitionedRegion userRegion;
+  protected PartitionedRegion userRegion = null;
   protected final LuceneSerializer serializer;
   protected final LuceneIndexImpl index;
   protected volatile boolean closed;
+  private CountDownLatch isDataRegionReady = new CountDownLatch(1);
--- End diff --

Should this be final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114161620
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

Nitpick isn't this representing that the repository is ready for use?  
Should rename the latch and method to reflect this, such as readyForUse and 
enableRepositoryForUse? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991154#comment-15991154
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114160633
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -47,18 +48,22 @@
   new ConcurrentHashMap();
 
   /** The user region for this index */
-  protected final PartitionedRegion userRegion;
+  protected PartitionedRegion userRegion = null;
   protected final LuceneSerializer serializer;
   protected final LuceneIndexImpl index;
   protected volatile boolean closed;
+  private CountDownLatch isDataRegionReady = new CountDownLatch(1);
--- End diff --

Should this be final?


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991155#comment-15991155
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114161620
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

Nitpick isn't this representing that the repository is ready for use?  
Should rename the latch and method to reflect this, such as readyForUse and 
enableRepositoryForUse? 


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58853: GEODE-2847: Get correct version tags for retried bulk operations

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58853/#review173479
---




geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
Line 685 (original), 689 (patched)


I see you have changed code to call this method.
So it should not longer be labelled as a "test method".



geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java
Line 6202 (original), 6213 (patched)


This type of code looks like it could have a race condition because it 
checks getEventTracker() to see if it is non-null and then calls a method on 
it. It makes you wonder if a race condition could exist in which it becomes 
null.

The only writer of the eventTracker field is "createEventTracker". It is 
implemented on both DistributedRegion and BucketRegion. I see no need for the 
BucketRegion impl since it is exactly the same as DistributedRegion and 
BucketRegion extends DistributedRegion.

I think some refactoring should be done to make eventTracker a final field 
but it does not need to be done for this ticket.


- Darrel Schneider


On April 28, 2017, 1:17 p.m., Eric Shu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58853/
> ---
> 
> (Updated April 28, 2017, 1:17 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, and Lynn 
> Gallinat.
> 
> 
> Bugs: GEODE-2847
> https://issues.apache.org/jira/browse/GEODE-2847
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Get correct version tags from recordedBulkOpVersionTags in eventTracker.
> Do not remove the recordedBulkOpVersionTags prematurely.
> Add the unit test which would fail without the fixes.
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/cache/EventTracker.java 
> 2ddfdc4 
>   geode-core/src/main/java/org/apache/geode/internal/cache/LocalRegion.java 
> 8c061b0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/PutAllPRMessage.java
>  27f5aa0 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/RemoveAllPRMessage.java
>  f4f6299 
>   
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProxyMembershipID.java
>  2cbf63b 
>   
> geode-core/src/test/java/org/apache/geode/internal/cache/EventTrackerTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58853/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114164780
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

I was under the impression that the latch is waiting before 
indexRepositories.compute in the computeRepositories method call hence the repo 
was not created yet. But the coutdown allows it to move ahead an compute the 
repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58682/#review173481
---


Ship it!




Ship It!

- Kirk Lund


On April 27, 2017, 6:30 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58682/
> ---
> 
> (Updated April 27, 2017, 6:30 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added unittests to capture failing behavior.
> 
> Corrected buildTable shifting columns when adding values with additional keys.
> 
> 
> Refactoring of DataCommandResult and DataCommandFunction
> 
> --
> 
> The majority of changes to DataCommandFunction and DataCommandResult are 
> refactoring.  Two ignored exceptions have been explicitly noted in the logger.
> 
> - In DataCommandFunction:423, there's an empty if block.  I imagine I should 
> remove that, since empty code is a waste.  Looking for it, I couldn't find 
> the comment-hinted separate method, though. Anyone familiar with this corner 
> of the code know if that actuall happens?
> 
> - Qualitative changes are in DataCommandResult.buildTable.  Items in the 
> table are scanned to build an agggregate key set, and those items missing any 
> of these keys are padded with `MISSING_VALUE`.
> 
> - I moved some of the more cumbersome blocks of code to subfunctions, but may 
> have done this more than necessary.  Opinions?
> 
> - Introduced DataCommandFunctionWithPDXJUnitTest to explicitly drive 
> development / note the bug in GEODE-2662.  Are there additional tests that 
> would fit naturally in this file?
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle f07444a 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
>  6324b5c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
>  423d781 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
>  bb77466 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/TabularResultData.java
>  e72654e 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  1af6261 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DataCommandFunctionWithPDXJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
>  ead1047 
> 
> 
> Diff: https://reviews.apache.org/r/58682/diff/5/
> 
> 
> Testing
> ---
> 
> Previous precheckin returned fully green.  Running with new refactoring but 
> expect no issues.  (Common last words.)
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991185#comment-15991185
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114164780
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

I was under the impression that the latch is waiting before 
indexRepositories.compute in the computeRepositories method call hence the repo 
was not created yet. But the coutdown allows it to move ahead an compute the 
repository.


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58849: GEODE-2840: add a DUnit test to test concurrent deploy

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58849/#review173482
---


Fix it, then Ship it!




Fix it and ship it!


geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
Lines 74 (patched)


You should null out the static variable as well:
```java
Invoke.invokeInEveryVM(() -> gfsh = null);
```


- Kirk Lund


On April 28, 2017, 6:02 p.m., Jinmei Liao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58849/
> ---
> 
> (Updated April 28, 2017, 6:02 p.m.)
> 
> 
> Review request for geode, Jared Stewart, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2840: add a DUnit test to test concurrent deploy
> 
> 
> Diffs
> -
> 
>   geode-core/src/main/java/org/apache/geode/internal/DeployedJar.java 
> f96863f66ab2c853567ba6ffdbe3da47c9bcbdb7 
>   geode-core/src/main/java/org/apache/geode/internal/JarDeployer.java 
> a65cd0f550a9cf5a93ae890c094e5f5c6e2908df 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ConcurrentDeployDUnitTest.java
>  PRE-CREATION 
>   geode-core/src/test/java/org/apache/geode/test/dunit/rules/JarFileRule.java 
> PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/LocatorServerStartupRule.java
>  34506c4fa803a1121c29d240ad7d7aa6a55dca99 
> 
> 
> Diff: https://reviews.apache.org/r/58849/diff/1/
> 
> 
> Testing
> ---
> 
> precheckin running
> 
> 
> Thanks,
> 
> Jinmei Liao
> 
>

Build failed in Jenkins: Geode-nightly #822

[Apache Jenkins Server]

See 

--
[...truncated 112.80 KB...]
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses
:geode-web:checkMissedTests
:geode-web:spotlessJavaCheck
:geode-web:spotlessCheck
:geode-web:test
:geode-web:check
:geode-web:build
:geode-web:distributedTest
:geode-web:flakyTest
:geode-web:integrationTest
:geode-web-api:assemble
:geode-web-api:compileTestJava
:geode-web-api:processTestResources UP-TO-DATE
:geode-web-api:testClasses
:geode-web-api:checkMissedTests
:geode-web-api:spotlessJavaCheck
:geode-web-api:spotlessCheck
:geode-web-api:test
:geode-web-api:check
:geode-web-api:build
:geode-web-api:distributedTest
:geode-web-api:flakyTest
:geode-web-api:integrationTest
:combineReports
All test reports at 

:extensions/geode-modules:precheckin
:extensions/geode-modules-assembly:precheckin
:extensions/geode-modules-session:precheckin
:extensions/geode-modules-session-internal:precheckin
:extensions/geode-modules-tomcat7:precheckin
:extensions/geode-modules-tomcat8:precheckin
:geode-assembly:precheckin
:geode-benchmarks:precheckin
:geode-common:precheckin
:geode-cq:precheckin

Re: Build failed in Jenkins: Geode-nightly #822

[Udo Kohlmeyer]

Am I reading this correctly... Do we need to provide more memory to 
gradle to complete the steps to publish the JUnit results?


Is this a problem that we would constantly face, as we add more and more 
"modules" to the Geode code base?


Should we maybe see this a chance to move some of the code (lucene and 
maybe redis) into their own repo?



On 5/1/17 11:06, Apache Jenkins Server wrote:

See 

--
[...truncated 112.80 KB...]
:geode-lucene:compileTestJavaNote: Some input files use or override a 
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote: 

 uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: 

 uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a deprecated 
API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:processTestResources UP-TO-DATE
:geode-web:testClasses
:geode-web:checkMissedTests
:geode-web:spotlessJavaCheck
:geode-web:spotlessCheck
:geode-web:test
:geode-web:check
:geode-web:build
:geode-web:distributedTest
:geode-web:flakyTest
:geode-web:integrationTest
:geode-web-api:assemble
:geode-web-api:compileTestJava
:geode-web-api:processTestResources UP-TO-DATE
:geode-web-api:testClasses
:geode-web-api:checkMissedTests
:geode-web-api:spotlessJavaCheck
:geode-web-api:spotlessCheck
:geode-web-api:test
:geode-web-api:check
:geode-web-api:build
:geode-web-api:distributedTest
:geode-web-api:flakyTest
:geode-web-api:integrationTest
:combineReports
All test reports at 

[jira] [Reopened] (GEODE-1988) CI failure: RegisterInterestKeysPRDUnitTest fails intermittently

[xiaojian zhou (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

xiaojian zhou reopened GEODE-1988:
--

It is reproduced in CI FlakeyTest #569 and #564

org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest
 > testParallelPropagationWithClientServer FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest$$Lambda$32/630572366.run
 in VM 7 running on Host 56dada81-012e-4ebc-6c30-8480d4e17975 with 8 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
at 
org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.testParallelPropagationWithClientServer(ParallelWANPropagationClientServerDUnitTest.java:56)

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
discovery failed.
at 
org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:191)
at 
org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:570)
at 
org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:805)
at 
org.apache.geode.cache.client.internal.RegisterInterestOp.execute(RegisterInterestOp.java:58)
at 
org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterest(ServerRegionProxy.java:362)
at 
org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3895)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3974)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3791)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3787)
at 
org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3783)
at 
org.apache.geode.internal.cache.wan.WANTestBase.createClientWithLocator(WANTestBase.java:2126)
at 
org.apache.geode.internal.cache.wan.parallel.ParallelWANPropagationClientServerDUnitTest.lambda$testParallelPropagationWithClientServer$998d73b4$1(ParallelWANPropagationClientServerDUnitTest.java:56)

Caused by:
org.apache.geode.cache.NoSubscriptionServersAvailableException: 
Primary discovery failed.


> CI failure: RegisterInterestKeysPRDUnitTest fails intermittently
> 
>
> Key: GEODE-1988
> URL: https://issues.apache.org/jira/browse/GEODE-1988
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Darrel Schneider
>  Labels: ci
>
> :geode-core:distributedTest
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest 
> > testRegisterCreatesInvalidEntry FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$18/601024495.run
>  in VM 3 running on Host 583dcf0e97d9 with 4 VMs
> Caused by:
> java.lang.AssertionError: failed while registering interest
> Caused by:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> Caused by:
> 
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary 
> discovery failed.
> 7578 tests completed, 1 failed, 588 skipped



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2856:


 Summary: CacheServerLauncherDUnitTest.testRebalance intermittently 
fails assertion for number of buckets
 Key: GEODE-2856
 URL: https://issues.apache.org/jira/browse/GEODE-2856
 Project: Geode
  Issue Type: Bug
  Components: tests
Reporter: Kirk Lund


This seems to fail intermittently:
{noformat}
org.apache.geode.internal.cache.CacheServerLauncherDUnitTest > testRebalance 
FAILED
java.lang.AssertionError: expected:<3> but was:<5>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:645)
at org.junit.Assert.assertEquals(Assert.java:631)
at 
org.apache.geode.internal.cache.CacheServerLauncherDUnitTest.testRebalance(CacheServerLauncherDUnitTest.java:428)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples pull request #6: Fix broken links to geode docs.

[sboorlagadda]

Github user sboorlagadda closed the pull request at:

https://github.com/apache/geode-examples/pull/6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2554) Geode incubator docs are still up

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991240#comment-15991240
 ] 

ASF GitHub Bot commented on GEODE-2554:
---

Github user sboorlagadda commented on the issue:

https://github.com/apache/geode-examples/pull/6
  
[GEODE-2554](https://issues.apache.org/jira/browse/GEODE-2554) addresses to 
fix the doc references issue and we would not need this fix.


> Geode incubator docs are still up
> -
>
> Key: GEODE-2554
> URL: https://issues.apache.org/jira/browse/GEODE-2554
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Galen O'Sullivan
>Assignee: Joey McAllister
>Priority: Minor
> Fix For: 1.2.0
>
>
> Search engines still direct users to the Geode incubating docs, which are at:
> https://geode.apache.org/docs/guide/basic_config/data_regions/managing_data_regions.html
> The most recent docs have an 11 in the URL:
> https://geode.apache.org/docs/guide/11/basic_config/data_regions/managing_data_regions.html
> The old docs should either be taken down, or the path made to refer to 
> whatever the latest docs are. That way visitors won't get stuck on an ever 
> increasingly stale docs site.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] geode-examples issue #6: Fix broken links to geode docs.

[sboorlagadda]

Github user sboorlagadda commented on the issue:

https://github.com/apache/geode-examples/pull/6
  
[GEODE-2554](https://issues.apache.org/jira/browse/GEODE-2554) addresses to 
fix the doc references issue and we would not need this fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Closed] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund closed GEODE-2856.


> CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for 
> number of buckets
> ---
>
> Key: GEODE-2856
> URL: https://issues.apache.org/jira/browse/GEODE-2856
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Kirk Lund
>
> This seems to fail intermittently:
> {noformat}
> org.apache.geode.internal.cache.CacheServerLauncherDUnitTest > testRebalance 
> FAILED
> java.lang.AssertionError: expected:<3> but was:<5>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.CacheServerLauncherDUnitTest.testRebalance(CacheServerLauncherDUnitTest.java:428)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (GEODE-2856) CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for number of buckets

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-2856.
--
Resolution: Won't Fix

Test does not exist

> CacheServerLauncherDUnitTest.testRebalance intermittently fails assertion for 
> number of buckets
> ---
>
> Key: GEODE-2856
> URL: https://issues.apache.org/jira/browse/GEODE-2856
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Reporter: Kirk Lund
>
> This seems to fail intermittently:
> {noformat}
> org.apache.geode.internal.cache.CacheServerLauncherDUnitTest > testRebalance 
> FAILED
> java.lang.AssertionError: expected:<3> but was:<5>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.CacheServerLauncherDUnitTest.testRebalance(CacheServerLauncherDUnitTest.java:428)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2857) Add getProcess to ProcessWrapper

[Kirk Lund (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-2857:


Assignee: Kirk Lund

> Add getProcess to ProcessWrapper
> 
>
> Key: GEODE-2857
> URL: https://issues.apache.org/jira/browse/GEODE-2857
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Adding an accessor to ProcessWrapper in order to expose the underlying 
> Process instance will allow tests more freedom when using ProcessWrapper for 
> forking of JVMs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (GEODE-2857) Add getProcess to ProcessWrapper

[Kirk Lund (JIRA)]

Kirk Lund created GEODE-2857:


 Summary: Add getProcess to ProcessWrapper
 Key: GEODE-2857
 URL: https://issues.apache.org/jira/browse/GEODE-2857
 Project: Geode
  Issue Type: Wish
  Components: tests
Reporter: Kirk Lund


Adding an accessor to ProcessWrapper in order to expose the underlying Process 
instance will allow tests more freedom when using ProcessWrapper for forking of 
JVMs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2857) Add getProcess to ProcessWrapper

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991251#comment-15991251
 ] 

ASF subversion and git services commented on GEODE-2857:


Commit c2e7d1fbcb59312631080491d5d217acb8d12203 in geode's branch 
refs/heads/develop from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c2e7d1f ]

GEODE-2857: add getProcess to ProcessWrapper for tests


> Add getProcess to ProcessWrapper
> 
>
> Key: GEODE-2857
> URL: https://issues.apache.org/jira/browse/GEODE-2857
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Adding an accessor to ProcessWrapper in order to expose the underlying 
> Process instance will allow tests more freedom when using ProcessWrapper for 
> forking of JVMs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Build failed in Jenkins: Geode-nightly #822

[Dan Smith]

I've usually seen this happen when one test logs a bunch of stuff, and
jenkins runs out memory trying to process that log. I don't think we should
reorganize repos because of jenkins issues - even if the # of tests were an
issue we could just create multiple jobs.

I'm not quite sure I see the value of moving lucene and redis into their
own repo. Maybe it cuts down on repo size, but it introduces a lot of
complexity for the release manager or someone trying to modify both
modules.

-Dan

On Mon, May 1, 2017 at 11:13 AM, Udo Kohlmeyer 
wrote:

> Am I reading this correctly... Do we need to provide more memory to gradle
> to complete the steps to publish the JUnit results?
>
> Is this a problem that we would constantly face, as we add more and more
> "modules" to the Geode code base?
>
> Should we maybe see this a chance to move some of the code (lucene and
> maybe redis) into their own repo?
>
>
>
> On 5/1/17 11:06, Apache Jenkins Server wrote:
>
>> See 
>>
>> --
>> [...truncated 112.80 KB...]
>> :geode-lucene:compileTestJavaNote: Some input files use or override a
>> deprecated API.
>> Note: Recompile with -Xlint:deprecation for details.
>> Note: Some input files use unchecked or unsafe operations.
>> Note: Recompile with -Xlint:unchecked for details.
>>
>> :geode-lucene:processTestResources
>> :geode-lucene:testClasses
>> :geode-lucene:checkMissedTests
>> :geode-lucene:spotlessJavaCheck
>> :geode-lucene:spotlessCheck
>> :geode-lucene:test
>> :geode-lucene:check
>> :geode-lucene:build
>> :geode-lucene:distributedTest
>> :geode-lucene:flakyTest
>> :geode-lucene:integrationTest
>> :geode-old-client-support:assemble
>> :geode-old-client-support:compileTestJava
>> :geode-old-client-support:processTestResources UP-TO-DATE
>> :geode-old-client-support:testClasses
>> :geode-old-client-support:checkMissedTests
>> :geode-old-client-support:spotlessJavaCheck
>> :geode-old-client-support:spotlessCheck
>> :geode-old-client-support:test
>> :geode-old-client-support:check
>> :geode-old-client-support:build
>> :geode-old-client-support:distributedTest
>> :geode-old-client-support:flakyTest
>> :geode-old-client-support:integrationTest
>> :geode-old-versions:javadoc UP-TO-DATE
>> :geode-old-versions:javadocJar
>> :geode-old-versions:sourcesJar
>> :geode-old-versions:signArchives SKIPPED
>> :geode-old-versions:assemble
>> :geode-old-versions:compileTestJava UP-TO-DATE
>> :geode-old-versions:processTestResources UP-TO-DATE
>> :geode-old-versions:testClasses UP-TO-DATE
>> :geode-old-versions:checkMissedTests UP-TO-DATE
>> :geode-old-versions:spotlessJavaCheck
>> :geode-old-versions:spotlessCheck
>> :geode-old-versions:test UP-TO-DATE
>> :geode-old-versions:check
>> :geode-old-versions:build
>> :geode-old-versions:distributedTest UP-TO-DATE
>> :geode-old-versions:flakyTest UP-TO-DATE
>> :geode-old-versions:integrationTest UP-TO-DATE
>> :geode-pulse:assemble
>> :geode-pulse:compileTestJavaNote: > /Geode-nightly/ws/geode-pulse/src/test/java/org/apache/
>> geode/tools/pulse/tests/ui/PulseBase.java> uses or overrides a
>> deprecated API.
>> Note: Recompile with -Xlint:deprecation for details.
>> Note: > src/test/java/org/apache/geode/tools/pulse/controllers/
>> PulseControllerJUnitTest.java> uses unchecked or unsafe operations.
>> Note: Recompile with -Xlint:unchecked for details.
>>
>> :geode-pulse:processTestResources
>> :geode-pulse:testClasses
>> :geode-pulse:checkMissedTests
>> :geode-pulse:spotlessJavaCheck
>> :geode-pulse:spotlessCheck
>> :geode-pulse:test
>> :geode-pulse:check
>> :geode-pulse:build
>> :geode-pulse:distributedTest
>> :geode-pulse:flakyTest
>> :geode-pulse:integrationTest
>> :geode-rebalancer:assemble
>> :geode-rebalancer:compileTestJava
>> :geode-rebalancer:processTestResources UP-TO-DATE
>> :geode-rebalancer:testClasses
>> :geode-rebalancer:checkMissedTests
>> :geode-rebalancer:spotlessJavaCheck
>> :geode-rebalancer:spotlessCheck
>> :geode-rebalancer:test
>> :geode-rebalancer:check
>> :geode-rebalancer:build
>> :geode-rebalancer:distributedTest
>> :geode-rebalancer:flakyTest
>> :geode-rebalancer:integrationTest
>> :geode-wan:assemble
>> :geode-wan:compileTestJavaNote: Some input files use or override a
>> deprecated API.
>> Note: Recompile with -Xlint:deprecation for details.
>> Note: Some input files use unchecked or unsafe operations.
>> Note: Recompile with -Xlint:unchecked for details.
>>
>> :geode-wan:processTestResources
>> :geode-wan:testClasses
>> :geode-wan:checkMissedTests
>> :geode-wan:spotlessJavaCheck
>> :geode-wan:spotlessCheck
>> :geode-wan:test
>> :geode-wan:check
>> :geode-wan:build
>> :geode-wan:distributedTest
>> :geode-wan:flakyTest
>> :geode-wan:integrationTest
>> :geode-web:assemble
>> :geode-web:compileTestJavaNote: Some input files use or override a
>> deprecated API.
>> Note: Recompile

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175681
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
 // create PR fileAndChunkRegion, but not to create its buckets for now
 final String fileRegionName = createFileRegionName();
 PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
-
-
-// create PR chunkRegion, but not to create its buckets for now
-
-// we will create RegionDirectories on the fly when data comes in
-HeterogeneousLuceneSerializer mapper = new 
HeterogeneousLuceneSerializer(getFieldNames());
-PartitionedRepositoryManager partitionedRepositoryManager =
-new PartitionedRepositoryManager(this, mapper);
 DM dm = 
this.cache.getInternalDistributedSystem().getDistributionManager();
 LuceneBucketListener lucenePrimaryBucketListener =
-new LuceneBucketListener(partitionedRepositoryManager, dm);
+new LuceneBucketListener((PartitionedRepositoryManager) 
partitionedRepositoryManager, dm);
--- End diff --

I made createLuceneListenerAndFileChunkRegion method take in 
PartitionedRepositoryManager
which removed all the casting in the LuceneIndexForPartitionRegion.java but 
I would like a suggestion on how to remove the casting in 
createLuceneListenersAndFileChunkRegions(  (PartitionedRepositoryManager) 
repositoryManager); in the LuceneIndexImpl.java file. As the repositoryManager 
is being created by createRepositoryManager() which creates  repository manager 
for both RawLuceneIndex as well as LuceneIndexForPartitionRegion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[nabarunnag]

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175765
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 ---
@@ -131,30 +131,41 @@ protected void initialize() {
 if (!hasInitialized) {
   /* create index region */
   dataRegion = getDataRegion();
-  // assert dataRegion != null;
-
-  repositoryManager = createRepositoryManager();
-
-  // create AEQ, AEQ listener and specify the listener to 
repositoryManager
-  createAEQ(dataRegion);
-
+  createLuceneListenersAndFileChunkRegions(
+  (AbstractPartitionedRepositoryManager) repositoryManager);
--- End diff --

Please refer to the comment above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991294#comment-15991294
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175765
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexImpl.java
 ---
@@ -131,30 +131,41 @@ protected void initialize() {
 if (!hasInitialized) {
   /* create index region */
   dataRegion = getDataRegion();
-  // assert dataRegion != null;
-
-  repositoryManager = createRepositoryManager();
-
-  // create AEQ, AEQ listener and specify the listener to 
repositoryManager
-  createAEQ(dataRegion);
-
+  createLuceneListenersAndFileChunkRegions(
+  (AbstractPartitionedRepositoryManager) repositoryManager);
--- End diff --

Please refer to the comment above


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991292#comment-15991292
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user nabarunnag commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114175681
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneIndexForPartitionedRegion.java
 ---
@@ -78,17 +87,9 @@ protected RepositoryManager createRepositoryManager() {
 // create PR fileAndChunkRegion, but not to create its buckets for now
 final String fileRegionName = createFileRegionName();
 PartitionAttributes partitionAttributes = 
dataRegion.getPartitionAttributes();
-
-
-// create PR chunkRegion, but not to create its buckets for now
-
-// we will create RegionDirectories on the fly when data comes in
-HeterogeneousLuceneSerializer mapper = new 
HeterogeneousLuceneSerializer(getFieldNames());
-PartitionedRepositoryManager partitionedRepositoryManager =
-new PartitionedRepositoryManager(this, mapper);
 DM dm = 
this.cache.getInternalDistributedSystem().getDistributionManager();
 LuceneBucketListener lucenePrimaryBucketListener =
-new LuceneBucketListener(partitionedRepositoryManager, dm);
+new LuceneBucketListener((PartitionedRepositoryManager) 
partitionedRepositoryManager, dm);
--- End diff --

I made createLuceneListenerAndFileChunkRegion method take in 
PartitionedRepositoryManager
which removed all the casting in the LuceneIndexForPartitionRegion.java but 
I would like a suggestion on how to remove the casting in 
createLuceneListenersAndFileChunkRegions(  (PartitionedRepositoryManager) 
repositoryManager); in the LuceneIndexImpl.java file. As the repositoryManager 
is being created by createRepositoryManager() which creates  repository manager 
for both RawLuceneIndex as well as LuceneIndexForPartitionRegion


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Build failed in Jenkins: Geode-nightly #822

[Udo Kohlmeyer]

Agree, multiple repos does introduce a higher amount of management for a 
release.


So... this is a discussion for the future then.

--Udo

On 5/1/17 11:33, Dan Smith wrote:

I've usually seen this happen when one test logs a bunch of stuff, and
jenkins runs out memory trying to process that log. I don't think we should
reorganize repos because of jenkins issues - even if the # of tests were an
issue we could just create multiple jobs.

I'm not quite sure I see the value of moving lucene and redis into their
own repo. Maybe it cuts down on repo size, but it introduces a lot of
complexity for the release manager or someone trying to modify both
modules.

-Dan

On Mon, May 1, 2017 at 11:13 AM, Udo Kohlmeyer 
wrote:


Am I reading this correctly... Do we need to provide more memory to gradle
to complete the steps to publish the JUnit results?

Is this a problem that we would constantly face, as we add more and more
"modules" to the Geode code base?

Should we maybe see this a chance to move some of the code (lucene and
maybe redis) into their own repo?



On 5/1/17 11:06, Apache Jenkins Server wrote:


See 

--
[...truncated 112.80 KB...]
:geode-lucene:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-lucene:processTestResources
:geode-lucene:testClasses
:geode-lucene:checkMissedTests
:geode-lucene:spotlessJavaCheck
:geode-lucene:spotlessCheck
:geode-lucene:test
:geode-lucene:check
:geode-lucene:build
:geode-lucene:distributedTest
:geode-lucene:flakyTest
:geode-lucene:integrationTest
:geode-old-client-support:assemble
:geode-old-client-support:compileTestJava
:geode-old-client-support:processTestResources UP-TO-DATE
:geode-old-client-support:testClasses
:geode-old-client-support:checkMissedTests
:geode-old-client-support:spotlessJavaCheck
:geode-old-client-support:spotlessCheck
:geode-old-client-support:test
:geode-old-client-support:check
:geode-old-client-support:build
:geode-old-client-support:distributedTest
:geode-old-client-support:flakyTest
:geode-old-client-support:integrationTest
:geode-old-versions:javadoc UP-TO-DATE
:geode-old-versions:javadocJar
:geode-old-versions:sourcesJar
:geode-old-versions:signArchives SKIPPED
:geode-old-versions:assemble
:geode-old-versions:compileTestJava UP-TO-DATE
:geode-old-versions:processTestResources UP-TO-DATE
:geode-old-versions:testClasses UP-TO-DATE
:geode-old-versions:checkMissedTests UP-TO-DATE
:geode-old-versions:spotlessJavaCheck
:geode-old-versions:spotlessCheck
:geode-old-versions:test UP-TO-DATE
:geode-old-versions:check
:geode-old-versions:build
:geode-old-versions:distributedTest UP-TO-DATE
:geode-old-versions:flakyTest UP-TO-DATE
:geode-old-versions:integrationTest UP-TO-DATE
:geode-pulse:assemble
:geode-pulse:compileTestJavaNote:  uses or overrides a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note:  uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-pulse:processTestResources
:geode-pulse:testClasses
:geode-pulse:checkMissedTests
:geode-pulse:spotlessJavaCheck
:geode-pulse:spotlessCheck
:geode-pulse:test
:geode-pulse:check
:geode-pulse:build
:geode-pulse:distributedTest
:geode-pulse:flakyTest
:geode-pulse:integrationTest
:geode-rebalancer:assemble
:geode-rebalancer:compileTestJava
:geode-rebalancer:processTestResources UP-TO-DATE
:geode-rebalancer:testClasses
:geode-rebalancer:checkMissedTests
:geode-rebalancer:spotlessJavaCheck
:geode-rebalancer:spotlessCheck
:geode-rebalancer:test
:geode-rebalancer:check
:geode-rebalancer:build
:geode-rebalancer:distributedTest
:geode-rebalancer:flakyTest
:geode-rebalancer:integrationTest
:geode-wan:assemble
:geode-wan:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-wan:processTestResources
:geode-wan:testClasses
:geode-wan:checkMissedTests
:geode-wan:spotlessJavaCheck
:geode-wan:spotlessCheck
:geode-wan:test
:geode-wan:check
:geode-wan:build
:geode-wan:distributedTest
:geode-wan:flakyTest
:geode-wan:integrationTest
:geode-web:assemble
:geode-web:compileTestJavaNote: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

:geode-web:pr

Remove keys from a PartitionedRegion

[Goutam Tadi]

Hi Team,

With +Bradford D Boyle 

We are trying to remove a set of keys from a `PartitionedRegion`.
Currently, we execute a function with `onRegion()`. Inside the function, we
call `PartitionRegionHelper.getLocalPrimaryData()` and use the returned
region to execute `region.removeAll(keys)`.

The problem we are facing is that is slow. Is there a faster way to remove
a set of keys from a partitioned region?

We are considering using `getDataStore().getAllLocalBucketRegions()` to get
the set of `BucketRegion`s and then using a thread pool to remove the keys
in parallel. Are there alternative approaches?

Thanks,
Goutam Tadi.
-- 
Regards,
*Goutam Tadi.*

Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
Howe, and Patrick Rhomberg.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

* misc cleanup of code where possible

I'm running full regression and precheckin. Sorry this is so many files -- I'm 
not sure this is even practical to review :/

I'd like to avoid any further cleanup and just get this committed asap to avoid 
conflicts. Let's hold off on throwing more changes on top of this if you see 
more lines of code in a file that you'd like cleaned up. I obviously want to 
fix problems in any code that I touched though!


Diffs
-

  
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
 fe16fc3bd85e5861205dcdac6583d32abe57fcac 
  
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
 20cfecac2aaafd09c04eb6115a0da9c99201927b 
  
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
 edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
  
extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
 4e9e9fdf63eba622a157138e8e164956c257f093 
  
geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
 112f2fa44478f00782bcb717d8cb75233c979dce 
  
geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
 520f7e245ca3493d54ac661da29f58a3dfc71189 
  geode-core/src/main/java/org/apache/geode/DataSerializer.java 
58518f4f5d43b3fe214a1218703360928efdee52 
  geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
  
geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
 f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
  
geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
 25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
  
geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
 ff6dd9d2088124203842a06d3a794e00a5636246 
  
geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
 951b364718f43c5efc85c0f0f0e5d54e24d87ced 
  
geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
 7025721180cb6b158cff4b21bfcea6549780ccd3 
  geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
  geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
b24bc2fc5ad39737e908f9df2704b62728222629 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
  geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
  geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
  geode-core/src/main/java/org/apache/geode/cache/Region.java 
3eef5438e78a94acd669764e88daaafe6f5fa388 
  geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
  
geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
 fded49f3c00772f38bac14bc57fa4614144930c1 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
 1a4052b27688c8e04addf6987ce39ea006f71cc5 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
 0def5d283e359b1766fc90dfa05903526c672b0b 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
 e799880d715ed1fba65df305cf37e92f27db54ea 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
 9252dc745b848ea7a5aa8793a1fdb3a3c004c7ee 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
e72cbff048b5a7ecb24594382d776feaa8e0f4bd 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientRegionFactoryImpl.java
 ef676673046c32f68558f85516c674f7dcc6e982 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionImpl.java
 a494138316d8538f3aebeffb7075bb2db33b6532 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecutablePool.java
 54521d52879088eeceea15a44933c909d536b76f 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionOp.java
 d32e0f41bd7a939241227137e2218eef72ccfc56 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteRegionFunctionOp.java

[GitHub] geode pull request #481: GEODE-2828: AEQ being created before the user regio...

[jhuynh1]

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114195735
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

ah ok, makes more sense, I think my mind mistook this method name with 
allowing the repo to do computation rather than allowing computing of repository


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2828) AEQ needs to be created before the user region

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991479#comment-15991479
 ] 

ASF GitHub Bot commented on GEODE-2828:
---

Github user jhuynh1 commented on a diff in the pull request:

https://github.com/apache/geode/pull/481#discussion_r114195735
  
--- Diff: 
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/AbstractPartitionedRepositoryManager.java
 ---
@@ -111,6 +121,10 @@ protected IndexRepository computeRepository(Integer 
bucketId) {
 return repo;
   }
 
+  protected void allowRepositoryComputation() {
--- End diff --

ah ok, makes more sense, I think my mind mistook this method name with 
allowing the repo to do computation rather than allowing computing of repository


> AEQ needs to be created before the user region
> --
>
> Key: GEODE-2828
> URL: https://issues.apache.org/jira/browse/GEODE-2828
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: nabarun
>
> Issue:
> Events are lost as the region is being created, because the AEQ gets created 
> after the user region is created, and the indexes are not being created via 
> AEQ.
> Solution:
> 1. AEQ being created before the user region.
> 2. Processing of lucene events are being halted by a countdown latch and 
> starts processing after the user region is created.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/
---

Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Repository: geode


Description
---

GEODE-2837: Start server creates specified working dir if necessary


Diffs
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
 b51505acde785582801920007eec7e38d2a0029d 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 0e681d725be25a4a8d9e5aa98d289ae07db8af55 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 a793235b45618bc4c95b56191f8c93712a8f7675 


Diff: https://reviews.apache.org/r/58891/diff/1/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58682/#review173509
---


Ship it!




Ship It!

- Jared Stewart


On April 27, 2017, 6:30 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58682/
> ---
> 
> (Updated April 27, 2017, 6:30 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added unittests to capture failing behavior.
> 
> Corrected buildTable shifting columns when adding values with additional keys.
> 
> 
> Refactoring of DataCommandResult and DataCommandFunction
> 
> --
> 
> The majority of changes to DataCommandFunction and DataCommandResult are 
> refactoring.  Two ignored exceptions have been explicitly noted in the logger.
> 
> - In DataCommandFunction:423, there's an empty if block.  I imagine I should 
> remove that, since empty code is a waste.  Looking for it, I couldn't find 
> the comment-hinted separate method, though. Anyone familiar with this corner 
> of the code know if that actuall happens?
> 
> - Qualitative changes are in DataCommandResult.buildTable.  Items in the 
> table are scanned to build an agggregate key set, and those items missing any 
> of these keys are padded with `MISSING_VALUE`.
> 
> - I moved some of the more cumbersome blocks of code to subfunctions, but may 
> have done this more than necessary.  Opinions?
> 
> - Introduced DataCommandFunctionWithPDXJUnitTest to explicitly drive 
> development / note the bug in GEODE-2662.  Are there additional tests that 
> would fit naturally in this file?
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle f07444a 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
>  6324b5c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
>  423d781 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
>  bb77466 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/TabularResultData.java
>  e72654e 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  1af6261 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DataCommandFunctionWithPDXJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
>  ead1047 
> 
> 
> Diff: https://reviews.apache.org/r/58682/diff/5/
> 
> 
> Testing
> ---
> 
> Previous precheckin returned fully green.  Running with new refactoring but 
> expect no issues.  (Common last words.)
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173501
---




geode-core/src/main/java/org/apache/geode/cache/query/internal/index/CompactRangeIndex.java
Line 1388 (original), 1306 (patched)


This could introduce new suspect string or Alert.



geode-core/src/main/java/org/apache/geode/internal/cache/DistributedRegion.java
Line 201 (original), 244 (patched)


Delete this TODO



geode-core/src/main/java/org/apache/geode/internal/cache/PartitionAttributesImpl.java
Line 353 (original), 352 (patched)


Remove the wrapped CloneNotSupportException. This could cause unexpected 
suspect strings or weird regression failures.



geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
Lines 5746 (patched)


Do NOT wrap e here. This may introduce weird failures.



geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
Lines 8458 (patched)


Do NOT wrap ex when throwing here. This may introduce new suspect strings 
or unexpected regression failures.



geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java
Line 9818 (original), 9573 (patched)


Add TODO about not wrapping RegionDestroyedException here


- Kirk Lund


On May 1, 2017, 7:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 7:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf8

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Darrel Schneider]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173512
---



For all the RegionEntry subclasses do the following:
 * Do not modify this class. It was generated. Instead modify 
LeafRegionEntry.cpp and then run
 * ./dev-tools/generateRegionEntryClasses.sh (it must be run from the top level 
directory).

- Darrel Schneider


On May 1, 2017, 12:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 12:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  1a4052b27688c8e04addf6987ce39ea006f71cc5 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  0def5d283e359b1766fc90dfa05903526c672b0b 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
>  e799880d715ed1fba65df305cf37e92f27db54ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
>  9252dc

Re: Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary

[Jinmei Liao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/#review173513
---



According to the documentation on this --dir: Specify the directory in which 
the server will run in. This directory is written to the location where you 
started. It sounds like this dir needs to be a relative path and always under 
where gfsh is started. Not sure if this is the case after your fix.

Probably add a test where you specify a relative path and make sure it's 
created under where gfsh started?

- Jinmei Liao


On May 1, 2017, 8:43 p.m., Jared Stewart wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58891/
> ---
> 
> (Updated May 1, 2017, 8:43 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick 
> Rhomberg.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2837: Start server creates specified working dir if necessary
> 
> 
> Diffs
> -
> 
>   
> geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
>  b51505acde785582801920007eec7e38d2a0029d 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
>  0e681d725be25a4a8d9e5aa98d289ae07db8af55 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
>  a793235b45618bc4c95b56191f8c93712a8f7675 
> 
> 
> Diff: https://reviews.apache.org/r/58891/diff/1/
> 
> 
> Testing
> ---
> 
> Precheckin started (still running)
> 
> 
> Thanks,
> 
> Jared Stewart
> 
>

[jira] [Commented] (GEODE-2848) While destroying a LuceneIndex, the AsyncEventQueue region is destroyed in remote members before stopping the AsyncEventQueue

[xiaojian zhou (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991583#comment-15991583
 ] 

xiaojian zhou commented on GEODE-2848:
--

I think it does not worth to introduce complexity of new message or re-arrange 
the message processing sequence. 

But the regionToDispatchedKeysMap will be cleared and temp will be lost, so the 
secondary at remote site will not receive the ParallelQueueRemovalMessage. 

There's a conservative simple fix:
In getAllRecipients(), we need to find the region is gone and return empty set. 
When found recipients.isEmpty(), call regionToDispatchedKeysMap.putAll(temp)

> While destroying a LuceneIndex, the AsyncEventQueue region is destroyed in 
> remote members before stopping the AsyncEventQueue
> -
>
> Key: GEODE-2848
> URL: https://issues.apache.org/jira/browse/GEODE-2848
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
>
> This causes a NullPointerException in BatchRemovalThread getAllRecipients 
> like:
> {noformat}
> [fine 2017/04/24 14:27:29.163 PDT gemfire4_r02-s28_3222  
> tid=0x6b] BatchRemovalThread: ignoring exception
> java.lang.NullPointerException
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.getAllRecipients(ParallelGatewaySenderQueue.java:1776)
>   at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue$BatchRemovalThread.run(ParallelGatewaySenderQueue.java:1722)
> {noformat}
> This message is currently only logged at fine level and doesn't cause any 
> real issues.
> The simple fix is to check for null in getAllRecipients like:
> {noformat}
> PartitionedRegion pReg = ((PartitionedRegion) (cache.getRegion((String) pr)));
> if (pReg != null) {
>   recipients.addAll(pReg.getRegionAdvisor().adviseDataStore());
> }
> {noformat}
> Another more complex fix is to change the destroyIndex sequence.
> The current destroyIndex sequence is:
> # stops and destroys the AEQ in the initiator (including the underlying PR)
> # closes the repository manager in the initiator
> # stops and destroys the AEQ in remote members (not including the underlying 
> PR)
> # closes the repository manager in the remote members
> # destroys the fileAndChunk region in the initiator
> Between steps 1 and 3, the region will be null in the remote members, so the 
> NPE can occur.
> A better sequence would be:
> # stops the AEQ in the initiator
> # stops the AEQ in remote members
> # closes the repository manager in the initiator
> # closes the repository manager in the remote members
> # destroys the AEQ in the initiator (including the underlying PR) 
> # destroys the AEQ in the remote members (not including the underlying PR)
> # destroys the fileAndChunk region in the initiator
> That would be 3 messages between the members.
> I think that can be combined into one remote message like:
> # stops the AEQ in the initiator
> # closes the repository manager in the initiator
> # stops the AEQ in remote members
> # closes the repository manager in the remote members
> # destroys the AEQ in the remote members (not including the underlying PR)
> # destroys the AEQ in the initiator (including the underlying PR) 
> # destroys the fileAndChunk region in the initiator



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2854) GEODE REST API Docs Missing Authentication

[Michael Martell (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-2854:
---
Description: 
The REST API docs don't document how to do authentication. Looks like HEAD 
params "security-username" and "security-password" are supported but 
undocumented in the REST API.

There is a comment about REST auth in this link: 
https://geode.apache.org/docs/guide/11/managing/security/implementing_authentication.html

Also, the docs seem to imply that you pass usr/passwd in the http headers such 
as 'security-username' and 'security-password'. However, it only works using 
HTTP Basic Authentication, which Spring must be translating on the server side 
into the 'security-username' and 'security-password' params.


  was:
The REST API docs don't document how to do authentication. Looks like HEAD 
params "security-username" and "security-password" are supported but 
undocumented in the REST API.

There is a comment about REST auth in this link: 
https://geode.apache.org/docs/guide/11/managing/security/implementing_authentication.html



> GEODE REST API Docs Missing Authentication
> --
>
> Key: GEODE-2854
> URL: https://issues.apache.org/jira/browse/GEODE-2854
> Project: Geode
>  Issue Type: Task
>  Components: docs
>Reporter: Michael Martell
>
> The REST API docs don't document how to do authentication. Looks like HEAD 
> params "security-username" and "security-password" are supported but 
> undocumented in the REST API.
> There is a comment about REST auth in this link: 
> https://geode.apache.org/docs/guide/11/managing/security/implementing_authentication.html
> Also, the docs seem to imply that you pass usr/passwd in the http headers 
> such as 'security-username' and 'security-password'. However, it only works 
> using HTTP Basic Authentication, which Spring must be translating on the 
> server side into the 'security-username' and 'security-password' params.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Remove keys from a PartitionedRegion

[Dan Smith]

That seems like it should do things fairly quickly. Are you executing the
function from a client? Did you find that using a function was actually
faster than just calling removeAll from the client? I think removeAll from
the client should send your keys in a single message, similar to your
function approach.

How many keys are you trying to remove? If you have a really large number
of keys, it might be better to batch up the keys. You could do multiple
removeAlls from the client, perhaps even in parallel.

-Dan

On Mon, May 1, 2017 at 12:19 PM, Goutam Tadi  wrote:

> Hi Team,
>
> With +Bradford D Boyle 
>
> We are trying to remove a set of keys from a `PartitionedRegion`.
> Currently, we execute a function with `onRegion()`. Inside the function, we
> call `PartitionRegionHelper.getLocalPrimaryData()` and use the returned
> region to execute `region.removeAll(keys)`.
>
> The problem we are facing is that is slow. Is there a faster way to remove
> a set of keys from a partitioned region?
>
> We are considering using `getDataStore().getAllLocalBucketRegions()` to
> get
> the set of `BucketRegion`s and then using a thread pool to remove the keys
> in parallel. Are there alternative approaches?
>
> Thanks,
> Goutam Tadi.
> --
> Regards,
> *Goutam Tadi.*
>

[jira] [Updated] (GEODE-2847) Retried bulk operation from client could not get applied version tag from the server and cause data inconsistency

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2847:
--
Labels: storage_2  (was: )

> Retried bulk operation from client could not get applied version tag from the 
> server and cause data inconsistency
> -
>
> Key: GEODE-2847
> URL: https://issues.apache.org/jira/browse/GEODE-2847
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Eric Shu
>Assignee: Eric Shu
>  Labels: storage_2
>
> Currently when bulk operation initiated from client failed due server 
> failure, it will retry to another server with same event ids. However, the 
> retried bulk operations may not get the version tags of the operations 
> already finished on the server. This leads to originating client cache failed 
> to apply these operations but servers and other clients would get those entry 
> operations and cause data inconsistency.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2829) VMRegionVersionVector allows/stores DiskStoreId as its member id

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2829:
--
Labels: storage_2  (was: )

> VMRegionVersionVector allows/stores DiskStoreId as its member id
> 
>
> Key: GEODE-2829
> URL: https://issues.apache.org/jira/browse/GEODE-2829
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Reporter: Anilkumar Gingade
>  Labels: storage_2
>
> The VMRegionVersionVector is a region version vector for regions without 
> persistent data. This region version vector suppose to allow the 
> InternalDistributedMember as the member id, but currently it allows both 
> DiskStoreId and InternalDistributedMember as member ids.
> This is in relation to ticket# GEODE-2802
> The issue can be reproduced by having persistent and non-persistent region in 
> the cluster (same region name). 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2827) ClientCacheFactory might ignore a provided PoolFactory

[Fred Krone (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-2827:
--
Component/s: (was: core)

> ClientCacheFactory might ignore a provided PoolFactory
> --
>
> Key: GEODE-2827
> URL: https://issues.apache.org/jira/browse/GEODE-2827
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Kirk Lund
>
> I found a weird double assignment of the GemFireCacheImpl variable 
> "poolFactory" that is most likely a bug. This might result in 
> ClientCacheFactory replacing a provided poolFactory with a default 
> poolFactory.
> {noformat}
> private PoolFactory poolFactory;
> {noformat}
> The constructor accepts an argument and sets it to that value:
> {noformat}
> private GemFireCacheImpl(boolean isClient, PoolFactory pf, DistributedSystem 
> system, CacheConfig cacheConfig, boolean asyncEventListeners, TypeRegistry 
> typeRegistry) {
>   this.isClient = isClient;
>   this.poolFactory = pf;
> {noformat}
> But then in "private void initialize()" it blindly sets it to null thus 
> wiping out whatever was passed in:
> {noformat}
> this.poolFactory = null;
> {noformat}
> Later during "private void initializeDeclarativeCache()" it calls 
> "determineDefaultPool()" but only if isClient is true:
> {noformat}
> if (this.poolFactory == null) {
>   Map pools = PoolManager.getAll();
>   if (pools.isEmpty()) {
> this.poolFactory = createDefaultPF();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991639#comment-15991639
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit a5af405693a6ccd0e7124a9d9b912f1a653d79f9 in geode's branch 
refs/heads/feature/GEM-1353 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a5af405 ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2840) add a dunit test to test concurrent deploy scenario

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991641#comment-15991641
 ] 

ASF subversion and git services commented on GEODE-2840:


Commit 8239fbd42cdefd0e78f04bf2795e15ee9e7d8988 in geode's branch 
refs/heads/feature/GEM-1353 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8239fbd ]

GEODE-2840: add a DUnit test to test concurrent deploy


> add a dunit test to test concurrent deploy scenario
> ---
>
> Key: GEODE-2840
> URL: https://issues.apache.org/jira/browse/GEODE-2840
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>
> as summary



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2823) The LuceneEventListener caues deserialized values to be stored in the entry when the region contains DataSerializable or Serializable values

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991642#comment-15991642
 ] 

ASF subversion and git services commented on GEODE-2823:


Commit 8da1ba353185c931d7d1626ca9e188b4f38d0761 in geode's branch 
refs/heads/feature/GEM-1353 from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8da1ba3 ]

GEODE-2823: The listener now forces a copy of the value to be made


> The LuceneEventListener caues deserialized values to be stored in the entry 
> when the region contains DataSerializable or Serializable values
> 
>
> Key: GEODE-2823
> URL: https://issues.apache.org/jira/browse/GEODE-2823
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If the {{Region}} contains {{DataSerializable}} or {{Serializable}} values, 
> then each {{RegionEntry}} contains a {{VMCachedDeserializable}}. When 
> {{LuceneEventListener.process}} calls {{entry.getValue()}}, the value is 
> deserialized and left in that state in the {{VMCachedDeserializable}}.
> Below is a live histogram for the no index test.
> {noformat}
>  num #instances #bytes  class name
> --
>1:1019016088544  [B
>2:115600056  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>3: 363463236272  [C
>4:10240  
> org.apache.geode.internal.cache.VMCachedDeserializable
>5:  3792 905488  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>6: 36161 867864  java.lang.String
>7:  6546 750464  java.lang.Class
>8:  8051 523264  [Ljava.lang.Object;
>9:  5151 453288  java.lang.reflect.Method
>   10:   704 405280  [J
>   11:  8390 402720  
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync
>   12: 11796 377472  
> java.util.concurrent.ConcurrentHashMap$Node
>   13: 11379 364128  java.util.HashMap$Node
>   14:   597 357552  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
>   15:  3409 319888  [Ljava.util.HashMap$Node;
>   16:  7754 310160  java.util.LinkedHashMap$Entry
>   17:  5817 279216  java.util.TreeMap
>   18:  4031 257984  java.util.concurrent.ConcurrentHashMap
>   19:  6385 255400  java.util.TreeMap$Entry
>   20: 13587 217392  java.lang.Object
> Total611397   28902304
> {noformat}
> Below is a live histogram for the index test. The main thing to notice 
> regarding this bug is the 10 Trade instances.
> {noformat}
>  num #instances #bytes  class name
> --
>1:338275   16181384  [C
>2:322931   15500688  
> org.apache.geode.internal.cache.TombstoneService$Tombstone
>3:220717   12360152  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapObjectKey
>4:197837   11078872  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>5:3380368112864  java.lang.String
>6:3231287755072  
> java.util.concurrent.ConcurrentLinkedQueue$Node
>7: 205015658048  [B
>8:1626495204768  java.util.UUID
>9:1592753822600  
> org.apache.geode.cache.lucene.internal.filesystem.ChunkKey
>   10:  56003787016  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>   11:10320  Trade
>   12:1034872483688  
> org.apache.geode.internal.cache.VMCachedDeserializable
>   13: 634942031808  java.util.HashMap$Node
>   14: 139741241616  [Ljava.util.HashMap$Node;
>   15: 254561221888  java.util.HashMap
>   16:  7396 843664  java.lang.Class
>   17: 10948 726856  [Ljava.lang.Object;
>   18: 11357 726848  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey2
>   19: 15856 634240  java.util.TreeMap$Entry
>   20:  1067 614992  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
> Total   2856366  118323456
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2857) Add getProcess to ProcessWrapper

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991644#comment-15991644
 ] 

ASF subversion and git services commented on GEODE-2857:


Commit c2e7d1fbcb59312631080491d5d217acb8d12203 in geode's branch 
refs/heads/feature/GEM-1353 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c2e7d1f ]

GEODE-2857: add getProcess to ProcessWrapper for tests


> Add getProcess to ProcessWrapper
> 
>
> Key: GEODE-2857
> URL: https://issues.apache.org/jira/browse/GEODE-2857
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Adding an accessor to ProcessWrapper in order to expose the underlying 
> Process instance will allow tests more freedom when using ProcessWrapper for 
> forking of JVMs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991643#comment-15991643
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 73db6e376696fdc9dd17a5f9df78c80545b5a60a in geode's branch 
refs/heads/feature/GEM-1353 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=73db6e3 ]

GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2795) Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991640#comment-15991640
 ] 

ASF subversion and git services commented on GEODE-2795:


Commit 953f1eebcb0a1615bc761b684463fe890abe5692 in geode's branch 
refs/heads/feature/GEM-1353 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=953f1ee ]

GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'


> Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest
> 
>
> Key: GEODE-2795
> URL: https://issues.apache.org/jira/browse/GEODE-2795
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> It looks like the nightly build is failing due to polluted DUnit vms.  
> (FastClassPathScanner uses the Path api instead of the File api, and while 
> File accepts modified values of System.getProperty("user.dir"), Path does 
> not).
> {noformat}
> :geode-core:distributedTest
> org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommandsDUnitTest
>  > testAlterRegionResetCacheListeners FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 908
> [error 2017/04/18 10:12:26.647 UTC  
> tid=0x5d9] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
>   at 
> org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
>   at 
> org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
>   at 
> org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
>   at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
>   at 
> org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
>   at 
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
>   at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   ... 1 more
> Caused by: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> ---
> Found suspect string in log4j at line 945
> [error 2017/04/18 10:12:26.671 UTC  
> tid=0x5b1] Could not deploy JAR file java.lang.RuntimeExcepti

Re: Review Request 58891: GEODE-2837: Start server creates specified working dir if necessary

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58891/
---

(Updated May 1, 2017, 10:16 p.m.)


Review request for geode, Jinmei Liao, Ken Howe, Kirk Lund, and Patrick 
Rhomberg.


Changes
---

Added test to verify behavior when the working dir is specified as a relative 
path.


Repository: geode


Description
---

GEODE-2837: Start server creates specified working dir if necessary


Diffs (updated)
-

  
geode-assembly/src/test/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommandsIntegrationTest.java
 b51505a 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java
 0e681d7 
  
geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java
 a793235 


Diff: https://reviews.apache.org/r/58891/diff/2/

Changes: https://reviews.apache.org/r/58891/diff/1-2/


Testing
---

Precheckin started (still running)


Thanks,

Jared Stewart

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173500
---



Posting my review in chunks. So far I've gotten through the first page of the 
list of diffs (out of 25!)

There are a number of javadoc formatting errors that look like they are 
artifacts from a global search and replace of \...\ with {@code...}


extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
Lines 132 (patched)


Would it clarify usage by naming this mBeanSessionStats or 
sessionStatsMBean instead of mBean which is a very generic sounding name?



geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java
Line 237 (original), 232 (patched)


{@code byteThreshold  should be
{@code byteThreshold}



geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java
Line 69 (original), 68 (patched)


delete line



geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java
Lines 76 (patched)


delete line


- Ken Howe


On May 1, 2017, 7:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 7:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/m

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #541 was SUCCESSFUL (with 1843 tests)

[Spring CI]

---
Spring Data GemFire > Nightly-ApacheGeode > #541 was successful.
---
Scheduled
1845 tests in total.

https://build.spring.io/browse/SGF-NAG-541/





--
This message is automatically generated by Atlassian Bamboo

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991729#comment-15991729
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit 73db6e376696fdc9dd17a5f9df78c80545b5a60a in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=73db6e3 ]

GEODE-2632: prevent ClassCastException from ConnectionCountProbe to Identifiable


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991724#comment-15991724
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit f1b14b0dda058ccdd6f82075edeb3fa62245c6ae in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=f1b14b0 ]

GEODE-2632: minor fixes from code review

* add TODO comments for some larger fixes from review


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2632) Integrated Security performance improvements

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991723#comment-15991723
 ] 

ASF subversion and git services commented on GEODE-2632:


Commit a48be603dbd135eaac3f79080b6457ca221dfa11 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a48be60 ]

GEODE-2632: make GemFireCacheImpl.getRegion(String) non-final

* mock getRegion(String) in ParallelQueueRemovalMessageJUnitTest


> Integrated Security performance improvements
> 
>
> Key: GEODE-2632
> URL: https://issues.apache.org/jira/browse/GEODE-2632
> Project: Geode
>  Issue Type: Improvement
>  Components: security
>Reporter: Jinmei Liao
>Assignee: Kirk Lund
>  Labels: performance
>
> There is a security check in Put65.cmdExecute() that, if removed, improved 
> the performance.
> The expense of this security call needs to be reduced in order to get the 
> performance back.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2723) remove "localCacheEnabled" dead code from PartitionedRegion

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991725#comment-15991725
 ] 

ASF subversion and git services commented on GEODE-2723:


Commit a5af405693a6ccd0e7124a9d9b912f1a653d79f9 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~adongre]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=a5af405 ]

GEODE-2723: Removed localCacheEnabled field, and associated dead code.
This closes #440

Signed-off-by: adongre 


> remove "localCacheEnabled" dead code from PartitionedRegion
> ---
>
> Key: GEODE-2723
> URL: https://issues.apache.org/jira/browse/GEODE-2723
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Avinash Dongre
> Fix For: 1.2.0
>
>
> The PartionedRegion class has a final field named "localCacheEnabled". It is 
> always false and never set to true. We have 5 methods that test for it being 
> true and do a bunch of stuff. This dead code should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-1597) gfsh parameters are not validated

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991722#comment-15991722
 ] 

ASF subversion and git services commented on GEODE-1597:


Commit 1fc0f0ca72705f5ea84ea67f0507bfcad515aacf in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~jinmeiliao]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=1fc0f0c ]

GEODE-1597: use Spring shell's parser and delete our own parsing code

* Use Spring's SimpleParser as a basis for command parsing
* reworked help/hint
* removing singleton CommandManager


> gfsh parameters are not validated
> -
>
> Key: GEODE-1597
> URL: https://issues.apache.org/jira/browse/GEODE-1597
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Reporter: Swapnil Bawaskar
>
> As a result of fixing GEODE-835, we now do not validate parameters passed 
> into gfsh. For example
> {noformat}
> >gfsh start locator foo --name=loc1
> {noformat}
> will succeed even though foo is not a valid parameter. All options are 
> correctly validated though, so:
> {noformat}
> >gfsh start locator --name=loc1 --foo
> {noformat}
> will result in an error.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2823) The LuceneEventListener caues deserialized values to be stored in the entry when the region contains DataSerializable or Serializable values

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991728#comment-15991728
 ] 

ASF subversion and git services commented on GEODE-2823:


Commit 8da1ba353185c931d7d1626ca9e188b4f38d0761 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~barry.oglesby]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8da1ba3 ]

GEODE-2823: The listener now forces a copy of the value to be made


> The LuceneEventListener caues deserialized values to be stored in the entry 
> when the region contains DataSerializable or Serializable values
> 
>
> Key: GEODE-2823
> URL: https://issues.apache.org/jira/browse/GEODE-2823
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Reporter: Barry Oglesby
> Fix For: 1.2.0
>
>
> If the {{Region}} contains {{DataSerializable}} or {{Serializable}} values, 
> then each {{RegionEntry}} contains a {{VMCachedDeserializable}}. When 
> {{LuceneEventListener.process}} calls {{entry.getValue()}}, the value is 
> deserialized and left in that state in the {{VMCachedDeserializable}}.
> Below is a live histogram for the no index test.
> {noformat}
>  num #instances #bytes  class name
> --
>1:1019016088544  [B
>2:115600056  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>3: 363463236272  [C
>4:10240  
> org.apache.geode.internal.cache.VMCachedDeserializable
>5:  3792 905488  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>6: 36161 867864  java.lang.String
>7:  6546 750464  java.lang.Class
>8:  8051 523264  [Ljava.lang.Object;
>9:  5151 453288  java.lang.reflect.Method
>   10:   704 405280  [J
>   11:  8390 402720  
> java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync
>   12: 11796 377472  
> java.util.concurrent.ConcurrentHashMap$Node
>   13: 11379 364128  java.util.HashMap$Node
>   14:   597 357552  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
>   15:  3409 319888  [Ljava.util.HashMap$Node;
>   16:  7754 310160  java.util.LinkedHashMap$Entry
>   17:  5817 279216  java.util.TreeMap
>   18:  4031 257984  java.util.concurrent.ConcurrentHashMap
>   19:  6385 255400  java.util.TreeMap$Entry
>   20: 13587 217392  java.lang.Object
> Total611397   28902304
> {noformat}
> Below is a live histogram for the index test. The main thing to notice 
> regarding this bug is the 10 Trade instances.
> {noformat}
>  num #instances #bytes  class name
> --
>1:338275   16181384  [C
>2:322931   15500688  
> org.apache.geode.internal.cache.TombstoneService$Tombstone
>3:220717   12360152  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapObjectKey
>4:197837   11078872  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey1
>5:3380368112864  java.lang.String
>6:3231287755072  
> java.util.concurrent.ConcurrentLinkedQueue$Node
>7: 205015658048  [B
>8:1626495204768  java.util.UUID
>9:1592753822600  
> org.apache.geode.cache.lucene.internal.filesystem.ChunkKey
>   10:  56003787016  
> [Lorg.apache.geode.internal.util.concurrent.CustomEntryConcurrentHashMap$HashEntry;
>   11:10320  Trade
>   12:1034872483688  
> org.apache.geode.internal.cache.VMCachedDeserializable
>   13: 634942031808  java.util.HashMap$Node
>   14: 139741241616  [Ljava.util.HashMap$Node;
>   15: 254561221888  java.util.HashMap
>   16:  7396 843664  java.lang.Class
>   17: 10948 726856  [Ljava.lang.Object;
>   18: 11357 726848  
> org.apache.geode.internal.cache.VersionedThinRegionEntryHeapStringKey2
>   19: 15856 634240  java.util.TreeMap$Entry
>   20:  1067 614992  
> [Ljava.util.concurrent.ConcurrentHashMap$Node;
> Total   2856366  118323456
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2857) Add getProcess to ProcessWrapper

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991730#comment-15991730
 ] 

ASF subversion and git services commented on GEODE-2857:


Commit c2e7d1fbcb59312631080491d5d217acb8d12203 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~apa...@the9muses.net]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=c2e7d1f ]

GEODE-2857: add getProcess to ProcessWrapper for tests


> Add getProcess to ProcessWrapper
> 
>
> Key: GEODE-2857
> URL: https://issues.apache.org/jira/browse/GEODE-2857
> Project: Geode
>  Issue Type: Wish
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>
> Adding an accessor to ProcessWrapper in order to expose the underlying 
> Process instance will allow tests more freedom when using ProcessWrapper for 
> forking of JVMs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (GEODE-2840) add a dunit test to test concurrent deploy scenario

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991727#comment-15991727
 ] 

ASF subversion and git services commented on GEODE-2840:


Commit 8239fbd42cdefd0e78f04bf2795e15ee9e7d8988 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=8239fbd ]

GEODE-2840: add a DUnit test to test concurrent deploy


> add a dunit test to test concurrent deploy scenario
> ---
>
> Key: GEODE-2840
> URL: https://issues.apache.org/jira/browse/GEODE-2840
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>
> as summary



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58682: GEODE-2662: Missing keys cause columns to shift in gfsh table display.

[Ken Howe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58682/#review173528
---


Ship it!




Ship It!

- Ken Howe


On April 27, 2017, 6:30 p.m., Patrick Rhomberg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58682/
> ---
> 
> (Updated April 27, 2017, 6:30 p.m.)
> 
> 
> Review request for geode, Jinmei Liao, Jared Stewart, Ken Howe, Kirk Lund, 
> and Swapnil Bawaskar.
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> Added unittests to capture failing behavior.
> 
> Corrected buildTable shifting columns when adding values with additional keys.
> 
> 
> Refactoring of DataCommandResult and DataCommandFunction
> 
> --
> 
> The majority of changes to DataCommandFunction and DataCommandResult are 
> refactoring.  Two ignored exceptions have been explicitly noted in the logger.
> 
> - In DataCommandFunction:423, there's an empty if block.  I imagine I should 
> remove that, since empty code is a waste.  Looking for it, I couldn't find 
> the comment-hinted separate method, though. Anyone familiar with this corner 
> of the code know if that actuall happens?
> 
> - Qualitative changes are in DataCommandResult.buildTable.  Items in the 
> table are scanned to build an agggregate key set, and those items missing any 
> of these keys are padded with `MISSING_VALUE`.
> 
> - I moved some of the more cumbersome blocks of code to subfunctions, but may 
> have done this more than necessary.  Opinions?
> 
> - Introduced DataCommandFunctionWithPDXJUnitTest to explicitly drive 
> development / note the bug in GEODE-2662.  Are there additional tests that 
> would fit naturally in this file?
> 
> 
> Diffs
> -
> 
>   geode-core/build.gradle f07444a 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java
>  6324b5c 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DataCommandResult.java
>  423d781 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java
>  bb77466 
>   
> geode-core/src/main/java/org/apache/geode/management/internal/cli/result/TabularResultData.java
>  e72654e 
>   
> geode-core/src/test/java/org/apache/geode/cache/query/dunit/QueryDataInconsistencyDUnitTest.java
>  1af6261 
>   
> geode-core/src/test/java/org/apache/geode/management/internal/cli/functions/DataCommandFunctionWithPDXJUnitTest.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/org/apache/geode/test/dunit/rules/ServerStarterRule.java
>  ead1047 
> 
> 
> Diff: https://reviews.apache.org/r/58682/diff/5/
> 
> 
> Testing
> ---
> 
> Previous precheckin returned fully green.  Running with new refactoring but 
> expect no issues.  (Common last words.)
> 
> 
> Thanks,
> 
> Patrick Rhomberg
> 
>

[jira] [Commented] (GEODE-2795) Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991726#comment-15991726
 ] 

ASF subversion and git services commented on GEODE-2795:


Commit 953f1eebcb0a1615bc761b684463fe890abe5692 in geode's branch 
refs/heads/feature/GEODE-2632-10 from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=953f1ee ]

GEODE-2795: Clean up DUnit VMs after dynamically changing 'user.dir'


> Nightly build failure: CreateAlterDestroyRegionCommandsDUnitTest
> 
>
> Key: GEODE-2795
> URL: https://issues.apache.org/jira/browse/GEODE-2795
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Jared Stewart
>Assignee: Jared Stewart
> Fix For: 1.2.0
>
>
> It looks like the nightly build is failing due to polluted DUnit vms.  
> (FastClassPathScanner uses the Path api instead of the File api, and while 
> File accepts modified values of System.getProperty("user.dir"), Path does 
> not).
> {noformat}
> :geode-core:distributedTest
> org.apache.geode.management.internal.cli.commands.CreateAlterDestroyRegionCommandsDUnitTest
>  > testAlterRegionResetCacheListeners FAILED
> java.lang.AssertionError: Suspicious strings were written to the log 
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 908
> [error 2017/04/18 10:12:26.647 UTC  
> tid=0x5d9] Could not deploy JAR file java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
> java.lang.RuntimeException: java.lang.RuntimeException: 
> java.nio.file.NoSuchFileException: /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1115)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1143)
>   at 
> io.github.lukehutch.fastclasspathscanner.FastClasspathScanner.scan(FastClasspathScanner.java:1166)
>   at 
> org.apache.geode.internal.DeployedJar.findFunctionsInThisJar(DeployedJar.java:328)
>   at 
> org.apache.geode.internal.DeployedJar.loadClassesAndRegisterFunctions(DeployedJar.java:175)
>   at 
> org.apache.geode.internal.JarDeployer.registerNewVersions(JarDeployer.java:477)
>   at org.apache.geode.internal.JarDeployer.deploy(JarDeployer.java:516)
>   at 
> org.apache.geode.management.internal.cli.functions.DeployFunction.execute(DeployFunction.java:68)
>   at 
> org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(MemberFunctionStreamingMessage.java:191)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
>   at 
> org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:442)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:621)
>   at 
> org.apache.geode.distributed.internal.DistributionManager$9$1.run(DistributionManager.java:1067)
>   at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.RuntimeException: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:217)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:61)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   ... 1 more
> Caused by: java.nio.file.NoSuchFileException: 
> /tmp/junit3985345267510453893/server-1
>   at 
> sun.nio.fs.UnixException.translateToIOException(UnixException.java:86)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
>   at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
>   at sun.nio.fs.UnixPath.toRealPath(UnixPath.java:876)
>   at 
> io.github.lukehutch.fastclasspathscanner.scanner.Scanner.call(Scanner.java:215)
>   ... 5 more
> ---
> Found suspect string in log4j at line 945
> [error 2017/04/18 10:12:26.671 UTC  
> tid=0x5b1] Could not deploy JAR file java.lang.RuntimeEx

[jira] [Assigned] (GEODE-2843) User Guide - example should specify

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2843:
--

Assignee: Dave Barnes

> User Guide - example should specify 
> --
>
> Key: GEODE-2843
> URL: https://issues.apache.org/jira/browse/GEODE-2843
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> Excerpt from John Blum's response to a user's question:
> See the example here: 
> http://geode.apache.org/docs/guide/11/reference/topics/client-cache.html#cc-pdx
> Unfortunately, the example is WRONG, as it is using the "peer" cache element 
> tag ( instead of ), but this reference ([5]) is from 
> client-cache section...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173511
---




geode-core/src/main/java/org/apache/geode/internal/cache/ProxyRegionMap.java
Line 284 (original), 284 (patched)


Last arg was deleted (unused). Need to delete the comment.



geode-core/src/test/java/org/apache/geode/cache/query/CacheUtils.java
Line 77 (original), 80 (patched)


These AssertionError changes may cause unexpected IntegrationTest failures. 

DUnit should be ok because suspect grep would already pick up the printed 
stack traces.



geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueDUnitTest.java
Line 109 (original), 110 (patched)


Need to add TODO on this anonymous Exception


- Kirk Lund


On May 1, 2017, 7:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 7:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/sr

[GitHub] geode pull request #485: GEODE-2843 User Guide - example should specify

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/485

GEODE-2843 User Guide - example should specify 

Fixed multiple occurrences in the  reference.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #485


commit dd246bd58a0897eb65c2f55fdd60b2a6ed66e9b7
Author: Dave Barnes 
Date:   2017-05-01T23:34:36Z

GEODE-2843 User Guide - example should specify 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2843) User Guide - example should specify

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991796#comment-15991796
 ] 

ASF GitHub Bot commented on GEODE-2843:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/485

GEODE-2843 User Guide - example should specify 

Fixed multiple occurrences in the  reference.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #485


commit dd246bd58a0897eb65c2f55fdd60b2a6ed66e9b7
Author: Dave Barnes 
Date:   2017-05-01T23:34:36Z

GEODE-2843 User Guide - example should specify 




> User Guide - example should specify 
> --
>
> Key: GEODE-2843
> URL: https://issues.apache.org/jira/browse/GEODE-2843
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>
> Excerpt from John Blum's response to a user's question:
> See the example here: 
> http://geode.apache.org/docs/guide/11/reference/topics/client-cache.html#cc-pdx
> Unfortunately, the example is WRONG, as it is using the "peer" cache element 
> tag ( instead of ), but this reference ([5]) is from 
> client-cache section...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

> On May 1, 2017, 10:28 p.m., Ken Howe wrote:
> > geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java
> > Line 237 (original), 232 (patched)
> > 
> >
> > {@code byteThreshold  should be
> > {@code byteThreshold}

Yeah, looks like  was ignored because I had "Match Case" checked when I 
replaced  with }

I haven't found any others yet. What classes have these typos in them?


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173500
---


On May 1, 2017, 7:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 7:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  1a4052b27688c8e04addf6987ce39ea006f71cc5 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  0def5d283e359b1766fc90dfa05903526c672b0b 
>   
> geode-core/src/main/java/org/apache/ge

Re: Remove keys from a PartitionedRegion

[Goutam Tadi]

Hi Dan,

Thanks for the reply.
No, we are neither executing the function nor passing keys from a client.
We are trying to remove a significant portion of the keys from a region
(most, but not all) at once.

Thanks.

On Mon, May 1, 2017 at 2:40 PM Dan Smith  wrote:

> That seems like it should do things fairly quickly. Are you executing the
> function from a client? Did you find that using a function was actually
> faster than just calling removeAll from the client? I think removeAll from
> the client should send your keys in a single message, similar to your
> function approach.
>
> How many keys are you trying to remove? If you have a really large number
> of keys, it might be better to batch up the keys. You could do multiple
> removeAlls from the client, perhaps even in parallel.
>
> -Dan
>
> On Mon, May 1, 2017 at 12:19 PM, Goutam Tadi  wrote:
>
> > Hi Team,
> >
> > With +Bradford D Boyle 
> >
> > We are trying to remove a set of keys from a `PartitionedRegion`.
> > Currently, we execute a function with `onRegion()`. Inside the function,
> we
> > call `PartitionRegionHelper.getLocalPrimaryData()` and use the returned
> > region to execute `region.removeAll(keys)`.
> >
> > The problem we are facing is that is slow. Is there a faster way to
> remove
> > a set of keys from a partitioned region?
> >
> > We are considering using `getDataStore().getAllLocalBucketRegions()` to
> > get
> > the set of `BucketRegion`s and then using a thread pool to remove the
> keys
> > in parallel. Are there alternative approaches?
> >
> > Thanks,
> > Goutam Tadi.
> > --
> > Regards,
> > *Goutam Tadi.*
> >
>
-- 
Regards,
*Goutam Tadi.*

[jira] [Commented] (GEODE-2841) unable to create off-heap region from cache.xml

[Darrel Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991802#comment-15991802
 ] 

Darrel Schneider commented on GEODE-2841:
-

This is an xml parser issue.
If you changed your xml to this it will work:
{code}

http://geode.apache.org/schema/cache";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://geode.apache.org/schema/cache 
http://geode.apache.org/schema/cache/cache-1.0.xsd";
version="1.0">

  
  
   

{code}

The xsd allows each region to have 0 or MORE region-attributes elements. From 
my understanding of the XML parser code the last one wins. (See 
org.apache.geode.internal.cache.xmlcache.CacheXmlParser.endRegionAttributes()).

I do not understand how having multiple region-attribute elements in a region 
could be useful. I think instead of 0 or MORE it should have just been an 
optional (0 or 1) element.

The cache element can also have region-attributes sub-elements and in that case 
multiple makes sense.

I'm not sure if the cache.xsd should be changed or not some I'm changing the 
component to management.

> unable to create off-heap region from cache.xml
> ---
>
> Key: GEODE-2841
> URL: https://issues.apache.org/jira/browse/GEODE-2841
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Swapnil Bawaskar
>
> I defined a cache.xml as follows:
> {noformat}
> 
>  xmlns="http://geode.apache.org/schema/cache";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd";
> version="1.0">
>   
>   
>   
>
> 
> {noformat}
> But, this region is not configured for off-heap:
> {noformat}
> gfsh>describe region --name=/regionA
> ..
> Name: regionA
> Data Policy : partition
> Hosting Members : serv1
> Non-Default Attributes Shared By Hosting Members
>  Type  |Name | Value
> -- | --- | -
> Region | size| 0
>| data-policy | PARTITION
> {noformat}
> When the region is created from gfsh
> {noformat}
> gfsh>create region --name=regionB --type=PARTITION --off-heap
> {noformat}
> The region is configured for off-heap
> {noformat}
> gfsh>describe region --name=/regionB
> ..
> Name: regionB
> Data Policy : partition
> Hosting Members : serv1
> Non-Default Attributes Shared By Hosting Members
>   Type|   Name   | Value
> - |  | -
> Region| data-policy  | PARTITION
>   | size | 0
>   | off-heap | true
> Partition | local-max-memory | 3276
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (GEODE-2841) unable to create off-heap region from cache.xml

[Darrel Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider updated GEODE-2841:

Component/s: (was: offheap)
 management

> unable to create off-heap region from cache.xml
> ---
>
> Key: GEODE-2841
> URL: https://issues.apache.org/jira/browse/GEODE-2841
> Project: Geode
>  Issue Type: Bug
>  Components: management
>Reporter: Swapnil Bawaskar
>
> I defined a cache.xml as follows:
> {noformat}
> 
>  xmlns="http://geode.apache.org/schema/cache";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://geode.apache.org/schema/cache 
> http://geode.apache.org/schema/cache/cache-1.0.xsd";
> version="1.0">
>   
>   
>   
>
> 
> {noformat}
> But, this region is not configured for off-heap:
> {noformat}
> gfsh>describe region --name=/regionA
> ..
> Name: regionA
> Data Policy : partition
> Hosting Members : serv1
> Non-Default Attributes Shared By Hosting Members
>  Type  |Name | Value
> -- | --- | -
> Region | size| 0
>| data-policy | PARTITION
> {noformat}
> When the region is created from gfsh
> {noformat}
> gfsh>create region --name=regionB --type=PARTITION --off-heap
> {noformat}
> The region is configured for off-heap
> {noformat}
> gfsh>describe region --name=/regionB
> ..
> Name: regionB
> Data Policy : partition
> Hosting Members : serv1
> Non-Default Attributes Shared By Hosting Members
>   Type|   Name   | Value
> - |  | -
> Region| data-policy  | PARTITION
>   | size | 0
>   | off-heap | true
> Partition | local-max-memory | 3276
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

> On May 1, 2017, 9:14 p.m., Darrel Schneider wrote:
> > For all the RegionEntry subclasses do the following:
> >  * Do not modify this class. It was generated. Instead modify 
> > LeafRegionEntry.cpp and then run
> >  * ./dev-tools/generateRegionEntryClasses.sh (it must be run from the top 
> > level directory).

I've regenerated the RegionEntry classes and will be uploading a new diff soon. 
Looks like Bruce already modified the RegionEntry subclasses in such a way that 
the cpp is out of sync with the subclasses. I'll fix that as well.


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173512
---


On May 1, 2017, 7:59 p.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 1, 2017, 7:59 p.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  1a4052b27688c8e04addf6987ce39ea006f71cc5 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  0def5d283e359b1766fc

[GitHub] geode pull request #486: GEODE-2830 Required permission for executing a func...

[davebarnes97]

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/486

GEODE-2830 Required permission for executing a function should be 

DATA:WRITE
Simple typo correction

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2830

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #486


commit cb341752a8039e03c85ca8f9119e5d0930714fb1
Author: Dave Barnes 
Date:   2017-05-01T23:49:21Z

GEODE-2830 Required permission for executing a function should be DATA:WRITE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (GEODE-2830) Required permission for executing a function should be DATA:WRITE

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/GEODE-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991814#comment-15991814
 ] 

ASF GitHub Bot commented on GEODE-2830:
---

GitHub user davebarnes97 opened a pull request:

https://github.com/apache/geode/pull/486

GEODE-2830 Required permission for executing a function should be 

DATA:WRITE
Simple typo correction

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/davebarnes97/geode feature/GEODE-2830

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/geode/pull/486.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #486


commit cb341752a8039e03c85ca8f9119e5d0930714fb1
Author: Dave Barnes 
Date:   2017-05-01T23:49:21Z

GEODE-2830 Required permission for executing a function should be DATA:WRITE




> Required permission for executing a function should be DATA:WRITE
> -
>
> Key: GEODE-2830
> URL: https://issues.apache.org/jira/browse/GEODE-2830
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>
> The required permission for executing a function as listed in the gfsh 
> command table (2nd table) is wrong in the docs:
> http://gemfire.docs.pivotal.io/geode/managing/security/implementing_authorization.html
> It is listed as DATA:MANAGE in the gfsh command table, but should be 
> DATA:WRITE.
> The correct permission is listed in the client operation table above the gfsh 
> table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (GEODE-2830) Required permission for executing a function should be DATA:WRITE

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-2830:
--

Assignee: Dave Barnes

> Required permission for executing a function should be DATA:WRITE
> -
>
> Key: GEODE-2830
> URL: https://issues.apache.org/jira/browse/GEODE-2830
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Diane Hardman
>Assignee: Dave Barnes
>
> The required permission for executing a function as listed in the gfsh 
> command table (2nd table) is wrong in the docs:
> http://gemfire.docs.pivotal.io/geode/managing/security/implementing_authorization.html
> It is listed as DATA:MANAGE in the gfsh command table, but should be 
> DATA:WRITE.
> The correct permission is listed in the client operation table above the gfsh 
> table.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/
---

(Updated May 2, 2017, 12:06 a.m.)


Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
Howe, and Patrick Rhomberg.


Changes
---

Fixed all review issues so far. Also excluded the generated RegionEntry java 
files from diff.


Bugs: GEODE-2632
https://issues.apache.org/jira/browse/GEODE-2632


Repository: geode


Description
---

GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

* misc cleanup of code where possible

I'm running full regression and precheckin. Sorry this is so many files -- I'm 
not sure this is even practical to review :/

I'd like to avoid any further cleanup and just get this committed asap to avoid 
conflicts. Let's hold off on throwing more changes on top of this if you see 
more lines of code in a file that you'd like cleaned up. I obviously want to 
fix problems in any code that I touched though!


Diffs (updated)
-

  
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
 fe16fc3bd85e5861205dcdac6583d32abe57fcac 
  
extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
 20cfecac2aaafd09c04eb6115a0da9c99201927b 
  
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
 edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
  
extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
 4e9e9fdf63eba622a157138e8e164956c257f093 
  
geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
 112f2fa44478f00782bcb717d8cb75233c979dce 
  
geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
 520f7e245ca3493d54ac661da29f58a3dfc71189 
  geode-core/src/main/java/org/apache/geode/DataSerializer.java 
58518f4f5d43b3fe214a1218703360928efdee52 
  geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
  
geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
 f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
  
geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
 25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
  
geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
 ff6dd9d2088124203842a06d3a794e00a5636246 
  
geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
 951b364718f43c5efc85c0f0f0e5d54e24d87ced 
  
geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
 7025721180cb6b158cff4b21bfcea6549780ccd3 
  geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
  geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
b24bc2fc5ad39737e908f9df2704b62728222629 
  geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
  geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
  geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
  geode-core/src/main/java/org/apache/geode/cache/Region.java 
3eef5438e78a94acd669764e88daaafe6f5fa388 
  geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
  
geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
 fded49f3c00772f38bac14bc57fa4614144930c1 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
 1a4052b27688c8e04addf6987ce39ea006f71cc5 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
 0def5d283e359b1766fc90dfa05903526c672b0b 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
 e799880d715ed1fba65df305cf37e92f27db54ea 
  
geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java
 9252dc745b848ea7a5aa8793a1fdb3a3c004c7ee 
  
geode-core/src/main/java/org/apache/geode/cache/client/ClientCacheFactory.java 
e72cbff048b5a7ecb24594382d776feaa8e0f4bd 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ClientRegionFactoryImpl.java
 ef676673046c32f68558f85516c674f7dcc6e982 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ConnectionImpl.java
 a494138316d8538f3aebeffb7075bb2db33b6532 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecutablePool.java
 54521d52879088eeceea15a44933c909d536b76f 
  
geode-core/src/main/java/org/apache/geode/cache/client/internal/E

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Kirk Lund]

> On May 1, 2017, 11:34 p.m., Kirk Lund wrote:
> > geode-core/src/test/java/org/apache/geode/cache/query/CacheUtils.java
> > Line 77 (original), 80 (patched)
> > 
> >
> > These AssertionError changes may cause unexpected IntegrationTest 
> > failures. 
> > 
> > DUnit should be ok because suspect grep would already pick up the 
> > printed stack traces.

Keeping this one


- Kirk


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173511
---


On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 2, 2017, 12:06 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  1a4052b27688c8e04addf6987ce39ea006f71cc5 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  0def5d283e359b1766fc90dfa05903526c672b0b 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncq

Re: Remove keys from a PartitionedRegion

[Barry Oglesby]

Are you passing the keys as a filter or an argument? What does
optimizeForWrite in your function return?

Thanks,
Barry Oglesby


On Mon, May 1, 2017 at 4:41 PM, Goutam Tadi  wrote:

> Hi Dan,
>
> Thanks for the reply.
> No, we are neither executing the function nor passing keys from a client.
> We are trying to remove a significant portion of the keys from a region
> (most, but not all) at once.
>
> Thanks.
>
> On Mon, May 1, 2017 at 2:40 PM Dan Smith  wrote:
>
> > That seems like it should do things fairly quickly. Are you executing the
> > function from a client? Did you find that using a function was actually
> > faster than just calling removeAll from the client? I think removeAll
> from
> > the client should send your keys in a single message, similar to your
> > function approach.
> >
> > How many keys are you trying to remove? If you have a really large number
> > of keys, it might be better to batch up the keys. You could do multiple
> > removeAlls from the client, perhaps even in parallel.
> >
> > -Dan
> >
> > On Mon, May 1, 2017 at 12:19 PM, Goutam Tadi  wrote:
> >
> > > Hi Team,
> > >
> > > With +Bradford D Boyle 
> > >
> > > We are trying to remove a set of keys from a `PartitionedRegion`.
> > > Currently, we execute a function with `onRegion()`. Inside the
> function,
> > we
> > > call `PartitionRegionHelper.getLocalPrimaryData()` and use the
> returned
> > > region to execute `region.removeAll(keys)`.
> > >
> > > The problem we are facing is that is slow. Is there a faster way to
> > remove
> > > a set of keys from a partitioned region?
> > >
> > > We are considering using `getDataStore().getAllLocalBucketRegions()`
> to
> > > get
> > > the set of `BucketRegion`s and then using a thread pool to remove the
> > keys
> > > in parallel. Are there alternative approaches?
> > >
> > > Thanks,
> > > Goutam Tadi.
> > > --
> > > Regards,
> > > *Goutam Tadi.*
> > >
> >
> --
> Regards,
> *Goutam Tadi.*
>

Re: [gemfire-dev] New Client-Server Protocol Proposal

[Dan Smith]

I think any new client driver or server we develop might want to
incorporate function execution at lower level than region operations like
get and put, etc. We could then easily build operations like GET, PUT,
PUTALL, etc. on top of that by making them functions. The original client
protocol isn't designed like that because it pre-dates function execution.

The current function execution API is a little clunky and needs some work.
But what it does do is provide the fundamental logic to target operations
at members that host certain keys and retry in the case of failure.

The advantage of this approach is that if someone just builds a driver that
only supports function execution and whatever serialization framework is
required to serialize function arguments, they already have an API that
application developers could use to do pretty much anything they wanted to
do on the server. Having a Region object with methods like get and put on
it could just be a little syntatic sugar on top of that.

-Dan

On Fri, Apr 28, 2017 at 2:49 PM, Udo Kohlmeyer 
wrote:

> Hi there Geode community,
>
> The new Client-Server protocol proposal is available for review.
>
> It can be viewed and commented on https://cwiki.apache.org/confl
> uence/display/GEODE/New+Client+Server+Protocol
>
> --Udo
>
>

Re: Review Request 58888: GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache

[Jared Stewart]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review173543
---




geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
Line 466 (original), 491 (patched)


It looks like this method, here as well as in the parent interface 
`IndexProtocol` can safely accept `Collection c`.  This would 
eliminate the unchecked cast on 493.


- Jared Stewart


On May 2, 2017, 12:06 a.m., Kirk Lund wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5/
> ---
> 
> (Updated May 2, 2017, 12:06 a.m.)
> 
> 
> Review request for geode, Darrel Schneider, Jinmei Liao, Jared Stewart, Ken 
> Howe, and Patrick Rhomberg.
> 
> 
> Bugs: GEODE-2632
> https://issues.apache.org/jira/browse/GEODE-2632
> 
> 
> Repository: geode
> 
> 
> Description
> ---
> 
> GEODE-2632: change dependencies on GemFireCacheImpl to InternalCache
> 
> * misc cleanup of code where possible
> 
> I'm running full regression and precheckin. Sorry this is so many files -- 
> I'm not sure this is even practical to review :/
> 
> I'd like to avoid any further cleanup and just get this committed asap to 
> avoid conflicts. Let's hold off on throwing more changes on top of this if 
> you see more lines of code in a file that you'd like cleaned up. I obviously 
> want to fix problems in any code that I touched though!
> 
> 
> Diffs
> -
> 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/common/CacheProperty.java
>  fe16fc3bd85e5861205dcdac6583d32abe57fcac 
>   
> extensions/geode-modules-session-internal/src/main/java/org/apache/geode/modules/session/internal/filter/GemfireSessionManager.java
>  20cfecac2aaafd09c04eb6115a0da9c99201927b 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSessionManager.java
>  edc2b7d8bfc684257c27d90d4b8d0c4db378347d 
>   
> extensions/geode-modules/src/main/java/org/apache/geode/modules/util/CreateRegionFunction.java
>  4e9e9fdf63eba622a157138e8e164956c257f093 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCALocalTransaction.java
>  112f2fa44478f00782bcb717d8cb75233c979dce 
>   
> geode-core/src/jca/java/org/apache/geode/internal/ra/spi/JCAManagedConnection.java
>  520f7e245ca3493d54ac661da29f58a3dfc71189 
>   geode-core/src/main/java/org/apache/geode/DataSerializer.java 
> 58518f4f5d43b3fe214a1218703360928efdee52 
>   geode-core/src/main/java/org/apache/geode/admin/GemFireMemberStatus.java 
> 5b4e59ef341007a4e42cd5a10b4e8a2eb4d18deb 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/CacheHealthEvaluator.java
>  f7ff9ede1e074425ce7aa7bed1a63c72c5174bf6 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FinishBackupRequest.java
>  25abd7ee5d346d764d68339ae6c03b2cffc63bc8 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/FlushToDiskRequest.java
>  ff6dd9d2088124203842a06d3a794e00a5636246 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/MemberHealthEvaluator.java
>  951b364718f43c5efc85c0f0f0e5d54e24d87ced 
>   
> geode-core/src/main/java/org/apache/geode/admin/internal/PrepareBackupRequest.java
>  7025721180cb6b158cff4b21bfcea6549780ccd3 
>   geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java 
> 1a46f241a7b3a4bbbd47da70c227b3e3ea237fd0 
>   geode-core/src/main/java/org/apache/geode/cache/CacheClosedException.java 
> b24bc2fc5ad39737e908f9df2704b62728222629 
>   geode-core/src/main/java/org/apache/geode/cache/CacheFactory.java 
> 0772dcf86b3d3ea9eebfe1d324c8fa043fa8ac79 
>   geode-core/src/main/java/org/apache/geode/cache/DynamicRegionFactory.java 
> 57a1a465c1bd0d91d8bb83ad2b97db1f2efbb025 
>   geode-core/src/main/java/org/apache/geode/cache/GemFireCache.java 
> e60bc59a88051ac11a863ea10be3e2bf07e4cbe7 
>   geode-core/src/main/java/org/apache/geode/cache/Region.java 
> 3eef5438e78a94acd669764e88daaafe6f5fa388 
>   geode-core/src/main/java/org/apache/geode/cache/RegionFactory.java 
> 3a2e9f68c96f9e4aae5a837e175014a3598f69ea 
>   
> geode-core/src/main/java/org/apache/geode/cache/TransactionDataRebalancedException.java
>  fded49f3c00772f38bac14bc57fa4614144930c1 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueFactoryImpl.java
>  1a4052b27688c8e04addf6987ce39ea006f71cc5 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/AsyncEventQueueImpl.java
>  0def5d283e359b1766fc90dfa05903526c672b0b 
>   
> geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
>  e799880d715ed1fba65df305cf37e92f27db54ea 
>   
> geo

[jira] [Assigned] (GEODE-1996) There are confusing references to "multicast" for locators ports

[Dave Barnes (JIRA)]

 [ 
https://issues.apache.org/jira/browse/GEODE-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dave Barnes reassigned GEODE-1996:
--

Assignee: Dave Barnes

> There are confusing references to "multicast" for locators ports
> 
>
> Key: GEODE-1996
> URL: https://issues.apache.org/jira/browse/GEODE-1996
> Project: Geode
>  Issue Type: Bug
>  Components: docs
>Reporter: Udo Kohlmeyer
>Assignee: Dave Barnes
>
> The documentation seems to contain confusing terms when it comes to locators 
> and locators ports. In the documentation, we state that port the locator runs 
> on as a *multicast* port. This is incorrect as the multicast port is 
> configured by the property `mcast-port`.
> http://geode.docs.pivotal.io/docs/configuring/running/firewalls_ports.html - 
> mentions ??By default, if not otherwise specified, Geode locators use the 
> default multicast port 10334.??
> We might have to scour the documentation for the term multicast and validate 
> that this is the correct usage for that scenario



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: [gemfire-dev] New Client-Server Protocol Proposal

[Dan Smith]

I think the current proposal seems to be gloming some things together that
probably belong in different layers.

The message header currently is specified to have things like correlation
id, isPartial message, and also metdatadata about whether the key or the
value is JSON. Fragmenting messages (isPartialMessage) seems like it
belongs at a lower level, and depending on what transport your are using is
probably already handled (TCP, HTTP). Potentially similar issue for
request/response (correlationId)  - if you were going over http that would
already be handled. Whether a value is JSON seems like it belongs at a
higher level that specifies the value serialization format. Not to mention
not all messages have keys and values, and some have more than one.

If wonder if it would make more sense to organize the message structure
into layers that each have their own responsibility - a fragmentation layer
(maybe not necessary), a request/response layer (maybe not necessary, not
needed for all message types), function execution layer, individual
operations layer (put, get), value serialization layer.

Without having nailed down what underlying serialization framework you are
using, talking about field byte sizes, etc. seems a bit premature.

-Dan

On Fri, Apr 28, 2017 at 2:49 PM, Udo Kohlmeyer 
wrote:

> Hi there Geode community,
>
> The new Client-Server protocol proposal is available for review.
>
> It can be viewed and commented on https://cwiki.apache.org/confl
> uence/display/GEODE/New+Client+Server+Protocol
>
> --Udo
>
>