Re: [PR] [fix](Azure) Correct the truncated condition for Azure's list in FE [doris]
doris-robot commented on PR #37986: URL: https://github.com/apache/doris/pull/37986#issuecomment-2232573086 ClickBench: Total hot run time: 31.08 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit d073463abf7c6ac8d3b4f000ec3d493724b70212, data reload: false query1 0.040.040.02 query2 0.080.040.04 query3 0.230.050.05 query4 1.680.070.07 query5 0.480.500.50 query6 1.130.710.72 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.490.49 query10 0.540.540.55 query11 0.160.120.11 query12 0.160.130.12 query13 0.590.590.59 query14 0.750.780.78 query15 0.860.820.83 query16 0.360.370.36 query17 1.041.011.02 query18 0.220.220.22 query19 1.841.711.68 query20 0.010.010.01 query21 15.39 0.770.66 query22 4.456.652.30 query23 18.30 1.481.19 query24 2.050.240.22 query25 0.160.090.09 query26 0.300.220.21 query27 0.460.240.23 query28 13.30 1.021.00 query29 12.59 3.393.43 query30 0.250.060.07 query31 2.880.380.39 query32 3.260.470.48 query33 2.892.962.91 query34 17.10 4.394.31 query35 4.454.444.48 query36 0.640.480.47 query37 0.180.150.16 query38 0.150.140.15 query39 0.040.040.03 query40 0.150.130.13 query41 0.100.050.05 query42 0.060.040.05 query43 0.040.040.04 Total cold run time: 109.98 s Total hot run time: 31.08 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv) Support querying rewrite by materialized view when DML such as insert and insert overwrite [doris]
morrySnow commented on code in PR #37561:
URL: https://github.com/apache/doris/pull/37561#discussion_r1680527087
##
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##
@@ -560,10 +560,16 @@ public class SessionVariable implements Serializable,
Writable {
public static final String ENABLE_MATERIALIZED_VIEW_REWRITE
= "enable_materialized_view_rewrite";
+public static final String ENABLE_DML_MATERIALIZED_VIEW_REWRITE
+= "enable_dml_materialized_view_rewrite";
+
+public static final String
ENABLE_DML_MATERIALIZED_VIEW_REWRITE_WHEN_BASE_TABLE_UNAWARENESS
+=
"enable_dml_materialized_view_rewrite_when_base_table_unawareness";
Review Comment:
unawareness? is it a standard phrases?
##
fe/fe-core/src/main/java/org/apache/doris/nereids/NereidsPlanner.java:
##
@@ -286,6 +289,12 @@ private void analyze(boolean showPlanProcess) {
LOG.debug("Start analyze plan");
}
keepOrShowPlanProcess(showPlanProcess, () ->
cascadesContext.newAnalyzer().analyze());
+if
(this.cascadesContext.getConnectContext().getSessionVariable().isEnableDmlMaterializedViewRewrite()
Review Comment:
u should add a analysis rule and check do this in rule. move hooks from
NereidsPlanner into StatementContext
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](fe) Fix `removeDroppedMember` use incorrect `nodeName` [doris]
doris-robot commented on PR #37987: URL: https://github.com/apache/doris/pull/37987#issuecomment-2232577593 ClickBench: Total hot run time: 30.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 467bac43b4d8ac4934f3743e7863643fc696f54e, data reload: false query1 0.040.040.03 query2 0.070.040.04 query3 0.220.040.04 query4 1.670.070.07 query5 0.520.490.50 query6 1.140.720.72 query7 0.020.020.01 query8 0.050.040.04 query9 0.560.490.49 query10 0.560.550.54 query11 0.150.110.12 query12 0.140.120.13 query13 0.600.590.59 query14 0.750.780.77 query15 0.850.810.81 query16 0.360.370.35 query17 0.980.951.01 query18 0.220.220.21 query19 1.811.651.67 query20 0.020.010.01 query21 15.39 0.750.67 query22 4.436.831.92 query23 18.69 1.381.25 query24 2.160.220.22 query25 0.160.090.09 query26 0.300.210.22 query27 0.460.230.23 query28 13.30 1.011.00 query29 12.56 3.363.31 query30 0.250.060.05 query31 2.860.390.39 query32 3.290.470.46 query33 2.872.892.93 query34 17.18 4.384.37 query35 4.454.434.43 query36 0.640.460.47 query37 0.180.160.16 query38 0.160.160.15 query39 0.040.030.04 query40 0.150.120.11 query41 0.100.040.05 query42 0.060.040.04 query43 0.050.040.03 Total cold run time: 110.46 s Total hot run time: 30.55 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](delete) fix delete random distributed tbl [doris]
doris-robot commented on PR #37985: URL: https://github.com/apache/doris/pull/37985#issuecomment-2232577655 ClickBench: Total hot run time: 30.69 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 59e20f735c3dc4163c1b2bdef8edb80c79e417e5, data reload: false query1 0.040.030.04 query2 0.090.040.04 query3 0.220.050.06 query4 1.660.070.06 query5 0.480.480.47 query6 1.140.730.73 query7 0.020.010.02 query8 0.050.040.05 query9 0.550.490.50 query10 0.540.550.58 query11 0.160.110.12 query12 0.150.120.13 query13 0.590.580.58 query14 0.750.800.78 query15 0.860.810.81 query16 0.340.380.37 query17 1.011.010.97 query18 0.220.220.22 query19 1.931.771.71 query20 0.020.010.00 query21 15.39 0.750.66 query22 3.887.931.93 query23 18.66 1.291.26 query24 2.110.220.22 query25 0.150.090.09 query26 0.290.210.22 query27 0.460.230.23 query28 13.25 1.021.01 query29 12.58 3.373.37 query30 0.250.060.06 query31 2.860.390.38 query32 3.280.470.46 query33 2.892.872.90 query34 16.93 4.364.34 query35 4.444.424.48 query36 0.640.470.47 query37 0.190.160.15 query38 0.140.140.15 query39 0.040.040.04 query40 0.150.120.12 query41 0.090.040.05 query42 0.050.050.05 query43 0.050.040.03 Total cold run time: 109.59 s Total hot run time: 30.69 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
mrhhsg opened a new pull request, #37990: URL: https://github.com/apache/doris/pull/37990 ## Proposed changes If the size of `PFetchDataResult` is greater than 2G, protocol buffer cannot serialize the message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232579390 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
mrhhsg commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232580557 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) bug: after is-null stats derive, other column stats are dropped [doris]
github-actions[bot] commented on PR #37809: URL: https://github.com/apache/doris/pull/37809#issuecomment-2232585954 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](Nereids) tablet prune wrong when decimal value scale is nagtive [doris]
morrySnow commented on PR #37889: URL: https://github.com/apache/doris/pull/37889#issuecomment-2232586966 run could_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) bug: after is-null stats derive, other column stats are dropped [doris]
github-actions[bot] commented on PR #37809: URL: https://github.com/apache/doris/pull/37809#issuecomment-2232586005 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support no-key hint parameter (#37720) [doris]
doris-robot commented on PR #37989: URL: https://github.com/apache/doris/pull/37989#issuecomment-2232588244 TPC-H: Total hot run time: 49967 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 189eca7512ed1dd761b0b84c4f43fda7deb37388, data reload: false -- Round 1 -- q1 17768 445944344434 q2 2079157 156 156 q3 10519 186419671864 q4 10326 124413151244 q5 8655394739133913 q6 232 148 124 124 q7 2040160515791579 q8 9313273027112711 q9 10889 10569 10344 10344 q10 8638353535093509 q11 426 256 258 256 q12 475 316 304 304 q13 18384 393240633932 q14 361 340 333 333 q15 511 463 453 453 q16 689 580 570 570 q17 1157993 948 948 q18 7290682969836829 q19 1802166315871587 q20 521 323 301 301 q21 4511419540924092 q22 555 484 488 484 Total cold run time: 117141 ms Total hot run time: 49967 ms - Round 2, with runtime_filter_mode=off - q1 4480441342964296 q2 325 234 223 223 q3 4217415041224122 q4 2753273527402735 q5 7195718771657165 q6 239 122 118 118 q7 3253283028582830 q8 4454448845084488 q9 17467 16959 16983 16959 q10 4200426442674264 q11 776 668 691 668 q12 1037846 848 846 q13 7089373637423736 q14 447 427 422 422 q15 498 463 459 459 q16 724 694 667 667 q17 3849383538623835 q18 8937886586838683 q19 1702168516421642 q20 2413213421172117 q21 8466855184608460 q22 1049995 972 972 Total cold run time: 85570 ms Total hot run time: 79707 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improve]Schema change parses ddl sql using jsqlparser framework [doris-flink-connector]
JNSimba merged PR #422: URL: https://github.com/apache/doris-flink-connector/pull/422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) branch master updated: [Improve]Schema change parses ddl sql using jsqlparser framework (#422)
This is an automated email from the ASF dual-hosted git repository.
diwu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git
The following commit(s) were added to refs/heads/master by this push:
new 13f1fcde [Improve]Schema change parses ddl sql using jsqlparser
framework (#422)
13f1fcde is described below
commit 13f1fcdeea2b7cf89e500539b8d888accf24c909
Author: wudongliang <46414265+donglian...@users.noreply.github.com>
AuthorDate: Wed Jul 17 15:10:15 2024 +0800
[Improve]Schema change parses ddl sql using jsqlparser framework (#422)
---
flink-doris-connector/pom.xml | 6 +
.../doris/flink/catalog/doris/DorisSystem.java | 3 +
.../flink/sink/schema/SQLParserSchemaManager.java | 218 +
.../flink/sink/schema/SchemaChangeHelper.java | 5 +-
.../doris/flink/sink/schema/SchemaChangeMode.java | 33
.../serializer/JsonDebeziumSchemaSerializer.java | 43 +++-
.../jsondebezium/JsonDebeziumChangeContext.java| 4 +-
.../jsondebezium/JsonDebeziumChangeUtils.java | 33
.../jsondebezium/JsonDebeziumSchemaChange.java | 69 +++
.../jsondebezium/JsonDebeziumSchemaChangeImpl.java | 11 +-
.../JsonDebeziumSchemaChangeImplV2.java| 102 +++---
.../jsondebezium/SQLParserSchemaChange.java| 93 +
.../org/apache/doris/flink/tools/cdc/CdcTools.java | 2 +
.../apache/doris/flink/tools/cdc/DatabaseSync.java | 7 +
.../sink/schema/SQLParserSchemaManagerTest.java| 206 +++
.../jsondebezium/TestSQLParserSchemaChange.java| 141 +
.../flink/tools/cdc/CdcMysqlSyncDatabaseCase.java | 5 +-
.../tools/cdc/CdcOraclelSyncDatabaseCase.java | 2 +-
.../tools/cdc/CdcPostgresSyncDatabaseCase.java | 2 +-
.../tools/cdc/CdcSqlServerSyncDatabaseCase.java| 2 +-
20 files changed, 895 insertions(+), 92 deletions(-)
diff --git a/flink-doris-connector/pom.xml b/flink-doris-connector/pom.xml
index b5080fb0..052180c4 100644
--- a/flink-doris-connector/pom.xml
+++ b/flink-doris-connector/pom.xml
@@ -92,6 +92,7 @@ under the License.
1.17.6
4.12
1.3
+4.9
@@ -354,6 +355,11 @@ under the License.
${flink.version}
test
+
+com.github.jsqlparser
+jsqlparser
+${jsqlparser.version}
+
diff --git
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java
index ab26e308..0d33eb9f 100644
---
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java
+++
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisSystem.java
@@ -285,6 +285,9 @@ public class DorisSystem implements Serializable {
}
public static String identifier(String name) {
+if (name.startsWith("`") && name.endsWith("`")) {
+return name;
+}
return "`" + name + "`";
}
diff --git
a/flink-doris-connector/src/main/java/org/apache/doris/flink/sink/schema/SQLParserSchemaManager.java
b/flink-doris-connector/src/main/java/org/apache/doris/flink/sink/schema/SQLParserSchemaManager.java
new file mode 100644
index ..6f157cdc
--- /dev/null
+++
b/flink-doris-connector/src/main/java/org/apache/doris/flink/sink/schema/SQLParserSchemaManager.java
@@ -0,0 +1,218 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.flink.sink.schema;
+
+import org.apache.flink.annotation.VisibleForTesting;
+
+import net.sf.jsqlparser.JSQLParserException;
+import net.sf.jsqlparser.parser.CCJSqlParserUtil;
+import net.sf.jsqlparser.statement.Statement;
+import net.sf.jsqlparser.statement.alter.Alter;
+import net.sf.jsqlparser.statement.alter.AlterExpression;
+import net.sf.jsqlparser.statement.alter.AlterExpression.ColumnDataType;
+import net.sf.jsqlparser.statement.alter.AlterOperation;
+import net.sf.jsqlparser.statement.create.table.ColDataType;
+import org.apache.commons.collections.CollectionUtils;
+import
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
github-actions[bot] commented on code in PR #37990:
URL: https://github.com/apache/doris/pull/37990#discussion_r1680537939
##
be/src/vec/sink/vmysql_result_writer.cpp:
##
@@ -140,23 +140,11 @@ Status VMysqlResultWriter::_set_options(
}
template
-Status VMysqlResultWriter::write(RuntimeState* state, Block&
input_block) {
-SCOPED_TIMER(_append_row_batch_timer);
+Status VMysqlResultWriter::_write_one_block(RuntimeState*
state, Block& block) {
Review Comment:
warning: function '_write_one_block' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status VMysqlResultWriter::_write_one_block(RuntimeState*
state, Block& block) {
^
```
Additional context
**be/src/vec/sink/vmysql_result_writer.cpp:142:** 95 lines including
whitespace and comments (threshold 80)
```cpp
Status VMysqlResultWriter::_write_one_block(RuntimeState*
state, Block& block) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](limit) Add group by limit regression test case [doris]
doris-robot commented on PR #37940: URL: https://github.com/apache/doris/pull/37940#issuecomment-2232591434 TPC-H: Total hot run time: 40338 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 7a6547f4080f3ccb5d3d4d5a2e59dbc42f77ecc6, data reload: false -- Round 1 -- q1 18110 450944894489 q2 2843200 200 200 q3 10721 119011571157 q4 11672 860 832 832 q5 7566282228422822 q6 227 146 160 146 q7 973 602 615 602 q8 9216206821112068 q9 8675658966046589 q10 8787382438563824 q11 459 240 239 239 q12 396 224 231 224 q13 18895 300030413000 q14 274 233 244 233 q15 535 483 495 483 q16 488 390 390 390 q17 984 606 707 606 q18 8127751974327432 q19 6326143612231223 q20 678 322 341 322 q21 4874317432383174 q22 358 287 283 283 Total cold run time: 121184 ms Total hot run time: 40338 ms - Round 2, with runtime_filter_mode=off - q1 4448428742844284 q2 388 262 269 262 q3 3045282427462746 q4 1930165615781578 q5 5308536853305330 q6 220 135 135 135 q7 2147176617291729 q8 3246335333343334 q9 8485840684538406 q10 3942377137433743 q11 600 505 471 471 q12 795 645 608 608 q13 17417 302130373021 q14 319 277 274 274 q15 521 492 477 477 q16 480 423 432 423 q17 1769150514831483 q18 7804767973577357 q19 2184160616161606 q20 2000181017811781 q21 5016471647124712 q22 543 501 484 484 Total cold run time: 72607 ms Total hot run time: 54244 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix aggr node colocate flag which local shuffle depending on [doris]
doris-robot commented on PR #37788: URL: https://github.com/apache/doris/pull/37788#issuecomment-2232595888 TPC-H: Total hot run time: 39893 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e7823ff965c8fe387860c164f90cdb141119ada5, data reload: false -- Round 1 -- q1 17949 453643854385 q2 2652223 191 191 q3 11570 119110621062 q4 10343 881 836 836 q5 7962280126402640 q6 227 142 140 140 q7 975 618 612 612 q8 9357204620752046 q9 8648652865406528 q10 8642381437943794 q11 454 238 248 238 q12 391 224 218 218 q13 17751 298929752975 q14 271 238 237 237 q15 517 478 492 478 q16 501 387 374 374 q17 953 702 690 690 q18 8016747473517351 q19 7913137613121312 q20 700 332 323 323 q21 4851317532323175 q22 351 293 288 288 Total cold run time: 120994 ms Total hot run time: 39893 ms - Round 2, with runtime_filter_mode=off - q1 4398422042214220 q2 364 262 278 262 q3 3033274127482741 q4 1891159316151593 q5 5273528153145281 q6 221 131 130 130 q7 2130175817261726 q8 3218331932863286 q9 8404836783778367 q10 3873375737383738 q11 594 517 484 484 q12 763 595 603 595 q13 16540 300529942994 q14 299 278 285 278 q15 518 483 478 478 q16 476 420 431 420 q17 1767147814841478 q18 7746748476177484 q19 1636157916111579 q20 2022181617801780 q21 5007476747774767 q22 548 500 518 500 Total cold run time: 70721 ms Total hot run time: 54181 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
mrhhsg commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232595829 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2232596114 TPC-H: Total hot run time: 40259 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit ec004681e12951547f2360e0c7ed685be4820a47, data reload: false -- Round 1 -- q1 17880 462644794479 q2 2611193 195 193 q3 11093 119810581058 q4 10567 772 886 772 q5 7881278026982698 q6 223 141 137 137 q7 965 607 596 596 q8 9235212921202120 q9 8997659066086590 q10 8632376737813767 q11 449 238 234 234 q12 396 224 220 220 q13 18878 296329692963 q14 281 233 230 230 q15 525 492 497 492 q16 502 378 377 377 q17 960 741 689 689 q18 8398767575287528 q19 5646139814231398 q20 697 311 333 311 q21 4895312632413126 q22 339 281 287 281 Total cold run time: 120050 ms Total hot run time: 40259 ms - Round 2, with runtime_filter_mode=off - q1 4412426842484248 q2 371 271 266 266 q3 3074276027752760 q4 1874161916431619 q5 5276529353075293 q6 219 132 128 128 q7 2084171617271716 q8 3201335832993299 q9 8486837084468370 q10 3951374136553655 q11 583 477 486 477 q12 792 582 621 582 q13 16430 296129952961 q14 303 275 281 275 q15 520 474 482 474 q16 470 418 413 413 q17 1805146714581458 q18 7744761174407440 q19 1746156715891567 q20 2010178618101786 q21 4977472746494649 q22 577 480 482 480 Total cold run time: 70905 ms Total hot run time: 53916 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
github-actions[bot] commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232601824 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
yiguolei commented on code in PR #37990:
URL: https://github.com/apache/doris/pull/37990#discussion_r1680548458
##
be/src/runtime/buffer_control_block.cpp:
##
@@ -80,6 +81,13 @@ void GetResultBatchCtx::on_data(const
std::unique_ptr& t_resul
result->set_packet_seq(packet_seq);
result->set_eos(eos);
}
+
+/// The size limit of proto buffer message is 2G
+if (result->ByteSizeLong() > std::numeric_limits::max()) {
Review Comment:
2G should be a config.
Set it to 1G.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
github-actions[bot] commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232603001 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete-sign) Disable deletion with delete sign when doing cumulative compaction [doris]
doris-robot commented on PR #37950: URL: https://github.com/apache/doris/pull/37950#issuecomment-2232603071 TPC-H: Total hot run time: 39459 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit e9725f15ee90f5859a39c2d993b797f580d353ce, data reload: false -- Round 1 -- q1 17611 438942634263 q2 2013187 190 187 q3 10478 121210701070 q4 10196 766 767 766 q5 7524273426642664 q6 221 135 135 135 q7 941 596 597 596 q8 9224205220732052 q9 8730654165206520 q10 8809379337633763 q11 461 233 228 228 q12 450 223 223 223 q13 17759 295129802951 q14 274 231 233 231 q15 526 492 477 477 q16 498 378 378 378 q17 958 630 696 630 q18 8088741572707270 q19 5295144612301230 q20 691 312 324 312 q21 5066323532603235 q22 338 278 280 278 Total cold run time: 116151 ms Total hot run time: 39459 ms - Round 2, with runtime_filter_mode=off - q1 4365419942394199 q2 366 268 261 261 q3 3035281329372813 q4 1947172316811681 q5 5673555255015501 q6 228 133 134 133 q7 2154180618571806 q8 3341341333503350 q9 8797872887858728 q10 4125401137143714 q11 576 478 516 478 q12 812 665 622 622 q13 17189 316831853168 q14 309 292 291 291 q15 517 498 486 486 q16 516 435 434 434 q17 1787155415091509 q18 80438154 q19 1769159616251596 q20 2140187118421842 q21 5101495048864886 q22 610 501 510 501 Total cold run time: 73400 ms Total hot run time: 55776 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Pick](Row store)pick #37145 [doris]
eldenmoon merged PR #37944: URL: https://github.com/apache/doris/pull/37944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-3.0 updated: [Pick](Row store) allow to set row_store_page_size for tables, change default value to 16KB
This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 5a44f57ba4b [Pick](Row store) allow to set row_store_page_size for
tables, change default value to 16KB
5a44f57ba4b is described below
commit 5a44f57ba4b1ec5cb65dbd7af79da2b26ac11993
Author: Xr Ling <63634816+lxr...@users.noreply.github.com>
AuthorDate: Wed Jul 17 15:19:49 2024 +0800
[Pick](Row store) allow to set row_store_page_size for tables, change
default value to 16KB
pick #37145
---
be/src/common/config.cpp | 2 --
be/src/common/config.h | 2 --
be/src/olap/rowset/segment_v2/options.h| 2 ++
be/src/olap/rowset/segment_v2/segment_writer.cpp | 2 +-
.../rowset/segment_v2/vertical_segment_writer.cpp | 2 +-
be/src/olap/tablet_meta.cpp| 3 +++
be/src/olap/tablet_schema.cpp | 4 +++
be/src/olap/tablet_schema.h| 4 +++
.../org/apache/doris/alter/CloudRollupJobV2.java | 3 ++-
.../apache/doris/alter/CloudSchemaChangeJobV2.java | 3 ++-
.../java/org/apache/doris/alter/RollupJobV2.java | 3 ++-
.../org/apache/doris/alter/SchemaChangeJobV2.java | 3 ++-
.../java/org/apache/doris/backup/RestoreJob.java | 3 ++-
.../main/java/org/apache/doris/catalog/Env.java| 4 +++
.../java/org/apache/doris/catalog/OlapTable.java | 14 ++
.../org/apache/doris/catalog/TableProperty.java| 13 +
.../cloud/datasource/CloudInternalCatalog.java | 12 ++---
.../apache/doris/common/util/PropertyAnalyzer.java | 29
.../apache/doris/datasource/InternalCatalog.java | 27 ++-
.../org/apache/doris/master/ReportHandler.java | 3 ++-
.../org/apache/doris/task/CreateReplicaTask.java | 6 -
.../java/org/apache/doris/task/AgentTaskTest.java | 3 ++-
gensrc/proto/olap_file.proto | 2 ++
gensrc/thrift/AgentService.thrift | 1 +
.../data/query_p0/system/test_table_options.out| 14 +-
.../query_p0/system/test_query_sys_tables.groovy | 1 +
.../query_p0/system/test_table_options.groovy | 31 ++
27 files changed, 166 insertions(+), 30 deletions(-)
diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 3590c7afd30..98243e74577 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -1059,8 +1059,6 @@ DEFINE_mInt64(max_tablet_io_errors, "-1");
DEFINE_Int32(tablet_path_check_interval_seconds, "-1");
DEFINE_mInt32(tablet_path_check_batch_size, "1000");
-// Page size of row column, default 4KB
-DEFINE_mInt64(row_column_page_size, "4096");
// it must be larger than or equal to 5MB
DEFINE_mInt64(s3_write_buffer_size, "5242880");
// Log interval when doing s3 upload task
diff --git a/be/src/common/config.h b/be/src/common/config.h
index a52a0357eb1..a1b9a504278 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1102,8 +1102,6 @@ DECLARE_mInt64(max_tablet_io_errors);
DECLARE_Int32(tablet_path_check_interval_seconds);
DECLARE_mInt32(tablet_path_check_batch_size);
-// Page size of row column, default 4KB
-DECLARE_mInt64(row_column_page_size);
// it must be larger than or equal to 5MB
DECLARE_mInt64(s3_write_buffer_size);
// Log interval when doing s3 upload task
diff --git a/be/src/olap/rowset/segment_v2/options.h
b/be/src/olap/rowset/segment_v2/options.h
index 19041f4c51d..93ec03df452 100644
--- a/be/src/olap/rowset/segment_v2/options.h
+++ b/be/src/olap/rowset/segment_v2/options.h
@@ -24,6 +24,8 @@ namespace segment_v2 {
static constexpr size_t DEFAULT_PAGE_SIZE = 1024 * 1024; // default size: 1M
+constexpr long ROW_STORE_PAGE_SIZE_DEFAULT_VALUE = 16384; // default row store
page size: 16KB
+
struct PageBuilderOptions {
size_t data_page_size = DEFAULT_PAGE_SIZE;
diff --git a/be/src/olap/rowset/segment_v2/segment_writer.cpp
b/be/src/olap/rowset/segment_v2/segment_writer.cpp
index 729e2500384..26802ed4bab 100644
--- a/be/src/olap/rowset/segment_v2/segment_writer.cpp
+++ b/be/src/olap/rowset/segment_v2/segment_writer.cpp
@@ -255,7 +255,7 @@ Status SegmentWriter::_create_column_writer(uint32_t cid,
const TabletColumn& co
if (column.is_row_store_column()) {
// smaller page size for row store column
-opts.data_page_size = config::row_column_page_size;
+opts.data_page_size = _tablet_schema->row_store_page_size();
}
std::unique_ptr writer;
RETURN_IF_ERROR(ColumnWriter::create(opts, &column, _file_writer,
&writer));
diff --git a/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
b/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
index 0930325d6d8..7467e28bd79 100644
--- a/be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp
Re: [PR] [regression-test](variant) seperate and optimize cases [doris]
doris-robot commented on PR #37991: URL: https://github.com/apache/doris/pull/37991#issuecomment-2232608499 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [regression-test](variant) seperate and optimize cases [doris]
eldenmoon opened a new pull request, #37991: URL: https://github.com/apache/doris/pull/37991 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix] Error: missing field initializer [doris]
github-actions[bot] commented on PR #37403: URL: https://github.com/apache/doris/pull/37403#issuecomment-2232609562 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support no-key hint parameter (#37720) [doris]
doris-robot commented on PR #37989: URL: https://github.com/apache/doris/pull/37989#issuecomment-2232609697 TPC-DS: Total hot run time: 203301 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 189eca7512ed1dd761b0b84c4f43fda7deb37388, data reload: false query1 923 423 381 381 query2 6544262925292529 query3 6925213 200 200 query4 21144 18053 18020 18020 query5 19737 654865296529 query6 303 216 234 216 query7 4168310 319 310 query8 445 388 403 388 query9 3094264725742574 query10 433 299 309 299 query11 11267 10689 10615 10615 query12 133 82 75 75 query13 5616698 701 698 query14 17849 13432 13738 13432 query15 373 251 255 251 query16 6451300 260 260 query17 17001422878 878 query18 2335409 409 409 query19 209 152 150 150 query20 73 79 79 79 query21 194 96 95 95 query22 5315507749594959 query23 32576 31968 31916 31916 query24 6955650064576457 query25 537 431 428 428 query26 535 172 160 160 query27 1850297 291 291 query28 6199236723382338 query29 2856283427382738 query30 239 170 173 170 query31 929 748 741 741 query32 74 67 63 63 query33 404 259 245 245 query34 841 474 467 467 query35 1144933 916 916 query36 1343117211481148 query37 87 61 62 61 query38 3102291529072907 query39 1362134313201320 query40 216 96 95 95 query41 46 45 44 44 query42 84 83 82 82 query43 729 744 794 744 query44 1107718 731 718 query45 236 234 230 230 query46 1221978 965 965 query47 1797172617451726 query48 1020698 711 698 query49 628 370 364 364 query50 856 627 604 604 query51 4749465546694655 query52 95 77 79 77 query53 445 317 315 315 query54 2630245124432443 query55 94 84 84 84 query56 244 214 213 213 query57 1170103612011036 query58 222 218 202 202 query59 4254356236103562 query60 217 205 205 205 query61 96 94 96 94 query62 832 497 488 488 query63 486 337 340 337 query64 2582156314031403 query65 3619355535983555 query66 813 384 386 384 query67 17313 15267 15193 15193 query68 9618651 661 651 query69 569 357 375 357 query70 1779153813461346 query71 417 301 322 301 query72 6541350535043504 query73 731 329 323 323 query74 6235582258625822 query75 5445372136923692 query76 6074115812181158 query77 1060261 257 257 query78 12629 11756 13297 11756 query79 8454655 674 655 query80 927 403 404 403 query81 489 232 236 232 query82 613 99 101 99 query83 170 137 133 133 query84 270 71 71 71 query85 876 334 341 334 query86 331 308 329 308 query87 3214303130413031 query88 4291235323402340 query89 358 302 285 285 query90 1975214 219 214 query91 173 143 138 138 query92 59 56 53 53 query93 3565580 564 564 query94 718 214 216 214 query95 1096104110471041 query96 656 324 329 324 query97 6458640663986398 query98 193 173 180 173 query99 2948906 895 895 Total cold run time: 312997 ms Total hot run time: 203301 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232609880 TPC-H: Total hot run time: 40079 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit 3da30be7fee716ee75cca24511db08ab8467bf12, data reload: false -- Round 1 -- q1 17877 444843654365 q2 2530196 187 187 q3 12154 115111281128 q4 10364 787 885 787 q5 7712273227422732 q6 228 142 137 137 q7 961 620 597 597 q8 9360207120912071 q9 8762654665726546 q10 8814384237543754 q11 502 231 244 231 q12 396 232 226 226 q13 17755 296529732965 q14 292 227 239 227 q15 525 493 486 486 q16 502 395 387 387 q17 957 660 727 660 q18 8108770274997499 q19 6751140813491349 q20 657 320 332 320 q21 4961314631953146 q22 348 289 279 279 Total cold run time: 120516 ms Total hot run time: 40079 ms - Round 2, with runtime_filter_mode=off - q1 4435425142164216 q2 377 277 267 267 q3 3029277827102710 q4 1854157216321572 q5 5336530752975297 q6 222 130 129 129 q7 2117167716561656 q8 3191334333013301 q9 8377834583658345 q10 3880372437333724 q11 582 491 502 491 q12 769 592 606 592 q13 17469 299230002992 q14 307 286 265 265 q15 508 490 481 481 q16 478 418 422 418 q17 1753149114701470 q18 7718745774367436 q19 1704151416511514 q20 2015175817851758 q21 9635462447894624 q22 559 506 499 499 Total cold run time: 76315 ms Total hot run time: 53757 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](limit) Add group by limit regression test case [doris]
doris-robot commented on PR #37940: URL: https://github.com/apache/doris/pull/37940#issuecomment-2232610228 TPC-DS: Total hot run time: 173572 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 7a6547f4080f3ccb5d3d4d5a2e59dbc42f77ecc6, data reload: false query1 915 391 369 369 query2 6444192317911791 query3 6651210 217 210 query4 23629 17638 17196 17196 query5 4197487 496 487 query6 277 172 174 172 query7 4594289 289 289 query8 249 196 192 192 query9 8441236423532353 query10 427 283 276 276 query11 10494 10050 10027 10027 query12 133 83 86 83 query13 1633364 361 361 query14 9190781675457545 query15 221 176 170 170 query16 7787316 325 316 query17 1794545 551 545 query18 1877274 275 274 query19 200 149 151 149 query20 91 81 80 80 query21 207 130 129 129 query22 4257402339123912 query23 33658 33176 33091 33091 query24 11906 282029182820 query25 685 396 408 396 query26 1829156 150 150 query27 2922275 272 272 query28 7551198419741974 query29 1121615 609 609 query30 284 145 143 143 query31 965 760 752 752 query32 97 57 60 57 query33 764 310 292 292 query34 946 491 500 491 query35 694 571 586 571 query36 1105924 941 924 query37 205 79 83 79 query38 2885278327502750 query39 902 834 815 815 query40 284 120 122 120 query41 49 46 48 46 query42 133 104 103 103 query43 518 479 456 456 query44 1161758 746 746 query45 191 171 164 164 query46 1100717 714 714 query47 1861180217791779 query48 376 302 308 302 query49 1223432 425 425 query50 792 402 404 402 query51 6989679266626662 query52 105 102 94 94 query53 354 295 291 291 query54 974 466 461 461 query55 76 78 77 77 query56 308 295 293 293 query57 1145105610381038 query58 261 248 258 248 query59 2726278626052605 query60 339 314 305 305 query61 119 113 117 113 query62 827 660 670 660 query63 322 290 289 289 query64 10622 229471952294 query65 3183316331303130 query66 1417368 347 347 query67 15617 15140 15070 15070 query68 4967545 551 545 query69 747 432 351 351 query70 1188118711451145 query71 461 290 286 286 query72 9128563559295635 query73 762 328 329 328 query74 6130572057295720 query75 4490266926992669 query76 3707931 977 931 query77 715 326 305 305 query78 9649899390008993 query79 6836530 525 525 query80 1338485 489 485 query81 597 229 230 229 query82 1321135 135 135 query83 400 170 163 163 query84 277 88 87 87 query85 1578325 290 290 query86 453 324 322 322 query87 3274314531063106 query88 4870248125152481 query89 522 379 373 373 query90 1945196 197 196 query91 131 100 103 100 query92 61 50 55 50 query93 5730523 504 504 query94 1363217 212 212 query95 405 316 318 316 query96 612 281 272 272 query97 3234302530583025 query98 218 194 209 194 query99 1560128012531253 Total cold run time: 293968 ms Total hot run time: 173572 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t
Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2232614713 TPC-DS: Total hot run time: 172378 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit ec004681e12951547f2360e0c7ed685be4820a47, data reload: false query1 916 375 357 357 query2 6461190618321832 query3 6640215 219 215 query4 24910 17422 17381 17381 query5 4232489 474 474 query6 261 176 166 166 query7 4604287 283 283 query8 243 198 200 198 query9 8453239323742374 query10 433 295 262 262 query11 11929 10151 10076 10076 query12 133 90 85 85 query13 1641372 391 372 query14 10236 791575327532 query15 234 162 172 162 query16 7315324 319 319 query17 1788559 538 538 query18 1776284 278 278 query19 207 159 158 158 query20 91 82 83 82 query21 209 133 121 121 query22 4352416239603960 query23 33872 33117 33557 33117 query24 10831 289828792879 query25 616 382 392 382 query26 1199151 145 145 query27 2675273 276 273 query28 6925200420002000 query29 948 641 629 629 query30 286 158 147 147 query31 970 762 750 750 query32 97 53 57 53 query33 760 310 308 308 query34 893 491 491 491 query35 701 593 588 588 query36 1117917 954 917 query37 139 84 82 82 query38 2854273727112711 query39 911 820 808 808 query40 204 122 123 122 query41 50 47 48 47 query42 122 97 104 97 query43 507 462 461 461 query44 1213715 723 715 query45 195 162 163 162 query46 1099751 733 733 query47 1956180817841784 query48 365 288 288 288 query49 1086429 405 405 query50 780 394 383 383 query51 6884690867856785 query52 102 93 92 92 query53 355 287 277 277 query54 819 436 434 434 query55 74 72 72 72 query56 297 275 274 274 query57 1162106010451045 query58 245 245 254 245 query59 2886274725602560 query60 305 279 298 279 query61 94 97 95 95 query62 831 638 661 638 query63 317 285 278 278 query64 10602 225016621662 query65 3180312631263126 query66 1132322 326 322 query67 15540 14922 14855 14855 query68 6223538 541 538 query69 698 434 353 353 query70 1249115411661154 query71 508 323 275 275 query72 8819533357015333 query73 807 323 322 322 query74 6279564656155615 query75 4917267626412641 query76 4669925 964 925 query77 773 296 311 296 query78 9624917290919091 query79 4740510 519 510 query80 1105466 460 460 query81 580 223 224 223 query82 869 136 135 135 query83 279 171 166 166 query84 279 93 84 84 query85 1557323 300 300 query86 449 324 311 311 query87 3276308031333080 query88 4573238823742374 query89 540 396 401 396 query90 1974191 194 191 query91 136 104 100 100 query92 65 50 49 49 query93 5383499 494 494 query94 1291211 207 207 query95 402 310 319 310 query96 601 276 273 273 query97 3158299830802998 query98 213 196 198 196 query99 1585128812371237 Total cold run time: 292881 ms Total hot run time: 172378 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [fix](nereids) fix aggr node colocate flag which local shuffle depending on [doris]
doris-robot commented on PR #37788: URL: https://github.com/apache/doris/pull/37788#issuecomment-2232614779 TPC-DS: Total hot run time: 173554 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e7823ff965c8fe387860c164f90cdb141119ada5, data reload: false query1 926 385 366 366 query2 6456194418581858 query3 6671212 220 212 query4 25559 17689 17319 17319 query5 4208511 491 491 query6 264 177 186 177 query7 4591295 293 293 query8 234 211 199 199 query9 8564240424022402 query10 452 299 288 288 query11 10561 10114 10010 10010 query12 140 88 85 85 query13 1668377 370 370 query14 10563 788677457745 query15 233 175 177 175 query16 7606328 324 324 query17 1780586 563 563 query18 1573289 282 282 query19 207 162 160 160 query20 90 85 85 85 query21 213 133 135 133 query22 4544407239793979 query23 34196 33235 33198 33198 query24 12078 293027982798 query25 667 395 397 395 query26 1778156 155 155 query27 2865277 281 277 query28 7592201620022002 query29 1070636 637 636 query30 291 157 152 152 query31 977 733 764 733 query32 94 55 59 55 query33 790 320 309 309 query34 930 501 494 494 query35 703 687 570 570 query36 1148944 946 944 query37 258 80 86 80 query38 2929280827662766 query39 861 801 822 801 query40 275 122 141 122 query41 53 46 43 43 query42 116 97 101 97 query43 499 470 459 459 query44 1258748 735 735 query45 189 162 167 162 query46 1113738 720 720 query47 1892181717991799 query48 363 293 293 293 query49 1222444 411 411 query50 786 405 399 399 query51 6893676368006763 query52 112 90 103 90 query53 381 299 301 299 query54 978 450 463 450 query55 75 77 72 72 query56 284 265 275 265 query57 1184111910701070 query58 275 257 253 253 query59 2876276126012601 query60 301 281 299 281 query61 95 96 95 95 query62 839 647 656 647 query63 324 293 296 293 query64 10547 222417021702 query65 3193312031023102 query66 1331343 345 343 query67 15447 15138 15146 15138 query68 6000554 572 554 query69 717 449 349 349 query70 1219113811451138 query71 483 286 273 273 query72 8618543754485437 query73 791 328 329 328 query74 6311570356935693 query75 4535269126962691 query76 40911002908 908 query77 703 323 330 323 query78 10523 914190219021 query79 7912536 531 531 query80 1096539 499 499 query81 585 224 231 224 query82 793 135 137 135 query83 293 177 168 168 query84 280 90 84 84 query85 1482321 303 303 query86 469 310 321 310 query87 3363311830913091 query88 5102237823822378 query89 560 393 378 378 query90 1933203 197 197 query91 131 105 104 104 query92 70 50 52 50 query93 6268515 510 510 query94 1314215 214 214 query95 424 320 312 312 query96 628 280 272 272 query97 3256305230693052 query98 217 207 197 197 query99 1643126412451245 Total cold run time: 301041 ms Total hot run time: 173554 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
[PR] [improvement](regression)Use createMV to create materialized view. (#37837) [doris]
Jibing-Li opened a new pull request, #37992: URL: https://github.com/apache/doris/pull/37992 backport: https://github.com/apache/doris/pull/37837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](regression)Use createMV to create materialized view. (#37837) [doris]
doris-robot commented on PR #37992: URL: https://github.com/apache/doris/pull/37992#issuecomment-2232615501 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [improvement](regression)Use createMV to create materialized view. (#37837) [doris]
Jibing-Li commented on PR #37992: URL: https://github.com/apache/doris/pull/37992#issuecomment-2232615973 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](variant) seperate and optimize cases [doris]
eldenmoon commented on PR #37991: URL: https://github.com/apache/doris/pull/37991#issuecomment-2232618156 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support no-key hint parameter (#37720) [doris]
doris-robot commented on PR #37989: URL: https://github.com/apache/doris/pull/37989#issuecomment-2232619227 ClickBench: Total hot run time: 30.58 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 189eca7512ed1dd761b0b84c4f43fda7deb37388, data reload: false query1 0.020.020.02 query2 0.070.030.03 query3 0.250.040.05 query4 1.780.060.07 query5 0.530.540.52 query6 1.250.630.64 query7 0.020.010.01 query8 0.040.030.02 query9 0.530.490.49 query10 0.530.530.53 query11 0.120.090.08 query12 0.120.090.09 query13 0.620.630.61 query14 0.810.770.78 query15 0.790.770.77 query16 0.380.360.36 query17 1.011.011.02 query18 0.250.250.23 query19 1.901.751.86 query20 0.020.010.01 query21 15.45 0.560.55 query22 1.932.111.42 query23 17.33 1.120.96 query24 6.163.111.00 query25 0.380.060.07 query26 0.880.180.18 query27 0.050.040.03 query28 4.940.750.78 query29 12.72 2.312.26 query30 0.610.540.57 query31 2.810.380.37 query32 3.400.510.48 query33 3.183.053.05 query34 15.27 4.804.81 query35 4.884.864.84 query36 1.061.021.02 query37 0.060.040.05 query38 0.040.030.02 query39 0.020.010.01 query40 0.160.140.14 query41 0.060.010.02 query42 0.020.010.01 query43 0.030.010.02 Total cold run time: 102.48 s Total hot run time: 30.58 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression](limit) Add group by limit regression test case [doris]
doris-robot commented on PR #37940: URL: https://github.com/apache/doris/pull/37940#issuecomment-2232619993 ClickBench: Total hot run time: 31.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 7a6547f4080f3ccb5d3d4d5a2e59dbc42f77ecc6, data reload: false query1 0.040.040.03 query2 0.090.040.04 query3 0.220.050.06 query4 1.650.080.08 query5 0.490.480.48 query6 1.130.740.73 query7 0.020.020.01 query8 0.050.040.04 query9 0.550.500.49 query10 0.550.540.54 query11 0.160.110.12 query12 0.140.110.13 query13 0.590.590.58 query14 0.750.790.77 query15 0.860.820.82 query16 0.370.350.37 query17 0.991.021.04 query18 0.240.220.23 query19 1.831.731.76 query20 0.010.010.01 query21 15.39 0.730.66 query22 4.256.552.68 query23 18.33 1.381.29 query24 2.060.230.23 query25 0.170.090.09 query26 0.290.210.20 query27 0.450.240.24 query28 13.30 1.021.00 query29 12.62 3.333.28 query30 0.260.060.06 query31 2.880.380.38 query32 3.260.480.46 query33 2.912.952.92 query34 17.03 4.434.34 query35 4.464.484.52 query36 0.650.460.48 query37 0.180.140.16 query38 0.150.140.14 query39 0.040.040.03 query40 0.160.120.12 query41 0.100.050.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 109.78 s Total hot run time: 31.55 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
Mryange commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232620770 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete-sign) Disable deletion with delete sign when doing cumulative compaction [doris]
doris-robot commented on PR #37950: URL: https://github.com/apache/doris/pull/37950#issuecomment-2232622053 TPC-DS: Total hot run time: 173359 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit e9725f15ee90f5859a39c2d993b797f580d353ce, data reload: false query1 900 366 377 366 query2 6461191518321832 query3 6639211 239 211 query4 24944 17409 17556 17409 query5 3676477 480 477 query6 262 186 168 168 query7 4584290 293 290 query8 248 184 211 184 query9 8485240023722372 query10 431 274 263 263 query11 12687 10217 10129 10129 query12 110 82 80 80 query13 1638361 352 352 query14 10129 764372647264 query15 211 160 164 160 query16 7505313 307 307 query17 1369545 555 545 query18 1745279 267 267 query19 201 146 144 144 query20 89 76 80 76 query21 205 134 123 123 query22 4454418743634187 query23 33747 33609 33600 33600 query24 10828 292929002900 query25 581 388 383 383 query26 740 150 163 150 query27 2234272 279 272 query28 5913206620582058 query29 924 641 603 603 query30 254 153 156 153 query31 974 778 753 753 query32 98 54 58 54 query33 691 341 323 323 query34 883 484 496 484 query35 715 579 584 579 query36 1100966 966 966 query37 145 87 122 87 query38 2972288228712871 query39 908 837 859 837 query40 200 117 120 117 query41 48 43 44 43 query42 116 102 102 102 query43 507 451 460 451 query44 1054724 742 724 query45 192 161 163 161 query46 1094747 734 734 query47 1888175417781754 query48 373 293 284 284 query49 823 396 404 396 query50 775 381 374 374 query51 6855685767986798 query52 107 95 87 87 query53 362 278 279 278 query54 906 450 435 435 query55 78 70 72 70 query56 284 260 281 260 query57 1135106910691069 query58 281 232 259 232 query59 2766261125642564 query60 308 266 271 266 query61 95 91 94 91 query62 783 620 649 620 query63 334 282 285 282 query64 9111215816461646 query65 3165309730793079 query66 745 324 328 324 query67 15471 15092 15080 15080 query68 4759593 553 553 query69 665 400 341 341 query70 1206112911261126 query71 406 275 272 272 query72 7767551662685516 query73 762 325 326 325 query74 6273560656695606 query75 3387269727252697 query76 2875909 941 909 query77 715 292 311 292 query78 9637906013033 9060 query79 3080514 527 514 query80 1944483 460 460 query81 583 217 228 217 query82 426 130 132 130 query83 326 170 165 165 query84 267 89 82 82 query85 1418293 288 288 query86 476 312 304 304 query87 3284315331313131 query88 3308237723712371 query89 467 368 375 368 query90 1760188 186 186 query91 128 96 99 96 query92 61 47 48 47 query93 1071500 501 500 query94 1194208 204 204 query95 397 307 309 307 query96 583 274 267 267 query97 3283298330072983 query98 292 198 195 195 query99 1564125312471247 Total cold run time: 274900 ms Total hot run time: 173359 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [enhancement](profile) Store profile on disk so that we can hold more profile in memory [doris]
doris-robot commented on PR #33690: URL: https://github.com/apache/doris/pull/33690#issuecomment-2232624756 ClickBench: Total hot run time: 30.5 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit ec004681e12951547f2360e0c7ed685be4820a47, data reload: false query1 0.040.030.03 query2 0.070.040.05 query3 0.220.040.04 query4 1.690.070.06 query5 0.480.500.50 query6 1.210.750.75 query7 0.020.010.02 query8 0.050.040.05 query9 0.550.490.50 query10 0.560.530.54 query11 0.150.120.12 query12 0.150.120.13 query13 0.600.590.59 query14 0.770.770.79 query15 0.840.800.80 query16 0.360.360.36 query17 0.971.010.95 query18 0.230.220.22 query19 1.911.711.66 query20 0.010.010.01 query21 15.39 0.760.67 query22 4.288.021.70 query23 18.31 1.391.38 query24 2.180.230.23 query25 0.160.080.07 query26 0.300.220.21 query27 0.450.230.23 query28 13.23 1.031.00 query29 12.63 3.403.40 query30 0.260.060.05 query31 2.890.390.39 query32 3.290.470.46 query33 2.922.852.97 query34 17.10 4.404.35 query35 4.484.494.39 query36 0.660.460.47 query37 0.180.160.15 query38 0.160.150.15 query39 0.050.030.04 query40 0.140.120.11 query41 0.090.040.04 query42 0.060.050.05 query43 0.040.040.04 Total cold run time: 110.13 s Total hot run time: 30.5 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids) fix aggr node colocate flag which local shuffle depending on [doris]
doris-robot commented on PR #37788: URL: https://github.com/apache/doris/pull/37788#issuecomment-2232624781 ClickBench: Total hot run time: 31.47 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e7823ff965c8fe387860c164f90cdb141119ada5, data reload: false query1 0.040.040.03 query2 0.070.030.04 query3 0.220.050.04 query4 1.680.080.08 query5 0.510.490.48 query6 1.150.720.71 query7 0.020.020.01 query8 0.050.050.05 query9 0.550.490.49 query10 0.550.540.55 query11 0.140.110.11 query12 0.150.120.12 query13 0.600.600.59 query14 0.770.770.79 query15 0.860.810.82 query16 0.370.350.36 query17 0.970.991.05 query18 0.240.220.22 query19 1.831.751.75 query20 0.020.010.00 query21 15.39 0.750.66 query22 3.926.382.41 query23 18.32 1.361.43 query24 2.120.230.24 query25 0.160.090.08 query26 0.300.210.21 query27 0.460.230.24 query28 13.31 1.041.01 query29 12.65 3.373.35 query30 0.260.060.06 query31 2.890.390.40 query32 3.260.490.50 query33 2.902.972.95 query34 17.03 4.364.35 query35 4.394.454.46 query36 0.660.470.50 query37 0.190.150.16 query38 0.170.150.15 query39 0.050.040.04 query40 0.160.120.12 query41 0.090.050.05 query42 0.060.060.05 query43 0.050.040.04 Total cold run time: 109.58 s Total hot run time: 31.47 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](Nereids) support no-key hint parameter (#37720) [doris]
doris-robot commented on PR #37989: URL: https://github.com/apache/doris/pull/37989#issuecomment-2232624857 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 189eca7512ed1dd761b0b84c4f43fda7deb37388 with default session variables Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s Insert into select: 21.9 seconds inserted 1000 Rows, about 456K ops/s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
Mryange commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232624937 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix]Fix the error of missing content returned by schema change response [doris-flink-connector]
DongLiang-0 opened a new pull request, #433: URL: https://github.com/apache/doris-flink-connector/pull/433 # Proposed changes Issue Number: close #xxx ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Enhancement](group commit)Optimize be select for group commit [doris]
github-actions[bot] commented on PR #35558: URL: https://github.com/apache/doris/pull/35558#issuecomment-2232626373 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [feature](mtmv) Support variants rewrite by materialized view [doris]
seawinde commented on code in PR #37929:
URL: https://github.com/apache/doris/pull/37929#discussion_r1680568378
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java:
##
@@ -568,6 +563,93 @@ protected List rewriteExpression(List sourceEx
return rewrittenExpressions;
}
+/**
+ * if query contains variant slot reference, extend the expression mapping
for rewrte
+ * such as targetToTargetReplacementMappingQueryBased is
+ * id#0 -> id#8
+ * type#1 -> type#9
+ * payload#4 -> payload#10
+ * query variants is payload['issue']['number']#20
+ * then we can add payload['issue']['number']#20 ->
element_at(element_at(payload#10, 'issue'), 'number')
+ * to targetToTargetReplacementMappingQueryBased
+ * */
+private void extendMappingByVariant(Set queryVariants,
+Map
targetToTargetReplacementMappingQueryBased) {
+if (queryVariants.isEmpty()) {
+return;
+}
+Map, Expression> viewNameToExprMap = new HashMap<>();
+for (Map.Entry targetExpressionEntry :
+targetToTargetReplacementMappingQueryBased.entrySet()) {
+if (targetExpressionEntry.getKey() instanceof SlotReference
+&& ((SlotReference)
targetExpressionEntry.getKey()).getDataType() instanceof VariantType) {
+List nameIdentifier = new ArrayList<>();
+nameIdentifier.add(((SlotReference)
targetExpressionEntry.getKey()).getName());
+nameIdentifier.addAll(((SlotReference)
targetExpressionEntry.getKey()).getSubPath());
+viewNameToExprMap.put(nameIdentifier,
targetExpressionEntry.getValue());
+}
+}
+if (viewNameToExprMap.isEmpty()) {
+return;
+}
+Map, SlotReference> queryNameAndExpressionMap = new
HashMap<>();
+for (SlotReference slotReference : queryVariants) {
+List nameIdentifier = new ArrayList<>();
+nameIdentifier.add(slotReference.getName());
+nameIdentifier.addAll(slotReference.getSubPath());
+queryNameAndExpressionMap.put(nameIdentifier, slotReference);
+}
+for (Map.Entry, ? extends Expression> queryNameEntry :
queryNameAndExpressionMap.entrySet()) {
+Expression minExpr = null;
+List minCompensateName = null;
+for (Map.Entry, Expression> entry :
viewNameToExprMap.entrySet()) {
+if (!containsAllWithOrder(queryNameEntry.getKey(),
entry.getKey())) {
+continue;
+}
+List removedQueryName = new
ArrayList<>(queryNameEntry.getKey());
+removedQueryName.removeAll(entry.getKey());
+if (minCompensateName == null) {
+minCompensateName = removedQueryName;
+minExpr = entry.getValue();
+}
+if (removedQueryName.size() < minCompensateName.size()) {
+minCompensateName = removedQueryName;
+minExpr = entry.getValue();
+}
+}
+if (minExpr != null) {
+
targetToTargetReplacementMappingQueryBased.put(queryNameEntry.getValue(),
+constructElementAt(minExpr, minCompensateName));
Review Comment:
yeah, this will push into scan node again by RBO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232629870 TPC-DS: Total hot run time: 173515 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit 3da30be7fee716ee75cca24511db08ab8467bf12, data reload: false query1 939 366 365 365 query2 6457191818321832 query3 6669217 215 215 query4 24757 17311 17236 17236 query5 4184480 479 479 query6 266 164 169 164 query7 4592286 284 284 query8 236 205 197 197 query9 8426238423732373 query10 449 299 274 274 query11 10588 1 10119 1 query12 142 84 87 84 query13 1649379 363 363 query14 10077 757777627577 query15 217 172 173 172 query16 7730323 318 318 query17 1789592 545 545 query18 1873290 281 281 query19 208 157 157 157 query20 100 83 88 83 query21 209 130 124 124 query22 4391416741094109 query23 33726 33157 33197 33157 query24 12080 287028442844 query25 681 393 398 393 query26 1740153 154 153 query27 2940274 279 274 query28 7244198519931985 query29 1096648 624 624 query30 290 151 150 150 query31 1010759 761 759 query32 100 54 56 54 query33 790 328 321 321 query34 961 499 491 491 query35 680 592 599 592 query36 1095969 930 930 query37 271 81 82 81 query38 2932271527282715 query39 850 792 818 792 query40 289 122 123 122 query41 49 48 48 48 query42 117 99 101 99 query43 517 472 472 472 query44 1187744 722 722 query45 194 162 163 162 query46 1093752 736 736 query47 1848177017701770 query48 370 293 305 293 query49 1222438 417 417 query50 802 400 395 395 query51 6905681468476814 query52 109 94 98 94 query53 360 294 297 294 query54 989 461 457 457 query55 76 76 78 76 query56 313 287 295 287 query57 1216108410491049 query58 275 263 268 263 query59 3003264826242624 query60 300 269 274 269 query61 101 93 108 93 query62 837 631 637 631 query63 317 286 283 283 query64 10436 224959762249 query65 3155307930883079 query66 1382333 343 333 query67 15718 14949 14939 14939 query68 7650554 552 552 query69 758 494 365 365 query70 1238107711421077 query71 528 280 282 280 query72 9287573756105610 query73 782 328 325 325 query74 6133563856685638 query75 5051272326842684 query76 5016976 907 907 query77 790 298 298 298 query78 9626957290129012 query79 9431523 524 523 query80 1001487 476 476 query81 589 221 228 221 query82 285 140 133 133 query83 337 166 162 162 query84 279 85 91 85 query85 1017341 291 291 query86 380 329 316 316 query87 3296309131563091 query88 4828238223672367 query89 506 370 388 370 query90 2179192 192 192 query91 130 98 99 98 query92 61 49 48 48 query93 6146503 505 503 query94 1517211 211 211 query95 400 308 311 308 query96 603 277 268 268 query97 3187303930503039 query98 210 206 194 194 query99 1504125412871254 Total cold run time: 302359 ms Total hot run time: 173515 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
github-actions[bot] commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232629628 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete-sign) Disable deletion with delete sign when doing cumulative compaction [doris]
doris-robot commented on PR #37950: URL: https://github.com/apache/doris/pull/37950#issuecomment-2232631406 ClickBench: Total hot run time: 31.46 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit e9725f15ee90f5859a39c2d993b797f580d353ce, data reload: false query1 0.040.040.03 query2 0.090.040.04 query3 0.230.050.05 query4 1.680.080.08 query5 0.510.490.49 query6 1.130.730.73 query7 0.020.010.02 query8 0.050.040.04 query9 0.550.490.50 query10 0.540.540.55 query11 0.150.110.11 query12 0.160.120.13 query13 0.600.580.58 query14 0.780.760.78 query15 0.850.810.82 query16 0.360.350.37 query17 0.980.950.97 query18 0.220.220.22 query19 1.811.681.81 query20 0.010.010.01 query21 15.39 0.730.65 query22 3.806.252.84 query23 18.32 1.401.27 query24 2.180.220.22 query25 0.150.090.08 query26 0.290.210.20 query27 0.460.220.23 query28 13.29 1.011.01 query29 12.63 3.293.32 query30 0.250.060.06 query31 2.880.390.38 query32 3.280.480.47 query33 2.832.992.92 query34 17.10 4.314.34 query35 4.454.394.39 query36 0.650.460.49 query37 0.180.150.15 query38 0.160.150.15 query39 0.050.040.04 query40 0.150.130.13 query41 0.100.040.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 109.46 s Total hot run time: 31.46 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [regression-test](variant) seperate and optimize cases [doris]
eldenmoon commented on PR #37991: URL: https://github.com/apache/doris/pull/37991#issuecomment-2232636243 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
github-actions[bot] commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232634687 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [opt](nereids) print ignored runtime filter in shape/physical plan [doris]
englefly opened a new pull request, #37993: URL: https://github.com/apache/doris/pull/37993 ## Proposed changes shape plan and physical plan should display the "ignore" tag of ignored runtime filters ` mysql> set ignore_runtime_filter_ids="1"; Query OK, 0 rows affected (0.00 sec) mysql> explain shape plan select * from nation join region on n_nationkey=r_regionkey where r_name='abc'; +--+ | Explain String(Nereids Planner) | +--+ | PhysicalResultSink | | --hashJoin[INNER_JOIN bucketShuffle] hashCondition=((nation.n_nationkey = region.r_regionkey)) otherCondition=() build RFs:RF0 r_regionkey->[n_nationkey];(ignore)RF1 r_regionkey->[n_nationkey] | | PhysicalOlapScan[nation] apply RFs: RF0 RF1 | | filter((region.r_name = 'abc')) | | --PhysicalOlapScan[region] | +--+ ` Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) print ignored runtime filter in shape/physical plan [doris]
doris-robot commented on PR #37993: URL: https://github.com/apache/doris/pull/37993#issuecomment-2232636629 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](nereids) print ignored runtime filter in shape/physical plan [doris]
englefly commented on PR #37993: URL: https://github.com/apache/doris/pull/37993#issuecomment-2232639532 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](sink) The issue with 2GB limit of protocol buffer [doris]
doris-robot commented on PR #37990: URL: https://github.com/apache/doris/pull/37990#issuecomment-2232639738 ClickBench: Total hot run time: 31 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit 3da30be7fee716ee75cca24511db08ab8467bf12, data reload: false query1 0.040.030.03 query2 0.080.030.04 query3 0.220.050.05 query4 1.680.080.08 query5 0.500.480.49 query6 1.130.720.73 query7 0.020.020.01 query8 0.050.040.04 query9 0.540.490.49 query10 0.540.550.56 query11 0.150.110.11 query12 0.150.120.13 query13 0.590.590.58 query14 0.760.790.79 query15 0.850.830.83 query16 0.370.370.37 query17 0.981.000.98 query18 0.230.220.21 query19 1.811.671.69 query20 0.010.010.01 query21 15.42 0.750.65 query22 4.796.822.28 query23 18.29 1.341.22 query24 2.100.240.23 query25 0.170.090.08 query26 0.300.210.21 query27 0.450.230.23 query28 13.22 1.031.03 query29 12.62 3.303.33 query30 0.260.060.05 query31 2.880.390.38 query32 3.280.480.46 query33 2.872.942.92 query34 16.86 4.364.33 query35 4.494.434.45 query36 0.660.460.48 query37 0.190.160.15 query38 0.160.150.15 query39 0.040.040.04 query40 0.150.120.13 query41 0.100.040.04 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 110.11 s Total hot run time: 31 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Feature](Planner) Support `SET_VAR` hint in insert statement [doris]
morrySnow commented on code in PR #36579:
URL: https://github.com/apache/doris/pull/36579#discussion_r1680578631
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/InsertUtils.java:
##
@@ -395,16 +411,21 @@ private static Expression castValue(Expression value,
DataType targetType) {
*/
public static TableIf getTargetTable(Plan plan, ConnectContext ctx) {
UnboundLogicalSink unboundTableSink;
-if (plan instanceof UnboundTableSink) {
-unboundTableSink = (UnboundTableSink) plan;
-} else if (plan instanceof UnboundHiveTableSink) {
-unboundTableSink = (UnboundHiveTableSink) plan;
-} else if (plan instanceof UnboundIcebergTableSink) {
-unboundTableSink = (UnboundIcebergTableSink) plan;
+Plan sinkPlan = plan;
+if (plan instanceof LogicalStatementHint) {
Review Comment:
too many `if (plan instanceOf LogicalStatementHint) {...} else {...}` in
different place. Maybe it is better to save hint in InserIntoTableCommand, and
add it back to plan tree before do real plan in `initPlan`. or do `eliminate
logical statement` at very begining in InsertIntoTableCommand
##
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##
@@ -117,7 +117,9 @@ private Plan
bindOlapTableSink(MatchingContext> ctx) {
Pair pair = bind(ctx.cascadesContext, sink);
Database database = pair.first;
OlapTable table = pair.second;
-boolean isPartialUpdate = sink.isPartialUpdate() &&
table.getKeysType() == KeysType.UNIQUE_KEYS;
+boolean isPartialUpdate = (table.getKeysType() == KeysType.UNIQUE_KEYS
+&& table.getEnableUniqueKeyMergeOnWrite() &&
(sink.isPartialUpdate()
+||
ctx.cascadesContext.getConnectContext().getSessionVariable().isEnableUniqueKeyPartialUpdate()));
Review Comment:
changes not related with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) fix the be coredump caused by a constant in the field… [doris]
github-actions[bot] commented on PR #37567: URL: https://github.com/apache/doris/pull/37567#issuecomment-2232644368 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) fix the be coredump caused by a constant in the field… [doris]
github-actions[bot] commented on PR #37567: URL: https://github.com/apache/doris/pull/37567#issuecomment-2232644437 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](test)remove redundant test cases [doris]
github-actions[bot] commented on PR #37866: URL: https://github.com/apache/doris/pull/37866#issuecomment-2232646100 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [enhancement](test)remove redundant test cases [doris]
github-actions[bot] commented on PR #37866: URL: https://github.com/apache/doris/pull/37866#issuecomment-2232646046 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) fix the be coredump caused by a constant in the field… [doris]
lide-reed merged PR #37567: URL: https://github.com/apache/doris/pull/37567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch branch-1.2-lts updated: [fix](function) fix the be coredump caused by a constant in the field… (#37567)
This is an automated email from the ASF dual-hosted git repository.
lide pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.2-lts by this push:
new ccdf9382d77 [fix](function) fix the be coredump caused by a constant
in the field… (#37567)
ccdf9382d77 is described below
commit ccdf9382d7704dce90563893008200278ee7921c
Author: lw112 <131352377+felixw...@users.noreply.github.com>
AuthorDate: Wed Jul 17 15:46:18 2024 +0800
[fix](function) fix the be coredump caused by a constant in the field…
(#37567)
cherry-pick #25859
---
be/src/vec/functions/function_multi_same_args.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/src/vec/functions/function_multi_same_args.h
b/be/src/vec/functions/function_multi_same_args.h
index 95ecd1d0345..c5dfb02670e 100644
--- a/be/src/vec/functions/function_multi_same_args.h
+++ b/be/src/vec/functions/function_multi_same_args.h
@@ -35,7 +35,7 @@ public:
String get_name() const override { return name; }
-bool use_default_implementation_for_constants() const override { return
true; }
+bool use_default_implementation_for_constants() const override { return
false; }
bool use_default_implementation_for_nulls() const override { return true; }
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]Query queued by be memory [doris]
wangbo commented on PR #37559: URL: https://github.com/apache/doris/pull/37559#issuecomment-2232655697 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
doris-robot commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232658865 TPC-H: Total hot run time: 39825 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit f26f8cf948a78d9e7c9a76d1d30c851f87ecb93c, data reload: false -- Round 1 -- q1 17620 434642554255 q2 2011189 185 185 q3 10465 115310701070 q4 10194 780 831 780 q5 7542268627432686 q6 219 140 139 139 q7 947 603 610 603 q8 9217207520512051 q9 8755654265116511 q10 8858374037253725 q11 448 235 235 235 q12 407 228 233 228 q13 17765 298729902987 q14 286 245 243 243 q15 537 485 497 485 q16 504 382 379 379 q17 957 679 695 679 q18 8043743873397339 q19 7302142114901421 q20 654 317 330 317 q21 4873321832213218 q22 352 289 294 289 Total cold run time: 117956 ms Total hot run time: 39825 ms - Round 2, with runtime_filter_mode=off - q1 4442425542914255 q2 364 277 265 265 q3 3046290928552855 q4 1983172617351726 q5 5667554755025502 q6 240 137 138 137 q7 2212188418561856 q8 3276340734143407 q9 8772884887808780 q10 4044382538413825 q11 615 527 535 527 q12 805 666 644 644 q13 17076 317232303172 q14 322 284 293 284 q15 521 488 487 487 q16 503 452 462 452 q17 1841153215151515 q18 8167782577997799 q19 1810167414771477 q20 2931188318721872 q21 7782490647254725 q22 606 520 506 506 Total cold run time: 77025 ms Total hot run time: 56068 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mv) fix bug in fetching mv row count [doris]
Jibing-Li commented on code in PR #37923:
URL: https://github.com/apache/doris/pull/37923#discussion_r1680592807
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/algebra/CatalogRelation.java:
##
@@ -27,4 +27,9 @@ public interface CatalogRelation extends Relation {
TableIf getTable();
DatabaseIf getDatabase() throws AnalysisException;
+
+// For empty table, nereids require getting 1 as row count. This is a wrap
function for nereids to call getRowCount.
+default long getRowCountForNereids() {
+return Math.max(getTable().fetchRowCount(), 1);
Review Comment:
I think we should use getTable().getRowCount(), because for external table,
getRowCount reads data in cache, fetchRowCount may connect remote data source,
could be very heavy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]Query queued by be memory [doris]
github-actions[bot] commented on PR #37559: URL: https://github.com/apache/doris/pull/37559#issuecomment-2232661733 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix] unsupport when use doris catalog list views [doris-flink-connector]
JNSimba merged PR #432: URL: https://github.com/apache/doris-flink-connector/pull/432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris-flink-connector) branch master updated: [Fix] unsupport when use doris catalog list views (#432)
This is an automated email from the ASF dual-hosted git repository.
diwu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris-flink-connector.git
The following commit(s) were added to refs/heads/master by this push:
new f92bc754 [Fix] unsupport when use doris catalog list views (#432)
f92bc754 is described below
commit f92bc7541448f1a946567f00bf06d915a2e65ad7
Author: wudi <676366...@qq.com>
AuthorDate: Wed Jul 17 15:52:12 2024 +0800
[Fix] unsupport when use doris catalog list views (#432)
---
.../src/main/java/org/apache/doris/flink/catalog/DorisCatalog.java| 4 ++--
.../src/main/java/org/apache/doris/flink/catalog/DorisTypeMapper.java | 2 ++
.../src/main/java/org/apache/doris/flink/catalog/doris/DorisType.java | 2 ++
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisCatalog.java
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisCatalog.java
index c56f64a0..a6e92158 100644
---
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisCatalog.java
+++
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisCatalog.java
@@ -202,7 +202,7 @@ public class DorisCatalog extends AbstractCatalog {
@Override
public List listViews(String databaseName)
throws DatabaseNotExistException, CatalogException {
-throw new UnsupportedOperationException();
+return Collections.emptyList();
}
@Override
@@ -425,7 +425,7 @@ public class DorisCatalog extends AbstractCatalog {
@Override
public boolean partitionExists(ObjectPath tablePath, CatalogPartitionSpec
partitionSpec)
throws CatalogException {
-throw new UnsupportedOperationException();
+return false;
}
@Override
diff --git
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisTypeMapper.java
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisTypeMapper.java
index a8e3d7d6..bfca184e 100644
---
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisTypeMapper.java
+++
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/DorisTypeMapper.java
@@ -47,6 +47,7 @@ import org.apache.doris.flink.catalog.doris.DorisType;
import static org.apache.doris.flink.catalog.doris.DorisType.ARRAY;
import static org.apache.doris.flink.catalog.doris.DorisType.BIGINT;
+import static org.apache.doris.flink.catalog.doris.DorisType.BIGINT_UNSIGNED;
import static org.apache.doris.flink.catalog.doris.DorisType.BOOLEAN;
import static org.apache.doris.flink.catalog.doris.DorisType.CHAR;
import static org.apache.doris.flink.catalog.doris.DorisType.DATE;
@@ -113,6 +114,7 @@ public class DorisTypeMapper {
case VARCHAR:
return DataTypes.VARCHAR(precision);
case LARGEINT:
+case BIGINT_UNSIGNED:
case STRING:
case JSONB:
case JSON:
diff --git
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisType.java
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisType.java
index b2b3776c..7bc9fd0b 100644
---
a/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisType.java
+++
b/flink-doris-connector/src/main/java/org/apache/doris/flink/catalog/doris/DorisType.java
@@ -24,6 +24,8 @@ public class DorisType {
public static final String INT = "INT";
public static final String BIGINT = "BIGINT";
public static final String LARGEINT = "LARGEINT";
+// largeint is bigint unsigned in information_schema.COLUMNS
+public static final String BIGINT_UNSIGNED = "BIGINT UNSIGNED";
public static final String FLOAT = "FLOAT";
public static final String DOUBLE = "DOUBLE";
public static final String DECIMAL = "DECIMAL";
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](mv) fix bug in fetching mv row count [doris]
englefly commented on code in PR #37923:
URL: https://github.com/apache/doris/pull/37923#discussion_r1680599132
##
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/algebra/CatalogRelation.java:
##
@@ -27,4 +27,9 @@ public interface CatalogRelation extends Relation {
TableIf getTable();
DatabaseIf getDatabase() throws AnalysisException;
+
+// For empty table, nereids require getting 1 as row count. This is a wrap
function for nereids to call getRowCount.
+default long getRowCountForNereids() {
+return Math.max(getTable().fetchRowCount(), 1);
Review Comment:
GET
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Improment]Query queued by be memory [doris]
github-actions[bot] commented on PR #37559: URL: https://github.com/apache/doris/pull/37559#issuecomment-2232665185 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete) fixed special decimal values [doris]
felixwluo commented on PR #37854: URL: https://github.com/apache/doris/pull/37854#issuecomment-2232671377 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)acos function should return null literal instead of NaN value [doris]
github-actions[bot] commented on PR #37932: URL: https://github.com/apache/doris/pull/37932#issuecomment-2232669930 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](nereids)acos function should return null literal instead of NaN value [doris]
github-actions[bot] commented on PR #37932: URL: https://github.com/apache/doris/pull/37932#issuecomment-2232670096 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](test)fix unstable test case [doris]
morrySnow merged PR #37901: URL: https://github.com/apache/doris/pull/37901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
(doris) branch master updated (5670e1ae764 -> aa968d6dc0e)
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 5670e1ae764 [fix](nereids)subquery unnesting get wrong result if correlated conjuncts is not slot_a = slot_b (#37644) add aa968d6dc0e [fix](test) correctness/test_mv_alias_table_name.groovy is unstable (#37901) No new revisions were added by this update. Summary of changes: regression-test/suites/correctness/test_mv_alias_table_name.groovy | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
doris-robot commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232672147 TPC-H: Total hot run time: 40141 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100 test result on commit baf70c8190e8d5e6dd69830c999ef43afe91e56b, data reload: false -- Round 1 -- q1 18682 474843954395 q2 2027191 197 191 q3 10458 117911351135 q4 10181 812 893 812 q5 7593272827922728 q6 220 139 140 139 q7 968 604 610 604 q8 9218207421182074 q9 8840655165726551 q10 8845378437953784 q11 436 243 236 236 q12 401 228 226 226 q13 18594 300230013001 q14 281 239 243 239 q15 520 483 513 483 q16 492 393 385 385 q17 963 618 645 618 q18 8150750574987498 q19 7646141415021414 q20 670 310 325 310 q21 5053303633443036 q22 360 293 282 282 Total cold run time: 120598 ms Total hot run time: 40141 ms - Round 2, with runtime_filter_mode=off - q1 4374429342674267 q2 374 260 258 258 q3 3002283528312831 q4 1934162816271627 q5 5326535453225322 q6 224 131 132 131 q7 2099175417491749 q8 3196337033433343 q9 8543845984298429 q10 3945368937103689 q11 591 493 483 483 q12 759 626 616 616 q13 17456 295730002957 q14 313 275 281 275 q15 511 471 485 471 q16 459 437 425 425 q17 1766146414711464 q18 7759742374077407 q19 1631155215041504 q20 1979180917671767 q21 4975471248214712 q22 589 510 508 508 Total cold run time: 71805 ms Total hot run time: 54235 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
github-actions[bot] commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232674947 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
github-actions[bot] commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232674999 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](delete) fixed special decimal values [doris]
github-actions[bot] commented on PR #37854: URL: https://github.com/apache/doris/pull/37854#issuecomment-2232681795 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
doris-robot commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232680924 TPC-DS: Total hot run time: 173977 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit f26f8cf948a78d9e7c9a76d1d30c851f87ecb93c, data reload: false query1 939 377 365 365 query2 6460187018571857 query3 6657216 225 216 query4 23238 17470 17410 17410 query5 3587488 472 472 query6 263 168 160 160 query7 4576287 286 286 query8 235 191 191 191 query9 8516239523952395 query10 442 301 279 279 query11 10733 10015 query12 117 86 86 86 query13 1636372 358 358 query14 10203 807679367936 query15 215 166 175 166 query16 7355306 311 306 query17 1812545 531 531 query18 1922270 269 269 query19 191 144 149 144 query20 88 79 82 79 query21 201 129 129 129 query22 4363403239603960 query23 34120 33857 33537 33537 query24 7500293329092909 query25 591 399 386 386 query26 702 155 152 152 query27 2130276 276 276 query28 5712204520562045 query29 904 643 622 622 query30 253 157 154 154 query31 969 780 767 767 query32 97 55 56 55 query33 574 298 290 290 query34 906 494 514 494 query35 684 569 582 569 query36 1141968 1002968 query37 146 90 84 84 query38 2946289228602860 query39 920 853 872 853 query40 203 118 119 118 query41 44 42 47 42 query42 111 101 95 95 query43 504 476 476 476 query44 1123726 729 726 query45 193 168 157 157 query46 1074731 722 722 query47 1810173317661733 query48 351 292 290 290 query49 823 404 422 404 query50 778 383 383 383 query51 6869681668096809 query52 117 95 90 90 query53 350 281 276 276 query54 576 442 441 441 query55 75 77 75 75 query56 305 270 280 270 query57 1153103110461031 query58 258 249 263 249 query59 2830264027162640 query60 303 276 278 276 query61 97 93 94 93 query62 774 665 650 650 query63 312 279 282 279 query64 9155231117381738 query65 3232313431723134 query66 731 331 332 331 query67 16196 15135 14702 14702 query68 4510539 544 539 query69 515 397 361 361 query70 1198108911641089 query71 368 285 275 275 query72 7340600458635863 query73 743 326 330 326 query74 6062565757155657 query75 3360268226932682 query76 2193932 900 900 query77 440 302 315 302 query78 9576895789668957 query79 2010515 527 515 query80 1908480 532 480 query81 594 218 227 218 query82 1016133 127 127 query83 275 170 169 169 query84 260 89 85 85 query85 1157320 305 305 query86 458 329 332 329 query87 3297311830683068 query88 239623812381 query89 478 378 387 378 query90 1696198 194 194 query91 130 102 105 102 query92 59 50 49 49 query93 2090511 499 499 query94 1126215 210 210 query95 415 326 324 324 query96 598 273 272 272 query97 3176304630143014 query98 230 196 202 196 query99 1772126613311266 Total cold run time: 266774 ms Total hot run time: 173977 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [feature](mtmv) Support variants rewrite by materialized view [doris]
seawinde commented on PR #37929: URL: https://github.com/apache/doris/pull/37929#issuecomment-2232684039 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](column nullable) Optimization for ColumnNullable serialization [doris]
zhiqiang- commented on PR #37896: URL: https://github.com/apache/doris/pull/37896#issuecomment-2232693245 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](spill) disable partitioned agg when group by limit opt is set [doris]
doris-robot commented on PR #37873: URL: https://github.com/apache/doris/pull/37873#issuecomment-2232691552 ClickBench: Total hot run time: 30.87 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit f26f8cf948a78d9e7c9a76d1d30c851f87ecb93c, data reload: false query1 0.040.030.03 query2 0.070.040.03 query3 0.220.050.05 query4 1.690.080.07 query5 0.500.490.48 query6 1.140.720.73 query7 0.010.020.01 query8 0.060.050.05 query9 0.560.500.50 query10 0.550.550.54 query11 0.150.120.11 query12 0.140.130.13 query13 0.590.590.58 query14 0.750.790.78 query15 0.860.810.82 query16 0.370.350.36 query17 0.971.001.04 query18 0.220.210.22 query19 1.821.781.77 query20 0.010.010.01 query21 15.42 0.760.66 query22 4.517.252.01 query23 18.31 1.481.36 query24 2.130.230.23 query25 0.170.090.09 query26 0.300.210.21 query27 0.450.230.23 query28 13.25 1.031.02 query29 12.66 3.313.28 query30 0.250.060.05 query31 2.880.390.40 query32 3.260.470.46 query33 2.872.902.86 query34 17.12 4.324.34 query35 4.404.454.40 query36 0.650.470.47 query37 0.190.160.15 query38 0.150.140.14 query39 0.040.040.04 query40 0.160.130.13 query41 0.090.050.05 query42 0.060.050.05 query43 0.050.040.04 Total cold run time: 110.09 s Total hot run time: 30.87 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix]fix be core when migration tablet to other disk [doris]
z404289981 commented on PR #37712: URL: https://github.com/apache/doris/pull/37712#issuecomment-2232692863 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
doris-robot commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232694638 TPC-DS: Total hot run time: 172935 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS sf100 test result on commit baf70c8190e8d5e6dd69830c999ef43afe91e56b, data reload: false query1 915 374 364 364 query2 6449193518731873 query3 6678212 221 212 query4 25599 17661 17422 17422 query5 4219486 468 468 query6 277 165 187 165 query7 4604298 286 286 query8 242 207 195 195 query9 8532240723872387 query10 429 285 269 269 query11 12054 992110004 9921 query12 137 85 81 81 query13 1648376 364 364 query14 10344 702579227025 query15 222 169 170 169 query16 7991323 339 323 query17 1769557 548 548 query18 1718286 290 286 query19 205 160 157 157 query20 91 82 83 82 query21 208 136 129 129 query22 4268399541143995 query23 33934 33307 33278 33278 query24 12117 290228462846 query25 688 393 395 393 query26 1741153 150 150 query27 2928274 273 273 query28 7594200119881988 query29 1090653 641 641 query30 292 154 148 148 query31 955 739 766 739 query32 98 58 57 57 query33 790 317 311 311 query34 949 478 483 478 query35 710 604 591 591 query36 1078920 939 920 query37 280 85 86 85 query38 2919276327432743 query39 887 847 826 826 query40 282 125 123 123 query41 49 48 49 48 query42 129 106 101 101 query43 503 481 489 481 query44 1316749 751 749 query45 195 168 163 163 query46 1091754 716 716 query47 1853178917831783 query48 368 293 297 293 query49 1194443 424 424 query50 772 396 401 396 query51 6994684068456840 query52 110 92 100 92 query53 369 299 293 293 query54 893 461 452 452 query55 82 77 78 77 query56 306 294 288 288 query57 1163103910771039 query58 275 254 380 254 query59 2897269426712671 query60 302 269 270 269 query61 96 93 93 93 query62 835 653 668 653 query63 330 300 290 290 query64 10481 227516911691 query65 3233311831403118 query66 1309337 325 325 query67 15768 15016 15008 15008 query68 6693546 567 546 query69 784 440 367 367 query70 1188111710981098 query71 571 276 282 276 query72 8598562857095628 query73 828 335 330 330 query74 6688572056915691 query75 5076271326682668 query76 4769986 946 946 query77 754 306 308 306 query78 978810063 89008900 query79 10693 576 541 541 query80 1073507 480 480 query81 581 226 224 224 query82 795 134 130 130 query83 325 167 165 165 query84 279 85 88 85 query85 1421305 332 305 query86 429 285 304 285 query87 3310315231053105 query88 5115240123892389 query89 545 386 385 385 query90 2088207 201 201 query91 137 98 101 98 query92 62 54 48 48 query93 7760505 498 498 query94 1428214 213 213 query95 412 319 320 319 query96 609 277 277 277 query97 3142308830583058 query98 228 199 202 199 query99 1551126112561256 Total cold run time: 308564 ms Total hot run time: 172935 ms ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the
Re: [PR] [Chore](dependencies)upgrade netty to 4.1.111.final [doris]
CalvinKirs commented on PR #37994: URL: https://github.com/apache/doris/pull/37994#issuecomment-2232695738 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [Chore](dependencies)upgrade netty to 4.1.111.final [doris]
CalvinKirs opened a new pull request, #37994: URL: https://github.com/apache/doris/pull/37994 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Chore](dependencies)upgrade netty to 4.1.111.final [doris]
doris-robot commented on PR #37994: URL: https://github.com/apache/doris/pull/37994#issuecomment-2232695611 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [bug](delete) fix delete random distributed tbl [doris]
DarvenDuan commented on PR #37985: URL: https://github.com/apache/doris/pull/37985#issuecomment-2232698065 > add test case please done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](case)fix s3 tvf case failed in pipeline of 2.1 [doris]
zddr opened a new pull request, #37995: URL: https://github.com/apache/doris/pull/37995 default value `enable_fallback_to_original_planner` is true, resource priv check only support in nereids,so need set enable_fallback_to_original_planner=false; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](case)fix s3 tvf case failed in pipeline of 2.1 [doris]
doris-robot commented on PR #37995: URL: https://github.com/apache/doris/pull/37995#issuecomment-2232702879 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR) Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website). See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](case)fix s3 tvf case failed in pipeline of 2.1 [doris]
zddr commented on PR #37995: URL: https://github.com/apache/doris/pull/37995#issuecomment-2232703070 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [opt](column nullable) Optimization for ColumnNullable serialization [doris]
github-actions[bot] commented on PR #37896: URL: https://github.com/apache/doris/pull/37896#issuecomment-2232704130 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [refine](pipeline) remove no pipeline code in SenderQueue [doris]
doris-robot commented on PR #37208: URL: https://github.com/apache/doris/pull/37208#issuecomment-2232705189 ClickBench: Total hot run time: 30.82 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools ClickBench test result on commit baf70c8190e8d5e6dd69830c999ef43afe91e56b, data reload: false query1 0.040.040.02 query2 0.080.040.04 query3 0.220.040.05 query4 1.710.080.07 query5 0.490.480.50 query6 1.140.730.73 query7 0.030.010.01 query8 0.050.040.05 query9 0.540.490.48 query10 0.550.540.55 query11 0.150.110.11 query12 0.150.130.13 query13 0.590.590.59 query14 0.770.790.80 query15 0.860.820.82 query16 0.360.370.36 query17 0.971.011.01 query18 0.230.220.22 query19 1.921.781.86 query20 0.010.010.01 query21 15.42 0.760.66 query22 4.606.701.82 query23 18.23 1.421.24 query24 2.100.230.21 query25 0.140.080.08 query26 0.290.220.21 query27 0.450.230.24 query28 13.36 1.011.00 query29 12.61 3.393.37 query30 0.250.060.05 query31 2.880.400.39 query32 3.250.490.46 query33 2.852.952.91 query34 17.01 4.404.44 query35 4.434.484.46 query36 0.650.510.48 query37 0.180.160.16 query38 0.150.160.15 query39 0.050.040.03 query40 0.150.120.12 query41 0.100.050.05 query42 0.050.040.05 query43 0.040.030.04 Total cold run time: 110.1 s Total hot run time: 30.82 s ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](regression) fix regression sql which has schema change [doris]
github-actions[bot] commented on PR #37941: URL: https://github.com/apache/doris/pull/37941#issuecomment-2232707608 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [Fix](regression) fix regression sql which has schema change [doris]
github-actions[bot] commented on PR #37941: URL: https://github.com/apache/doris/pull/37941#issuecomment-2232707688 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) the bucket number arg of width_bucket should be a positive integer value [doris]
github-actions[bot] commented on PR #37892: URL: https://github.com/apache/doris/pull/37892#issuecomment-2232707952 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
Re: [PR] [fix](function) the bucket number arg of width_bucket should be a positive integer value [doris]
zhiqiang- commented on code in PR #37892:
URL: https://github.com/apache/doris/pull/37892#discussion_r1680633197
##
be/src/vec/functions/function_width_bucket.cpp:
##
@@ -86,12 +92,12 @@ class FunctionWidthBucket : public IFunction {
void _execute(const IColumn& expr_column, const IColumn& min_value_column,
const IColumn& max_value_column, const int64_t num_buckets,
IColumn& nested_column) const {
-const ColumnType& expr_column_concrete = reinterpret_cast(expr_column);
-const ColumnType& min_value_column_concrete =
+const auto& expr_column_concrete = reinterpret_cast(expr_column);
Review Comment:
why not using assert_cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
[PR] [fix](nereids)acos function should return null literal instead of NaN value [doris]
starocean999 opened a new pull request, #37996: URL: https://github.com/apache/doris/pull/37996 pick from master https://github.com/apache/doris/pull/37932 ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
