github-actions[bot] commented on code in PR #37990:
URL: https://github.com/apache/doris/pull/37990#discussion_r1680537939
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -140,23 +140,11 @@ Status VMysqlResultWriter<is_binary_format>::_set_options(
}
template <bool is_binary_format>
-Status VMysqlResultWriter<is_binary_format>::write(RuntimeState* state, Block&
input_block) {
- SCOPED_TIMER(_append_row_batch_timer);
+Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState*
state, Block& block) {
Review Comment:
warning: function '_write_one_block' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState*
state, Block& block) {
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/sink/vmysql_result_writer.cpp:142:** 95 lines including
whitespace and comments (threshold 80)
```cpp
Status VMysqlResultWriter<is_binary_format>::_write_one_block(RuntimeState*
state, Block& block) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
