Jibing-Li commented on code in PR #37923:
URL: https://github.com/apache/doris/pull/37923#discussion_r1680592807
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/algebra/CatalogRelation.java:
##########
@@ -27,4 +27,9 @@ public interface CatalogRelation extends Relation {
TableIf getTable();
DatabaseIf getDatabase() throws AnalysisException;
+
+ // For empty table, nereids require getting 1 as row count. This is a wrap
function for nereids to call getRowCount.
+ default long getRowCountForNereids() {
+ return Math.max(getTable().fetchRowCount(), 1);
Review Comment:
I think we should use getTable().getRowCount(), because for external table,
getRowCount reads data in cache, fetchRowCount may connect remote data source,
could be very heavy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
