zhiqiang-hhhh commented on code in PR #37892: URL: https://github.com/apache/doris/pull/37892#discussion_r1680633197
########## be/src/vec/functions/function_width_bucket.cpp: ########## @@ -86,12 +92,12 @@ class FunctionWidthBucket : public IFunction { void _execute(const IColumn& expr_column, const IColumn& min_value_column, const IColumn& max_value_column, const int64_t num_buckets, IColumn& nested_column) const { - const ColumnType& expr_column_concrete = reinterpret_cast<const ColumnType&>(expr_column); - const ColumnType& min_value_column_concrete = + const auto& expr_column_concrete = reinterpret_cast<const ColumnType&>(expr_column); Review Comment: why not using assert_cast? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org