Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

Any reason to not add tests on test_vec4_cmod_propagation as the fs equivalent did? Also, two small comments below. On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > No changes on Broadwell and later becuase those plaforms do not use the > vec4 backend at all. typo: becuase -> bec

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

Looks good in general, just a comment below. On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > This method is similar to the existing ::equals methods. Instead of > testing that two src_regs are equal to each other, it tests that one is > the negation of the other. > > v2: Simplif

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Allow cmod propagation when src0 is a uniform or shader input

Reviewed-by: Alejandro Piñeiro On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > No shader-db changes. This source must have been written by a previous > instruction, so it cannot be a uniform or a shader input. However, this > change allows the next commit to help about 900 mor

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Propagate conditional modifiers from compares to adds

Reviewed-by: Alejandro Piñeiro On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > The math inside the add and the cmp in this instruction sequence is the > same. We can utilize this to eliminate the compare. > > add(8) g5<1>F g2<8,8,1>F g64.5<0,1,0>F { ali

Re: [Mesa-dev] [PATCH 4/6] i965/vec4: Allow cmod propagation when src0 is a uniform or shader input

Reviewed-by: Alejandro Piñeiro On 22/03/18 01:58, Ian Romanick wrote: > From: Ian Romanick > > No shader-db changes. This source must have been written by a previous > instruction, so it cannot be a uniform or a shader input. However, this > change allows the next commit to help more shaders.

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

Hi Rob, On Thu, Mar 22, 2018 at 12:16 AM, Robert Foss wrote: > Hey, > > I've started looking into removing the gralloc method > GRALLOC_MODULE_PERFORM_GET_DRM_FD. Thanks a lot for looking into this. > > The issues around this seems to be two parts: > 1) Finding the right device to open > 2) Sha

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: > 2018-02-21 3:03 GMT+08:00 Rob Herring : >> >> Perhaps worth revisiting. Given we've failed to progress at all since >> then may change opinions some. We already have to handle multiple >> opens share the same pipe_screen, so I

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

Hi Stefan, On Thu, Mar 22, 2018 at 8:42 AM, Stefan Schake wrote: > Hey Robert, > > On Wed, Mar 21, 2018 at 4:16 PM, Robert Foss > wrote: >> Hey, >> >> I've started looking into removing the gralloc method >> GRALLOC_MODULE_PERFORM_GET_DRM_FD. >> >> The issues around this seems to be two parts:

Re: [Mesa-dev] [RFC] Mesa 17.3.x release problems and process improvements

On Thu, 2018-03-22 at 00:28 +, Emil Velikov wrote: > Hi all, > > Having gone through the thread a few times, I believe it can be > summarised as follows: > * Greater transparency is needed. > * Subsystem/team maintainers. > * Unfit and late nominations. > * Developers/everyone should be mo

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

On 22 March 2018 at 08:21, Tomasz Figa wrote: > Hi Rob, > > On Thu, Mar 22, 2018 at 12:16 AM, Robert Foss > wrote: >> Sharing the device between components >> - >> >> Currently the device is used by drm_hwc, gbm_gralloc and mesa. >> >> drm_hwc opens the *prim

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On Wed, 2018-03-21 at 13:36 +, Daniel Stone wrote: > Hi Juan, > > On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: > > The first two patches in the series is a new fix for issue > > https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version > > breaks when running the

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: > Hi Chih-Wei, > > On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: >> 2018-02-21 3:03 GMT+08:00 Rob Herring : >>> >>> Perhaps worth revisiting. Given we've failed to progress at all since >>> then may change opinions some. We already

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On 21 March 2018 at 13:36, Daniel Stone wrote: > Hi Juan, > > On 19 March 2018 at 17:49, Juan A. Suarez Romero wrote: >> The first two patches in the series is a new fix for issue >> https://bugs.freedesktop.org/show_bug.cgi?id=105211, as the current version >> breaks when running the above comma

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > On 21 March 2018 at 13:36, Daniel Stone wrote: > > Hi Juan, > > > > On 19 March 2018 at 17:49, Juan A. Suarez Romero > > wrote: > > > The first two patches in the series is a new fix for issue > > > https://bugs.freedesktop.org/show_bug.c

[Mesa-dev] [PATCH] nir/lower_vec_to_movs: Don't coalesce the mmove when src and dest are the same reg

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105440 Fixes: 2458ea95c56 "nir/lower_vec_to_movs: Coalesce movs on-the-fly when possible" Signed-off-by: Andriy Khulap Signed-off-by: Vadym Shovkoplias --- src/compiler/nir/nir_lower_vec_to_movs.c | 7 ++- 1 file changed, 6 insertions(+

[Mesa-dev] [Bug 105670] [regression][hang] Trine1EE hangs GPU after loading screen on Mesa3D-17.3 and later

https://bugs.freedesktop.org/show_bug.cgi?id=105670 --- Comment #1 from Tapani Pälli --- Could be related to loop unrolling (?) While playing back trace on i965 I saw this: --- 8< --- glretrace: ../src/compiler/nir/nir_opt_loop_unroll.c:414: complex_unroll: Assertion `unroll_loc->type == nir_cf_

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> On 21 March 2018 at 13:36, Daniel Stone wrote: >> > I thought we had resolved earlier to _not_ ship files generated by >> > wayland-scanner in dist after the last round of fixes. >>

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-03-12 09:09:50) > > On 12 March 2018 at 15:01, Eric Engestrom wrote: > > > Signed-off-by: Eric Engestrom > > > --- > > > Dylan, was there any reason to have -Werror=missing-prototypes and > > > -Werror=implicit-

Re: [Mesa-dev] [PATCH] radv: Unset ZRANGE_PRECISION when depth was zeroed

On Thu, 2018-03-22 at 02:36 +0100, Bas Nieuwenhuizen wrote: > On Thu, Mar 8, 2018 at 12:59 PM, James Legg > wrote: > > This avoids bug 105396 somehow. I suspect it is a VI and GFX9 hardware > > bug which PAL calls WaTcCompatZRange, but I don't know for sure. > > > > In the VK_FORMAT_D32_SFLOAT c

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: > On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: > > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > > > On 21 March 2018 at 13:36, Daniel Stone wrote: > > > > I thought we had resolved earlier to _not_ ship files generated

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On Thu, 2018-03-22 at 13:32 +0100, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: > > On 22 March 2018 at 11:16, Juan A. Suarez Romero > > wrote: > > > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: > > > > On 21 March 2018 at 13:36, Daniel Stone wr

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On 03/22/2018 01:01 PM, Emil Velikov wrote: Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we've failed to progress at all since then may c

[Mesa-dev] [Bug 105396] tc compatible htile sets depth of htiles of discarded fragments to 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=105396 soredake changed: What|Removed |Added CC||fds...@krutt.org -- You are receiving this

Re: [Mesa-dev] [PATCH v1 0/7] Implement commont gralloc_handle_t in libdrm

On March 22, 2018 06:07:01 Tapani Pälli wrote: On 03/22/2018 01:01 PM, Emil Velikov wrote: Hi guys, On 22 March 2018 at 08:23, Tomasz Figa wrote: Hi Chih-Wei, On Thu, Feb 22, 2018 at 2:53 PM, Chih-Wei Huang wrote: 2018-02-21 3:03 GMT+08:00 Rob Herring : Perhaps worth revisiting. Given we'

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On 22 March 2018 at 12:32, Juan A. Suarez Romero wrote: > On Thu, 2018-03-22 at 12:08 +, Daniel Stone wrote: >> On 22 March 2018 at 11:16, Juan A. Suarez Romero wrote: >> > On Thu, 2018-03-22 at 11:03 +, Emil Velikov wrote: >> > > On 21 March 2018 at 13:36, Daniel Stone wrote: >> > > > I

[Mesa-dev] [PATCH v2 1/4] mesa: add support for nvidia conservative rasterization extensions

Although the specs are written against compatibility GL 4.3 and allows core profile and GLES2+, it is exposed for GL 1.0+ and GLES1 and GLES2+. v2: fix indentation error in gl_API.xml --- src/mapi/glapi/gen/gl_API.xml | 47 +++ src/mapi/glapi/gen/gl_genexec.py| 1 +

[Mesa-dev] [PATCH v2 0/4] Implement Various Conservative Rasterization Extensions

This patch-set adds support for GL_NV_conservative_raster and GL_NV_conservative_raster_dilate on GM2xx and newer. It also adds support for GL_NV_conservative_raster_pre_snap_triangles on GP1xx. In doing so, it implements various functions in mesa core, extends the Gallium API, connects the new me

[Mesa-dev] [PATCH v2 2/4] gallium: add initial support for conservative rasterization

--- src/gallium/docs/source/cso/rasterizer.rst | 18 ++ src/gallium/docs/source/screen.rst | 18 ++ src/gallium/drivers/etnaviv/etnaviv_screen.c | 10 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 10 ++ src/gallium/dr

[Mesa-dev] [PATCH v2 3/4] st/mesa: add support for nvidia conservative rasterization extensions

--- src/mesa/state_tracker/st_atom_rasterizer.c | 12 ++ src/mesa/state_tracker/st_atom_viewport.c | 4 src/mesa/state_tracker/st_context.c | 2 ++ src/mesa/state_tracker/st_extensions.c | 34 + 4 files changed, 52 insertions(+) diff --git

[Mesa-dev] [PATCH 4v2 /4] nvc0: add conservative rasterization support (v2)

Subpixel precision bias, dilation and the post-snap mode are supported on GM200 and newer. The pre-snap mode is supported for triangle primitives on GP100. v2: fix code to handle earlier hardware --- src/gallium/drivers/nouveau/nvc0/nvc0_3d.xml.h | 5 + src/gallium/drivers/nouveau/nvc

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

Hello Ilia, On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: > Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's > called... I forget.) I checked and I don't think a capability exists for this (anymore?). Everywhere, the assumption is meant that all Gallium drivers

Re: [Mesa-dev] [PATCH 4/7] freedreno: a2xx: Support TEXTURE_RECT

On Thu, Mar 22, 2018 at 10:43 AM, Wladimir J. van der Laan wrote: > Hello Ilia, > > On Thu, Jan 25, 2018 at 08:41:11AM -0500, Ilia Mirkin wrote: >> Should you also expose PIPE_CAP_TEXTURE_RECTANGLE? (Or whatever it's >> called... I forget.) > > I checked and I don't think a capability exists for t

[Mesa-dev] [PATCH 3/5] ac/gpu_info: rename has_virtual_memory -> r600_has_virtual_memory

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 2 +- src/amd/common/ac_gpu_info.h | 2 +- src/gallium/drivers/r600/r600_buffer_common.c | 4 ++-- src/gallium/drivers/r600/r600_cs.h| 2 +- src/gallium/drivers/r600/r600_pipe_c

[Mesa-dev] [PATCH 1/5] winsys/amdgpu: always allow GTT placements on APUs

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c index 7740b46b7b9..22b5a73143d 100644 --- a/src/gallium/winsys/a

[Mesa-dev] [PATCH 4/5] ac/gpu_info: reorder the fields and print them nicely

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 107 --- src/amd/common/ac_gpu_info.h | 24 ++ 2 files changed, 76 insertions(+), 55 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 8f01038a3a0..9fe

[Mesa-dev] [PATCH 2/5] ac/gpu_info: don't print irrelevant fields

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 73fc36203c1..ca556a8b11f 100644 --- a/src/amd/common/ac_gpu_info.c +++ b/src/amd/common/ac_gpu_info.c @@ -415,21 +415,20 @@

[Mesa-dev] [PATCH 5/5] ac/gpu_info: print GB_ADDR_CONFIG

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 50 src/amd/common/ac_gpu_info.h | 1 + 2 files changed, 51 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c b/src/amd/common/ac_gpu_info.c index 9fe1a318723..bd7bc50dafb 100644 --- a/src/a

[Mesa-dev] [PATCH 1/2] amd/addrlib: update to the latest version for Vega12

From: Marek Olšák Reviewed-by: Alex Deucher --- src/amd/addrlib/addrinterface.cpp| 32 - src/amd/addrlib/addrinterface.h | 62 ++ src/amd/addrlib/addrtypes.h | 6 +- src/amd/addrlib/amdgpu_asic_addr.h | 3 + src/amd/addrlib/core/addrlib.cpp | 80 ++

[Mesa-dev] [PATCH 2/2] radeonsi: add support for Vega12

From: Marek Olšák Reviewed-by: Alex Deucher --- include/pci_ids/radeonsi_pci_ids.h | 6 + src/amd/common/ac_llvm_util.c | 1 + src/amd/common/ac_surface.c | 33 +++-- src/amd/common/amd_family.h |

[Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface queues, but the display_sync for swrast_commit_backbuffer remained on the old queue. This is likely to break when dispatching the correct queue at the top of function (which can't dispatch the sync callback we're waiting for).

[Mesa-dev] [PATCH] st/mesa: silence unhandled switch case warning

And improve the unreachable() error message. --- src/mesa/state_tracker/st_glsl_types.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_types.cpp b/src/mesa/state_tracker/st_glsl_types.cpp index ef7b7fa..baba2d4 100644 --- a/src/mesa/state_tr

[Mesa-dev] [PATCH v2 0/8] freedreno: a2xx improvements

While working on a205 support for i.MX51/53, I've also written some patches that are not specific to a20x but should apply to the whole a2xx range. As I'm figuring out how to handle backward compatibility to other a2xx, I think it makes sense to send these upstream already to reduce the patch stac

[Mesa-dev] [PATCH v2 3/8] freedreno: a2xx: Fix fd2_tex_swiz

Compose swizzles using util_format_compose_swizzles instead of the custom code (which somehow had a bug). This makes the GL_ALPHA internal format work. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 18 +- 1 file changed, 9 insertions

[Mesa-dev] [PATCH v2 4/8] freedreno: a2xx: Prevent crash in emit_texture if view is not set

Textures will sometimes be updated if texture view state was un-set, without this change that causes an assertion crash or segfault. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) dif

[Mesa-dev] [PATCH v2 7/8] freedreno: a2xx: implement SEQ/SNE instructions

Extend translate_sge_slt to emit these, in analogous fashion but using CNDEv. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/freedreno/a

[Mesa-dev] [PATCH v2 1/8] freedreno: a2xx: Update rnndb header for formats enumeration

The format enumeration comes comes from the yamoto register headers that are part of the amd-gpu kernel driver. (see freedreno envytools commit 1b32c444f82cd7144d71602106462f59f146c1d0) Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/a2xx.xml.h | 33 +++

[Mesa-dev] [PATCH v2 2/8] freedreno: a2xx: Change use of BLEND_ to BLEND2_

Change use of BLEND_ to BLEND2_, BLEND_* a3xx_rb_blend_opcode BLEND2_* is a2xx_rb_blend_opcode This makes no effective difference as the used enumerant has the same value (0), but the other enumerants do not match 1-to-1 so this will avoid future problems. Signed-off-by: Wladimir J. van

[Mesa-dev] [PATCH v2 5/8] freedreno: a2xx: Support TEXTURE_RECT

Denormalized texture coordinates are required for text rendering in GALLIUM_HUD. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 3 ++- src/gallium/drivers/freedreno/a2xx/ir-a2xx.c | 1 + src/gallium/drivers/freedreno/a2xx/ir-a2xx.h | 1 +

[Mesa-dev] [PATCH v2 6/8] freedreno: a2xx: Compressed textures support

Add support for: - PIPE_FORMAT_ETC1_RGB8 - PIPE_FORMAT_DXT1_RGB - PIPE_FORMAT_DXT1_RGBA - PIPE_FORMAT_DXT3_RGBA - PIPE_FORMAT_DXT5_RGBA Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_util.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/

[Mesa-dev] [PATCH] x11: Only report supported DRI3/Present versions

The version passed to QueryVersion requests is the version that the client supports. We were just passing in whatever version of XCB was present on the system, which may not be a version that Mesa actually explicitly supports, e.g. it might bring unwanted semantics. Set specific protocol versions

[Mesa-dev] [PATCH v2 8/8] freedreno: a2xx: Implement DP2 instruction

Use DOT2ADDv instruction with 0.0f constant add. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_compiler.c b/src/gallium/drivers/freed

[Mesa-dev] [PATCH 1/7] tgsi: convert opcode macros to enums

Enums are nicer in gdb. --- src/gallium/include/pipe/p_shader_tokens.h | 548 +++-- 1 file changed, 275 insertions(+), 273 deletions(-) diff --git a/src/gallium/include/pipe/p_shader_tokens.h b/src/gallium/include/pipe/p_shader_tokens.h index 4e95789..f4e45c2 100644 --- a

[Mesa-dev] [PATCH 7/7] tgsi,softpipe: use enum tgsi_opcode

--- src/gallium/auxiliary/tgsi/tgsi_exec.h | 4 ++-- src/gallium/drivers/softpipe/sp_buffer.c | 4 ++-- src/gallium/drivers/softpipe/sp_image.c | 8 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.h b/src/gallium/auxiliary/tgsi/tgsi_

[Mesa-dev] [PATCH 4/7] tgsi: use enum tgsi_opcode

--- src/gallium/auxiliary/tgsi/tgsi_build.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_lowering.c | 6 +++--- src/gallium/auxiliary/tgsi/tgsi_scan.c | 6 +++--- src/gallium/auxiliary/tgsi/tgsi_transform.c | 2 +- src/gallium/auxiliary/tgsi/tgsi_transform.h | 12 ++-- 5 files cha

[Mesa-dev] [PATCH 6/7] st/mesa,tgsi: use enum tgsi_opcode

Need to update the tgsi code and st_glsl_to_tgsi code at the same time to prevent compile break since C++ is much pickier about implicit enum/unsigned casting. Bump size of glsl_to_tgsi_instruction::op to 10 bits to be sure to avoid MSVC signed enum overflow issue. No change in class size. --- s

[Mesa-dev] [PATCH 3/7] gallivm: use enum tgis_opcode

--- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 8 src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 12 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c index 079

[Mesa-dev] [PATCH 5/7] tgsi/nir: use enum tgsi_opcode

--- src/gallium/auxiliary/nir/tgsi_to_nir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index bbbf101..b5b4869 100644 --- a/src/gallium/auxiliary/nir/tgsi_to_nir.c +++ b/src/gallium/auxil

Re: [Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

On 22 March 2018 at 15:20, Derek Foreman wrote: > commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface > queues, but the display_sync for swrast_commit_backbuffer remained on > the old queue. This is likely to break when dispatching the correct > queue at the top of function (wh

[Mesa-dev] [PATCH 2/7] svga: use enum tgsi_opcode

--- src/gallium/drivers/svga/svga_tgsi_insn.c | 2 +- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_insn.c b/src/gallium/drivers/svga/svga_tgsi_insn.c index be99ad5..c08809c 100644 ---

[Mesa-dev] [PATCH 2/2] svga: simplify uses_flat_interp expression in emit_input_declarations()

--- src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c index 04d8303..4292894 100644 --- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c +++ b/src/g

[Mesa-dev] [PATCH 1/2] svga: replace unsigned with proper enum names

--- src/gallium/drivers/svga/svga_tgsi_emit.h | 12 ++-- src/gallium/drivers/svga/svga_tgsi_insn.c | 19 ++- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/src/gallium/drivers/svga/svga_tgsi_emit.h b/src/gallium/drivers/svga/svga_tgsi_emit.h index 114c956

[Mesa-dev] [PATCH 3/3] st/mesa: s/unsigned/enum pipe_shader_type/ for st_bind_ubos()

--- src/mesa/state_tracker/st_atom_constbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index 0c094dc..6455e61 100644 --- a/src/mesa/state_tracker/st_atom_constbuf.c +++ b/src/mesa/stat

[Mesa-dev] [PATCH 2/3] st/mesa: whitespace/formatting fixes in st_atom_constbuf.c

--- src/mesa/state_tracker/st_atom_constbuf.c | 57 +++ 1 file changed, 36 insertions(+), 21 deletions(-) diff --git a/src/mesa/state_tracker/st_atom_constbuf.c b/src/mesa/state_tracker/st_atom_constbuf.c index 87a72b2..0c094dc 100644 --- a/src/mesa/state_tracker/st_a

[Mesa-dev] [PATCH 1/3] st/mesa: s/unsigned/enum pipe_shader_type/

--- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 6 -- src/mesa/state_tracker/st_glsl_to_tgsi.h | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index fc53811..5f7a0dc 100644 --- a/

Re: [Mesa-dev] [PATCH 1/5] winsys/amdgpu: always allow GTT placements on APUs

Reviewed-by: Christian König Am 22.03.2018 um 16:03 schrieb Marek Olšák: From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_bo.c b/src/gallium/winsys/amdgpu/d

[Mesa-dev] [PATCH 2/2] radv: rename VEGA10 device name

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index e9122072a8..8c406a572c 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c

[Mesa-dev] [PATCH 1/2] radv: add support for Vega12

Based on RadeonSI. Untested. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 5 - src/amd/vulkan/radv_pipeline.c | 1 + src/amd/vulkan/si_cmd_buffer.c | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_d

Re: [Mesa-dev] [Freedreno] [PATCH v2 7/8] freedreno: a2xx: implement SEQ/SNE instructions

On Thu, Mar 22, 2018 at 11:26 AM, Wladimir J. van der Laan wrote: > Extend translate_sge_slt to emit these, in analogous fashion > but using CNDEv. > > Signed-off-by: Wladimir J. van der Laan > --- > src/gallium/drivers/freedreno/a2xx/fd2_compiler.c | 23 > --- > 1 file chan

Re: [Mesa-dev] [PATCH v2 0/8] freedreno: a2xx improvements

With the minor whitespace issue I pointed out (which might also apply to 8/8, couldn't tell), this is Reviewed-by: Ilia Mirkin On Thu, Mar 22, 2018 at 11:26 AM, Wladimir J. van der Laan wrote: > While working on a205 support for i.MX51/53, I've also written some patches > that are not specific

[Mesa-dev] [PATCH] i965/perf: fix config registration when uploading to kernel

When registring configuration to the kernel for the first time, we run into an issue where the id number is not properly set. As a result when trying to use that id later on, we get an error. This issue manifest itself the first time you use frameretrace after reboot, subsequent runs are fine. Fi

Re: [Mesa-dev] [PATCH v2 0/8] freedreno: a2xx improvements

On Thu, Mar 22, 2018 at 11:46:57AM -0400, Ilia Mirkin wrote: > With the minor whitespace issue I pointed out (which might also apply > to 8/8, couldn't tell), this is Looks like there is also a case in 5/8, will go over them and resubmit the ones with wacky spacing. (I think the issue here is that

Re: [Mesa-dev] [PATCH 05/11] intel/compiler: Use null destination register for memory fence messages

On Wed, Mar 21, 2018 at 3:08 PM, Francisco Jerez wrote: > Matt Turner writes: > >> On Wed, Mar 21, 2018 at 2:56 PM, Francisco Jerez >> wrote: >>> Matt Turner writes: >>> From Message Descriptor section in gfxspecs: "Memory fence messages without Commit Enable set do not return

Re: [Mesa-dev] [PATCH] st: Allow accelerated CopyTexImage from RGBA to RGB.

On 03/21/2018 02:54 PM, Eric Anholt wrote: There's nothing to worry about here -- the A channel just gets dropped by the blit. This avoids a segfault in the fallback path when copying from a RGBA16_SINT renderbuffer to a RGB16_SINT destination represented by an RGBA16_SINT texture (the fallback

Re: [Mesa-dev] [PATCH] egl/wayland: Make swrast display_sync the correct queue

On Thursday, 2018-03-22 15:28:49 +, Daniel Stone wrote: > On 22 March 2018 at 15:20, Derek Foreman wrote: > > commit 03dd9a88b0be17ff0ce91e92f6902a9a85ba584a introduced per surface > > queues, but the display_sync for swrast_commit_backbuffer remained on > > the old queue. This is likely to b

Re: [Mesa-dev] [PATCH] gallium/u_vbuf: Protect against overflow with large instance divisors.

On 03/21/2018 11:06 AM, Eric Anholt wrote: GTF-GLES3.gtf.GL3Tests.instanced_arrays.instanced_arrays_divisor uses -1 as a divisor, Since GL's vertex attrib instance divisor is a GLuint, we can alternately say the divisor is ~0, right? so we would overflow to count=0 and upload no data, trig

[Mesa-dev] [PATCH v2 0/7] Fix several issues/missings in make dist/distcheck

This series fix several issues that happen when running "./autogen.sh && make {dist, distcheck}". This V2 is similar to V1, except for the first patch: we now exclude from dist the generated wayland-scanner files. Juan A. Suarez Romero (7): waylan-drm: do not distribute generated sources nir

[Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

Instead we will re-generate them again on building. --- src/egl/Makefile.am | 10 +- src/egl/wayland/wayland-drm/Makefile.am | 8 ++-- src/vulkan/Makefile.am | 11 +-- 3 files changed, 24 insertions(+), 5 deletions(-) diff --git a/src/egl/

[Mesa-dev] [PATCH v2 4/7] radv: autotools: add radv_extensions.h in the generated VULKAN list

Reviewed-by: Emil Velikov --- src/amd/vulkan/Makefile.sources | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/Makefile.sources b/src/amd/vulkan/Makefile.sources index b0a8f8b97d8..ccb956a2396 100644 --- a/src/amd/vulkan/Makefile.sources +++ b/src/amd/vulkan/Ma

[Mesa-dev] [PATCH v2 2/7] nir: autotools, meson: add GLSL.ext.AMD.h in the files list

Reviewed-by: Emil Velikov --- src/compiler/Makefile.sources | 1 + src/compiler/nir/meson.build | 1 + 2 files changed, 2 insertions(+) diff --git a/src/compiler/Makefile.sources b/src/compiler/Makefile.sources index b231f2fa972..2dc48365507 100644 --- a/src/compiler/Makefile.sources +++ b/src/

[Mesa-dev] [PATCH v2 3/7] anv/radv: autotools: include vulkan_*.h headers

Reviewed-by: Emil Velikov --- src/amd/vulkan/Makefile.am | 4 src/intel/Makefile.vulkan.am | 4 2 files changed, 8 insertions(+) diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am index cc1b53980fd..00b808229fa 100644 --- a/src/amd/vulkan/Makefile.am +++ b/src/amd/v

Re: [Mesa-dev] [PATCH 0/8] Fix several issues/missings in make dist/distcheck

On Thu, 2018-03-22 at 14:16 +, Emil Velikov wrote: > Can we merge the series as-is, until we untangle the dist bits? Just sent a V2 following Daniel proposal. J.A. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.free

[Mesa-dev] [PATCH v2 6/7] autotools: add tegra header files

Reviewed-by: Emil Velikov --- Makefile.am | 1 + src/gallium/winsys/tegra/drm/Makefile.sources | 1 + 2 files changed, 2 insertions(+) diff --git a/Makefile.am b/Makefile.am index de6921bf1fc..804b1d85353 100644 --- a/Makefile.am +++ b/Makefile.am @@ -75,6 +75,7

[Mesa-dev] [PATCH v2 5/7] swr/rast: autotools: add events_private.proto in dist tarball.

Reviewed-by: Emil Velikov --- src/gallium/drivers/swr/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am index 13c7f8b7345..5ec9213c349 100644 --- a/src/gallium/drivers/swr/Makefile.am +++ b/src/gallium/driver

[Mesa-dev] [PATCH v2 7/7] broadcom/vc4: add path to nir_builder.h

As the other VC4 files do. Otherwise, it won't find nir_builder.h v2: add path in source code rather changing autotools (Emil) Reviewed-by: Emil Velikov --- src/gallium/drivers/vc4/vc4_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_blit.c

[Mesa-dev] [Bug 105670] [regression][hang] Trine1EE hangs GPU after loading screen on Mesa3D-17.3 and later

https://bugs.freedesktop.org/show_bug.cgi?id=105670 --- Comment #2 from Gert Wollny --- I can confirm this on Radeon 6870 HD. I was able to track the issue to the series beginning with ab23b759f24 glsl: don't drop instructions from unreachable terminators continue branch

Re: [Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

Hi Juan, On 22 March 2018 at 16:49, Juan A. Suarez Romero wrote: > Instead we will re-generate them again on building. Thanks for sending the v2 - that looks good to me. There was some kind of problem with having the sources in BUILT_SOURCES though, which Emil might be able to remember. Is it ne

Re: [Mesa-dev] [PATCH v3 3/8] drm-uapi: bump headers

On Wednesday, March 21, 2018 7:12:48 AM PDT Lionel Landwerlin wrote: > Required updates from drm-next for changes in i965. > > Signed-off-by: Lionel Landwerlin > --- > include/drm-uapi/README | 8 +-- > include/drm-uapi/drm_mode.h | 43 +--- > include/drm-uapi/i915_drm.h | 152

Re: [Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

On Thu, 2018-03-22 at 17:01 +, Daniel Stone wrote: > Hi Juan, > > On 22 March 2018 at 16:49, Juan A. Suarez Romero wrote: > > Instead we will re-generate them again on building. > > Thanks for sending the v2 - that looks good to me. There was some kind > of problem with having the sources in

Re: [Mesa-dev] [PATCH v2 1/7] waylan-drm: do not distribute generated sources

On 22 March 2018 at 17:01, Daniel Stone wrote: > Hi Juan, > > On 22 March 2018 at 16:49, Juan A. Suarez Romero wrote: >> Instead we will re-generate them again on building. > > Thanks for sending the v2 - that looks good to me. There was some kind > of problem with having the sources in BUILT_SOU

Re: [Mesa-dev] [PATCH v3 5/8] intel: devinfo: add helper functions to fill fusing masks values

On Wednesday, March 21, 2018 7:12:50 AM PDT Lionel Landwerlin wrote: > There are a couple of ways we can get the fusing information from the > kernel : > > - Through DRM_I915_GETPARAM with the SLICE_MASK/SUBSLICE_MASK > parameters > > - Through the new DRM_IOCTL_I915_QUERY by requesting t

Re: [Mesa-dev] [PATCH] i965/perf: fix config registration when uploading to kernel

On Thursday, March 22, 2018 9:02:11 AM PDT Lionel Landwerlin wrote: > When registring configuration to the kernel for the first time, we run > into an issue where the id number is not properly set. As a result > when trying to use that id later on, we get an error. > > This issue manifest itself t

[Mesa-dev] [Bug 105670] [regression][hang] Trine1EE hangs GPU after loading screen on Mesa3D-17.3 and later

https://bugs.freedesktop.org/show_bug.cgi?id=105670 --- Comment #3 from Roland Scheidegger --- (In reply to Gert Wollny from comment #2) > Regarding bisecting this, after a failure one usually must reboot the > system, otherwise the graphics card is in a bad state. But given the nature > of the b

[Mesa-dev] [PATCH v3] radv: fix scanning output_usage_mask with structs

To fix a regression in: dEQP-VK.spirv_assembly.instruction.graphics.variable_init.output.struct And the following regressions (Polaris only): dEQP-VK.glsl.indexing.varying_array.* v3: account for slots (Dave) v2: handle indirect array accesses (Dave) Fixes: f3275ca01c ("ac/nir: only enable used

[Mesa-dev] [PATCH] radv: disable binning state in some situations

This is imported from RadeonSI/ADMVLK. That might or might not improve performance. Anyway, it's still disabled by default. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 56 +- 1 file changed, 55 insertions(+), 1 deletion(-) diff --g

Re: [Mesa-dev] Removing GRALLOC_MODULE_PERFORM_GET_DRM_FD

Hey Tomasz, On 03/22/2018 09:27 AM, Tomasz Figa wrote: Hi Stefan, On Thu, Mar 22, 2018 at 8:42 AM, Stefan Schake wrote: Hey Robert, On Wed, Mar 21, 2018 at 4:16 PM, Robert Foss wrote: Hey, I've started looking into removing the gralloc method GRALLOC_MODULE_PERFORM_GET_DRM_FD. The issues

Re: [Mesa-dev] [PATCH 5/6] i965/vec4: Propagate conditional modifiers from compares to adds

On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: > Any reason to not add tests on test_vec4_cmod_propagation as the fs > equivalent did? Laziness. :) > Also, two small comments below. > > On 22/03/18 01:58, Ian Romanick wrote: >> From: Ian Romanick >> >> No changes on Broadwell and later becuas

Re: [Mesa-dev] [PATCH 1/6] i965: Add negative_equals methods

On 03/22/2018 01:12 AM, Alejandro Piñeiro wrote: > Looks good in general, just a comment below. > > > On 22/03/18 01:58, Ian Romanick wrote: >> From: Ian Romanick >> >> This method is similar to the existing ::equals methods. Instead of >> testing that two src_regs are equal to each other, it t

Re: [Mesa-dev] [PATCH mesa] meson: merge C and C++ compiler arguments check

Quoting Eric Engestrom (2018-03-22 05:08:55) > On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > > Quoting Emil Velikov (2018-03-12 09:09:50) > > > On 12 March 2018 at 15:01, Eric Engestrom > > > wrote: > > > > Signed-off-by: Eric Engestrom > > > > --- > > > > Dylan, was there any reaso

Re: [Mesa-dev] [PATCH v6 1/2] gallium/winsys/kms: Fix possible leak in map/unmap.

On 21 March 2018 at 18:00, Lepton Wu wrote: > Thanks all for review. Is there anything else missing for getting this > committed? Some of us tend to give extra 24h or so for other devs to send final comments/R-B. Everything seems silent so the series is in master now. Thanks! Tomasz can apply f

[Mesa-dev] [PATCH] i965: Drop PIPE_CONTROL_NO_WRITE from various calls.

This is just zero - passing nothing already gives us a post-sync operation of "nothing". --- src/mesa/drivers/dri/i965/brw_misc_state.c | 4 +--- src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 4 +--- src/mesa/drivers/dri/i965/gen7_l3_state.c

  1   2   >