On Monday, 2018-03-12 10:16:33 -0700, Dylan Baker wrote: > Quoting Emil Velikov (2018-03-12 09:09:50) > > On 12 March 2018 at 15:01, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > > --- > > > Dylan, was there any reason to have -Werror=missing-prototypes and > > > -Werror=implicit-function-declaration in C but not C++? > > > Both sound to me like something we always want. > > > > Seems to be copied from the autotools setup. > > Reason being, both are not valid for C++. > > Although since we probe for them, everything should be fine. The C++ > > test will bail out and the flags won't be set during the actual build. > > Which is why I left them separate, since it avoids having to compile for > arguments we know that C++ doesn't support.
Pushed now (cb2ddcefa5196fdfeff7), but to explain, my point was: we want those warnings when possible, so we might as well test for them and use them if/when support is added in the compilers. The configure-time cost is very low, and the build-time cost is non-existent :) > It probably doesn't matter either way, > > Reviewed-by: Dylan Baker <dy...@pnwbakers.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
