[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes If someone (aka me) wanted to convert this into another format (aka Markdown), these changes mean you can more easily script that conversion. --- Patch is 118.87 KiB, truncated to 20.00 KiB below, fu

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: Subsequent PRs will build on this: * Enable Markdown support in the website build. * Use a script to convert this file to Markdown. * Hand correct the result. So we: 1. Have this on the website, just like GDB's protocol specs and 2. It's in a format that's easier to contribu

[Lldb-commits] [lldb] [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (PR #89427)

2024-04-22 Thread Michael Buch via lldb-commits
Michael137 wrote: LGTM thanks for the cleanup! https://github.com/llvm/llvm-project/pull/89427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (PR #89427)

2024-04-22 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/89427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes written (base 16) +//-- +// vFile:MD5: +// +// BRIEF +// Generate an MD5 hash of the

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/89357 >From 518cb052ee364192fc5c813a2962f80f39345cd5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 19 Apr 2024 09:15:54 + Subject: [PATCH 1/2] [lldb][Docs] Document vFile:exists and vFile:MD5 Thes

[Lldb-commits] [lldb] [lldb][Docs] Document vFile:exists and vFile:MD5 (PR #89357)

2024-04-22 Thread David Spickett via lldb-commits
@@ -429,7 +429,43 @@ incompatible with the flags that gdb specifies. // // Response is F, followed by the number of bytes written (base 16) +//-- +// vFile:MD5: +// +// BRIEF +// Generate an MD5 hash of the

[Lldb-commits] [lldb] [llvm] [lldb][FreeBSD][AArch64] Enable register field detection (PR #85058)

2024-04-22 Thread David Spickett via lldb-commits
DavidSpickett wrote: @emaste ping! https://github.com/llvm/llvm-project/pull/85058 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/89405 >From 91a4fa40c9fdaee1794fedb3c49707130c22a06b Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 19 Apr 2024 08:08:02 -0700 Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli Summary: Wh

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
@@ -104,3 +124,27 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message(self): +source = "main.cpp" +program = self.get

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
@@ -104,3 +124,27 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message(self): +source = "main.cpp" +program = self.get

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] 9ef9db7 - [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (#89427)

2024-04-22 Thread via lldb-commits
Author: Zequan Wu Date: 2024-04-22T10:17:26-04:00 New Revision: 9ef9db7087fe6ce00a84f1456fce9f2e98db0769 URL: https://github.com/llvm/llvm-project/commit/9ef9db7087fe6ce00a84f1456fce9f2e98db0769 DIFF: https://github.com/llvm/llvm-project/commit/9ef9db7087fe6ce00a84f1456fce9f2e98db0769.diff LOG

[Lldb-commits] [lldb] [lldb][DWARF] Remove m_forward_decl_die_to_compiler_type as it never actually being used. (PR #89427)

2024-04-22 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/89427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused pexpect/ptyprocess (PR #89609)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jordan Rupprecht (rupprecht) Changes --- Patch is 224.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/89609.diff 35 Files Affected: - (removed) lldb/third_party/Python/module/pexpect-4.6/.

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/89405 >From 5e270c26adbb1e8febb72fc74d348d4f9619c7bf Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 19 Apr 2024 08:08:02 -0700 Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli Summary: Wh

[Lldb-commits] [lldb] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. lgtm. Thank you! I've wanted this feature for a while, tbh, because the user doesn't know if the program terminated successfully or if the debugger crashed. https://github.com/llvm/llvm-project/pull/89405 _

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3a4bc11b675c0511319c2843221133e986825b3b...5e270c26adbb1e8febb72fc74d348d4f9619c7bf lldb/

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/89405 >From b20ef7c68e23835ebf2c31f836407a0fb9f875a0 Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 19 Apr 2024 08:08:02 -0700 Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli Summary: Wh

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Subsequent PRs will build on this: > > * Enable Markdown support in the website build. I added markdown support in 8b95bd3310c126e76e0714bea6003a9b1aa739fb but it was subsequently removed again in d03b04f211e73c2f59ba5dc6a6a8c777de001ad6 (I wasn't added as a reviewer, so

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: +1 on making this available on the website. Unless the goal is to preserve both the textual and the markdown format, I'm not sure there's a whole lot of value in landing this. Maybe we can avoid churn and jump straight ahead to the markdown version? https://github.com/llv

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
@@ -104,3 +115,49 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message_sigterm(self): +source = "main.cpp" +program =

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused pexpect/ptyprocess (PR #89609)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thank you for seeing this all the way through, Jordan! 🥳 https://github.com/llvm/llvm-project/pull/89609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb][Docs] Make formatting regular in lldb-gdb-remote.txt (PR #89587)

2024-04-22 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. Yes please, very long overdue, I've felt bad about not trying to do something here myself. https://github.com/llvm/llvm-project/pull/89587 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread via lldb-commits
@@ -104,3 +115,49 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message_sigterm(self): +source = "main.cpp" +program =

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread via lldb-commits
@@ -503,6 +503,14 @@ void EventThreadFunction() { SendContinuedEvent(); break; case lldb::eStateExited: +const int exit_status = process.GetExitStatus(); +const char *const exit_description = process.GetExitDescription()

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread via lldb-commits
@@ -104,3 +115,49 @@ def test_empty_escape_prefix(self): "Help can be invoked", command_escape_prefix="", ) + +@skipIfWindows +@skipIfRemote +def test_exit_status_message_sigterm(self): +source = "main.cpp" +program =

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
@@ -4,10 +4,30 @@ import dap_server import lldbdap_testcase +import psutil +from collections import deque from lldbsuite.test import lldbutil from lldbsuite.test.decorators import * from lldbsuite.test.lldbtest import * +def get_subprocess_pid(process_name): +queue =

[Lldb-commits] [lldb] 92631a4 - [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam (#88564)

2024-04-22 Thread via lldb-commits
Author: Miro Bucko Date: 2024-04-22T10:40:06-07:00 New Revision: 92631a4824a91f3268a5716dd3459df8dc6bfb63 URL: https://github.com/llvm/llvm-project/commit/92631a4824a91f3268a5716dd3459df8dc6bfb63 DIFF: https://github.com/llvm/llvm-project/commit/92631a4824a91f3268a5716dd3459df8dc6bfb63.diff LO

[Lldb-commits] [lldb] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam (PR #88564)

2024-04-22 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/88564 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][MinidumpFileBuilder] Fix addition of MemoryList steam (PR #88564)

2024-04-22 Thread via lldb-commits
github-actions[bot] wrote: @mbucko Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

2024-04-22 Thread Fred Grim via lldb-commits
https://github.com/feg208 created https://github.com/llvm/llvm-project/pull/89637 @jimingham I am wondering if you are ok removing this test? It caused failures in some of the build bots because the user time was less than a microsecond. Alternatively we can increase the number of loops or may

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Fred Grim (feg208) Changes @jimingham I am wondering if you are ok removing this test? It caused failures in some of the build bots because the user time was less than a microsecond. Alternatively we can increase the number of loops or may

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Michael Kruse via lldb-commits
https://github.com/Meinersbur ready_for_review https://github.com/llvm/llvm-project/pull/89153 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARGET

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARG

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Kruse (Meinersbur) Changes Update the folder titles for targets in the monorepository that have not seen taken care of for some time. These are the folders that targets are organized in Visual Studio and XCode (`set_property(TARGET

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -406,5 +426,13 @@ function(llvm_ExternalProject_Add name source_dir) WORKING_DIRECTORY ${BINARY_DIR} VERBATIM USES_TERMINAL) +if (ARG_FOLDER) + set_target_properties(${target} PROPERTIES FOLDER "${ARG_FOLDER}") +endif () endforeach() + + #s

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/89405 >From 4c22c237dae73f3fbac22c0d725ae4fa449170df Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 19 Apr 2024 08:08:02 -0700 Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli Summary: Wh

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread via lldb-commits
@@ -56,11 +56,13 @@ endfunction() # Use provided strip tool instead of the default one. # TARGET_TRIPLE triple # Optional target triple to pass to the compiler +# FOLDER +# For IDEs, the Folder to put the targets into.= whisperity wrote: Maybe

[Lldb-commits] [lldb] [lldb][NFC] Remove unused pexpect/ptyprocess (PR #89609)

2024-04-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/89609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-22 Thread Miro Bucko via lldb-commits
https://github.com/mbucko updated https://github.com/llvm/llvm-project/pull/89405 >From d0ed0c618aeaf81dd471fc31c9f14d4b207effaa Mon Sep 17 00:00:00 2001 From: Miro Bucko Date: Fri, 19 Apr 2024 08:08:02 -0700 Subject: [PATCH] Report exit status message in lldb-dap, same as lldb cli Summary: Wh

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89650 Addresses #85984 >From 8aed7cb301347db507de10106ed41f9c6be50b1b Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 22 Apr 2024 14:56:11 -0400 Subject: [PATCH] [lldb][Core] Fix pointless if conditon Sign

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Troy Butler (Troy-Butler) Changes Addresses #85984 --- Full diff: https://github.com/llvm/llvm-project/pull/89650.diff 1 Files Affected: - (modified) lldb/source/Core/Debugger.cpp (-3) ``diff diff --git a/lldb/source/Core/Deb

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

2024-04-22 Thread Semen Komissarov via lldb-commits
semensanyok wrote: Bug confirmed. Its causing exception for nvim-dap plugin which expects column required in specification, but not sent by server. pr contains log message, showing missing column case. closed by maintainer: > Thanks for the PR, but I'm not going to merge this. column is a requi

[Lldb-commits] [lldb] 99f42e6 - [lldb][dap] always add column field in StackFrame body (#73393)

2024-04-22 Thread via lldb-commits
Author: Xu Jun Date: 2024-04-22T15:51:11-04:00 New Revision: 99f42e6b88177328ebe725b5cb6d422106bbb3e6 URL: https://github.com/llvm/llvm-project/commit/99f42e6b88177328ebe725b5cb6d422106bbb3e6 DIFF: https://github.com/llvm/llvm-project/commit/99f42e6b88177328ebe725b5cb6d422106bbb3e6.diff LOG: [

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

2024-04-22 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/73393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dap] always add column field in StackFrame body (PR #73393)

2024-04-22 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @semensanyok, I've just merged this PR because it's very straightforward. If it breaks the buildbots, I'll just revert it and let the original author fix it. https://github.com/llvm/llvm-project/pull/73393 ___ lldb-commits mail

[Lldb-commits] [lldb] [lldb/test] Add basic ld.lld --debug-names tests (PR #88335)

2024-04-22 Thread David Blaikie via lldb-commits
dwblaikie wrote: looks approximately right to me, but wouldn't' mind a set of eyes more familiar with lldb to take a look https://github.com/llvm/llvm-project/pull/88335 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Michael Kruse via lldb-commits
@@ -56,11 +56,13 @@ endfunction() # Use provided strip tool instead of the default one. # TARGET_TRIPLE triple # Optional target triple to pass to the compiler +# FOLDER +# For IDEs, the Folder to put the targets into.= Meinersbur wrote: It's a

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Michael Kruse via lldb-commits
@@ -406,5 +426,13 @@ function(llvm_ExternalProject_Add name source_dir) WORKING_DIRECTORY ${BINARY_DIR} VERBATIM USES_TERMINAL) +if (ARG_FOLDER) + set_target_properties(${target} PROPERTIES FOLDER "${ARG_FOLDER}") +endif () endforeach() + + #s

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/89650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2987fca - [lldb][Core] Fix pointless if conditon (#89650)

2024-04-22 Thread via lldb-commits
Author: Troy Butler Date: 2024-04-22T14:50:17-07:00 New Revision: 2987fca041caddead6655a34009b6a6517d0c7df URL: https://github.com/llvm/llvm-project/commit/2987fca041caddead6655a34009b6a6517d0c7df DIFF: https://github.com/llvm/llvm-project/commit/2987fca041caddead6655a34009b6a6517d0c7df.diff L

[Lldb-commits] [lldb] [lldb][Core] Fix pointless if conditon (PR #89650)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89650 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [libunwind] [lld] [lldb] [llvm] [mlir] [openmp] [polly] [pstl] Update IDE Folders (PR #89153)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: This looks like a nice improvement for folks using those generators. Even though most of these changes look straightforward, it would be a lot easier to review if this was broken up per subproject. Is there any reason that's not possible? https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Remove duplicate disjunction in CumulativeSystemTimeIsValid (PR #89680)

2024-04-22 Thread Marc Auberer via lldb-commits
https://github.com/marcauberer created https://github.com/llvm/llvm-project/pull/89680 Resolves #89674 >From d5bd3f32fa0d87c3bed1024857c3fae412702567 Mon Sep 17 00:00:00 2001 From: Marc Auberer Date: Tue, 23 Apr 2024 00:05:53 +0200 Subject: [PATCH] [lldb] Remove duplicate disjunction in Proce

[Lldb-commits] [lldb] [lldb] Remove duplicate disjunction in CumulativeSystemTimeIsValid (PR #89680)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Marc Auberer (marcauberer) Changes Resolves #89674 --- Full diff: https://github.com/llvm/llvm-project/pull/89680.diff 1 Files Affected: - (modified) lldb/include/lldb/Utility/ProcessInfo.h (+1-2) ``diff diff --git a/lldb/incl

[Lldb-commits] [lldb] [lldb] Remove duplicate disjunction in CumulativeSystemTimeIsValid (PR #89680)

2024-04-22 Thread Marc Auberer via lldb-commits
https://github.com/marcauberer updated https://github.com/llvm/llvm-project/pull/89680 >From b626dc5e116fc6c566f8a3be50fac173aa5df653 Mon Sep 17 00:00:00 2001 From: Marc Auberer Date: Tue, 23 Apr 2024 00:05:53 +0200 Subject: [PATCH] [lldb] Fix typo in CumulativeSystemTimeIsValid check --- lld

[Lldb-commits] [lldb] [lldb] Fix typo in CumulativeSystemTimeIsValid check (PR #89680)

2024-04-22 Thread Marc Auberer via lldb-commits
https://github.com/marcauberer edited https://github.com/llvm/llvm-project/pull/89680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler created https://github.com/llvm/llvm-project/pull/89685 Addresses issue #87243. >From 20c093a1cd51adab9387e9a15fca7c8b592f3f21 Mon Sep 17 00:00:00 2001 From: Troy-Butler Date: Mon, 22 Apr 2024 19:17:08 -0400 Subject: [PATCH] [lldb] Replace always-false condition

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Troy Butler (Troy-Butler) Changes Addresses issue #87243. --- Full diff: https://github.com/llvm/llvm-project/pull/89685.diff 1 Files Affected: - (modified) lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp (+1-1) `

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Even though you link the issue, I would recommend also summarizing the issue in the commit. Something like "The current code is checking the validity of `obj` twice, instead of checking the new `str_obj` pointer." Otherwise this LGTM

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
https://github.com/Troy-Butler edited https://github.com/llvm/llvm-project/pull/89685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Troy Butler via lldb-commits
Troy-Butler wrote: > Otherwise this LGTM! > Even though you link the issue, I would recommend also summarizing the issue > in the commit. Something like "The current code is checking the validity of > `obj` twice, instead of checking the new `str_obj` pointer." > > Otherwise this LGTM! I a

[Lldb-commits] [lldb] [lldb][nfc] Move broadcaster class strings away from ConstString (PR #89690)

2024-04-22 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/89690 These are hardcoded strings that are already present in the data section of the binary, no need to immediately place them in the ConstString StringPools. Lots of code still calls `GetBroadcasterClass` and plac

[Lldb-commits] [lldb] [lldb][nfc] Move broadcaster class strings away from ConstString (PR #89690)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes These are hardcoded strings that are already present in the data section of the binary, no need to immediately place them in the ConstString StringPools. Lots of code still calls `GetBroadcasterClass` and

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread Pranav Kant via lldb-commits
https://github.com/pranavk created https://github.com/llvm/llvm-project/pull/89692 #73393 introduced a mandatory column field. Update test for that. >From dfe807c57b3cb9923c2b774f8f8a13ea3d8a4e6a Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Tue, 23 Apr 2024 00:26:56 + Subject: [PATCH]

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pranav Kant (pranavk) Changes #73393 introduced a mandatory column field. Update test for that. --- Full diff: https://github.com/llvm/llvm-project/pull/89692.diff 1 Files Affected: - (modified) lldb/test/API/tools/lldb-dap/coreFile/Test

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread Pranav Kant via lldb-commits
pranavk wrote: Merging this after self-review. Need this to unblock something internally for us. Hope you don't mind. https://github.com/llvm/llvm-project/pull/89692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] aa89c1b - [lldb][DAP] Fix test failure from #73393 (#89692)

2024-04-22 Thread via lldb-commits
Author: Pranav Kant Date: 2024-04-22T17:47:17-07:00 New Revision: aa89c1bd78a0c49801193bec5e7f5c023448bd19 URL: https://github.com/llvm/llvm-project/commit/aa89c1bd78a0c49801193bec5e7f5c023448bd19 DIFF: https://github.com/llvm/llvm-project/commit/aa89c1bd78a0c49801193bec5e7f5c023448bd19.diff L

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread Pranav Kant via lldb-commits
https://github.com/pranavk closed https://github.com/llvm/llvm-project/pull/89692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DAP] Fix test failure from #73393 (PR #89692)

2024-04-22 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht commented: LGTM https://github.com/llvm/llvm-project/pull/89692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP + CreateValueObjectFromBytes(lldb::TargetSP ta

[Lldb-commits] [lldb] [lldb] Replace condition that always evaluates to false (PR #89685)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/89685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] af8445e - [lldb] Replace condition that always evaluates to false (#89685)

2024-04-22 Thread via lldb-commits
Author: Troy Butler Date: 2024-04-22T20:17:51-07:00 New Revision: af8445e9ce4d9bd74775a68b694957640f29d28a URL: https://github.com/llvm/llvm-project/commit/af8445e9ce4d9bd74775a68b694957640f29d28a DIFF: https://github.com/llvm/llvm-project/commit/af8445e9ce4d9bd74775a68b694957640f29d28a.diff L

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-22 Thread via lldb-commits
@@ -668,6 +699,32 @@ class ValueObject { CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data, const ExecutionContext &exe_ctx, CompilerType type); + static lldb::ValueObjectSP cmtice wrote: CreateValueObje

[Lldb-commits] [lldb] [lldb] Fix typo in CumulativeSystemTimeIsValid check (PR #89680)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix typo in CumulativeSystemTimeIsValid check (PR #89680)

2024-04-22 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Can this be tested in `HostTest.cpp`? https://github.com/llvm/llvm-project/pull/89680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-22 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/87197 >From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Sun, 31 Mar 2024 10:59:38 -0700 Subject: [PATCH 1/3] [LLDB] Add more helper functions to ValueObject class. Create

[Lldb-commits] [lldb] [LLDB] Add more helper functions to ValueObject class. (PR #87197)

2024-04-22 Thread via lldb-commits
cmtice wrote: I've now addressed the comments for the "CreateValueObjectFrom..." functions (I think). I will not be able to work on this for the next couple of weeks, but I'll get back to it and fix the rest as soon as I can. https://github.com/llvm/llvm-project/pull/87197 ___