Troy-Butler wrote:

> Otherwise this LGTM!



> Even though you link the issue, I would recommend also summarizing the issue 
> in the commit. Something like "The current code is checking the validity of 
> `obj` twice, instead of checking the new `str_obj` pointer."
> 
> Otherwise this LGTM!

I appreciate the advice, thank you! 

Also, I do not have the ability to merge. If everything looks good on your end, 
can you please merge with main? Thank you again!

https://github.com/llvm/llvm-project/pull/89685
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to