https://github.com/JDevlieghere approved this pull request.
Even though you link the issue, I would recommend also summarizing the issue in the commit. Something like "The current code is checking the validity of `obj` twice, instead of checking the new `str_obj` pointer." Otherwise this LGTM! https://github.com/llvm/llvm-project/pull/89685 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
