================
@@ -668,6 +699,32 @@ class ValueObject {
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType
type);
+ static lldb::ValueObjectSP
----------------
cmtice wrote:
CreateValueObjectFromBytes was being called from
CreateValueObjectfrom{APInt,Pointer,Bool,Nullptr}, receivng the pointer to the
appropriate values in the input parameter, putting the bytes into a
DataExtractor, then calling CreateValueObjectFromData with the DataExtractor. I
thought that would handle things like correct endianness, etc. However, I will
move the "putting the bytes into the DataExtractor" into the callers for
CreateValueObjectFromBytes & call CreateValueObjectFromData directly from each
of them. This leads to a bit of code duplication, but I can see that it's
safer. (This eliminates the CreateValueObjectFromBytes functions altogether).
https://github.com/llvm/llvm-project/pull/87197
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
