[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

DavidSpickett added a comment. I stopped being lazy and went and found where this is used. It's actually a command you can run from the interpreter that prints out the results of the testing. (lldb) process plugin packet speed-test -c 0 Testing sending 0 packets of various sizes: <...>

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

nhaehnle added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); Meinersbur wrote: > This file is imported from the upstream project > (https://repo.or.cz/isl.git/blob/29

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

nhaehnle updated this revision to Diff 449609. nhaehnle added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129131/new/ https://reviews.llvm.org/D129131 Files: bolt/tools/driver/llvm-bolt.cpp bolt/tools/merge-

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it can be built with CXX_STANDARD=17 and OSX_DEPLOYMENT_TARGET=10.11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

labath accepted this revision. labath added a comment. In D130803#3691363 , @augusto2112 wrote: > In D130803#3690754 , @labath wrote: > >> Who sets this flag? How do you intend to use it? > > I need this change d

Re: [Lldb-commits] [lldb] 318454a - Inline my uuid_is_null() implementation in a header file

On 02/08/2022 23:24, Jason Molenda via lldb-commits wrote: Author: Jason Molenda Date: 2022-08-02T14:24:11-07:00 New Revision: 318454a8e5fce57a92573f42e39f148adcedc5d4 URL: https://github.com/llvm/llvm-project/commit/318454a8e5fce57a92573f42e39f148adcedc5d4 DIFF: https://github.com/llvm/llvm-

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

frasercrmck added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:55 +This means that the the following versions are now required to build LLVM +and there is no way to supress this error. + `suppress` Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

labath added a comment. In D130796#3692243 , @zequanwu wrote: > In D130796#3691227 , @zequanwu > wrote: > >>> If you find yourself needing to do extra work to work its limitations, we >>> should fix that algorit

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. For my education, what is the effect of not providing a specific inheritance attribute, like it's being done in the pdb code (which, I presume, is not possible because that

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

labath added a comment. Ok, I think I like this, but since this is pretty finicky code, could I ask you to split it up into smaller patches? The first could be just the interruption refactor. The second could contain all the `m_notification_packet_queue` and `ReadPacket` stuff (I think this one

[Lldb-commits] [lldb] 69c39e2 - [lldb] Fix TestDeletedExecutable on linux

Author: Pavel Labath Date: 2022-08-03T15:44:19+02:00 New Revision: 69c39e2abc311aa226d54b82a2cc8fa648902c7d URL: https://github.com/llvm/llvm-project/commit/69c39e2abc311aa226d54b82a2cc8fa648902c7d DIFF: https://github.com/llvm/llvm-project/commit/69c39e2abc311aa226d54b82a2cc8fa648902c7d.diff

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c39e2abc31: [lldb] Fix TestDeletedExecutable on linux (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:138 +// and then drain the notification queue +// TODO: issue vCont;t to ensure that all threads have actually stopped +// (this is not needed for LLGS but for gdb

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:138 +// and then drain the notification queue +// TODO: issue vCont;t to ensure that all threads have actually stopped +// (this is not needed for LLGS but for gdb

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

mgorny created this revision. mgorny added reviewers: labath, krytarowski, jingham, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Refactor the mechanism for sending interrupt packets to send them from async thread (i.e. the s

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Please pay special attention to the windows bot when landing. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:55-63 OnRunPacketSent(

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG446b61cff4ea: [lldb] [gdb-remote] Send interrupt packets from async thread (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] 446b61c - [lldb] [gdb-remote] Send interrupt packets from async thread

Author: Michał Górny Date: 2022-08-03T18:40:25+02:00 New Revision: 446b61cff4ea0cb7e7fcc5e0fec7bc749d379b08 URL: https://github.com/llvm/llvm-project/commit/446b61cff4ea0cb7e7fcc5e0fec7bc749d379b08 DIFF: https://github.com/llvm/llvm-project/commit/446b61cff4ea0cb7e7fcc5e0fec7bc749d379b08.diff

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

mgorny added a comment. Herald added a subscriber: JDevlieghere. In D131075#3696782 , @labath wrote: > Looks good. Please pay special attention to the windows bot when landing. Thanks. Will do. Comment at: lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:604 + r'(' +version+ r')?' # img_version + r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)' # addr + r' +(.*)'

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

wallace created this revision. wallace added reviewers: clayborg, jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @clayborg found a potential race condition when setting a static variable. The f

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. lgtm Comment at: lldb/examples/python/crashlog.py:1251-1253 +err = lldb.SBError() +err.SetErrorString(str(e)) +

[Lldb-commits] [lldb] 3426fc7 - Revert "[lldb] [gdb-remote] Send interrupt packets from async thread"

Author: Michał Górny Date: 2022-08-03T19:09:35+02:00 New Revision: 3426fc7318fe555ee37db14525e9bf024760fde2 URL: https://github.com/llvm/llvm-project/commit/3426fc7318fe555ee37db14525e9bf024760fde2 DIFF: https://github.com/llvm/llvm-project/commit/3426fc7318fe555ee37db14525e9bf024760fde2.diff

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Yep, you were right. It broke on Windows ;-). https://lab.llvm.org/buildbot/#/builders/83/builds/22075 Failed Tests (6): lldb-unit :: Process/gdb-remote/./ProcessGdbRemoteTests.exe/GDBR

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/Procfs.cpp:22 Expected> lldb_private::process_linux::GetProcfsCpuInfo() { static Optional> cpu_info; + static Optional error; How about storing this as `ErrorOr>` (that's what `getP

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} I'm concerned that this isn't real

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere created this revision. JDevlieghere added reviewers: mib, kastiglione, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a function to make it easier to debug a test failure caused by an unexpected stop reason. This is similar to the `assertSta

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere updated this revision to Diff 449707. JDevlieghere added a comment. Add missing stop reasons CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131083/new/ https://reviews.llvm.org/D131083 Files: lldb/docs/resources/test.rst lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [lldb] 6a48dc0 - [lldb] Add missing newlines after LLDB_INSTRUMENT_VA

Author: Jonas Devlieghere Date: 2022-08-03T10:51:16-07:00 New Revision: 6a48dc092b0fda65e786021ebf75bda3e1be5c33 URL: https://github.com/llvm/llvm-project/commit/6a48dc092b0fda65e786021ebf75bda3e1be5c33 DIFF: https://github.com/llvm/llvm-project/commit/6a48dc092b0fda65e786021ebf75bda3e1be5c33.d

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

augusto2112 updated this revision to Diff 449712. augusto2112 added a comment. Updated test to use elf object file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130803/new/ https://reviews.llvm.org/D130803 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib created this revision. mib added reviewers: JDevlieghere, kastiglione. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the CrashLogParser class to be both the base class and a Factory for

[Lldb-commits] [lldb] 3aef968 - [lldb] Allow SymbolTable regex search functions to match mangled name

Author: Augusto Noronha Date: 2022-08-03T10:55:32-07:00 New Revision: 3aef968ec3faada22319aaa3530776974082d2d5 URL: https://github.com/llvm/llvm-project/commit/3aef968ec3faada22319aaa3530776974082d2d5 DIFF: https://github.com/llvm/llvm-project/commit/3aef968ec3faada22319aaa3530776974082d2d5.dif

[Lldb-commits] [PATCH] D130803: [lldb] Allow SymbolTable regex search functions to match mangled name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3aef968ec3fa: [lldb] Allow SymbolTable regex search functions to match mangled name (authored by augusto2112). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D131038: [lldb/crashlog] Skip null image dsym fetching on interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/scripted_process/crashlog_scripted_process.py:28 if image not in self.loaded_images: +if image.uuid == uuid.UUID(int=0): +print(f"Note: S

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1198-1204 +option_parser.add_option( +'--skip-status', +'-s', +dest='skip_status', +action='store_true', +help='prevent the interac

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/python/crashlog.py:1013-1015 +nonlocal result +result.SetError(sb_error, "error: %s" % message) +r

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib created this revision. mib added reviewers: JDevlieghere, jingham, jasonmolenda. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improve exception reporting when loading a crash report in a scrip

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

wallace updated this revision to Diff 449724. wallace added a comment. use an idea similar to labath's to simplify this code while still using call_once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131081/new/ https://reviews.llvm.org/D131081 Fi

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1025 +if not target: +result.PutCString("error: couldn't create target provided by the user ({option.target_path})") +return This is not an f-string

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 449725. mib added a comment. Add missing `import` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_process.py

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:604 + r'(' +version+ r')?' # img_version + r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)' # addr + r' +(.*)'

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

efriedma added inline comments. Comment at: polly/lib/External/isl/interface/extract_interface.cc:590 delete Clang; - llvm::llvm_shutdown(); nhaehnle wrote: > Meinersbur wrote: > > This file is imported from the upstream project > > (https://repo

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:604 + r'(' +version+ r')?' # img_version + r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)' # addr + r' +(.*)'

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:418-422 +def __new__(cls, debugger, path, verbose, *args, **kwargs): try: -return JSONCrashLogParser(debugger, path, verbose).parse() +return super(CrashLogParser,

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:417 +class CrashLogParser(object): +"Base class and factory." +def __new__(cls, debugger, path, verbose, *args, **kwargs): Comment at: lldb/examples/pytho

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} rnk wrote: > I'm concerned th

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +return "EXC_BAD_ACCESS"; + case EXC_BAD_INSTRUCTION: +return "EXC_BAD_INSTRUCTION"; + case EXC_ARITHMETIC: +return "EXC_AR

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lld

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:428 self.crashlog = CrashLog(debugger, self.path, self.verbose) +self.data = None + JDevlieghere wrote: > Can this stay in the JSONCrashLogParser? I need it to get the `excep

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

cassanova updated this revision to Diff 449729. cassanova added a comment. Set the LLDB_FUZZER_TARGET environment variable in the CMake file for the source code to use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131020/new/ https://reviews.llvm.org/D131020 Files: clang/cmake/modu

[Lldb-commits] [lldb] 3716107 - [NFC][intel pt] Improve troubleshooting message

Author: Walter Erquinigo Date: 2022-08-03T11:34:03-07:00 New Revision: 371610793491fcd1c9af114a0de0cdda9a4408b0 URL: https://github.com/llvm/llvm-project/commit/371610793491fcd1c9af114a0de0cdda9a4408b0 DIFF: https://github.com/llvm/llvm-project/commit/371610793491fcd1c9af114a0de0cdda9a4408b0.di

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lldb.eStopReasonProcessorT

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1025 +if not target: +result.PutCString("error: couldn't create target provided by the user ({option.target_path})") +return

[Lldb-commits] [lldb] 0f82133 - [lldb] Add assertStopReason helper function

Author: Jonas Devlieghere Date: 2022-08-03T11:44:13-07:00 New Revision: 0f821339dad1bf45dd71a1cac32b6352ba251ecb URL: https://github.com/llvm/llvm-project/commit/0f821339dad1bf45dd71a1cac32b6352ba251ecb DIFF: https://github.com/llvm/llvm-project/commit/0f821339dad1bf45dd71a1cac32b6352ba251ecb.d

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG0f821339dad1: [lldb] Add assertStopReason helper function (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [lldb] 1f64f8b - [lldb] Fix 'FileCheck' spelling on symtab regex tests

Author: Augusto Noronha Date: 2022-08-03T11:57:33-07:00 New Revision: 1f64f8bcabb65c9622386d7458e42ee33b2eb7dc URL: https://github.com/llvm/llvm-project/commit/1f64f8bcabb65c9622386d7458e42ee33b2eb7dc DIFF: https://github.com/llvm/llvm-project/commit/1f64f8bcabb65c9622386d7458e42ee33b2eb7dc.dif

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

fixathon updated this revision to Diff 449736. fixathon edited the summary of this revision. fixathon added a comment. Address the review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130939/new/ https://reviews.llvm.org/D130939 Files:

[Lldb-commits] [PATCH] D131094: [lldb] [gdb-remote] Support reading notification packets

mgorny created this revision. mgorny added reviewers: labath, emaste, jingham, krytarowski. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Add explicit support for reading (or skipping) notification packets to GDBRemoteCommunication::

[Lldb-commits] [PATCH] D126614: [lldb] [gdb-remote] Client support for using the non-stop protocol

mgorny updated this revision to Diff 449744. mgorny added a comment. Rebase on top of the split patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126614/new/ https://reviews.llvm.org/D126614 Files: lldb/packages/Python/lldbsuite/test/gdbclientutils.py lldb/source/Plugins/Proce

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

aprantl added a comment. Could we test this by removing the key from an existing testcase? Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] Is it now undefine

[Lldb-commits] [lldb] 11e5275 - Document why test is disabled on macOS Ventura

Author: Adrian Prantl Date: 2022-08-03T13:05:21-07:00 New Revision: 11e5275cc266ab5ff07e3685935cebf6e09372f7 URL: https://github.com/llvm/llvm-project/commit/11e5275cc266ab5ff07e3685935cebf6e09372f7 DIFF: https://github.com/llvm/llvm-project/commit/11e5275cc266ab5ff07e3685935cebf6e09372f7.diff

[Lldb-commits] [PATCH] D131025: Document why test is disabled on macos ventura

This revision was automatically updated to reflect the committed changes. Closed by commit rG11e5275cc266: Document why test is disabled on macOS Ventura (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Make LLDB resilient against failing dyld introspection APIs: `dyld_process_create_for_current_task`, `dyld_process_snapshot_create_for_process`

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

aprantl added a comment. Nice. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:533 if (dyld_process_create_for_current_task) { - auto dyld_process = dyld_process_create_for_current_task(); - auto snapshot = - dyld_process_snapshot_create_for

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere marked 3 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:534 + if (auto dyld_process = dyld_process_create_for_current_task()) { +if (auto snapshot = dyld_process_snapshot_create_f

[Lldb-commits] [PATCH] D130796: [LLDB][NativePDB] Switch to use DWARFLocationList.

zequanwu added a comment. In D130796#3696351 , @labath wrote: > In D130796#3692243 , @zequanwu > wrote: > >> In D130796#3691227 , @zequanwu >> wrote: >> If you find

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib updated this revision to Diff 449782. mib added a comment. Change `f-string` to `string.format` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129611/new/ https://reviews.llvm.org/D129611 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scri

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib updated this revision to Diff 449784. mib added a comment. - Add custom `InteractiveCrashLogException` - Simplify the `except` block CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 Files: lldb/examples/python/crashlog.py lldb/source/Pl

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib updated this revision to Diff 449785. mib edited the summary of this revision. mib added a comment. Implement @kastiglione's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 Files: lldb/examples/python/crashlog.py Index: lldb

[Lldb-commits] [lldb] 880b212 - [lldb] Mark TestRosetta as skipIfDarwinEmbedded

Author: Jonas Devlieghere Date: 2022-08-03T14:24:37-07:00 New Revision: 880b2128ef4b884612a59836583a5d3d4108fb43 URL: https://github.com/llvm/llvm-project/commit/880b2128ef4b884612a59836583a5d3d4108fb43 DIFF: https://github.com/llvm/llvm-project/commit/880b2128ef4b884612a59836583a5d3d4108fb43.d

[Lldb-commits] [lldb] 2b61b77 - [lldb] Make TestModuleLoadedNotifys work with dyld from the shared cache

Author: Jonas Devlieghere Date: 2022-08-03T14:24:42-07:00 New Revision: 2b61b770df813539b38b620efcae8fd3d11faad2 URL: https://github.com/llvm/llvm-project/commit/2b61b770df813539b38b620efcae8fd3d11faad2 DIFF: https://github.com/llvm/llvm-project/commit/2b61b770df813539b38b620efcae8fd3d11faad2.d

[Lldb-commits] [lldb] 9ffcc85 - Revert "Revert "[lldb][modules] Disable Clang Modules in source/Host directory on macOS""

Author: Jonas Devlieghere Date: 2022-08-03T14:39:45-07:00 New Revision: 9ffcc85fbe52b4480a82749e58b19c3ea5be5e99 URL: https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99 DIFF: https://github.com/llvm/llvm-project/commit/9ffcc85fbe52b4480a82749e58b19c3ea5be5e99.d

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:472-473 self.crashlog.process_identifier = json_data['procName'] -self.crashlog.process_path = json_data['procPath'] +if 'procPath' in json_data: +self.crashlog.pr

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] aprantl wrote: > Is it now undefined if it doe

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere updated this revision to Diff 449795. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131110/new/ https://reviews.llvm.org/D131110 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/H

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

JDevlieghere updated this revision to Diff 449797. JDevlieghere added a comment. Reduce indentation with early returns in a helper function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131110/new/ https://reviews.llvm.org/D131110 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

GabrielRavier created this revision. Herald added a project: All. GabrielRavier requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I went over the output of the following mess of a command: `(ulimit -m 200; ulimit -v 200; git ls-files

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! Evidently I had trouble following the control flow in the earlier revision ;-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131110/new/ https://reviews.llvm.org/D131110 _

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib updated this revision to Diff 449809. mib marked an inline comment as done. mib added a comment. Remove `procPath` key from crash report for testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131033/new/ https://reviews.llvm.org/D131033 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [lldb] 71ebcd3 - [lldb] Make LLDB resilient against failing dyld introspection SPIs

Author: Jonas Devlieghere Date: 2022-08-03T15:47:58-07:00 New Revision: 71ebcd3348061de2fde3a13f1adb56059aca5997 URL: https://github.com/llvm/llvm-project/commit/71ebcd3348061de2fde3a13f1adb56059aca5997 DIFF: https://github.com/llvm/llvm-project/commit/71ebcd3348061de2fde3a13f1adb56059aca5997.d

[Lldb-commits] [PATCH] D131110: [lldb] Make LLDB resilient against failing dyld introspection APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rG71ebcd334806: [lldb] Make LLDB resilient against failing dyld introspection SPIs (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131110?vs=44

[Lldb-commits] [PATCH] D131081: [lldb] Prevent race condition when fetching /proc/cpuinfo

clayborg added a comment. lgtm. Pavel? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131081/new/ https://reviews.llvm.org/D131081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129614/new/ https://reviews.llvm.org/D129614 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

JDevlieghere added a comment. Can we test this by modifying an address in the existing test case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131032/new/ https://reviews.llvm.org/D131032 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

jingham added a comment. The code looks fine to me. This is a new capability, and I don't see how we can guess with certainty whether the clients want this output or not, so I think we should add it as an explicit option, as in the current patch. Comment at: lldb/examples/py

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] mib wrote: > aprantl wrote: > > Is it now undefined if it doesn't exist? Do

[Lldb-commits] [PATCH] D131020: Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131020/new/ https://reviews.llvm.org/D131020 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 5a906b7 - [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

Author: Slava Gurevich Date: 2022-08-03T16:08:18-07:00 New Revision: 5a906b70c11ecd60082ff080789a6700890322e1 URL: https://github.com/llvm/llvm-project/commit/5a906b70c11ecd60082ff080789a6700890322e1 DIFF: https://github.com/llvm/llvm-project/commit/5a906b70c11ecd60082ff080789a6700890322e1.diff

[Lldb-commits] [PATCH] D130939: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div by 0

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a906b70c11e: [LLDB][NFC] Fix potential div by 0 "count" can be zero potentially causing div… (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

Michael137 added a comment. FYI, there's a couple of instances of `sythetic` (instead of `synthetic`) around LLDB that could be included in this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131122/new/ https://reviews.llvm.org/D131122 __

[Lldb-commits] [PATCH] D130805: [trace][intel pt] Support a new kernel section in LLDB’s trace bundle schema

persona0220 updated this revision to Diff 449823. persona0220 marked 9 inline comments as done. persona0220 added a comment. Resolved comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130805/new/ https://reviews.llvm.org/D130805 Files: lldb/source/Plugins/Trace/intel-pt/TraceInt

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:473 +if 'procPath' in json_data: +self.crashlog.process_path = json_data['procPath'] JDevlieghere wrote: > mib wrote: > > aprantl wrote: > > > Is it now undefined if it

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

mib added a comment. In D131032#3698108 , @JDevlieghere wrote: > Can we test this by modifying an address in the existing test case? Sure but we won't be able to symbolicate that frame anymore ... do we really want to do that ? CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

mib updated this revision to Diff 449830. mib retitled this revision from "[lldb/crashlog] Fix parsing issue with `procPath`" to "[lldb/crashlog] Remove 'process_path' parsing logic". mib edited the summary of this revision. mib added a comment. Remove the `process_path` parsing logic CHANGES S

[Lldb-commits] [PATCH] D131130: [lldb] Improve EXC_RESOURCE exception reason

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Jason noted that the stop message we print for a memory high water mark notification (EXC_RESOURCE) could be clearer. Currently, th

[Lldb-commits] [PATCH] D62732: [RISCV] Add SystemV ABI

tzb99 added a comment. In D62732#3681388 , @jasonmolenda wrote: > In D62732#3680154 , @tzb99 wrote: > >> In D62732#2790160 , @sven wrote: >> >>> > > > >>> But the unwind ca

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:428 self.crashlog = CrashLog(debugger, self.path, self.verbose) +self.data = None + mib wrote: > JDevlieghere wrote: > > Can this stay i

[Lldb-commits] [PATCH] D131085: [lldb/crashlog] Refactor the CrashLogParser logic

mib updated this revision to Diff 449847. mib added a comment. Address @JDevlieghere comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 Files: lldb/examples/python/crashlog.py lldb/examples/python/scripted_process/crashlog_scripted_p

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:525-542 + case EXC_BAD_ACCESS: +return "EXC_BAD_ACCESS"; + case EXC_BAD_INSTRUCTION: +return "EXC_BAD_INSTRUCTION"; + case EXC_AR

[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

mib updated this revision to Diff 449848. mib added a comment. Use `llvm::StringSwitch` to get the exception code with the name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files: lldb/examples/python/scripted_process/crashlog_scripted_pr

  1   2   >