JDevlieghere added inline comments.

================
Comment at: lldb/examples/python/crashlog.py:604
+                             r'(' +version+ r')?'               # img_version
+                             r'(0x[0-9a-fA-F]{7}[0-9a-fA-F]*)'  # addr
+                             r' +(.*)'                          # offs
----------------
kastiglione wrote:
> Can it be simplified to using `{7,}`, for "7 or more"?
> 
> Ex: `r'(0x[0-9a-fA-F]{7,}`
I like this idea (and learned something new)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131032/new/

https://reviews.llvm.org/D131032

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to