mib marked 4 inline comments as done. mib added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:428 self.crashlog = CrashLog(debugger, self.path, self.verbose) + self.data = None + ---------------- mib wrote: > JDevlieghere wrote: > > Can this stay in the JSONCrashLogParser? > I need it to get the `exception` dictionary for D131086 ... I took another look at this ... it seems that `TextCrashLogParser` doesn't set the `data` or `exception` attributes ... I'd need first to have both parsers produce the same `exception` dictionary before being able to use it. I'll do that on a follow-up patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131085/new/ https://reviews.llvm.org/D131085 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits