[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Fix parsing issue with `procPath`

[Med Ismail Bennani via Phabricator via lldb-commits]

mib updated this revision to Diff 449809.
mib marked an inline comment as done.
mib added a comment.

Remove `procPath` key from crash report for testing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131033/new/

https://reviews.llvm.org/D131033

Files:
  lldb/examples/python/crashlog.py
  
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips


Index: 
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
===================================================================
--- 
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
+++ 
lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
@@ -52,7 +52,6 @@
   "procExitAbsTime": 2823154294289,
   "procLaunch": "2022-07-28 11:10:19.4122 -0700",
   "procName": "multithread-test",
-  "procPath": "/Users/USER/*/multithread-test",
   "procRole": "Unspecified",
   "procStartAbsTime": 2823154159663,
   "responsiblePid": 1640,
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -471,7 +471,8 @@
     def parse_process_info(self, json_data):
         self.crashlog.process_id = json_data['pid']
         self.crashlog.process_identifier = json_data['procName']
-        self.crashlog.process_path = json_data['procPath']
+        if 'procPath' in json_data:
+            self.crashlog.process_path = json_data['procPath']
 
     def parse_crash_reason(self, json_exception):
         exception_type = json_exception['type']



Index: lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
===================================================================
--- lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
+++ lldb/test/Shell/ScriptInterpreter/Python/Crashlog/Inputs/interactive_crashlog/multithread-test.ips
@@ -52,7 +52,6 @@
   "procExitAbsTime": 2823154294289,
   "procLaunch": "2022-07-28 11:10:19.4122 -0700",
   "procName": "multithread-test",
-  "procPath": "/Users/USER/*/multithread-test",
   "procRole": "Unspecified",
   "procStartAbsTime": 2823154159663,
   "responsiblePid": 1640,
Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -471,7 +471,8 @@
     def parse_process_info(self, json_data):
         self.crashlog.process_id = json_data['pid']
         self.crashlog.process_identifier = json_data['procName']
-        self.crashlog.process_path = json_data['procPath']
+        if 'procPath' in json_data:
+            self.crashlog.process_path = json_data['procPath']
 
     def parse_crash_reason(self, json_exception):
         exception_type = json_exception['type']

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits