[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

labath added a comment. In D75929#1924373 , @ikudrin wrote: > @dblaikie, @labath, as far as I can understand, the patch complies with your > vision. The main difference is that the enum is still intended for internal > use only, but it probably should no

[Lldb-commits] [PATCH] D75929: [DebugInfo] Support DWARFv5 index sections.

dblaikie added a comment. Side note: This has become complicated enough it might be worth separating these patches now rather than later - changes to dumping should be separate from changes to llvm-dwp, for instance. In D75929#1926834 , @labath wrote: >

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

anton.kolesov created this revision. anton.kolesov added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If LLDB attaches to an already running target, then structure SBAttachInfo is used instead of SBLaunchInfo. lldb-vscode function request_atta

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1871895 , @labath wrote: > Yep. It may be interesting to try this out on regular dwo first. Right now, > dwo dodges this problem by storing a CompileUnit pointer on both skeleton and > split units. If we can make

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/ https://reviews.llvm.org/D76188 ___

[Lldb-commits] [lldb] db31e2e - [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

Author: Med Ismail Bennani Date: 2020-03-18T14:15:58+01:00 New Revision: db31e2e1e6cacb31f3fe5a9b0e9e52cd626b5ff2 URL: https://github.com/llvm/llvm-project/commit/db31e2e1e6cacb31f3fe5a9b0e9e52cd626b5ff2 DIFF: https://github.com/llvm/llvm-project/commit/db31e2e1e6cacb31f3fe5a9b0e9e52cd626b5ff2.

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for catching that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76316/new/ https://reviews.llvm.org/D76316 __

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h:146 DWARFDIE *decl_ctx_die); + lldb_private::ModuleID GetOwningModuleID(const DWARFDIE &die); I am kind

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb31e2e1e6ca: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76188/new/

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76351/new/ https://reviews.llvm.org/D76351 ___

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

labath added a comment. In D73206#1928710 , @jankratochvil wrote: > In D73206#1871895 , @labath wrote: > > > Yep. It may be interesting to try this out on regular dwo first. Right now, > > dwo dodges this problem

[Lldb-commits] [lldb] 3481062 - [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

Author: Jan Kratochvil Date: 2020-03-18T15:49:24+01:00 New Revision: 3481062bc688e21eac175aae0142adcaae361c1c URL: https://github.com/llvm/llvm-project/commit/3481062bc688e21eac175aae0142adcaae361c1c DIFF: https://github.com/llvm/llvm-project/commit/3481062bc688e21eac175aae0142adcaae361c1c.diff

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

labath added a comment. Thanks. Could you also add the other kind of test (the one inline asm) I mentioned. In an ideal world we'd have a test case for every boundary condition, but we're pretty far from that right now. Even so, one test case like that would be nice. I am imagining the inferio

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1928869 , @labath wrote: > But I'm not sure that removing `GetBaseSymbolFile` is the right way to start > that, as without it you cannot implement the redirection. Current code is: SymbolFileDWARF::DIEToTypePt

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk updated this revision to Diff 251086. kwk added a comment. Herald added a reviewer: jdoerfert. - Added debuginfod2.py - after running: autopep8 --in-place --aggressive --aggressive debuginfod2.py - exponential backoff implemented - Added http.py with doctests - autopep8 --in-place --aggressiv

[Lldb-commits] [PATCH] D76316: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG3481062bc688: [lldb] [testsuite] Enable forgotten -gsplit-dwarf for 2 testfiles (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

labath added a comment. This looks pretty good overall. I have a bunch of comments, but nothing major. Could you also please rebase the other patch (D74636 ) on top of this. I think that a very common use case for this will be taking the platform environment, tw

Re: [Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

[Splitting this off to not derail the review] On 14/03/2020 00:45, Greg Clayton via Phabricator wrote: > labath wrote: >> This will return a dangling pointer as Envp is a temporary object. It's >> intended to be used to pass the environment object to execve-like function. >> The current "state o

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

kwk added a comment. @labath I've updated my patch and would love to hear your opinion on it. So far I've only written the python `ServeDirectoryWithHTTP()` function with proper doctest and documentation but since you mentioned the `0` port thingy I've tried that on the command line when using

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

labath added a comment. In D76168#1925176 , @shafik wrote: > Long-term I would like to modify clang to stop doing that for LLDB, but LLDB > will still have to support older compilers for a while. So I think this fix > is still needed. So is this some a

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl abandoned this revision. aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:996 m_clang_ast_context->GetUniqueNamespaceDeclaration( - g_lldb_local_vars

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl added a comment. > And then there's ClangModulesDeclVendor::ModuleID -- I have no idea what's > the relationship of this to that.. `ClangModulesDeclVendor::ModuleID` is a typedef to `clang::Module *` so it is a bit of a misnomer, since clang calls the unsigned module numbers module ids.

[Lldb-commits] [PATCH] D75626: Add support for owning module information to TypeSystemClang.

aprantl added a comment. I'm merging this back into https://reviews.llvm.org/D75488 for easier reviewing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75626/new/ https://reviews.llvm.org/D75626 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D75488: Preserve the owning module information from DWARF in the synthesized AST

aprantl updated this revision to Diff 251116. aprantl added a comment. Rolled https://reviews.llvm.org/D75626 back into this patch, addressed more review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 Files: lldb/include/lldb/Symbo

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251143. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 Files: lldb/bindings/headers.swig lldb/bindings/interface/SBEnviro

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D76341: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76341/new/ https://reviews.llvm.org/D76341 __

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We need to determine if the objects we return are copies (from SBPlatform and SBTarget), or if they are objects that will modify the environment for the platform and target respe

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251150. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251149. wallace added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py lldb/

[Lldb-commits] [lldb] b40ee7f - [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

Author: Fred Riss Date: 2020-03-18T13:18:02-07:00 New Revision: b40ee7ff1b16982b39582eee04ca82cac5f3d154 URL: https://github.com/llvm/llvm-project/commit/b40ee7ff1b16982b39582eee04ca82cac5f3d154 DIFF: https://github.com/llvm/llvm-project/commit/b40ee7ff1b16982b39582eee04ca82cac5f3d154.diff LOG

[Lldb-commits] [PATCH] D76168: CPlusPlusNameParser does not handles templated operator< properly

shafik added a comment. In D76168#1929211 , @labath wrote: > In D76168#1925176 , @shafik wrote: > > > Long-term I would like to modify clang to stop doing that for LLDB, but > > LLDB will still have to support olde

[Lldb-commits] [PATCH] D76341: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

This revision was automatically updated to reflect the committed changes. Closed by commit rGb40ee7ff1b16: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7634

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

clayborg added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py:46-48 +program = self.getBuildArtifact("a.out") +self.build_and_launch(program, stopOnEntry=True) +self.vscode.request_disconnect(terminateDebuggee=True

[Lldb-commits] [lldb] 85bd436 - [Host] Remove some code that's not needed anymore.

Author: Davide Italiano Date: 2020-03-18T14:44:53-07:00 New Revision: 85bd4369610fe60397455c8e0914a09288285e84 URL: https://github.com/llvm/llvm-project/commit/85bd4369610fe60397455c8e0914a09288285e84 DIFF: https://github.com/llvm/llvm-project/commit/85bd4369610fe60397455c8e0914a09288285e84.dif

[Lldb-commits] [lldb] 5ffb30f - [lldb/PlatformDarwin] Expose current toolchain and CL tools directory

Author: Jonas Devlieghere Date: 2020-03-18T15:08:24-07:00 New Revision: 5ffb30fd6c7faff314b01ef0dc75f2683ca85cdf URL: https://github.com/llvm/llvm-project/commit/5ffb30fd6c7faff314b01ef0dc75f2683ca85cdf DIFF: https://github.com/llvm/llvm-project/commit/5ffb30fd6c7faff314b01ef0dc75f2683ca85cdf.d

[Lldb-commits] [lldb] 1497066 - [lldb/Test] Add unittest for FileSpec::operator bool()

Author: Jonas Devlieghere Date: 2020-03-18T15:08:23-07:00 New Revision: 14970669ddedb07b68518ae708889e54e6d6eeb9 URL: https://github.com/llvm/llvm-project/commit/14970669ddedb07b68518ae708889e54e6d6eeb9 DIFF: https://github.com/llvm/llvm-project/commit/14970669ddedb07b68518ae708889e54e6d6eeb9.d

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

clayborg accepted this revision. clayborg added a comment. Yep, copy and paste error! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76351/new/ https://reviews.llvm.org/D76351 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin updated this revision to Diff 251181. jarin marked 5 inline comments as done. jarin added a comment. Addressed reviewer comments in the code, but still have no clue how to write the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/ne

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

teemperor updated this revision to Diff 251184. teemperor added a comment. - Rebased the patch. This has been (really) delayed because of the whole unit test I wanted to write, but I'll just land this as-is (as having this broken even longer just because I haven't written that new unit test see

[Lldb-commits] [PATCH] D75750: WIP: [lldb] integrate debuginfod

jankratochvil added a comment. On Fedora 31 x86_64 with LLDB using python3 I got: llvm-lit: .../llvm-monorepo2/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '.../llvm-monorepo2-clangassert/tools/lldb/test/Shell/lit.site.cfg.py', traceback: Traceback (most recent

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin added a comment. In D74398#1929019 , @labath wrote: > Thanks. Could you also add the other kind of test (the one inline asm) I > mentioned. In an ideal world we'd have a test case for every boundary > condition, but we're pretty far from that right

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251200. wallace added a comment. Addressed Greg's comments. At the end I ended up not using APIs that use the format NAME=value, as they could be error prone. I think it's safer to use functions that work with explicit names and values. Besides, I don't wa

[Lldb-commits] [PATCH] D76111: Create basic SBEnvironment class

wallace updated this revision to Diff 251201. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D76314: [lldb-vscode] stop read loop after termination

wallace updated this revision to Diff 251204. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76314/new/ https://reviews.llvm.org/D76314 Files: lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

[Lldb-commits] [PATCH] D76216: Improve step over performance

jarin updated this revision to Diff 251208. jarin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 Files: lldb/source/Target/ThreadPlanStepOverRange.cpp Index: lldb/source/Target/

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251235. wallace added a comment. Using the new SBEnvironment class Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/bindings/interface/SBLaunchInfo.i lld

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

wallace updated this revision to Diff 251236. wallace added a comment. improve a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/bindings/interface/SBLaunchInfo.i lldb/include/lldb/A

[Lldb-commits] [lldb] f0ca0a2 - [AppleObjCRuntimeV2] Rewrite GetClassDescriptor, reducing indentation.

Author: Davide Italiano Date: 2020-03-18T19:23:58-07:00 New Revision: f0ca0a25388066bd3605fe8ffc180e640d13c5a2 URL: https://github.com/llvm/llvm-project/commit/f0ca0a25388066bd3605fe8ffc180e640d13c5a2 DIFF: https://github.com/llvm/llvm-project/commit/f0ca0a25388066bd3605fe8ffc180e640d13c5a2.dif

[Lldb-commits] [lldb] 52b2bae - [lldb/testsuite] Skip TestEmptyStdModule.py if using a remote platform

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: 52b2bae777f2a30d1ed6e87c8812bbffc4f4feeb URL: https://github.com/llvm/llvm-project/commit/52b2bae777f2a30d1ed6e87c8812bbffc4f4feeb DIFF: https://github.com/llvm/llvm-project/commit/52b2bae777f2a30d1ed6e87c8812bbffc4f4feeb.diff LOG

[Lldb-commits] [lldb] 59918d3 - [lldb/testsuite] Make TestObjCIvarStripped.py working with codesigning

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: 59918d3793a1136e7041b1a76f38a42cf8644474 URL: https://github.com/llvm/llvm-project/commit/59918d3793a1136e7041b1a76f38a42cf8644474 DIFF: https://github.com/llvm/llvm-project/commit/59918d3793a1136e7041b1a76f38a42cf8644474.diff LOG

[Lldb-commits] [lldb] c182be2 - [lldb/testsuite] Tweak TestBreakpointLocations.py to pass for arm64

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: c182be211a4d1a79390703ede8f041dcbaaf7947 URL: https://github.com/llvm/llvm-project/commit/c182be211a4d1a79390703ede8f041dcbaaf7947 DIFF: https://github.com/llvm/llvm-project/commit/c182be211a4d1a79390703ede8f041dcbaaf7947.diff LOG

[Lldb-commits] [lldb] 71db787 - [lldb/testsuite] Rewrite TestThreadLocal.py

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: 71db787c4583b5b05b9066509c36eb996924aeda URL: https://github.com/llvm/llvm-project/commit/71db787c4583b5b05b9066509c36eb996924aeda DIFF: https://github.com/llvm/llvm-project/commit/71db787c4583b5b05b9066509c36eb996924aeda.diff LOG

[Lldb-commits] [lldb] 127b9d9 - [lldb/testsuite] Apply @skipIfDarwinEmbedded to part of TestHWBreakMultiThread

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: 127b9d9d774dcc593cfd50eccde307dbe96097a2 URL: https://github.com/llvm/llvm-project/commit/127b9d9d774dcc593cfd50eccde307dbe96097a2 DIFF: https://github.com/llvm/llvm-project/commit/127b9d9d774dcc593cfd50eccde307dbe96097a2.diff LOG

[Lldb-commits] [lldb] acd641c - [lldb/testsuite] Slightly rework TestHiddenIvars.py

Author: Fred Riss Date: 2020-03-18T20:52:28-07:00 New Revision: acd641c19d687c7117b08cdd568a91a381043ebb URL: https://github.com/llvm/llvm-project/commit/acd641c19d687c7117b08cdd568a91a381043ebb DIFF: https://github.com/llvm/llvm-project/commit/acd641c19d687c7117b08cdd568a91a381043ebb.diff LOG

[Lldb-commits] [PATCH] D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

friss created this revision. friss added reviewers: labath, jingham. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. TestInlineStepping tests LLDB's ability to step in the presence of inline frames. The testcase source has a number of functions and some of them a

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss created this revision. friss added reviewers: mib, jingham. Herald added a project: LLDB. The crash info annotations are not necessarily indicative of a crash. Some APIs will set them before doing something risk and clean them up after, while some others might just leave a breadcrumb there f

[Lldb-commits] [PATCH] D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

friss created this revision. friss added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. TestBuiltinTrap fail on darwin embedded because the `__builin_trap` builtin doesn't get any line info attached to it by clang when building for arm64. Th

[Lldb-commits] [lldb] 5d881dd - Update so debugserver can be built on macos again with xcodebuild.

Author: Jason Molenda Date: 2020-03-18T21:46:20-07:00 New Revision: 5d881dd8a8b8ea6f80bf4ef5b900ca006dacd9bf URL: https://github.com/llvm/llvm-project/commit/5d881dd8a8b8ea6f80bf4ef5b900ca006dacd9bf DIFF: https://github.com/llvm/llvm-project/commit/5d881dd8a8b8ea6f80bf4ef5b900ca006dacd9bf.diff

[Lldb-commits] [PATCH] D76411: [debugserver] Implement hardware breakpoints for ARM64

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added subscribers: danielkiss, kristof.beyls. Add support for hardware breakpoints on ARM64 Repository: rLLDB LLDB https://reviews.llvm.org/D76411 Files: lldb/tools/debugserver/source/MacOSX/arm64/DNBAr

[Lldb-commits] [PATCH] D76216: Improve step over performance

clayborg added a comment. Jim is the one that really needs to mark this as accepted as the thread plans are one of his many areas of expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 ___