anton.kolesov created this revision.
anton.kolesov added reviewers: labath, clayborg.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
If LLDB attaches to an already running target, then structure SBAttachInfo is
used instead of SBLaunchInfo. lldb-vscode function request_attach sets some
values to g_vsc.launch_info, however this field is then not passed anywhere, so
this action has no effect. This commit removes invocation of
SBLaunchInfo::SetDetachOnError, which has no equivalent in SBAttachInfo.
File package.json doesn't describe detachOnError property for "attach" request
type, therefore it is not needed to update it.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D76351
Files:
lldb/tools/lldb-vscode/lldb-vscode.cpp
Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -543,9 +543,6 @@
return;
}
- const bool detatchOnError = GetBoolean(arguments, "detachOnError", false);
- g_vsc.launch_info.SetDetachOnError(detatchOnError);
-
// Run any pre run LLDB commands the user specified in the launch.json
g_vsc.RunPreRunCommands();
Index: lldb/tools/lldb-vscode/lldb-vscode.cpp
===================================================================
--- lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -543,9 +543,6 @@
return;
}
- const bool detatchOnError = GetBoolean(arguments, "detachOnError", false);
- g_vsc.launch_info.SetDetachOnError(detatchOnError);
-
// Run any pre run LLDB commands the user specified in the launch.json
g_vsc.RunPreRunCommands();
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
