abhishek.aggarwal closed this revision.
abhishek.aggarwal added a comment.
Already merged it in LLDb repo. So closing this revision.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
labath added subscribers: zturner, lldb-commits, clayborg.
labath added a comment.
I am cc'ing a bunch of people to make sure we don't do this behind anyone's
back. I don't know whether you discussed this with anyone on lldb side (it's
certainly new to me), but I think it deserves a wider audien
Author: labath
Date: Fri Sep 9 04:49:54 2016
New Revision: 281025
URL: http://llvm.org/viewvc/llvm-project?rev=281025&view=rev
Log:
Fix new gdb-remote client unit test for windows
The behaviour of FileSpec differed between host OS versions. Hardcode the path
syntax to posix, as we don't care abo
Author: nitesh.jain
Date: Fri Sep 9 04:50:33 2016
New Revision: 281026
URL: http://llvm.org/viewvc/llvm-project?rev=281026&view=rev
Log:
[LLDB][MIPS] Fix TestLldbGdbServer.py failure
Subscribers: jaydeep, bhushan, slthakur, lldb-commits
Modified:
lldb/trunk/packages/Python/lldbsuite/test/t
Author: labath
Date: Fri Sep 9 05:12:57 2016
New Revision: 281029
URL: http://llvm.org/viewvc/llvm-project?rev=281029&view=rev
Log:
NFC: Reformat ABISysV_i386 register context into something readable
add clang-format guards so it does not reformat it again.
Modified:
lldb/trunk/source/Plugi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281030: Fixing a build breakage caused from a change in LLVM
rL281019 (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24382?vs=70805&id=70806#toc
Repository:
rL LLVM
htt
dvlahovski created this revision.
dvlahovski added a reviewer: ldrumm.
dvlahovski added a subscriber: lldb-commits.
LLVM guys did some clean-up of the Attribute getters/setters
and because of that the build was failing.
https://reviews.llvm.org/D24382
Files:
source/Plugins/LanguageRuntime/Ren
Author: dvlahovski
Date: Fri Sep 9 05:14:11 2016
New Revision: 281030
URL: http://llvm.org/viewvc/llvm-project?rev=281030&view=rev
Log:
Fixing a build breakage caused from a change in LLVM rL281019
Summary:
LLVM guys did some clean-up of the Attribute getters/setters
and because of that the buil
Author: nitesh.jain
Date: Fri Sep 9 05:20:08 2016
New Revision: 281031
URL: http://llvm.org/viewvc/llvm-project?rev=281031&view=rev
Log:
[LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS
Reviewers: clayborg, labath
Subscribers: jaydeep, bhushan, slthakur, lldb-commits
Differential Revision: https
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281031: [LLDB][MIPS] Fix TestEhFrameUnwind.py for MIPS
(authored by nitesh.jain).
Changed prior to commit:
https://reviews.llvm.org/D24122?vs=69974&id=70807#toc
Repository:
rL LLVM
https://reviews.l
Author: nitesh.jain
Date: Fri Sep 9 05:46:25 2016
New Revision: 281032
URL: http://llvm.org/viewvc/llvm-project?rev=281032&view=rev
Log:
[LLDB][MIPS] Fix Emulation for JALR64 Instruction
Subscribers: jaydeep, bhushan, slthakur, sdardis, lldb-commits
Modified:
lldb/trunk/source/Plugins/Instr
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added a subscriber: lldb-commits.
Herald added a subscriber: beanz.
Added parsing of the MiscInfo data stream.
The main member of it that we care about is the process_id
On Linux generated Minidump (from brea
dvlahovski updated this revision to Diff 70816.
dvlahovski added a comment.
Forgot to run clang-format
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/MinidumpParser.h
source/Plugins/Process/minidump/MinidumpTypes.c
dvlahovski added a comment.
Also added parsing code for Minidump strings - the string in the file are
UTF-16 encoded. I used the code from the WinMiniDump plugin and it can extract
a UTF-16 string and convert it to a UTF-8 one.
https://reviews.llvm.org/D24385
___
zturner added reviewers: dblaikie, chandlerc.
zturner added a comment.
Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid the
JSON parser that currently exists in LLDB won't do. As Pavel mentioned, the
code has a definite LLDB feel to it, but more importantly it depends o
It just occurred to me that clang-tidy parses json, and I believe also
rolls its own json parser. Assuming nobody objects to having a json parser
in llvm, i think the clang-tidy one would be the one to use as a starting
point (assuming it's general enough), then we could delete lldb's
On Fri, Sep
labath added a comment.
A collection of small remarks, mostly to do with style. Mainly, I'd like to
make the tests more strict about what they accept as reasonable values.
A higher level question: Given that we are already in the `minidump` namespace,
do we want all (most) of these symbols to b
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:88-89
@@ +87,4 @@
+MinidumpParser::GetMinidumpString(uint32_t rva) {
+ llvm::ArrayRef arr_ref(m_data_sp->GetBytes() + rva,
+ m_data_sp->GetByteSize() - r
Author: tfiala
Date: Fri Sep 9 12:07:15 2016
New Revision: 281058
URL: http://llvm.org/viewvc/llvm-project?rev=281058&view=rev
Log:
xfail DarwinLog "filter message by regex" tests
These tests are not working reliably. I'm marking them
xfail until I resolve the issue.
Tracked by:
llvm.org/pr302
tfiala added a subscriber: tfiala.
tfiala accepted this revision.
tfiala added a reviewer: tfiala.
tfiala added a comment.
Accepting and then closing.
https://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
tfiala added inline comments.
Comment at: cmake/LLDBDependencies.cmake:168
@@ -167,3 +167,3 @@
# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR CMAKE_SYSTEM_NAME MATCHES "NetBSD")
+if ((CMAKE_SYSTEM_NAME MATCHES "Fr
tfiala added a comment.
Getting back to this change.
I'm going to rebase for code reformatting, remove the signature change on the
JSON parsing, adjust my call sites for it, refactor the structured data parsing
in the gdb-remote reception to a separate function, and then put this back up
for r
zturner added a comment.
In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
> In https://reviews.llvm.org/D24369#538213, @zturner wrote:
>
> > Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid
> > the JSON parser that currently exists in LLDB won't do. As Pavel
clayborg added a comment.
I like the idea of moving this down into LLVM. We should fully LLVM-ize the
code on the first pass though and take the LLDB style out of it.
https://reviews.llvm.org/D24369
___
lldb-commits mailing list
lldb-commits@lists.
aizatsky added a comment.
In https://reviews.llvm.org/D24369#538213, @zturner wrote:
> Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid the
> JSON parser that currently exists in LLDB won't do. As Pavel mentioned, the
> code has a definite LLDB feel to it, but more imp
Sorry Guys,
I got pulled off lldb work some time ago. lldb didn't seem particularly easy to
twist around to support the targets we maintained then. If there is anything I
did that gets in anyone's way please just remove/ignore it.
thanks
Matthew Gardiner
aizatsky updated this revision to Diff 70877.
aizatsky added a comment.
- getting rid of StringExtractor
- renaming methods to lowerCase.
https://reviews.llvm.org/D24369
Files:
.clang-tidy
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CM
aizatsky added a comment.
In https://reviews.llvm.org/D24369#538472, @zturner wrote:
> In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
>
> > In https://reviews.llvm.org/D24369#538213, @zturner wrote:
> >
> > > Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid
aizatsky updated this revision to Diff 70879.
aizatsky added a comment.
remove .clang-tidy
https://reviews.llvm.org/D24369
Files:
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CMakeLists.txt
unittests/Support/JSONTest.cpp
Index: unittes
tfiala retitled this revision from "Add StructuredData unit tests; remove JSON
parsing string copy" to "Add StructuredData unit tests; move packet processing
into delegate.".
tfiala updated this revision to Diff 70909.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/G
Hello everyone,
Below are some buildbot numbers for the last week of 8/28/2016 - 9/03/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
zturner added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4812
@@ +4811,3 @@
+static const std::string &GetStructuredDataPacketPrefix() {
+ static const std::string prefix("JSON-async:");
+ return prefix;
How about just a
tfiala marked 3 inline comments as done.
tfiala added a comment.
I'll make a few more adjustments here based on Zachary's feedback.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4812
@@ +4811,3 @@
+static const std::string &GetStructuredDataPacketPrefix() {
tfiala added a comment.
In https://reviews.llvm.org/D23884#539142, @tfiala wrote:
> I'll make a few more adjustments here based on Zachary's feedback.
Heh, ahem, that was meant to be "global *destructor*" above, not global
constructor.
https://reviews.llvm.org/D23884
_
zturner added inline comments.
Comment at: include/llvm/Support/JSON.h:27
@@ +26,3 @@
+public:
+ typedef std::shared_ptr SP;
+ enum class Kind { String, Number, True, False, Null, Object, Array };
I scanned the entire patch and I'm not sure I understand the need
zturner added inline comments.
Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:335
@@ +334,3 @@
+ StreamGDBRemote stream;
+ stream.PutEscapedBytes(json_packet.c_str(), json_packet.length());
+ stream.Flush();
tfiala wrote:
> zturner wrote:
tfiala updated this revision to Diff 70930.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
source/Plugins/Process/gdb-remote/Pro
tfiala updated this revision to Diff 70931.
tfiala added a comment.
Re-uploaded last patch with full context.
https://reviews.llvm.org/D23884
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugins/Process/gdb
tfiala added inline comments.
Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:38
@@ -36,2 +37,3 @@
unsigned stop_reply_called = 0;
+ std::vector structured_data_packets;
Yeah, I did try a std::vector but that actually blew up since
the
tfiala added a comment.
I'm going to go ahead with this since I think the biggest concerns have been
addressed. @labath we can adjust more later if you still have concerns.
https://reviews.llvm.org/D23884
___
lldb-commits mailing list
lldb-commits
Author: tfiala
Date: Fri Sep 9 19:06:29 2016
New Revision: 281121
URL: http://llvm.org/viewvc/llvm-project?rev=281121&view=rev
Log:
async structured data packet handling improvements
This change does the following:
* Changes the signature for the continuation delegate method that handles
async
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281121: async structured data packet handling improvements
(authored by tfiala).
Changed prior to commit:
https://reviews.llvm.org/D23884?vs=70931&id=70933#toc
Repository:
rL LLVM
https://reviews.ll
amccarth added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21
@@ +20,3 @@
+llvm::StringRef
+lldb_private::minidump::consumeString(llvm::ArrayRef &Buffer) {
+ return llvm::StringRef(reinterpret_cast(Buffer.data()),
zturner wrote:
Even if it's length prefixed, the logic here basically just consumes the
entire buffer, which doesn't seem right
On Fri, Sep 9, 2016 at 5:43 PM Adrian McCarthy wrote:
> amccarth added inline comments.
>
>
> Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21
> @@ +20
chandlerc added a comment.
In https://reviews.llvm.org/D24369#538472, @zturner wrote:
> In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
>
> > > I'm a bit surprised there's not already a json parser in LLVM. Maybe
> > > there's a reason for it. I think this CL needs a few more revie
I had no idea yaml was a superset of json. Makes it an easy decision
On Fri, Sep 9, 2016 at 6:48 PM Chandler Carruth wrote:
> chandlerc added a comment.
>
> In https://reviews.llvm.org/D24369#538472, @zturner wrote:
>
> > In https://reviews.llvm.org/D24369#538422, @aizatsky wrote:
> >
> > > > I'm
aizatsky updated this revision to Diff 70946.
aizatsky marked 10 inline comments as done.
aizatsky added a comment.
cleanup
https://reviews.llvm.org/D24369
Files:
include/llvm/Support/JSON.h
lib/Support/CMakeLists.txt
lib/Support/JSON.cpp
unittests/Support/CMakeLists.txt
unittests/Sup
Oh, that's great! Thanks for pointing this out. I'll just upload the
cleaned up version in case lldb/ folks would like it. I'll figure out how
to use our YAML library.
On Fri, Sep 9, 2016 at 6:48 PM Chandler Carruth wrote:
> chandlerc added a comment.
>
> In https://reviews.llvm.org/D24369#53847
aizatsky abandoned this revision.
Comment at: include/llvm/Support/JSON.h:207
@@ +206,3 @@
+private:
+ typedef std::map Map;
+ typedef Map::iterator Iterator;
zturner wrote:
> `DenseMap` seems like a better choice here.
DenseMap doesn't seem to be defined for st
On Fri, Sep 9, 2016 at 7:31 PM Mike Aizatsky wrote:
> aizatsky abandoned this revision.
>
>
> Comment at: include/llvm/Support/JSON.h:207
> @@ +206,3 @@
> +private:
> + typedef std::map Map;
> + typedef Map::iterator Iterator;
>
> zturner wrote:
> > `DenseMap`
I'll figure out how to port lldb's use over to yaml
On Fri, Sep 9, 2016 at 7:31 PM Mike Aizatsky wrote:
> Oh, that's great! Thanks for pointing this out. I'll just upload the
> cleaned up version in case lldb/ folks would like it. I'll figure out how
> to use our YAML library.
>
> On Fri, Sep 9,
51 matches
Mail list logo
