It just occurred to me that clang-tidy parses json, and I believe also rolls its own json parser. Assuming nobody objects to having a json parser in llvm, i think the clang-tidy one would be the one to use as a starting point (assuming it's general enough), then we could delete lldb's
On Fri, Sep 9, 2016 at 7:05 AM Zachary Turner <ztur...@google.com> wrote: > zturner added reviewers: dblaikie, chandlerc. > zturner added a comment. > > Having a JSON parser in LLVM seems like a reasonable idea, but I'm afraid > the JSON parser that currently exists in LLDB won't do. As Pavel > mentioned, the code has a definite LLDB feel to it, but more importantly it > depends on StringExtractor which I think probably doesn't belong in LLVM. > If you want to go down this route, I would start by deleting the > StringExtractor changes from this CL. 90% of the stuff StringExtractor is > used for, like hex string to number, string to integer, etc are covered by > existing LLVM classes or methods. > > I'm a bit surprised there's not already a json parser in LLVM. Maybe > there's a reason for it. I think this CL needs a few more reviewers on the > LLVM side, so I'm adding a few people. > > > https://reviews.llvm.org/D24369 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
