zturner added inline comments. ================ Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:335 @@ +334,3 @@ + StreamGDBRemote stream; + stream.PutEscapedBytes(json_packet.c_str(), json_packet.length()); + stream.Flush(); ---------------- tfiala wrote: > zturner wrote: > > Would be nice to see `PutEscapedBytes` updated to take a `StringRef`. > > Every occurrence of passing `const char * str, int len` should be replaced > > with `StringRef` as we find occurrences of it. > Yep. I'd prefer to not make that part of this change, though. Yea you are right, since the packets are coming in asynchronously I don't think we can make any assumptions about how long it will live.
https://reviews.llvm.org/D23884 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
