tfiala added inline comments. ================ Comment at: unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp:38 @@ -36,2 +37,3 @@ unsigned stop_reply_called = 0; + std::vector<std::string> structured_data_packets; ---------------- Yeah, I did try a std::vector<llvm::StringRef> but that actually blew up since the backing storage did disappear.
For the rest of the interface, I was able to pipe through the llvm::StringRef, though, since that's all serial up to the JSON parser, which itself then makes a copy that it requires. So I think that's all for the better. Thanks for the suggestion! https://reviews.llvm.org/D23884 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
