uschindler commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023668563
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak
dweiss commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023671778
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak java
dweiss commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023673686
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak java
jpountz commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316595426
@uschindler @rmuir I wonder if you have thoughts on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
jpountz opened a new pull request, #11940:
URL: https://github.com/apache/lucene/pull/11940
Closes #11932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
dweiss commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r102369
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak java
jpountz commented on code in PR #11940:
URL: https://github.com/apache/lucene/pull/11940#discussion_r1023687106
##
lucene/core/src/java/org/apache/lucene/util/VectorUtil.java:
##
@@ -225,7 +225,7 @@ public static float[] l2normalize(float[] v, boolean
throwOnZero) {
re
jpountz commented on PR #11940:
URL: https://github.com/apache/lucene/pull/11940#issuecomment-1316631812
Oh, I'm just seeing #11938 now. Closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jpountz closed pull request #11940: Address some error-prone
NarrowingCompoundAssignment warnings.
URL: https://github.com/apache/lucene/pull/11940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jpountz commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1023705104
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class Merg
jpountz commented on PR #11938:
URL: https://github.com/apache/lucene/pull/11938#issuecomment-1316638147
I fixed one other warning from PointRangeQuery which looked worth addressing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jpountz commented on PR #11939:
URL: https://github.com/apache/lucene/pull/11939#issuecomment-1316641902
Great catch, can you add a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
maosuhan commented on PR #11939:
URL: https://github.com/apache/lucene/pull/11939#issuecomment-1316675899
> Great catch, can you add a test?
@jpountz I have added the test code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jpountz commented on code in PR #11928:
URL: https://github.com/apache/lucene/pull/11928#discussion_r1023716348
##
lucene/core/src/java/org/apache/lucene/search/DisjunctionDISIApproximation.java:
##
@@ -45,29 +51,54 @@ public long cost() {
@Override
public int docID() {
romseygeek commented on issue #11864:
URL: https://github.com/apache/lucene/issues/11864#issuecomment-1316715728
Ah, I see what you mean. I think we can improve the internal API here to
not rely on there being a non-empty TermAndBoost array when constructing the
synonym query. I'll open a
uschindler commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316719591
Hi,
I think the idea of IOContext was beyond simple flags like "sequentially
reading" or "random IO" (and you can create your own IOContexts). I think we
added that to allow f
jpountz commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316724527
I opened this issue because I found several instances of codecs opening
their meta file with the default `IOContext` instead of using `READONCE`.
https://github.com/apache/lucene/pu
thecoop commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1316834475
I've changed it to use a separate object for the string map, scoped to the
deserialisation method.
I couldn't come up with a nice way to handle `readMapOfStrings` to cache the
key
uschindler commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023893339
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak
uschindler commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1316889438
I think we can remove it, but if we keep it maybe it should always use
READONCE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rmuir commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023903448
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak javac
rmuir commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023906901
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak javac
rmuir commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1023927808
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class Merged
thecoop opened a new pull request, #11942:
URL: https://github.com/apache/lucene/pull/11942
Change calls to `new HashMap(int)`/`new HashSet(int)` to a method that
ensures the backing array won't be resized.
A few other optimisations around map methods I picked up along the way
--
T
uschindler commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023954625
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak
rmuir commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023957903
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak javac
dweiss commented on code in PR #11937:
URL: https://github.com/apache/lucene/pull/11937#discussion_r1023961947
##
gradle/hacks/turbocharge-jvm-opts.gradle:
##
@@ -38,4 +39,20 @@ allprojects {
jvmArgs += vmOpts
}
-}
\ No newline at end of file
+
+// Tweak java
jpountz commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1023992252
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class Merg
jpountz commented on PR #11939:
URL: https://github.com/apache/lucene/pull/11939#issuecomment-1317027842
This looks good to me. Can you add a CHANGES entry under `9.4.2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mikemccand commented on issue #11933:
URL: https://github.com/apache/lucene/issues/11933#issuecomment-1317075989
+1 to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
rmuir commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1024068862
##
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class Merged
maosuhan commented on PR #11939:
URL: https://github.com/apache/lucene/pull/11939#issuecomment-1317154566
@jpountz changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
rmuir commented on PR #11938:
URL: https://github.com/apache/lucene/pull/11938#issuecomment-1317237989
Thanks @jpountz for going thru the file with me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
rmuir closed issue #11932: one-time pass thru error-prone
NarrowingCompoundAssignment check
URL: https://github.com/apache/lucene/issues/11932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
rmuir merged PR #11938:
URL: https://github.com/apache/lucene/pull/11938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz merged PR #11939:
URL: https://github.com/apache/lucene/pull/11939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
rmuir opened a new issue, #11943:
URL: https://github.com/apache/lucene/issues/11943
### Description
Currently this is enabled nightly-only, and it is very slow compared to java
compiler. I wonder if we could enable it "more often" somehow. Besides being
slow it also has some compati
dweiss commented on issue #11943:
URL: https://github.com/apache/lucene/issues/11943#issuecomment-1317401162
> Maybe a compromise would be to enable it just for github actions?
I'm fine with this. Doesn't bother me to push and do something else while
waiting for CI to complete its che
rmuir commented on issue #11943:
URL: https://github.com/apache/lucene/issues/11943#issuecomment-1317413881
Looks like we tend to spin off two "big" jobs in parallel: `gradle test` and
`gradle check -x test`. The `gradle test` job tends to run a bit slower
already, so it may not hurt overal
rmuir opened a new pull request, #11944:
URL: https://github.com/apache/lucene/pull/11944
The idea is to fail faster, prevent new violations from failing nightly
builds. If it becomes a hindrance to contributions or an annoyance, we can
disable it.
Closes #11943
--
This is an aut
risdenk commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317463797
Looking at the last main github actions run:
https://github.com/apache/lucene/actions/runs/3481009561/jobs/5821544088 The
gradle check without tests was `6m 32s`. The same step for this
dweiss commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317507423
Well, it was definitely slower before the patch ()?
https://github.com/apache/lucene/actions/runs/3473485571/jobs/5805548845
--
This is an automated message from the Apache Git Servic
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317507534
hmm... so did it actually run? :)
fwiw, my biggest concern for this is annoying contributors. if they do the
right thing and `gradle check` fails, then make a contribution and the bu
dweiss commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317510122
> hmm... so did it actually run? :)
You could try to revert the commit with offending code - then we'd see. :)
--
This is an automated message from the Apache Git Service.
To resp
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317515764
i will add a violation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jpountz commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1317520371
@uschindler It looks like this benchmark has a noticeable slowdown with this
change?
https://home.apache.org/~mikemccand/lucenebench/MedTermDayTaxoFacets.html
--
This is an automated mess
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317529801
If it works, build should fail and look like this:
```
> Task :lucene:core:compileTestJava FAILED
/home/rmuir/workspace/lucene/lucene/core/src/test/org/apache/lucene/TestDemo.java:
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317535353
It worked... even for the `gradle test` task which didn't turn it on. So now
i'm wondering if it has been enabled here all along because of `isCIBuild`
which has a "CI-detector" that looks
rmuir commented on PR #11944:
URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317542732
yeah, nothing to do here apparently. errorprone is already on via magical CI
detection: `isCIBuild = System.getenv().keySet().find { it ==~
/(?i)((JENKINS|HUDSON)(_\w+)?|CI)/ } != null`
rmuir closed pull request #11944: enable errorprone for github check action
URL: https://github.com/apache/lucene/pull/11944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmuir closed issue #11943: try to re-enable error-prone checks to happen more
often?
URL: https://github.com/apache/lucene/issues/11943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
rmuir commented on issue #11943:
URL: https://github.com/apache/lucene/issues/11943#issuecomment-1317543404
error-prone is already enabled via ci-detection magic :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dweiss commented on issue #11943:
URL: https://github.com/apache/lucene/issues/11943#issuecomment-1317546712
Ahem. Right. Now, where's that facepalm emoji...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
uschindler commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1317618039
Could be. It may be caused by too much coping of very small arrays
(especially float and long) between offheap and heap. For explanation see above.
I don't think this is a huge prob
uschindler commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1317634632
Code similar like this:
https://github.com/openjdk/jdk/blob/37848a9ca2ab3021e7b3b2e112bab4631fbe1d99/src/java.base/share/classes/java/nio/X-Buffer.java.template#L929
The of statemen
uschindler commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1317635619
I was hoping that JDK people do it in the same way for MemorySegment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
gsmiller commented on PR #11901:
URL: https://github.com/apache/lucene/pull/11901#issuecomment-1317848376
@mdmarshmallow started to dig into this. Will get you some feedback this
week. Just letting you know it's on my radar. Thanks for all the hard work on
this!
--
This is an automated m
jdconrad opened a new pull request, #11945:
URL: https://github.com/apache/lucene/pull/11945
This change adds an additional test codec allowing a configurable number for
max connections per vector when building an hnsw index. By setting the number
of connections to `128` as part of `TestMan
rmuir commented on PR #11945:
URL: https://github.com/apache/lucene/pull/11945#issuecomment-1317994569
we need to run a `./gradlew tidy` and commit/push the results to fix
formatting.
Very cool, will test on my 2-core. we may be able to upgrade from `@Monster`
to `@Nightly`.
--
T
jdconrad commented on PR #11945:
URL: https://github.com/apache/lucene/pull/11945#issuecomment-1318001086
Updated with tidy! (Oops on failing precommit.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmuir commented on PR #11945:
URL: https://github.com/apache/lucene/pull/11945#issuecomment-1318068758
Works for me. I was able to now run this monster test in < 10 minutes time.
```
<===:lucene:core:test (SUCCESS): 1 test(s)
The slowest tests (exceeding 500 ms) during this run:
rmuir merged PR #11945:
URL: https://github.com/apache/lucene/pull/11945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
62 matches
Mail list logo
