jpountz commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1023992252
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##########
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class MergedVectorValues extends VectorValues {
private final List<VectorValuesSub> subs;
private final DocIDMerger<VectorValuesSub> docIdMerger;
- private final int cost;
+ private final long cost;
Review Comment:
I pushed a commit with what I had in mind. Essentially `cost()` and `size()`
are the same thing on vectors except that the latter is expected to be
accurate. Maybe we should rethink this, e.g. could `cost()` be required to be
accurate on `VectorValues` instances, or could the base class make `cost()`
final and delegate to `size()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
