rmuir commented on PR #11944: URL: https://github.com/apache/lucene/pull/11944#issuecomment-1317507534
hmm... so did it actually run? :) fwiw, my biggest concern for this is annoying contributors. if they do the right thing and `gradle check` fails, then make a contribution and the build fails here, it could bother them. Especially if they have to play whack-a-mole because error-prone feeds them one violation at a time :( At the same time, we don't have a lot of crazy error-prone checks turned on... they are selective... so hopefully it would be more of a rare event. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
