rmuir commented on code in PR #11938:
URL: https://github.com/apache/lucene/pull/11938#discussion_r1024068862
##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java:
##########
@@ -108,7 +108,7 @@ public int nextDoc() throws IOException {
protected static class MergedVectorValues extends VectorValues {
private final List<VectorValuesSub> subs;
private final DocIDMerger<VectorValuesSub> docIdMerger;
- private final int cost;
+ private final long cost;
Review Comment:
i'm happy either way, i'm not familiar enough with the specifics of the
code, and I lean conservative when trying to fix issues before a release. we
don't even have to touch it here now if there's no real risk of overflow (e.g.
its just count of subs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
