uschindler commented on PR #912:
URL: https://github.com/apache/lucene/pull/912#issuecomment-1257975327
OpenJDK 19 was released by Eclipse Temurin:
https://adoptium.net/de/temurin/releases?version=19
Thanks @gdams and @adoptium.
@msokolov: I will merge this to main, 9.x and 9.4
rmuir commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979984394
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=${tes
uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979984774
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=
uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979985242
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=
uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979990105
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=
uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979991502
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=
jpountz merged PR #11818:
URL: https://github.com/apache/lucene/pull/11818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979990105
##
gradle/generation/local-settings.gradle:
##
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
# Maximum number of test JVMs forked per test task.
tests.jvms=
vsop-479 commented on PR #11722:
URL: https://github.com/apache/lucene/pull/11722#issuecomment-1258003910
@jpountz
I added a test to BasePostingsFormatTestCase. Please have a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uschindler merged PR #912:
URL: https://github.com/apache/lucene/pull/912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
yugushihuang closed pull request #1057: LUCENE-10670: Add a codec class to
track merge time of each index part
URL: https://github.com/apache/lucene/pull/1057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yugushihuang commented on PR #1057:
URL: https://github.com/apache/lucene/pull/1057#issuecomment-1258240704
@rmuir Thanks for pointing this out. I will close this PR and investigate
other way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
uschindler opened a new issue, #11819:
URL: https://github.com/apache/lucene/issues/11819
### Description
After merge of #912 when creting the Eclipse workspace files, it also adds
the Java 19 part, which fails to compile with JDK 11 or 17. I think the same
will be happing with Intel
rmuir opened a new issue, #11820:
URL: https://github.com/apache/lucene/issues/11820
### Description
smoketester runs gradle which generates a `gradle.properties` but it isn't
picked up, which causes it to fail. I think if we just ran `gradlew
localSettings` first, then it would actu
gsmiller merged PR #11804:
URL: https://github.com/apache/lucene/pull/11804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
rmuir commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258366985
To be clear, i set `JAVA19_HOME` env var, but gradle doesn't pick it up
because it hasn't "pulled in" the `gradle.properties`, then it fails because it
can't find java 19. I have `org
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258367644
Yes, on Github CI jobs we do exactly this:
https://github.com/apache/lucene/blob/ac12cd9f176bf50bc80f1d7528f4c35d5ad22adf/.github/workflows/distribution.yml#L37-L44
I agree
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258369276
Let's just add this additional exec before it executes `gradlew` for the
first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258377651
Something like this would be fine:
```python
validateCmd = './gradlew --no-daemon localSettings'
print('run "%s"' % validateCmd)
java.run_java17(validat
uschindler commented on issue #11820:
URL: https://github.com/apache/lucene/issues/11820#issuecomment-1258378657
Anyways we should fix gradlew somehow to make sure the settings file is
there and restart itsself. Maybe it should also check for updates of settings.
Because once you wrote the
gsmiller opened a new pull request, #11821:
URL: https://github.com/apache/lucene/pull/11821
Just backporting. No PR requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
gsmiller merged PR #11738:
URL: https://github.com/apache/lucene/pull/11738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
stefanvodita commented on code in PR #11815:
URL: https://github.com/apache/lucene/pull/11815#discussion_r980472199
##
lucene/misc/src/java/org/apache/lucene/misc/index/IndexRearranger.java:
##
@@ -175,5 +202,7 @@ public CacheHelper getReaderCacheHelper() {
/** Select documen
stefanvodita commented on PR #11815:
URL: https://github.com/apache/lucene/pull/11815#issuecomment-1258596125
Thank you for the review @zhaih ! Your feedback is much appreciated. I left
a detailed response to your comment on the code. Let me know what you think.
--
This is an automated me
stefanvodita commented on PR #11780:
URL: https://github.com/apache/lucene/pull/11780#issuecomment-1258609162
> How is it different from making a subclass/alternative of ReaderManager
and just put the state calculation inside `refreshIfNeed`?
I think there’s two things that would be d
zhaih commented on code in PR #11803:
URL: https://github.com/apache/lucene/pull/11803#discussion_r980469938
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java:
##
@@ -149,63 +162,147 @@ public int score(LeafCollector collector, Bits
acceptDocs, int min,
gsmiller merged PR #11821:
URL: https://github.com/apache/lucene/pull/11821
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
zhaih commented on PR #11780:
URL: https://github.com/apache/lucene/pull/11780#issuecomment-1258623624
For 1. I think we can always create a ReferenceManager of
`IndexReaderAndState` so that those two are always refreshed together and you
can acquire them together.
For 2. I think people
stevenschlansker opened a new pull request, #11822:
URL: https://github.com/apache/lucene/pull/11822
Adds a configurable timeout for PrimaryNode waiting for remotes to close.
The default matches existing behavior. In the long run, maybe this wait loop
goes away entirely, but I elected to
uschindler opened a new pull request, #11823:
URL: https://github.com/apache/lucene/pull/11823
This fixes the eclipse part of #11819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1258639937
Here is the fix for Eclipse: #11823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
zhaih commented on PR #11815:
URL: https://github.com/apache/lucene/pull/11815#issuecomment-1258661752
I think the overall process in my mind would be:
1. Identify all deletes and save them
2. Create a document selector which ignores all deletes in the original index
3. Rearrange
stefanvodita commented on PR #11815:
URL: https://github.com/apache/lucene/pull/11815#issuecomment-1258665033
> we can pass in another single DocumentSelector, which basically select
which documents should be deleted afterwards. And we apply the deletions to the
whole index after rearrange?
mdmarshmallow commented on code in PR #11796:
URL: https://github.com/apache/lucene/pull/11796#discussion_r980528010
##
lucene/core/src/java/org/apache/lucene/store/ByteTrackingIndexOutput.java:
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
gsmiller commented on code in PR #11768:
URL: https://github.com/apache/lucene/pull/11768#discussion_r980530138
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java:
##
@@ -189,10 +190,11 @@ private TopChildrenForPath
getTopChildrenForPath(DimConfi
gsmiller commented on code in PR #11768:
URL: https://github.com/apache/lucene/pull/11768#discussion_r980530440
##
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java:
##
@@ -626,7 +626,7 @@ public void testBasicWithCollectorManager() throws
Exception {
Li
gsmiller merged PR #11768:
URL: https://github.com/apache/lucene/pull/11768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
gsmiller commented on code in PR #11803:
URL: https://github.com/apache/lucene/pull/11803#discussion_r980557793
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java:
##
@@ -149,63 +162,147 @@ public int score(LeafCollector collector, Bits
acceptDocs, int mi
gsmiller commented on code in PR #11803:
URL: https://github.com/apache/lucene/pull/11803#discussion_r980560040
##
lucene/facet/src/java/org/apache/lucene/facet/DrillSidewaysScorer.java:
##
@@ -149,63 +162,147 @@ public int score(LeafCollector collector, Bits
acceptDocs, int mi
stevenschlansker commented on issue #11674:
URL: https://github.com/apache/lucene/issues/11674#issuecomment-1258739382
Not hearing any other opinions, I opened a PR with a proposed solution.
Hopefully that will spur some discussion :)
--
This is an automated message from the Apache Git Se
mdmarshmallow commented on PR #11796:
URL: https://github.com/apache/lucene/pull/11796#issuecomment-1258901123
Sorry for the delayed response, I haven't had internet for a few days. I
added the option to include temp output in tracking, as well as the a method
for real time byte tracking as
dsmiley commented on PR #11807:
URL: https://github.com/apache/lucene/pull/11807#issuecomment-1258920877
> I thought the changes you made for unrecognized queries fixed the issues
with the surround query parser?
I forget LOL but...
> If not it would be good to implement query
hakanai commented on issue #6967:
URL: https://github.com/apache/lucene/issues/6967#issuecomment-1258972455
This issue is still alive and well in v8.5.1.
The example discovered this time (in this case mode is set to SEARCH):
1. input: 非公開
tokens:
- 非 (接頭詞)
zhaih commented on PR #11803:
URL: https://github.com/apache/lucene/pull/11803#issuecomment-1258979907
Changes LGTM, do we need to add some unit tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
zhaih commented on code in PR #11822:
URL: https://github.com/apache/lucene/pull/11822#discussion_r980742864
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/PrimaryNode.java:
##
@@ -61,6 +61,7 @@ public abstract class PrimaryNode extends Node {
private CopyStat
45 matches
Mail list logo
