stefanvodita commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1258609162
> How is it different from making a subclass/alternative of ReaderManager and just put the state calculation inside `refreshIfNeed`? I think there’s two things that would be different. Please correct me if I’m wrong. 1. If we simply override `refreshIfNeeded`, we don’t have a way to return the new reader states. We would still need to create some new method that does the refresh and returns the reader states. 2. Doing this in the `ReferenceManager` makes it work for both `ReaderManager` and `SearcherManager` with the right `StateCalculator` for each. I don’t know how valuable that is though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
