uschindler commented on code in PR #912:
URL: https://github.com/apache/lucene/pull/912#discussion_r979990105


##########
gradle/generation/local-settings.gradle:
##########
@@ -98,12 +98,12 @@ org.gradle.workers.max=${maxWorkers}
 # Maximum number of test JVMs forked per test task.
 tests.jvms=${testsJvms}
 
-# Disable auto JVM provisioning (we don't use toolchains yet but want no 
surprises).
-org.gradle.java.installations.auto-download=false
+# Enable auto JVM provisioning.
+org.gradle.java.installations.auto-download=true
 
 # Set these to enable automatic JVM location discovery.
-org.gradle.java.installations.fromEnv=JDK11,JDK12,JDK13,JDK14,JDK15,JDK16,JDK17
-org.gradle.java.installations.paths=(custom paths)
+org.gradle.java.installations.fromEnv=JDK17,JDK19,JAVA19_HOME

Review Comment:
   Done. BTW, Policeman Jenkins was doing exactly this before the 
auto-provisioning worked. The JAVA19_HOME env var is currently the only one 
used. JAVA17_HOME was just added for consistency.
   
   Could you still test this on your Mac? Github jobs already did this and all 
worked. It will automatically download like any other JAR file from Maven 
Central. To get rid of it and for testing do `rm -rf ~/.gradle/jdks/*`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to