gsmiller commented on code in PR #11768:
URL: https://github.com/apache/lucene/pull/11768#discussion_r980530138
##########
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java:
##########
@@ -189,10 +190,11 @@ private TopChildrenForPath
getTopChildrenForPath(DimConfig dimConfig, int pathOr
TopOrdAndFloatQueue.OrdAndValue reuse = null;
while (ord != TaxonomyReader.INVALID_ORDINAL) {
- if (values[ord] > 0) {
+ float value = values[ord];
+ if (value > 0) {
aggregatedValue = aggregationFunction.aggregate(aggregatedValue,
values[ord]);
Review Comment:
Thanks for the catch. I intended to do this everyone but looks like I missed
a spot. I'll go back through and re-check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
