[jira] [Created] (LUCENE-10293) Add an equivalent of ant's stage-maven-artifacts for the release wizard

2021-12-07 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10293: Summary: Add an equivalent of ant's stage-maven-artifacts for the release wizard Key: LUCENE-10293 URL: https://issues.apache.org/jira/browse/LUCENE-10293 Project: Lu

[jira] [Created] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10294: Summary: Avoid compiling javadocs twice in 'gradlew check'? Key: LUCENE-10294 URL: https://issues.apache.org/jira/browse/LUCENE-10294 Project: Lucene - Core

[jira] [Updated] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10294: - Attachment: LUCENE-10294.patch > Avoid compiling javadocs twice in 'gradlew check'? > -

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454471#comment-17454471 ] Uwe Schindler commented on LUCENE-10294: +1 to only run "documentation" (site j

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454475#comment-17454475 ] Uwe Schindler commented on LUCENE-10294: bq. The downside is that a project-loc

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454480#comment-17454480 ] Dawid Weiss commented on LUCENE-10294: -- I thought about it but I don't know how to

[jira] [Commented] (LUCENE-10293) Add an equivalent of ant's stage-maven-artifacts for the release wizard

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454483#comment-17454483 ] Dawid Weiss commented on LUCENE-10293: -- [~jpountz] - this PR has the task that ass

[GitHub] [lucene] romseygeek commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
romseygeek commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r763792009 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(In

[GitHub] [lucene] dweiss commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
dweiss commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r763795223 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(Interv

[GitHub] [lucene] romseygeek commented on pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
romseygeek commented on pull request #521: URL: https://github.com/apache/lucene/pull/521#issuecomment-987729638 This looks great, thanks @zhaih! Could we also add a test for the atLeast case in TestIntervals? Testing in highlighting is great, but I'd like to make sure we cover as mu

[GitHub] [lucene] romseygeek commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
romseygeek commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r763805979 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(In

[GitHub] [lucene] ChrisHegarty commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-07 Thread GitBox
ChrisHegarty commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-987783947 > I still have a gut feeling that if we defined explicit dependency configurations for modules, they'd fit right in. Yeah, I tend to agree. I also find the explicitness

[GitHub] [lucene] jpountz opened a new pull request #524: Fix path of docs for import into the website.

2021-12-07 Thread GitBox
jpountz opened a new pull request #524: URL: https://github.com/apache/lucene/pull/524 The current `svn import` looks for docs where they used to be produced by the `Ant` build, but `Gradle` now puts them in a different place. -- This is an automated message from the Apache Git Ser

[jira] [Commented] (LUCENE-10287) Add jdk.unsupported module to Luke startup script

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454574#comment-17454574 ] Dawid Weiss commented on LUCENE-10287: -- I've added an integration layer test to th

[GitHub] [lucene] jpountz commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-07 Thread GitBox
jpountz commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r763869267 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sona

[jira] [Commented] (LUCENE-10287) Add jdk.unsupported module to Luke startup script

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454576#comment-17454576 ] Dawid Weiss commented on LUCENE-10287: -- We could verify SPI sanity in a similar wa

[GitHub] [lucene] dweiss commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-07 Thread GitBox
dweiss commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r763876290 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sonat

[GitHub] [lucene] dweiss commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-07 Thread GitBox
dweiss commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r763878796 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sonat

[GitHub] [lucene] dweiss commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-07 Thread GitBox
dweiss commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r763878796 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sonat

[GitHub] [lucene] dweiss commented on a change in pull request #523: LUCENE-10293: adds a stand-alone prepareSonatypeBundle that compiles …

2021-12-07 Thread GitBox
dweiss commented on a change in pull request #523: URL: https://github.com/apache/lucene/pull/523#discussion_r763883614 ## File path: lucene/distribution/build.gradle ## @@ -126,3 +126,31 @@ tasks.matching {it.name in [ ]}.all { group "distribution" } + +// Prepare a sonat

[jira] [Created] (LUCENE-10295) the release's .gitrev file is lost somewhere when uploading release to the svn repository

2021-12-07 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-10295: Summary: the release's .gitrev file is lost somewhere when uploading release to the svn repository Key: LUCENE-10295 URL: https://issues.apache.org/jira/browse/LUCENE-10295

[jira] [Commented] (LUCENE-10295) the release's .gitrev file is lost somewhere when uploading release to the svn repository

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454592#comment-17454592 ] Dawid Weiss commented on LUCENE-10295: -- I think it's svn commands in the release w

[GitHub] [lucene] jpountz opened a new pull request #525: Modernize release announcement text.

2021-12-07 Thread GitBox
jpountz opened a new pull request #525: URL: https://github.com/apache/lucene/pull/525 It currently reads as Lucene is a full-text search library when it can do much more than that nowadays. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Resolved] (LUCENE-5590) remove .zip binary artifacts

2021-12-07 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-5590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-5590. -- Resolution: Duplicate > remove .zip binary artifacts > > >

[GitHub] [lucene] rmuir opened a new pull request #526: remove unnecessary "dependencies" in versions.props

2021-12-07 Thread GitBox
rmuir opened a new pull request #526: URL: https://github.com/apache/lucene/pull/526 Looks like stray cats from back when it was shared with solr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob merged pull request #2624: SOLR-15833

2021-12-07 Thread GitBox
madrob merged pull request #2624: URL: https://github.com/apache/lucene-solr/pull/2624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[GitHub] [lucene-solr] chatman commented on pull request #2624: SOLR-15833

2021-12-07 Thread GitBox
chatman commented on pull request #2624: URL: https://github.com/apache/lucene-solr/pull/2624#issuecomment-988062139 Why does it say there was a force push? Was it on apache/lucene-solr's branch_8_11? -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454780#comment-17454780 ] Dawid Weiss commented on LUCENE-10294: -- If there are no objections, I'll commit it

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454783#comment-17454783 ] Uwe Schindler commented on LUCENE-10294: Naaa, just the simple patch. All fine.

[GitHub] [lucene] zhaih commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
zhaih commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r764251721 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(Interva

[GitHub] [lucene] apanimesh061 commented on pull request #412: LUCENE-10197: UnifiedHighlighter should use builders for thread-safety

2021-12-07 Thread GitBox
apanimesh061 commented on pull request #412: URL: https://github.com/apache/lucene/pull/412#issuecomment-988169852 @dsmiley In order to make this portable to v9.x should we make 2 unit test suites for "with builder" and "w/o builder"? It will just be easier to remove the non-builder files

[jira] [Commented] (LUCENE-10294) Avoid compiling javadocs twice in 'gradlew check'?

2021-12-07 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454795#comment-17454795 ] Robert Muir commented on LUCENE-10294: -- +1, personally I only run {{check}} at the

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-07 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-988215171 I went back to explicit configurations for modular dependencies. Maybe it doesn't fit the gradle convention model but it's simpler and less magical in the end (no automatic detectio

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-07 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-988216299 Just to be clear: I don't want to convert all tests to be modular - the other way around: I want existing tests to work as they currently do (in classpath mode) but want to have the

[GitHub] [lucene] zhaih commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
zhaih commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r764406016 ## File path: lucene/highlighter/src/test/org/apache/lucene/search/matchhighlight/TestMatchHighlighter.java ## @@ -541,6 +539,234 @@ protected TokenStreamComp

[GitHub] [lucene] zhaih commented on pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
zhaih commented on pull request #521: URL: https://github.com/apache/lucene/pull/521#issuecomment-988304204 @romseygeek Sure thing, I added one more test for the atLeast change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] rmuir commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-07 Thread GitBox
rmuir commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-988334834 > Just to be clear: I don't want to convert all tests to be modular - the other way around: I want existing tests to work as they currently do (in classpath mode) but want to have th

[GitHub] [lucene] jtibshirani opened a new pull request #527: LUCENE-10040: Add test for vector search with skewed deletions

2021-12-07 Thread GitBox
jtibshirani opened a new pull request #527: URL: https://github.com/apache/lucene/pull/527 This exercises a challenging case where the documents to skip all happen to be closest to the query vector. In many cases, HNSW appears to be robust to this case and maintains good recall.

[jira] [Commented] (LUCENE-10040) Handle deletions in nearest vector search

2021-12-07 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454894#comment-17454894 ] Julie Tibshirani commented on LUCENE-10040: --- I ran some local tests to sanity

[GitHub] [lucene] rmuir merged pull request #526: remove unnecessary "dependencies" in versions.props

2021-12-07 Thread GitBox
rmuir merged pull request #526: URL: https://github.com/apache/lucene/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [lucene] rmuir merged pull request #513: LUCENE-10010: don't determinize/minimize in RegExp

2021-12-07 Thread GitBox
rmuir merged pull request #513: URL: https://github.com/apache/lucene/pull/513 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (LUCENE-10010) Should we have a NFA Query?

2021-12-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454934#comment-17454934 ] ASF subversion and git services commented on LUCENE-10010: -- Co

[jira] [Created] (LUCENE-10296) Stop minimizing regexps

2021-12-07 Thread Robert Muir (Jira)
Robert Muir created LUCENE-10296: Summary: Stop minimizing regexps Key: LUCENE-10296 URL: https://issues.apache.org/jira/browse/LUCENE-10296 Project: Lucene - Core Issue Type: Task Affect

[GitHub] [lucene] rmuir commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-07 Thread GitBox
rmuir commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-988451392 ok, sorry, I realize the latest two PR-split-outs still don't solve your problem. The API is still ugly because we still `minimize()` regexps, and that implies `determinize()`... but

[GitHub] [lucene] fmmoret commented on pull request #380: LUCENE-10171 - Fix dictionary-based OpenNLPLemmatizerFilterFactory caching issue

2021-12-07 Thread GitBox
fmmoret commented on pull request #380: URL: https://github.com/apache/lucene/pull/380#issuecomment-988465154 How far is this from making it into a release? We have been dealing with this exact issue & have considered a local patch -- This is an automated message from the Apache Git Ser

[GitHub] [lucene] rmuir opened a new pull request #528: LUCENE-10296: Stop minimizing regepx

2021-12-07 Thread GitBox
rmuir opened a new pull request #528: URL: https://github.com/apache/lucene/pull/528 In current trunk, we let caller (e.g. RegExpQuery) try to "reduce" the expression. The parser nor the low-level executors don't implicitly call exponential-time algorithms anymore. But now that we h

[GitHub] [lucene] rmuir commented on pull request #225: LUCENE-10010 Introduce NFARunAutomaton to run NFA directly

2021-12-07 Thread GitBox
rmuir commented on pull request #225: URL: https://github.com/apache/lucene/pull/225#issuecomment-988465898 ok one more, but I think it sets us up even better: https://github.com/apache/lucene/pull/528 -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene] msokolov commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
msokolov commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r764555865 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(Inte

[GitHub] [lucene] msokolov commented on a change in pull request #521: LUCENE-10229: Unify behaviour of match offsets for interval queries

2021-12-07 Thread GitBox
msokolov commented on a change in pull request #521: URL: https://github.com/apache/lucene/pull/521#discussion_r764555865 ## File path: lucene/queries/src/java/org/apache/lucene/queries/intervals/Intervals.java ## @@ -275,7 +275,10 @@ public static IntervalsSource ordered(Inte

[jira] [Commented] (LUCENE-10040) Handle deletions in nearest vector search

2021-12-07 Thread Xi Caoqiu (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454967#comment-17454967 ] Xi Caoqiu commented on LUCENE-10040: Weaviate have done similar method to implement

[GitHub] [lucene] dweiss commented on pull request #470: LUCENE-10255: fully embrace the java module system

2021-12-07 Thread GitBox
dweiss commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-988542101 The overlapping packages (tests accessing package-private classes) is the main problem here, I think. Maybe there are workarounds to that - I'm a newbie to all this myself, so still

[GitHub] [lucene] zacharymorn commented on pull request #418: LUCENE-10061: Implements dynamic pruning support for CombinedFieldsQuery

2021-12-07 Thread GitBox
zacharymorn commented on pull request #418: URL: https://github.com/apache/lucene/pull/418#issuecomment-988548076 > These numbers are super interesting. Let's go with the approach of you baseline for now since it performs better, sorry for putting you on a track that performs worse. :)