ChrisHegarty commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-987783947
> I still have a gut feeling that if we defined explicit dependency configurations for modules, they'd fit right in. Yeah, I tend to agree. I also find the explicitness of these, and their correlation to the requires directives in the module declaration, quite appealing. These can also be used from both projects with and without a module-info.java. I've not yet tried these in the ES code base, but effectively have something similar. I'll see how they work (and report back here), but I expect it will be fine. There's still some attractiveness in the auto-magic of inferring which path things should go on, but it seems more fragile and less configurable. It's something that could be revisited in the future if needed, but I suspect the above configurations will work just nicely - and lead to less head scratching and hard to debug moments! ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
