[ 
https://issues.apache.org/jira/browse/LUCENE-10287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454574#comment-17454574
 ] 

Dawid Weiss commented on LUCENE-10287:
--------------------------------------

I've added an integration layer test to the jms PR branch to verify mmap can be 
loaded and confirmed it fails without this patch:
{code}
org.apache.lucene.distribution.TestModularLayer > test suite's output saved to 
C:\Work\apache\lucene\lucene\distribution-tests\build\test-results\test\outputs\OUTPUT-org.apache.lucene.distribution.TestModularLayer.txt,
 copied below:
   >     java.lang.AssertionError:
   >     Expecting map:
   >       {"hello"="world", "unmap.supported"="false"}
   >     to contain only:
   >       ["unmap.supported"="true", "hello"="world"]
   >     map entries not found:
   >       ["unmap.supported"="true"]
   >     and map entries not expected:
   >       ["unmap.supported"="false"]
   >         at org.apache.lucene.distribution.TestModularLayer....
{code}

> Add jdk.unsupported module to Luke startup script
> -------------------------------------------------
>
>                 Key: LUCENE-10287
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10287
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: luke
>    Affects Versions: 9.0
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Major
>             Fix For: 9.1, 10.0 (main), 9.x
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> See my note on the JDK 9.0 release: When you start Luke (in module mode, as 
> done by default), it won't use MMapDirectory when opening indexes. The reason 
> is simple: It can't see sun.misc.Unsafe, which is needed to unmap mapped byte 
> buffers. It will silently disable itsself (as it is not a hard dependency).
> By default we should pass the "jdk.unsupported" module when starting Luke.
> In case of a respin, this should be backported.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to