rmuir commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-988334834
> Just to be clear: I don't want to convert all tests to be modular - the other way around: I want existing tests to work as they currently do (in classpath mode) but want to have the extra ability to add tests that do run as full modules. Whether this is a separate source set or separate subprojects - I'm not sure yet. why not? having sets of tests that run two different ways sounds really confusing. if we want to "fully embrace" the module system: means removing the test-framework split packages (?), hacky package-private testing (?), or whatever else, why not at least look at how hard it is. Some of this stuff is probably doable, e.g. fixing the test-framework module. I bet most stuff there doesn't really need to be in the specific packages it happens to be in. And those base classes that we have there, should be "higher quality" test code, I would hope. less hacky shit and proper testing of public apis. we could open a spinoff issue to look into it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
