uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689352137
The import error was fixed already. It was not caused by this PR, but a
change in master.
This is an aut
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192690#comment-17192690
]
Andras Salamon commented on SOLR-14439:
---
[~tallison] Can you please change the stat
Frank Zhu created LUCENE-9513:
-
Summary: Use seconds instead of millisecs
Key: LUCENE-9513
URL: https://issues.apache.org/jira/browse/LUCENE-9513
Project: Lucene - Core
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frank Zhu updated LUCENE-9513:
--
Description:
In RangeFacetsExample, there is a trivial mistake where
private final long nowSec is sup
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Frank Zhu updated LUCENE-9513:
--
Fix Version/s: master (9.0)
> Use seconds instead of millisecs
>
>
>
Simon Willnauer created LUCENE-9514:
---
Summary: Include TermVectorsWriter in DWPT accounting
Key: LUCENE-9514
URL: https://issues.apache.org/jira/browse/LUCENE-9514
Project: Lucene - Core
Is
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192701#comment-17192701
]
Simon Willnauer commented on LUCENE-9511:
-
{quote}I guess this would mean applic
s1monw opened a new pull request #1847:
URL: https://github.com/apache/lucene-solr/pull/1847
TermVectorsWriter might consume some heap space memory that
can have a significant impact on decisions made in the IW if
writers should be stalled or DWPTs should be flushed if memory
settin
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192701#comment-17192701
]
Simon Willnauer edited comment on LUCENE-9511 at 9/9/20, 7:35 AM:
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689369526
I merged from master to retrigger the check. Clicking on "Rerun checks" did
not work, as it merged into same master commit as before. Makes no sense to me
(maybe because
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192711#comment-17192711
]
Markus Kalkbrenner commented on SOLR-14768:
---
I just want to mention that I crea
[
https://issues.apache.org/jira/browse/SOLR-14768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192711#comment-17192711
]
Markus Kalkbrenner edited comment on SOLR-14768 at 9/9/20, 7:54 AM:
---
dweiss commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689410243
I've tried to clean up things a bit and ended up implementing both forked
and in-JVM mode. It's not super beautiful (those intermediate interfaces could
probably be simplifie
Simon Willnauer created LUCENE-9515:
---
Summary: Detach DWPT from DefaultIndexingChain
Key: LUCENE-9515
URL: https://issues.apache.org/jira/browse/LUCENE-9515
Project: Lucene - Core
Issue Ty
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689410718
> I don't want to block the changes here, but just think we should make a
followup to implement the same test, but with clients in the same JVM.
>
> There are two se
s1monw opened a new pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848
This change removes the DWPT dependency from DefaultIndexingChain
and rather passes on the primitives needed for creating the chain.
-
Simon Willnauer created LUCENE-9516:
---
Summary: Remove DocConsumer and IndexingChain from Lucene
Key: LUCENE-9516
URL: https://issues.apache.org/jira/browse/LUCENE-9516
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192727#comment-17192727
]
ASF subversion and git services commented on LUCENE-9511:
-
Commi
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689463433
Hi @dweiss
indeed this looks now very complicated (before the test was so simple after
my changes from last night). Indeed I want to remove some abstraction, the
fact
Ignacio Vera created LUCENE-9517:
Summary: BugfixDeflater_JDK8252739 causes Java security issues in
JDk11
Key: LUCENE-9517
URL: https://issues.apache.org/jira/browse/LUCENE-9517
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-9517:
-
Description:
We are running into issues when running Elasticsearch CI with java security
turned
mikemccand commented on a change in pull request #1847:
URL: https://github.com/apache/lucene-solr/pull/1847#discussion_r485497049
##
File path: lucene/core/src/java/org/apache/lucene/util/Accountable.java
##
@@ -41,4 +41,8 @@
return Collections.emptyList();
}
+ /**
mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485498630
##
File path:
lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
##
@@ -73,21 +78,38 @@
// Holds fields seen in each docume
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689467186
I'd also change the test name now to `TestStressLockFactories`.
This is an automated message from the Apa
mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485499853
##
File path:
lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
##
@@ -73,21 +78,38 @@
// Holds fields seen in each docume
mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485499853
##
File path:
lucene/core/src/java/org/apache/lucene/index/DefaultIndexingChain.java
##
@@ -73,21 +78,38 @@
// Holds fields seen in each docume
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689479947
Hi, I reordered the methods a bit in the class and applied some changes with
number of clients:
- Default is now 3. Actually this does not change the test runtime (on m
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689480950
FYI, the limit to 2 clients was caused by ANT's xml. Every client used
another XML copypaste. But actually the number of clients is not really a
performance factor.
---
dweiss commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689486069
I don't mind. Reshape any way you like.
This is an automated message from the Apache Git Service.
To respond
iverase opened a new pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849
see https://issues.apache.org/jira/browse/LUCENE-9517
This is an automated message from the Apache Git Service.
To respond to the m
iverase commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689503221
A couple of notes:
* Not sure how this change can be tested.
* We know this is only an issue for JDK11, should be add a check and only
perform privilege action in t
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192801#comment-17192801
]
Andrzej Bialecki commented on SOLR-14843:
-
{quote}This is not a user facing api
{
dweiss commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689507031
This is a hideous implementation detail inside the JDK but I think the
privileged action should just be there - I think this is the correct way to
dodge the problem.
--
cpoerschke merged pull request #1790:
URL: https://github.com/apache/lucene-solr/pull/1790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
cpoerschke merged pull request #1832:
URL: https://github.com/apache/lucene-solr/pull/1832
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192814#comment-17192814
]
ASF subversion and git services commented on SOLR-14831:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192818#comment-17192818
]
ASF subversion and git services commented on SOLR-14831:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192820#comment-17192820
]
Christine Poerschke commented on SOLR-14831:
The {{FacetParams.FACET_DISTRIB}
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192829#comment-17192829
]
ASF subversion and git services commented on SOLR-14831:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192828#comment-17192828
]
ASF subversion and git services commented on SOLR-14831:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192831#comment-17192831
]
ASF subversion and git services commented on SOLR-14831:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-14831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke resolved SOLR-14831.
Fix Version/s: 8.7
master (9.0)
Resolution: Fixed
> remov
[
https://issues.apache.org/jira/browse/LUCENE-9484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated LUCENE-9484:
Fix Version/s: 8.7
master (9.0)
> Allow index sorting to happen
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689546656
Hi,
I refactored the code further and removed the randomization:
- If uses `(clientId % 4)==0` to produce a thread client and otherwise a
process client
- In defa
[
https://issues.apache.org/jira/browse/SOLR-14843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192855#comment-17192855
]
Jan Høydahl commented on SOLR-14843:
[~dsmiley] Feel free to adapt the SIP page instr
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192858#comment-17192858
]
Alexandre Rafalovitch commented on SOLR-14701:
--
So, I am doing some quick re
uschindler edited a comment on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689546656
Hi,
*correction*
Actually we need at least two in process clients, otherwise it's not really
testing anything with in-process (explanation: the in-porcess
uschindler edited a comment on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689546656
Hi,
*correction*
Actually we need at least two in process clients, otherwise it's not really
testing anything with in-process (explanation: the in-porcess
uschindler edited a comment on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689562340
Hi again,
after reading the code of the LockStressTest: It tries to re-obtain a lock
in the same JVM based on randomization. So actually the original test did
e
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689562340
Hi again,
after reading the code of the LockStressTest: It tries to re-obtain a lock
in the same JVM based on randomization. So actually the original test did
everythi
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689563876
Code is here:
```java
try (final Lock l = verifyLF.obtainLock(lockDir, LOCK_FILE_NAME)) {
if (rnd.nextInt(10) == 0) {
if (rnd.next
uschindler edited a comment on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689562340
Hi again,
after reading the code of the LockStressTest: It tries to re-obtain a lock
in the same JVM based on randomization. So actually the original test did
e
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689574638
I was talking with Robert. Let's revert the in-process stuff. Makes not much
difference. We actually have a very good test for in-process logs, part of
BaseLockFactoryTes
s1monw commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689577005
change LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192884#comment-17192884
]
Jan Høydahl commented on SOLR-14701:
Thanks for doing this Alexandre!
bq. * Widen to
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689584918
OK, reverted most of the changes in the stress tester. I kept the changes
done by @dweiss about the magic numbers like starting gun "43" or
access/release in the wire pro
[
https://issues.apache.org/jira/browse/LUCENE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192887#comment-17192887
]
ASF subversion and git services commented on LUCENE-9470:
-
Commi
iverase merged pull request #1776:
URL: https://github.com/apache/lucene-solr/pull/1776
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192888#comment-17192888
]
ASF subversion and git services commented on LUCENE-9470:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera resolved LUCENE-9470.
--
Fix Version/s: 8.7
Assignee: Ignacio Vera
Resolution: Fixed
> TestXYMultiPolyg
mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485644701
##
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##
@@ -272,7 +273,9 @@ static int getActualMaxDocs() {
* and a mess
[
https://issues.apache.org/jira/browse/LUCENE-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192896#comment-17192896
]
Michael McCandless commented on LUCENE-9516:
+1
> Remove DocConsumer and In
madrob merged pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192898#comment-17192898
]
Michael McCandless commented on LUCENE-9513:
Thanks [~frankmanzhu] – fix loo
mikemccand commented on a change in pull request #1846:
URL: https://github.com/apache/lucene-solr/pull/1846#discussion_r485650485
##
File path:
lucene/demo/src/java/org/apache/lucene/demo/facet/RangeFacetsExample.java
##
@@ -46,7 +46,7 @@
private final Directory indexDir
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192899#comment-17192899
]
ASF subversion and git services commented on SOLR-14846:
Commit c
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192902#comment-17192902
]
Uwe Schindler commented on LUCENE-9517:
---
Sorry, I don't understand the issue.
Luc
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192905#comment-17192905
]
Uwe Schindler commented on LUCENE-9517:
---
This is more a bug in this jdk code. So p
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192906#comment-17192906
]
Uwe Schindler commented on LUCENE-9517:
---
Sorry, this is bullshit.
Please don't do
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689603748
Sorry, this is bullshit. Fix your CI and don't apply such stuff in Lucene.
This is an automated message f
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192908#comment-17192908
]
Erick Erickson commented on SOLR-14846:
---
[~mdrob] Is this something that should nev
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689606665
Actually the bug is in JDK and not in our code.
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9517.
---
Assignee: Uwe Schindler
Resolution: Won't Fix
> BugfixDeflater_JDK8252739 causes Java
[
https://issues.apache.org/jira/browse/LUCENE-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-9513.
Fix Version/s: 8.7
Resolution: Fixed
Thanks [~frankmanzhu]!
> Use seconds
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689611169
Actually I remember that this same issue happened also at other places in
the JDK, luckily it was fixed on their side, because I complained on the
mailing list.
---
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689611752
If this an issue at your CI, just use StackWalker and let this go through.
This is an automated message f
sigram commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-689612257
Thanks @murblanc for taking the lead on this issue, and for your patience!
This is an automated message from
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192918#comment-17192918
]
Michael McCandless commented on LUCENE-9444:
Overall the patch looks good!
HoustonPutman commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485683230
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192921#comment-17192921
]
Andrzej Bialecki commented on SOLR-14749:
-
[~ichattopadhyaya] as I explained in t
[
https://issues.apache.org/jira/browse/SOLR-14701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192924#comment-17192924
]
Alexandre Rafalovitch commented on SOLR-14701:
--
Thanks Jan, these are good q
[
https://issues.apache.org/jira/browse/SOLR-14439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tim Allison updated SOLR-14439:
---
Status: Patch Available (was: Open)
> Upgrade to Tika 1.24.1
> --
>
>
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689635578
The problem with the fix here is:
- I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a link to your CI, to se
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689636897
Does it help, because this code is only called from Deflater's ctor?
http://hg.openjdk.java.net/jdk/jdk11/file/1ddf9a99e4ad/src/java.base/share/classes/java/util/zip/Defla
uschindler edited a comment on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689635578
The problem with the fix here is:
- I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a link to your CI
HoustonPutman commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485708813
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
uschindler commented on a change in pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#discussion_r485711771
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene87/BugfixDeflater_JDK8252739.java
##
@@ -40,7 +42,9 @@ public static Deflater cr
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689648275
Maybe we should do another fix for the original bug: As only setDictionary
is affected, my proposal would be to not subclass `Deflater` at all and instead
just return an
[
https://issues.apache.org/jira/browse/LUCENE-9517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reopened LUCENE-9517:
---
Maybe we should do a completely different fix for the original issue. I will
provide a PR soon.
uschindler commented on pull request #1842:
URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689649444
@dweiss Are you fine with this? I would like to commit and backport this
soon.
Unless you have some minor comments about the cleanup process, as I had to
remove yo
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192970#comment-17192970
]
Mike Drob commented on SOLR-14846:
--
Individually calling ofNullable and calling orElse*
[
https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-14846.
--
Fix Version/s: master (9.0)
Resolution: Fixed
> Avoid use of Optional.ofNullable.orElse in the s
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192974#comment-17192974
]
Ishan Chattopadhyaya commented on SOLR-14749:
-
I'd prefer if this were to be
dweiss commented on a change in pull request #1844:
URL: https://github.com/apache/lucene-solr/pull/1844#discussion_r485726236
##
File path: solr/packaging/build.gradle
##
@@ -109,6 +109,21 @@ task toDir(type: Sync) {
}
}
+task toTgz(type: Tar) {
Review comment:
C
Tomas Eduardo Fernandez Lobbe created SOLR-14849:
Summary: Investigate test failures in
TestReRankQParserPlugin.testMinExactCount
Key: SOLR-14849
URL: https://issues.apache.org/jira/browse/SOLR-148
iverase commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689663895
Thanks Uwe for taking the time reviewing this issue.
>I have no idea how the stack trace looks like. And under which
circumstances you see this bug. Can you post a li
uschindler opened a new pull request #1850:
URL: https://github.com/apache/lucene-solr/pull/1850
Bugfix for LUCENE-9517: Instead of subclassing Deflater like in LUCENE-9500,
we just provide a method reference (using a functional interface), so code can
call Deflater#setDictionary.
T
uschindler commented on pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849#issuecomment-689670688
I have a better fix without hacks, just not subclassing Deflater!
See PR #1850. I will close this one.
uschindler closed pull request #1849:
URL: https://github.com/apache/lucene-solr/pull/1849
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sigram commented on pull request #1831:
URL: https://github.com/apache/lucene-solr/pull/1831#issuecomment-689671370
@noblepaul in this PR the Scheduler depends on ClusterSingleton, that's why
I imported it into this PR. Whatever the ClusterSingleton becomes it will be
the version from PR-1
1 - 100 of 160 matches
Mail list logo
