uschindler edited a comment on pull request #1842: URL: https://github.com/apache/lucene-solr/pull/1842#issuecomment-689546656
Hi, *correction* Actually we need at least two in process clients, otherwise it's not really testing anything with in-process (explanation: the in-porcess client is also "external" to the spawned process; to actually test that two lock factories in same process work, you need 2 local ones. My misunderstanding wa sthat the LockVerifyServer does not take place in locking). I refactored the code further and removed the randomization: - If uses `(clientId % 2)==0` to produce a thread client and otherwise a process client - In default mode, it creates 4 clients, so two of them is always in-process - In nightly mode, it creates 12 clients, so six of them are in-process I think that covers all modes. I think it's ready to commit. Question: Also backport to 8.x and remove the additional ANT task? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
