mikemccand commented on a change in pull request #1848:
URL: https://github.com/apache/lucene-solr/pull/1848#discussion_r485644701
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -272,7 +273,9 @@ static int getActualMaxDocs() {
* and a message is printed to infoStream, if set (see {@link
* IndexWriterConfig#setInfoStream(InfoStream)}).
*/
- public final static int MAX_TERM_LENGTH =
DocumentsWriterPerThread.MAX_TERM_LENGTH_UTF8;
+ // if you increase this, you must fix field cache impl for
+ // getTerms/getTermsIndex requires <= 32768
Review comment:
Maybe remove this stale comment :) FieldCache is long gone!
##########
File path: lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java
##########
@@ -1533,7 +1533,7 @@ public void testWickedLongTerm() throws IOException {
Directory dir = newDirectory();
RandomIndexWriter w = new RandomIndexWriter(random(), dir, new
StringSplitAnalyzer());
- char[] chars = new char[DocumentsWriterPerThread.MAX_TERM_LENGTH_UTF8];
+ char[] chars = new char[IndexWriter.MAX_TERM_LENGTH];
Review comment:
Ooh good catch (`char[]` vs `byte[]`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
